163331 2016-10-12 07:38:13 -0700 [Win] Encode function pointers. 2018-11-25 22:24:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191960 InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham webkit-bug-importer oldest_to_newest 1239274 0 pvollan 2016-10-12 07:38:13 -0700 For security reasons, we should encode stored function pointers. 1239276 1 291356 pvollan 2016-10-12 07:43:54 -0700 Created attachment 291356 Patch 1239280 2 pvollan 2016-10-12 07:54:45 -0700 <rdar://problem/9915523> 1239287 3 291356 achristensen 2016-10-12 08:25:54 -0700 Comment on attachment 291356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review > Source/WebCore/platform/win/SoftLinking.h:-105 > - static resultType callingConvention init##functionName parameterDeclarations \ Are these unit functions no longer needed? 1239359 4 pvollan 2016-10-12 10:42:56 -0700 (In reply to comment #3) > Comment on attachment 291356 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291356&action=review > > > Source/WebCore/platform/win/SoftLinking.h:-105 > > - static resultType callingConvention init##functionName parameterDeclarations \ > > Are these unit functions no longer needed? No, these should not be needed anymore. The function pointer will be initialized the first time the function is called. Thanks for reviewing! 1239699 5 291356 bfulgham 2016-10-12 22:36:31 -0700 Comment on attachment 291356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review r=me. >>> Source/WebCore/platform/win/SoftLinking.h:-105 >>> - static resultType callingConvention init##functionName parameterDeclarations \ >> >> Are these unit functions no longer needed? > > No, these should not be needed anymore. The function pointer will be initialized the first time the function is called. > > Thanks for reviewing! r=me if you remove the unneeded functions! 1239742 6 pvollan 2016-10-13 05:00:57 -0700 Committed r207282: <http://trac.webkit.org/changeset/207282> 291356 2016-10-12 07:43:54 -0700 2016-10-12 22:36:31 -0700 Patch bug-163331-20161012074031.patch text/plain 6992 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzIxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTEyICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBFbmNvZGUgZnVu Y3Rpb24gcG9pbnRlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjMzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGb3Igc2VjdXJpdHkgcmVhc29ucywgd2Ugc2hvdWxkIGVuY29kZSBzdG9yZWQgZnVu Y3Rpb24gcG9pbnRlcnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU29mdExpbmtpbmcuaDoK KwogMjAxNi0xMC0xMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgQXR0cmlidXRlIHNldHRlciBiaW5kaW5nIGdlbmVyYXRlZCBjb2RlIHNob3VsZCB1c2UgbW9y ZSByZWZlcmVuY2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU29mdExpbmtp bmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vU29mdExpbmtp bmcuaAkocmV2aXNpb24gMjA3MjEzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Nv ZnRMaW5raW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDE5ICs0NCwxMyBAQAogI3ByYWdtYSBt YXJrIC0gU29mdC1saW5rIG1hY3JvcyBmb3IgdXNlIHdpdGhpbiBhIHNpbmdsZSBzb3VyY2UgZmls ZQogCiAjZGVmaW5lIFNPRlRfTElOSyhsaWJyYXJ5LCBmdW5jdGlvbk5hbWUsIHJlc3VsdFR5cGUs IGNhbGxpbmdDb252ZW50aW9uLCBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMsIHBhcmFtZXRlck5hbWVz KSBcCi0gICAgc3RhdGljIHJlc3VsdFR5cGUgY2FsbGluZ0NvbnZlbnRpb24gaW5pdCMjZnVuY3Rp b25OYW1lIHBhcmFtZXRlckRlY2xhcmF0aW9uczsgXAotICAgIHN0YXRpYyByZXN1bHRUeXBlIChj YWxsaW5nQ29udmVudGlvbipzb2Z0TGluayMjZnVuY3Rpb25OYW1lKSBwYXJhbWV0ZXJEZWNsYXJh dGlvbnMgPSBpbml0IyNmdW5jdGlvbk5hbWU7IFwKLSAgICBcCi0gICAgc3RhdGljIHJlc3VsdFR5 cGUgY2FsbGluZ0NvbnZlbnRpb24gaW5pdCMjZnVuY3Rpb25OYW1lIHBhcmFtZXRlckRlY2xhcmF0 aW9ucyBcCi0gICAgeyBcCi0gICAgICAgIHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUgPSByZWludGVy cHJldF9jYXN0PHJlc3VsdFR5cGUgKGNhbGxpbmdDb252ZW50aW9uKikgcGFyYW1ldGVyRGVjbGFy YXRpb25zPihTT0ZUX0xJTktfR0VUUFJPQ0FERFJFU1MobGlicmFyeSMjTGlicmFyeSgpLCAjZnVu Y3Rpb25OYW1lKSk7IFwKLSAgICAgICAgQVNTRVJUKHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUpOyBc Ci0gICAgICAgIHJldHVybiBzb2Z0TGluayMjZnVuY3Rpb25OYW1lIHBhcmFtZXRlck5hbWVzOyBc Ci0gICAgfSBcCisgICAgc3RhdGljIHJlc3VsdFR5cGUoY2FsbGluZ0NvbnZlbnRpb24qc29mdExp bmsjI2Z1bmN0aW9uTmFtZSkgcGFyYW1ldGVyRGVjbGFyYXRpb25zID0gbnVsbHB0cjsgXAogICAg IFwKICAgICBpbmxpbmUgcmVzdWx0VHlwZSBmdW5jdGlvbk5hbWUgcGFyYW1ldGVyRGVjbGFyYXRp b25zIFwKICAgICB7IFwKLSAgICAgICAgcmV0dXJuIHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUgcGFy YW1ldGVyTmFtZXM7IFwKKyAgICAgICAgaWYgKCFzb2Z0TGluayMjZnVuY3Rpb25OYW1lKSBcCisg ICAgICAgICAgICBzb2Z0TGluayMjZnVuY3Rpb25OYW1lID0gcmVpbnRlcnByZXRfY2FzdDxyZXN1 bHRUeXBlKGNhbGxpbmdDb252ZW50aW9uKilwYXJhbWV0ZXJEZWNsYXJhdGlvbnM+KDo6RW5jb2Rl UG9pbnRlcihTT0ZUX0xJTktfR0VUUFJPQ0FERFJFU1MobGlicmFyeSMjTGlicmFyeSgpLCAjZnVu Y3Rpb25OYW1lKSkpOyBcCisgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHJlc3VsdFR5 cGUgKGNhbGxpbmdDb252ZW50aW9uKikgcGFyYW1ldGVyRGVjbGFyYXRpb25zPig6OkRlY29kZVBv aW50ZXIoc29mdExpbmsjI2Z1bmN0aW9uTmFtZSkpIHBhcmFtZXRlck5hbWVzOyBcCiAgICAgfQog CiAjZGVmaW5lIFNPRlRfTElOS19PUFRJT05BTChsaWJyYXJ5LCBmdW5jdGlvbk5hbWUsIHJlc3Vs dFR5cGUsIGNhbGxpbmdDb252ZW50aW9uLCBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMpIFwKQEAgLTY2 LDEyICs2MCwxMSBAQAogICAgICAgICBzdGF0aWMgZnVuY3Rpb25OYW1lIyNQdHJUeXBlIHB0cjsg XAogICAgICAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZDsgXAogICAgICAgICBcCi0gICAgICAg IGlmIChpbml0aWFsaXplZCkgXAotICAgICAgICAgICAgcmV0dXJuIHB0cjsgXAotICAgICAgICBp bml0aWFsaXplZCA9IHRydWU7IFwKLSAgICAgICAgXAotICAgICAgICBwdHIgPSByZWludGVycHJl dF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oU09GVF9MSU5LX0dFVFBST0NBRERSRVNTKGxp YnJhcnkjI0xpYnJhcnkoKSwgI2Z1bmN0aW9uTmFtZSkpOyBcCi0gICAgICAgIHJldHVybiBwdHI7 IFwKKyAgICAgICAgaWYgKCFpbml0aWFsaXplZCkgeyBcCisgICAgICAgICAgICBwdHIgPSByZWlu dGVycHJldF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oOjpFbmNvZGVQb2ludGVyKFNPRlRf TElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5IyNMaWJyYXJ5KCksICNmdW5jdGlvbk5hbWUpKSk7 IFwKKyAgICAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsgXAorICAgICAgICB9IFwKKyAgICAg ICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8ZnVuY3Rpb25OYW1lIyNQdHJUeXBlPig6OkRlY29k ZVBvaW50ZXIocHRyKSk7IFwKICAgICB9IFwKIAogI2RlZmluZSBTT0ZUX0xJTktfTE9BREVEX0xJ QlJBUlkobGlicmFyeSwgZnVuY3Rpb25OYW1lLCByZXN1bHRUeXBlLCBjYWxsaW5nQ29udmVudGlv biwgcGFyYW1ldGVyRGVjbGFyYXRpb25zKSBcCkBAIC04MSwxNCArNzQsMTMgQEAKICAgICAgICAg c3RhdGljIGZ1bmN0aW9uTmFtZSMjUHRyVHlwZSBwdHI7IFwKICAgICAgICAgc3RhdGljIGJvb2wg aW5pdGlhbGl6ZWQ7IFwKICAgICAgICAgXAotICAgICAgICBpZiAoaW5pdGlhbGl6ZWQpIFwKLSAg ICAgICAgICAgIHJldHVybiBwdHI7IFwKLSAgICAgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOyBcCi0g ICAgICAgIFwKKyAgICAgICAgaWYgKCFpbml0aWFsaXplZCkgeyBcCisgICAgICAgICAgICBwdHIg PSByZWludGVycHJldF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oOjpFbmNvZGVQb2ludGVy KFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5SW5zdGFuY2UsICNmdW5jdGlvbk5hbWUp KSk7IFwKKyAgICAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsgXAorICAgICAgICB9IFwKICAg ICAgICAgc3RhdGljIEhJTlNUQU5DRSBsaWJyYXJ5SW5zdGFuY2UgPSA6OkdldE1vZHVsZUhhbmRs ZShMI2xpYnJhcnkpOyBcCiAgICAgICAgIFwKLSAgICAgICAgcHRyID0gcmVpbnRlcnByZXRfY2Fz dDxmdW5jdGlvbk5hbWUjI1B0clR5cGU+KFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5 SW5zdGFuY2UsICNmdW5jdGlvbk5hbWUpKTsgXAotICAgICAgICByZXR1cm4gcHRyOyBcCisgICAg ICAgIHJldHVybiByZWludGVycHJldF9jYXN0PGZ1bmN0aW9uTmFtZSMjUHRyVHlwZT4oOjpEZWNv ZGVQb2ludGVyKHB0cikpOyBcCiAgICAgfSBcCiAKIC8qCkBAIC05OSwxOSArOTEsMTMgQEAKICAg ICAjZGVmaW5lIG15RnVuY3Rpb24gc29mdExpbmtfbXlGdW5jdGlvbgogKi8KICNkZWZpbmUgU09G VF9MSU5LX0RMTF9JTVBPUlQobGlicmFyeSwgZnVuY3Rpb25OYW1lLCByZXN1bHRUeXBlLCBjYWxs aW5nQ29udmVudGlvbiwgcGFyYW1ldGVyRGVjbGFyYXRpb25zLCBwYXJhbWV0ZXJOYW1lcykgXAot ICAgIHN0YXRpYyByZXN1bHRUeXBlIGNhbGxpbmdDb252ZW50aW9uIGluaXQjI2Z1bmN0aW9uTmFt ZSBwYXJhbWV0ZXJEZWNsYXJhdGlvbnM7IFwKLSAgICBzdGF0aWMgcmVzdWx0VHlwZShjYWxsaW5n Q29udmVudGlvbipzb2Z0TGluayMjZnVuY3Rpb25OYW1lKSBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMg PSBpbml0IyNmdW5jdGlvbk5hbWU7IFwKLSAgICBcCi0gICAgc3RhdGljIHJlc3VsdFR5cGUgY2Fs bGluZ0NvbnZlbnRpb24gaW5pdCMjZnVuY3Rpb25OYW1lIHBhcmFtZXRlckRlY2xhcmF0aW9ucyBc Ci0gICAgeyBcCi0gICAgICAgIHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUgPSByZWludGVycHJldF9j YXN0PHJlc3VsdFR5cGUgKGNhbGxpbmdDb252ZW50aW9uKilwYXJhbWV0ZXJEZWNsYXJhdGlvbnM+ KFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5IyNMaWJyYXJ5KCksICNmdW5jdGlvbk5h bWUpKTsgXAotICAgICAgICBBU1NFUlQoc29mdExpbmsjI2Z1bmN0aW9uTmFtZSk7IFwKLSAgICAg ICAgcmV0dXJuIHNvZnRMaW5rIyNmdW5jdGlvbk5hbWUgcGFyYW1ldGVyTmFtZXM7IFwKLSAgICB9 IFwKKyAgICBzdGF0aWMgcmVzdWx0VHlwZShjYWxsaW5nQ29udmVudGlvbipzb2Z0TGluayMjZnVu Y3Rpb25OYW1lKSBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMgPSBudWxscHRyOyBcCiAgICAgXAogICAg IGlubGluZSByZXN1bHRUeXBlIHNvZnRMaW5rXyMjZnVuY3Rpb25OYW1lIHBhcmFtZXRlckRlY2xh cmF0aW9ucyBcCiAgICAgeyBcCi0gICAgICAgIHJldHVybiBzb2Z0TGluayMjZnVuY3Rpb25OYW1l IHBhcmFtZXRlck5hbWVzOyBcCisgICAgICAgIGlmICghc29mdExpbmsjI2Z1bmN0aW9uTmFtZSkg XAorICAgICAgICAgICAgc29mdExpbmsjI2Z1bmN0aW9uTmFtZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8 cmVzdWx0VHlwZShjYWxsaW5nQ29udmVudGlvbiopcGFyYW1ldGVyRGVjbGFyYXRpb25zPig6OkVu Y29kZVBvaW50ZXIoU09GVF9MSU5LX0dFVFBST0NBRERSRVNTKGxpYnJhcnkjI0xpYnJhcnkoKSwg I2Z1bmN0aW9uTmFtZSkpKTsgXAorICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxyZXN1 bHRUeXBlKGNhbGxpbmdDb252ZW50aW9uKilwYXJhbWV0ZXJEZWNsYXJhdGlvbnM+KDo6RGVjb2Rl UG9pbnRlcihzb2Z0TGluayMjZnVuY3Rpb25OYW1lKSkgcGFyYW1ldGVyTmFtZXM7IFwKICAgICB9 CiAKICNkZWZpbmUgU09GVF9MSU5LX0RMTF9JTVBPUlRfT1BUSU9OQUwobGlicmFyeSwgZnVuY3Rp b25OYW1lLCByZXN1bHRUeXBlLCBjYWxsaW5nQ29udmVudGlvbiwgcGFyYW1ldGVyRGVjbGFyYXRp b25zKSBcCkBAIC0xMjEsMTIgKzEwNywxMSBAQAogICAgICAgICBzdGF0aWMgZnVuY3Rpb25OYW1l IyNQdHJUeXBlIHB0cjsgXAogICAgICAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZDsgXAogICAg ICAgICBcCi0gICAgICAgIGlmIChpbml0aWFsaXplZCkgXAotICAgICAgICAgICAgcmV0dXJuIHB0 cjsgXAotICAgICAgICBpbml0aWFsaXplZCA9IHRydWU7IFwKLSAgICAgICAgXAotICAgICAgICBw dHIgPSByZWludGVycHJldF9jYXN0PHJlc3VsdFR5cGUoY2FsbGluZ0NvbnZlbnRpb24qKXBhcmFt ZXRlckRlY2xhcmF0aW9ucz4oU09GVF9MSU5LX0dFVFBST0NBRERSRVNTKGxpYnJhcnkjI0xpYnJh cnkoKSwgI2Z1bmN0aW9uTmFtZSkpOyBcCi0gICAgICAgIHJldHVybiBwdHI7IFwKKyAgICAgICAg aWYgKCFpbml0aWFsaXplZCkgeyBcCisgICAgICAgICAgICBwdHIgPSByZWludGVycHJldF9jYXN0 PHJlc3VsdFR5cGUoY2FsbGluZ0NvbnZlbnRpb24qKXBhcmFtZXRlckRlY2xhcmF0aW9ucz4oOjpF bmNvZGVQb2ludGVyKFNPRlRfTElOS19HRVRQUk9DQUREUkVTUyhsaWJyYXJ5IyNMaWJyYXJ5KCks ICNmdW5jdGlvbk5hbWUpKSk7IFwKKyAgICAgICAgICAgIGluaXRpYWxpemVkID0gdHJ1ZTsgXAor ICAgICAgICB9IFwKKyAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8ZnVuY3Rpb25OYW1l IyNQdHJUeXBlPig6OkRlY29kZVBvaW50ZXIocHRyKSk7IFwKICAgICB9IFwKIAogI2RlZmluZSBT T0ZUX0xJTktfRExMX0lNUE9SVF9PUFRJT05BTChsaWJyYXJ5LCBmdW5jdGlvbk5hbWUsIHJlc3Vs dFR5cGUsIGNhbGxpbmdDb252ZW50aW9uLCBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMpIFwKQEAgLTEz NiwxMiArMTIxLDExIEBACiAgICAgICAgIHN0YXRpYyBmdW5jdGlvbk5hbWUjI1B0clR5cGUgcHRy OyBcCiAgICAgICAgIHN0YXRpYyBib29sIGluaXRpYWxpemVkOyBcCiAgICAgICAgIFwKLSAgICAg ICAgaWYgKGluaXRpYWxpemVkKSBcCi0gICAgICAgICAgICByZXR1cm4gcHRyOyBcCi0gICAgICAg IGluaXRpYWxpemVkID0gdHJ1ZTsgXAotICAgICAgICBcCi0gICAgICAgIHB0ciA9IHJlaW50ZXJw cmV0X2Nhc3Q8cmVzdWx0VHlwZShjYWxsaW5nQ29udmVudGlvbiopcGFyYW1ldGVyRGVjbGFyYXRp b25zPihTT0ZUX0xJTktfR0VUUFJPQ0FERFJFU1MobGlicmFyeSMjTGlicmFyeSgpLCAjZnVuY3Rp b25OYW1lKSk7IFwKLSAgICAgICAgcmV0dXJuIHB0cjsgXAorICAgICAgICBpZiAoIWluaXRpYWxp emVkKSB7IFwKKyAgICAgICAgICAgIHB0ciA9IHJlaW50ZXJwcmV0X2Nhc3Q8cmVzdWx0VHlwZShj YWxsaW5nQ29udmVudGlvbiopcGFyYW1ldGVyRGVjbGFyYXRpb25zPig6OkVuY29kZVBvaW50ZXIo U09GVF9MSU5LX0dFVFBST0NBRERSRVNTKGxpYnJhcnkjI0xpYnJhcnkoKSwgI2Z1bmN0aW9uTmFt ZSkpKTsgXAorICAgICAgICAgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOyBcCisgICAgICAgIH0gXAor ICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxmdW5jdGlvbk5hbWUjI1B0clR5cGU+KDo6 RGVjb2RlUG9pbnRlcihwdHIpKTsgXAogICAgIH0gXAogCiAvKgo=