162873 2016-10-03 11:46:21 -0700 Missing include in MediaDescription 2016-10-08 04:57:26 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 157314 1 eocanha eocanha calvaris commit-queue oldest_to_newest 1235835 0 eocanha 2016-10-03 11:46:21 -0700 Build fails when MediaDesciption.h is included in a file with no other dependencies which already require the AtomicString header. 1235836 1 290498 eocanha 2016-10-03 11:49:14 -0700 Created attachment 290498 Patch 1235899 2 290498 achristensen 2016-10-03 14:13:19 -0700 Comment on attachment 290498 Patch Actually, does <wtf/Forward.h> work? 1236117 3 290585 eocanha 2016-10-04 02:57:09 -0700 Created attachment 290585 Patch 1236118 4 eocanha 2016-10-04 02:58:36 -0700 Yes, Forward.h works at the expense of having to include the AtomicString header in the final cpp file. It seems a good compromise. 1236152 5 290585 calvaris 2016-10-04 06:35:47 -0700 Comment on attachment 290585 Patch For this you wouldn't even need to upload the patch for review. It could be an unreviewed build fix. 1236153 6 calvaris 2016-10-04 06:36:34 -0700 And it is something you can land now, no need to wait for other MSE changes. 1237954 7 290585 commit-queue 2016-10-08 04:57:22 -0700 Comment on attachment 290585 Patch Clearing flags on attachment: 290585 Committed r206952: <http://trac.webkit.org/changeset/206952> 1237955 8 commit-queue 2016-10-08 04:57:26 -0700 All reviewed patches have been landed. Closing bug. 290498 2016-10-03 11:49:14 -0700 2016-10-04 02:57:03 -0700 Patch bug-162873-20161003184604.patch text/plain 1141 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2VmNjdmNWI3ZGZjNmZk NGQxN2NlNzAwM2JhYzlhYTMxNzNjMWZmYi4uNzE5NDU2NzIzMWI3YWY1ZmM4YTA1YmNkODM3MGE3 NThmZDJiY2NhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTEwLTAzICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgTWlz c2luZyBpbmNsdWRlIGluIE1lZGlhRGVzY3JpcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG1pc3NpbmcgaGVhZGVyLgorCisgICAgICAg ICogcGxhdGZvcm0vTWVkaWFEZXNjcmlwdGlvbi5oOgorCisyMDE2LTEwLTAzICBFbnJpcXVlIE9j YcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dTdHJlYW1l cl0gRHJhaW4gcXVlcnkgc3VwcG9ydAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYyODcyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL01lZGlhRGVzY3JpcHRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lZGlhRGVz Y3JpcHRpb24uaAppbmRleCA3YjZmZmNkZTVlOGZmM2I0ZmZmZDQ3M2IxNmFiOWUwZmIxMDgzMDY2 Li5hZDNiNDAwYjAyMDVkYTdhNjljMTZjZTgxNTBlZTllYjM2NzI5NzIxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZWRpYURlc2NyaXB0aW9uLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vTWVkaWFEZXNjcmlwdGlvbi5oCkBAIC0yNyw2ICsyNyw3IEBACiAjZGVm aW5lIE1lZGlhRGVzY3JpcHRpb25faAogCiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KKyNp bmNsdWRlIDx3dGYvdGV4dC9BdG9taWNTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewog Cg== 290585 2016-10-04 02:57:09 -0700 2016-10-08 04:57:22 -0700 Patch bug-162873-20161004095358.patch text/plain 1157 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2VmNjdmNWI3ZGZjNmZk NGQxN2NlNzAwM2JhYzlhYTMxNzNjMWZmYi4uNzE5NDU2NzIzMWI3YWY1ZmM4YTA1YmNkODM3MGE3 NThmZDJiY2NhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTEwLTAzICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgTWlz c2luZyBpbmNsdWRlIGluIE1lZGlhRGVzY3JpcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mjg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG1pc3NpbmcgaGVhZGVyLgorCisgICAgICAg ICogcGxhdGZvcm0vTWVkaWFEZXNjcmlwdGlvbi5oOgorCisyMDE2LTEwLTAzICBFbnJpcXVlIE9j YcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dTdHJlYW1l cl0gRHJhaW4gcXVlcnkgc3VwcG9ydAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYyODcyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL01lZGlhRGVzY3JpcHRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lZGlhRGVz Y3JpcHRpb24uaAppbmRleCA3YjZmZmNkZTVlOGZmM2I0ZmZmZDQ3M2IxNmFiOWUwZmIxMDgzMDY2 Li40ZGFjMDRjNWIyMTUwZjRkMWFjODlhODRkM2I5Nzg3YjQwYTYzMWI1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZWRpYURlc2NyaXB0aW9uLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vTWVkaWFEZXNjcmlwdGlvbi5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZu ZGVmIE1lZGlhRGVzY3JpcHRpb25faAogI2RlZmluZSBNZWRpYURlc2NyaXB0aW9uX2gKIAorI2lu Y2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIAogbmFt ZXNwYWNlIFdlYkNvcmUgewo=