162613 2016-09-27 08:27:28 -0700 [GTK] Improve OS X UA quirk 2016-10-05 13:23:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 142074 162610 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233863 0 mcatanzaro 2016-09-27 08:27:28 -0700 Add a fake OS X version number to the Macintosh quirk user agent, in order to more convincingly pretend to be OS X. 1233905 1 289956 mcatanzaro 2016-09-27 09:43:57 -0700 Created attachment 289956 Patch 1234323 2 289956 cgarcia 2016-09-28 03:40:35 -0700 Comment on attachment 289956 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289956&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:134 > - uaString.appendLiteral(" Mac OS X"); > + uaString.appendLiteral(" Mac OS X 10_12"); is there any website broken because of this? 1234346 3 mcatanzaro 2016-09-28 05:38:06 -0700 (In reply to comment #2) > is there any website broken because of this? Not that I know of. Consider that this is a quirk that was previously only used at yahoo.com; I am just improving the quirk. 1234363 4 289956 cgarcia 2016-09-28 06:25:00 -0700 Comment on attachment 289956 Patch Ok, update the unit tests. 1234370 5 mcatanzaro 2016-09-28 07:27:44 -0700 (In reply to comment #4) > Comment on attachment 289956 [details] > Patch > > Ok, update the unit tests. I don't want to, because (a) updating the test would not accomplish much, as it would be difficult to unintentionally remove the hardcoded version, and (b) I want to change the version string here without having to modify the test. I will update the unit tests for the other two patches, though. 1236288 6 289956 commit-queue 2016-10-04 11:37:50 -0700 Comment on attachment 289956 Patch Rejecting attachment 289956 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 289956, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: " exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/gtk/UserAgentGtk.cpp Hunk #1 FAILED at 131. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/gtk/UserAgentGtk.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2218936 1236769 7 mcatanzaro 2016-10-05 13:23:57 -0700 Committed r206826: <http://trac.webkit.org/changeset/206826> 289956 2016-09-27 09:43:57 -0700 2016-10-04 11:37:50 -0700 Patch bug-162613-20160927184058.patch text/plain 1432 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1 OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uZmFjNjQyZThhYTBlODBjZjFkMjc1MWQ5ZmRmZWRk NTVmMzk3ZWE5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA5LTI3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBJ bXByb3ZlIE9TIFggVUEgcXVpcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MjYxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluY2x1ZGUgT1MgWCB2ZXJzaW9uIG51bWJlciBpbiB1c2VyIGFnZW50LCBs aWtlIFNhZmFyaSBkb2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5j cHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKKzIwMTYtMDkt MjcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAg IFVucmV2aWV3ZWQgdHlwbyBmaXgKIAogICAgICAgICAqIHBsYXRmb3JtL2d0ay9Vc2VyQWdlbnRH dGsuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2Vu dEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApp bmRleCA3NDNlYmEwMDExY2NiNTQ4NGZmNmY2MzZiNjVlMmQ1ZWIyYWY3OTM4Li5jMDUxYmY0OTFj MjczMGFhYTQyOTEyYjAwMmJjNGYyZWYwYmZhYTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBTdHJp bmcgYnVpbGRVc2VyQWdlbnRTdHJpbmcoY29uc3QgVXNlckFnZW50UXVpcmtzJiBxdWlya3MpCiAK ICAgICBpZiAocXVpcmtzLmNvbnRhaW5zKFVzZXJBZ2VudFF1aXJrczo6TmVlZHNNYWNpbnRvc2hQ bGF0Zm9ybSkpIHsKICAgICAgICAgdWFTdHJpbmcuYXBwZW5kKGNwdURlc2NyaXB0aW9uRm9yVUFT dHJpbmcoKSk7Ci0gICAgICAgIHVhU3RyaW5nLmFwcGVuZExpdGVyYWwoIiBNYWMgT1MgWCIpOwor ICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCIgTWFjIE9TIFggMTBfMTIiKTsKICAgICB9 IGVsc2UKICAgICAgICAgdWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5n KCkpOwogCg==