162612 2016-09-27 08:21:16 -0700 [GTK] Improve comment in platformVersionForUAString 2016-10-05 13:22:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 142074 162610 0 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233861 0 mcatanzaro 2016-09-27 08:21:16 -0700 This function is not implemented properly for Windows or OS X; let's add FIXMEs. 1233888 1 mcatanzaro 2016-09-27 09:10:23 -0700 Um, let's add an OS X FIXME only, since we don't support Windows. And remove the existing comment here, since it hasn't been true for a long time. 1233889 2 289951 mcatanzaro 2016-09-27 09:11:59 -0700 Created attachment 289951 Patch 1234324 3 289951 cgarcia 2016-09-28 03:42:34 -0700 Comment on attachment 289951 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289951&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:108 > - // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites. > + // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4". I don't understand the relationship between the comment removed and the FIXME added. The previous comment tried to explain why we include Mac OS X unconditionally, there's nothing to fix here. 1234337 4 mcatanzaro 2016-09-28 05:25:43 -0700 There is something to fix, because we don't include Mac OS X unconditionally. We need the OS X quirk. Probably adding the new comment should have be done in bug #162612. Let's handle this in that bug to avoid conflicts. 1234339 5 mcatanzaro 2016-09-28 05:28:58 -0700 Sorry, I got confused, this is a different place, separate issue. I still want to commit this patch. * The old comment is wrong. * The new comment is a FIXME that belongs in the same place. I could split it into two patches if you really want, but seems like wasted effort. 1234341 6 mcatanzaro 2016-09-28 05:31:26 -0700 (In reply to comment #5) > Sorry, I got confused, this is a different place, separate issue. I still > want to commit this patch. > > * The old comment is wrong. No, I got really confused, the comment is right, sorry. I will just add the new one. 1234343 7 mcatanzaro 2016-09-28 05:33:34 -0700 Well, it's wrong in that that code will never be executed on Linux; I'll tweak it a bit. 1234345 8 290077 mcatanzaro 2016-09-28 05:35:10 -0700 Created attachment 290077 Patch 1236286 9 mcatanzaro 2016-10-04 11:36:20 -0700 Ping reviewers 1236591 10 290077 commit-queue 2016-10-05 03:36:51 -0700 Comment on attachment 290077 Patch Rejecting attachment 290077 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 290077, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: " exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/gtk/UserAgentGtk.cpp Hunk #1 FAILED at 105. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/gtk/UserAgentGtk.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2223501 1236767 11 mcatanzaro 2016-10-05 13:22:33 -0700 Committed r206825: <http://trac.webkit.org/changeset/206825> 289951 2016-09-27 09:11:59 -0700 2016-09-28 05:35:05 -0700 Patch bug-162612-20160927180900.patch text/plain 1571 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1 OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uMTNjNWU5N2I5Y2VhZjFmMzdkMGZmODliZDgxODEw ZGVjZmYyOGYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTA5LTI3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBJ bXByb3ZlIGNvbW1lbnQgaW4gcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1VzZXJB Z2VudEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmlu Zyk6CisKKzIwMTYtMDktMjcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEu Y29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQgdHlwbyBmaXgKIAogICAgICAgICAqIHBsYXRmb3Jt L2d0ay9Vc2VyQWdlbnRHdGsuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNl ckFnZW50R3RrLmNwcAppbmRleCA3NDNlYmEwMDExY2NiNTQ4NGZmNmY2MzZiNjVlMmQ1ZWIyYWY3 OTM4Li4zMDVjMGI4NzM1OTVjY2NkMDZkYjM2NWEzYTNhZjBiNmUwMGY1NWUxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApAQCAtMTA1LDcgKzEwNSw3 IEBAIHN0YXRpYyBjb25zdCBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKQogICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IHVhT1NWZXJzaW9uKFN0cmluZzo6 Zm9ybWF0KCIlcyAlcyIsIG5hbWUuc3lzbmFtZSwgbmFtZS5tYWNoaW5lKSk7CiAgICAgcmV0dXJu IHVhT1NWZXJzaW9uOwogI2Vsc2UKLSAgICAvLyBXZSB3aWxsIGFsd2F5cyBjbGFpbSB0byBiZSBT YWZhcmkgaW4gTWFjIE9TIFgsIHNpbmNlIFNhZmFyaSBpbiBMaW51eCB0cmlnZ2VycyB0aGUgaU9T IHBhdGggb24gc29tZSB3ZWJzaXRlcy4KKyAgICAvLyBGSVhNRTogVGhlIGZpbmFsIHJlc3VsdCBz aG91bGQgaW5jbHVkZSBPUyB2ZXJzaW9uLCBlLmcuICJJbnRlbCBNYWMgT1MgWCAxMF84XzQiLgog ICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+IHVhT1NWZXJzaW9uKFN0cmlu Zzo6Zm9ybWF0KCIlcyBNYWMgT1MgWCIsIGNwdURlc2NyaXB0aW9uRm9yVUFTdHJpbmcoKSkpOwog ICAgIHJldHVybiB1YU9TVmVyc2lvbjsKICNlbmRpZgo= 290077 2016-09-28 05:35:10 -0700 2016-10-05 03:36:51 -0700 Patch bug-162612-20160928143210.patch text/plain 1648 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1 OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uYmIwMjllNTQyNmEwZGJjY2I1ZTE1YTIyMTg1NjRh NzI0YWU0MmNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA5LTI4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBJ bXByb3ZlIGNvbW1lbnQgaW4gcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1VzZXJB Z2VudEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmlu Zyk6CisKIDIwMTYtMDktMjcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdHlwbyBmaXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKaW5kZXggNzQzZWJhMDAxMWNjYjU0ODRmZjZmNjM2 YjY1ZTJkNWViMmFmNzkzOC4uNjk0OTQ3OTFlZmE3YjBiZDFhMjkxODNmYmYzMzhlZWNmNWI4NTBm ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKQEAg LTEwNSw3ICsxMDUsOCBAQCBzdGF0aWMgY29uc3QgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVB U3RyaW5nKCkKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YU9TVmVy c2lvbihTdHJpbmc6OmZvcm1hdCgiJXMgJXMiLCBuYW1lLnN5c25hbWUsIG5hbWUubWFjaGluZSkp OwogICAgIHJldHVybiB1YU9TVmVyc2lvbjsKICNlbHNlCi0gICAgLy8gV2Ugd2lsbCBhbHdheXMg Y2xhaW0gdG8gYmUgU2FmYXJpIGluIE1hYyBPUyBYLCBzaW5jZSBTYWZhcmkgaW4gTGludXggdHJp Z2dlcnMgdGhlIGlPUyBwYXRoIG9uIHNvbWUgd2Vic2l0ZXMuCisgICAgLy8gV2Ugd2lsbCBhbHdh eXMgY2xhaW0gdG8gYmUgU2FmYXJpIGluIE1hYyBPUyBYLCBzaW5jZSBTYWZhcmkgd2l0aG91dCBP UyBYIHRyaWdnZXJzIHRoZSBpT1MgcGF0aCBvbiBzb21lIHdlYnNpdGVzLgorICAgIC8vIEZJWE1F OiBUaGUgZmluYWwgcmVzdWx0IHNob3VsZCBpbmNsdWRlIE9TIHZlcnNpb24sIGUuZy4gIkludGVs IE1hYyBPUyBYIDEwXzhfNCIuCiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmlu Zz4gdWFPU1ZlcnNpb24oU3RyaW5nOjpmb3JtYXQoIiVzIE1hYyBPUyBYIiwgY3B1RGVzY3JpcHRp b25Gb3JVQVN0cmluZygpKSk7CiAgICAgcmV0dXJuIHVhT1NWZXJzaW9uOwogI2VuZGlmCg==