<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>162611</bug_id>
          
          <creation_ts>2016-09-27 08:19:43 -0700</creation_ts>
          <short_desc>[WPE][GTK] Allow distributors to brand user agent</short_desc>
          <delta_ts>2020-03-23 15:59:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=204399</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>142074</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jbicha</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>olivier.blin</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>tpopela</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1233860</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-27 08:19:43 -0700</bug_when>
    <thetext>Allow distributions to add branding to user agent, right after X11, if desired. This seems to be the safest place to put it to avoid breakage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1233862</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-27 08:22:56 -0700</bug_when>
    <thetext>Also, fix related issues in this function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1233874</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-27 08:51:41 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Also, fix related issues in this function.

Just kidding</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1233914</commentid>
    <comment_count>3</comment_count>
      <attachid>289961</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-27 09:55:42 -0700</bug_when>
    <thetext>Created attachment 289961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1234318</commentid>
    <comment_count>4</comment_count>
      <attachid>289961</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2016-09-28 03:33:06 -0700</bug_when>
    <thetext>Comment on attachment 289961
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289961&amp;action=review

&gt; Source/WebCore/platform/gtk/UserAgentGtk.cpp:132
&gt; +#ifdef USER_AGENT_GTK_DISTRIBUTOR_NAME

Usually we go with defined(MACRO) &amp;&amp; MACRO -- unless an empty string is an option(?).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1234336</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-28 05:23:15 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; Comment on attachment 289961 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=289961&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/gtk/UserAgentGtk.cpp:132
&gt; &gt; +#ifdef USER_AGENT_GTK_DISTRIBUTOR_NAME
&gt; 
&gt; Usually we go with defined(MACRO) &amp;&amp; MACRO -- unless an empty string is an
&gt; option(?).

Usually our macros are defined to 0 or 1 where a boolean comparison is more natural. This one is either defined to a string if it&apos;s to be used, or not defined at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1234768</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-09-29 03:16:47 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Usually our macros are defined to 0 or 1 where a boolean comparison is more
&gt; natural. This one is either defined to a string if it&apos;s to be used, or not
&gt; defined at all.

To be clear, the reason we usually need both checks is that we don&apos;t want to enable the feature if the preprocessor variable is defined to 0. That&apos;s not a concern in this case. If you define USER_AGENT_GTK_DISTRIBUTOR_NAME to an empty string, that&apos;s pretty silly, but harmless (you&apos;ll get an extra semicolon in the UA).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1236287</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-04 11:36:28 -0700</bug_when>
    <thetext>Ping reviewers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1240929</commentid>
    <comment_count>8</comment_count>
      <attachid>291809</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-17 04:41:01 -0700</bug_when>
    <thetext>Created attachment 291809
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1245121</commentid>
    <comment_count>9</comment_count>
      <attachid>293018</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-27 07:21:14 -0700</bug_when>
    <thetext>Created attachment 293018
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262779</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-12-26 15:07:54 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Ping reviewers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262987</commentid>
    <comment_count>11</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-12-28 15:13:15 -0800</bug_when>
    <thetext>What can I do to get this approved? What if I move the distributor to the end of the UA, would that be accepted?

Distributor branding is not optional for us and I hate carrying this downstream forever.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1268424</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-01-20 05:49:37 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; What can I do to get this approved? What if I move the distributor to the
&gt; end of the UA, would that be accepted?

Let&apos;s move it to the end, and also put WebKitGTK+ there. And instead of using a preprocessor conditional, let&apos;s read it from the NAME and VERSION_ID fields in /etc/os-release. Should look like e.g.:

Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/603.1 (KHTML, like Gecko) Version/10.0 Safari/603.1 Fedora/25 WebKitGTK+/603.1 Epiphany/3.22.5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1268425</commentid>
    <comment_count>13</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-01-20 05:51:40 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/603.1 (KHTML, like
&gt; Gecko) Version/10.0 Safari/603.1 Fedora/25 WebKitGTK+/603.1 Epiphany/3.22.5

I&apos;m really bad at copy-pasting. The distributor should only be there once:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/603.1 (KHTML, like Gecko) Version/10.0 Safari/603.1 Fedora/25 WebKitGTK+/603.1 Epiphany/3.22.5

Also looks like we need to bump Safari version from Version/10.0 to Version/11.0.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1268882</commentid>
    <comment_count>14</comment_count>
      <attachid>293018</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-01-22 08:58:06 -0800</bug_when>
    <thetext>Comment on attachment 293018
Patch

The /etc/os-release plan was a bad idea. It&apos;s not good enough because there is no field that includes a name that is guaranteed to be suitable for use in the user agent. E.g. the name could be &quot;Debian GNU/Linux&quot; which is not suitable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1306966</commentid>
    <comment_count>15</comment_count>
      <attachid>293018</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-05-10 13:09:09 -0700</bug_when>
    <thetext>Comment on attachment 293018
Patch

In the end, I&apos;ve come to believe Carlos Garcia was right all along and we shouldn&apos;t do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1378619</commentid>
    <comment_count>16</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-12-06 08:52:04 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #15)
&gt; Comment on attachment 293018 [details]
&gt; Patch
&gt; 
&gt; In the end, I&apos;ve come to believe Carlos Garcia was right all along and we
&gt; shouldn&apos;t do this.

Um, I forgot I ever said this. We&apos;re still using this patch in Fedora. I&apos;ve removed Epiphany&apos;s distro branding feature, and advised Ubuntu to apply this patch instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1610677</commentid>
    <comment_count>17</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-01-24 08:00:26 -0800</bug_when>
    <thetext>Ubuntu and Fedora have been applying this patch for years... any hope of reconsideration?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617052</commentid>
    <comment_count>18</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-02-10 13:13:55 -0800</bug_when>
    <thetext>Carlos, if I change this to be a CMake build option, could we get it in? I&apos;d really like to reduce downstream patches as far as possible. This is being used by both Ubuntu and Fedora, and combined that accounts for probably 80% of our users.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1617299</commentid>
    <comment_count>19</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2020-02-11 01:02:13 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #18)
&gt; Carlos, if I change this to be a CMake build option, could we get it in? I&apos;d
&gt; really like to reduce downstream patches as far as possible. This is being
&gt; used by both Ubuntu and Fedora, and combined that accounts for probably 80%
&gt; of our users.

Let&apos;s do that</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626904</commentid>
    <comment_count>20</comment_count>
      <attachid>392784</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-06 15:20:14 -0800</bug_when>
    <thetext>Created attachment 392784
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626905</commentid>
    <comment_count>21</comment_count>
      <attachid>392785</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-06 15:20:41 -0800</bug_when>
    <thetext>Created attachment 392785
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1627285</commentid>
    <comment_count>22</comment_count>
      <attachid>392785</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-03-07 13:21:33 -0800</bug_when>
    <thetext>Comment on attachment 392785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392785&amp;action=review

&gt; Source/WebCore/ChangeLog:3
&gt; +        [GTK] Allow distributors to brand user agent

The patch (and bug title) should include “[WPE]” :)

&gt; Source/WebCore/platform/glib/UserAgentGLib.cpp:93
&gt; +        uaString.appendLiteral(DISTRIBUTOR_BRANDING &quot;; &quot;);

Let&apos;s imagine for a moment that I don&apos;t trust what people will pass in the
build option as a valid User-Agent header value: if somebody puts something
here which does not conform to RFC 7231 (section 5.5.3, more specifically)
they will have web sites fails in mysterious ways when the server does strict
validation of the header. I have seen some CDNs (Cloudfare, for example)
returning HTTP 400 (Bad Request) if the UA string has invalid contents. And
trust me that people will knock their heads against the wall for days without
end before realizing that they have added garbage to the UA string.

Therefore, that when custom branding is added we need to unconditionally
call isValidUserAgentHeaderValue()—not just an assertion—, log an error
message very noticeably, and abort() the process... Unless you can come up
with some way of checking the passed value when running CMake.

&gt; Source/cmake/OptionsGTK.cmake:20
&gt; +set(DISTRIBUTOR_BRANDING &quot;&quot; CACHE STRING &quot;Branding to add to user agent string&quot;)

The name “DISTRIBUTOR_BRANDING” kind of implies that this is some general
branding, to be used only by distributors (what if I am not one and still
want to use the option?) and not just for the user agent. The description
of the option clarifies it, yet I think a better name could be something
like “USER_AGENT_BRANDING”.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1627874</commentid>
    <comment_count>23</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-09 12:31:19 -0700</bug_when>
    <thetext>(In reply to Adrian Perez from comment #22)
&gt; Therefore, that when custom branding is added we need to unconditionally
&gt; call isValidUserAgentHeaderValue()—not just an assertion—, log an error
&gt; message very noticeably, and abort() the process...

So... RELEASE_ASSERT()?

&gt; Unless you can come up
&gt; with some way of checking the passed value when running CMake.

Certainly not.

&gt; The name “DISTRIBUTOR_BRANDING” kind of implies that this is some general
&gt; branding, to be used only by distributors (what if I am not one and still
&gt; want to use the option?) and not just for the user agent. The description
&gt; of the option clarifies it, yet I think a better name could be something
&gt; like “USER_AGENT_BRANDING”.

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628990</commentid>
    <comment_count>24</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-11 19:32:43 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #23)
&gt; So... RELEASE_ASSERT()?

Adrian, is this OK?

There will be more overhead on every request... tbh, I don&apos;t think it&apos;s worth it, but your call.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630783</commentid>
    <comment_count>25</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 10:44:58 -0700</bug_when>
    <thetext>Assuming RELEASE_ASSERT() is OK... and hoping a runtime check doesn&apos;t regress perf... I still don&apos;t think it&apos;s useful to perform this check at runtime tbh, as configuring invalid branding is pretty unlikely....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630784</commentid>
    <comment_count>26</comment_count>
      <attachid>393766</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 10:48:31 -0700</bug_when>
    <thetext>Created attachment 393766
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630793</commentid>
    <comment_count>27</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-03-17 11:12:12 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #25)
&gt; Assuming RELEASE_ASSERT() is OK... and hoping a runtime check doesn&apos;t
&gt; regress perf... 

If you are able to find any benchmark or test where this extra RELEASE_ASSERT can cause any noticeable performance regression I would be very very surprised, please let me know it.
 
&gt; I still don&apos;t think it&apos;s useful to perform this check at
&gt; runtime tbh, as configuring invalid branding is pretty unlikely....

I think its useful for the reasons Adrian commented, specially if you tell the user/distributor what is happening.

So instead of using RELEASE_ASSERT and simply crash, I think we should use RELEASE_ASSERT_WITH_MESSAGE() and log some meaningful message before crashing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630805</commentid>
    <comment_count>28</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-03-17 11:24:46 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #27)
&gt; (In reply to Michael Catanzaro from comment #25)
&gt; &gt; Assuming RELEASE_ASSERT() is OK... and hoping a runtime check doesn&apos;t
&gt; &gt; regress perf... 
&gt; 
&gt; If you are able to find any benchmark or test where this extra
&gt; RELEASE_ASSERT can cause any noticeable performance regression I would be
&gt; very very surprised, please let me know it.
&gt;  
&gt; &gt; I still don&apos;t think it&apos;s useful to perform this check at
&gt; &gt; runtime tbh, as configuring invalid branding is pretty unlikely....
&gt; 
&gt; I think its useful for the reasons Adrian commented, specially if you tell
&gt; the user/distributor what is happening.
&gt; 
&gt; So instead of using RELEASE_ASSERT and simply crash, I think we should use
&gt; RELEASE_ASSERT_WITH_MESSAGE() and log some meaningful message before
&gt; crashing.

Mmm.. not sure if RELEASE_ASSERT_WITH_MESSAGE() does what i think it should do on GTK.. i don&apos;t see it logging a message on a quick test :\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630807</commentid>
    <comment_count>29</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 11:29:42 -0700</bug_when>
    <thetext>It should boil down to the vfprintf(stderr, format, args) call at the bottom of vprintf_stderr_common() in Assertions.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630810</commentid>
    <comment_count>30</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2020-03-17 11:31:58 -0700</bug_when>
    <thetext>Is it desirable to brand UA of whole engine, or of particular applications? In Qt port we support putting application name (or other string, provided by application) into UA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630821</commentid>
    <comment_count>31</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 11:53:04 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #28) 
&gt; Mmm.. not sure if RELEASE_ASSERT_WITH_MESSAGE() does what i think it should
&gt; do on GTK.. i don&apos;t see it logging a message on a quick test :\

Yeah, it indeed seems to be busted. Anyway, that should be fixed separately.

(In reply to Konstantin Tokarev from comment #30)
&gt; Is it desirable to brand UA of whole engine, or of particular applications?
&gt; In Qt port we support putting application name (or other string, provided by
&gt; application) into UA

Yes, our two largest distributors will continue doing this in downstream patches if we don&apos;t allow it upstream.

I don&apos;t necessarily recommend branding by application name anyway. I&apos;ve started to experiment by removing Epiphany entirely from its user agent string. This makes a big difference on browserdetect.org at least, because Safari version is now detected as 13 instead of 605.1. Probably we&apos;ll stick with this approach.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630823</commentid>
    <comment_count>32</comment_count>
      <attachid>393772</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 11:53:39 -0700</bug_when>
    <thetext>Created attachment 393772
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630834</commentid>
    <comment_count>33</comment_count>
      <attachid>393772</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-03-17 12:17:14 -0700</bug_when>
    <thetext>Comment on attachment 393772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393772&amp;action=review

&gt; Source/WebCore/platform/glib/UserAgentGLib.cpp:147
&gt; +    RELEASE_ASSERT(isValidUserAgentHeaderValue(userAgent), &quot;%s is not a valid user agent header&quot;, userAgent.utf8().data());

Shouldn&apos;t this be RELEASE_ASSERT_WITH_MESSAGE?

&gt; Source/WebCore/platform/glib/UserAgentGLib.cpp:159
&gt; +    RELEASE_ASSERT(isValidUserAgentHeaderValue(userAgent), &quot;%s is not a valid user agent header&quot;, userAgent.utf8().data());

ditto</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630836</commentid>
    <comment_count>34</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 12:29:23 -0700</bug_when>
    <thetext>(In reply to Carlos Alberto Lopez Perez from comment #33)
&gt; Shouldn&apos;t this be RELEASE_ASSERT_WITH_MESSAGE?

Yeah, calling the right function would certainly help....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630837</commentid>
    <comment_count>35</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 12:32:20 -0700</bug_when>
    <thetext>It doesn&apos;t work anyway though. I found: bug #204399.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1630841</commentid>
    <comment_count>36</comment_count>
      <attachid>393776</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-17 12:35:46 -0700</bug_when>
    <thetext>Created attachment 393776
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1632635</commentid>
    <comment_count>37</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-22 08:20:54 -0700</bug_when>
    <thetext>Ping Adrian!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1632928</commentid>
    <comment_count>38</comment_count>
      <attachid>393776</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2020-03-23 10:57:44 -0700</bug_when>
    <thetext>Comment on attachment 393776
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393776&amp;action=review

Patch looks good, thanks a lot for updating it!

&gt; Source/WebCore/platform/glib/UserAgentGLib.cpp:147
&gt; +    RELEASE_ASSERT_WITH_MESSAGE(isValidUserAgentHeaderValue(userAgent), &quot;%s is not a valid user agent header&quot;, userAgent.utf8().data());

If there are concerns about the assertion being made on each network
request, an option could be to have a boolean flag to do it only
the first time:

   static bool uaBrandCheckDone = false;
   if (!uaBrandCheckDone) {
       RELEASE_ASSERT_WITH_MESSAGE(...);
       uaBrandCheckDone =  true;
   }</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633015</commentid>
    <comment_count>39</comment_count>
      <attachid>394301</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-23 14:07:14 -0700</bug_when>
    <thetext>Created attachment 394301
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633042</commentid>
    <comment_count>40</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-03-23 14:50:54 -0700</bug_when>
    <thetext>Committed r258877: &lt;https://trac.webkit.org/changeset/258877&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394301.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633067</commentid>
    <comment_count>41</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-23 15:19:40 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633068</commentid>
    <comment_count>42</comment_count>
      <attachid>394311</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-23 15:19:43 -0700</bug_when>
    <thetext>Created attachment 394311
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1633093</commentid>
    <comment_count>43</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-03-23 15:59:38 -0700</bug_when>
    <thetext>Committed r258883: &lt;https://trac.webkit.org/changeset/258883&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394311.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>289961</attachid>
            <date>2016-09-27 09:55:42 -0700</date>
            <delta_ts>2016-10-17 04:40:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20160927185243.patch</filename>
            <type>text/plain</type>
            <size>1410</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1
OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uZGRiMDVmYTFkODMxYzk1NzA0YzQ0NzUyZjM2OTA1
MzU0YzM1MWRmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTA5LTI3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBB
bGxvdyBkaXN0cmlidXRvcnMgdG8gYnJhbmQgdXNlciBhZ2VudAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjExCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVXNlckFnZW50R3Rr
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5nKToKKworMjAxNi0w
OS0yNyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAg
ICAgVW5yZXZpZXdlZCB0eXBvIGZpeAogCiAgICAgICAgICogcGxhdGZvcm0vZ3RrL1VzZXJBZ2Vu
dEd0ay5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFn
ZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3Bw
CmluZGV4IDc0M2ViYTAwMTFjY2I1NDg0ZmY2ZjYzNmI2NWUyZDVlYjJhZjc5MzguLmQ3ZjQ1NWUw
M2M3Zjk5M2NkMmQxN2IxODhmMzc3MWY5NjgyM2Y1NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCkBAIC0xMjksNiArMTI5LDEwIEBAIHN0YXRpYyBT
dHJpbmcgYnVpbGRVc2VyQWdlbnRTdHJpbmcoY29uc3QgVXNlckFnZW50UXVpcmtzJiBxdWlya3Mp
CiAKICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCI7ICIpOwogCisjaWZkZWYgVVNFUl9BR0VO
VF9HVEtfRElTVFJJQlVUT1JfTkFNRQorICAgIHVhU3RyaW5nLmFwcGVuZExpdGVyYWwoVVNFUl9B
R0VOVF9HVEtfRElTVFJJQlVUT1JfTkFNRSAiOyAiKTsKKyNlbmRpZgorCiAgICAgaWYgKHF1aXJr
cy5jb250YWlucyhVc2VyQWdlbnRRdWlya3M6Ok5lZWRzTWFjaW50b3NoUGxhdGZvcm0pKSB7CiAg
ICAgICAgIHVhU3RyaW5nLmFwcGVuZChjcHVEZXNjcmlwdGlvbkZvclVBU3RyaW5nKCkpOwogICAg
ICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCIgTWFjIE9TIFgiKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>291809</attachid>
            <date>2016-10-17 04:41:01 -0700</date>
            <delta_ts>2016-10-27 07:21:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20161017063728.patch</filename>
            <type>text/plain</type>
            <size>1450</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E4OTQzY2M4OGMzOGRl
MDM2NDdiZTAyZjAzMDVjMzhlODMwZjg0YS4uMDlhZjQ0Y2NhOWEwNzM0MWNiZmIzOGQ4NTViYTVj
MDQwNjc3OThlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTEwLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBB
bGxvdyBkaXN0cmlidXRvcnMgdG8gYnJhbmQgdXNlciBhZ2VudAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjExCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVXNlckFnZW50R3Rr
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5nKToKKworMjAxNi0x
MC0xNyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAg
ICAgTW92ZSB1c2VyIGFnZW50IHF1aXJrcyB0byBjcm9zcy1wbGF0Zm9ybSBsb2NhdGlvbgogICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNTA4CiAKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKaW5kZXggYTEwMjdj
M2MwNmQzMjliZjAyNzRjNjYwNzA3Njc0ZDFmY2IxNzE5Ny4uYjJjZDMyNDM3NGE4NTc3MDNmMTJm
YjdhMTk3OTNmYjNlMTk0MzBhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3RrL1VzZXJBZ2VudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Vz
ZXJBZ2VudEd0ay5jcHAKQEAgLTg1LDYgKzg1LDkgQEAgc3RhdGljIFN0cmluZyBidWlsZFVzZXJB
Z2VudFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykKICAgICBlbHNlIHsKICAg
ICAgICAgdWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtRm9yVUFTdHJpbmcoKSk7CiAgICAgICAgIHVh
U3RyaW5nLmFwcGVuZExpdGVyYWwoIjsgIik7CisjaWYgZGVmaW5lZChVU0VSX0FHRU5UX0dUS19E
SVNUUklCVVRPUl9OQU1FKSAmJiBVU0VSX0FHRU5UX0dUS19ESVNUUklCVVRPUl9OQU1FCisgICAg
ICAgIHVhU3RyaW5nLmFwcGVuZExpdGVyYWwoVVNFUl9BR0VOVF9HVEtfRElTVFJJQlVUT1JfTkFN
RSAiOyAiKTsKKyNlbmRpZgogICAgICAgICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1WZXJzaW9u
Rm9yVUFTdHJpbmcoKSk7CiAgICAgfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>293018</attachid>
            <date>2016-10-27 07:21:14 -0700</date>
            <delta_ts>2020-03-06 15:20:12 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20161027091725.patch</filename>
            <type>text/plain</type>
            <size>1369</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU3ODNiMjM1NDdjNjY5
MjYyYWZiZDE4NGRmYTEyMGMxZjdkZmIxNS4uNjBkOTU0M2E0N2MyMzcwN2Q0ZGE3MDU4YjcwNGVm
NGRjNzNhMWIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTI3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBB
bGxvdyBkaXN0cmlidXRvcnMgdG8gYnJhbmQgdXNlciBhZ2VudAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjExCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVXNlckFnZW50R3Rr
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5nKToKKwogMjAxNi0x
MC0yNiAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ1NTIFBhcnNl
cl0gVW5pZnkgQ1NTQ3VzdG9tUHJvcGVydHlWYWx1ZSBhbmQgQ1NTQ3VzdG9tUHJvcGVydHlEZWNs
YXJhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2Vu
dEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApp
bmRleCBhMTAyN2MzYzA2ZDMyOWJmMDI3NGM2NjA3MDc2NzRkMWZjYjE3MTk3Li45ZGMyNjI5ZWI0
OWZhYTZhOWJmMTI4ZDdlNzc3MTBjNjJlOTc3OTgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcApAQCAtODUsNiArODUsOSBAQCBzdGF0aWMgU3RyaW5n
IGJ1aWxkVXNlckFnZW50U3RyaW5nKGNvbnN0IFVzZXJBZ2VudFF1aXJrcyYgcXVpcmtzKQogICAg
IGVsc2UgewogICAgICAgICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1Gb3JVQVN0cmluZygpKTsK
ICAgICAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJhbCgiOyAiKTsKKyNpZiBkZWZpbmVkKFVTRVJf
QUdFTlRfR1RLX0RJU1RSSUJVVE9SX05BTUUpCisgICAgICAgIHVhU3RyaW5nLmFwcGVuZExpdGVy
YWwoVVNFUl9BR0VOVF9HVEtfRElTVFJJQlVUT1JfTkFNRSAiOyAiKTsKKyNlbmRpZgogICAgICAg
ICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKSk7CiAgICAgfQog
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>392784</attachid>
            <date>2020-03-06 15:20:14 -0800</date>
            <delta_ts>2020-03-06 15:20:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20200306172013.patch</filename>
            <type>text/plain</type>
            <size>3819</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RlNDI2ZDMyNTgyYjEy
ZTMyNzFlODZlMmM4NTMxMTdlOGJiYzg3Yy4uNzkxYmRlZDk5ZGVjNWY2ZGY3MTBjYmU1MjhkNjFj
YWFlNTFiOTQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTA2ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xp
Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKIDIwMjAt
MDMtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg
TWFrZSBpdCBwb3NzaWJsZSB0byBzYWZlbHkgYWNjZXNzIENBTGF5ZXJzIGFuZCBQbGF0Zm9ybUNB
TGF5ZXJDb2NvYSBvYmplY3RzIG9uIHRoZSBzY3JvbGxpbmcgdGhyZWFkCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAppbmRleCA2NzI5MTYyNGVmZmRm
YzExM2JkMWEwODRjMGU3ZGYzODA4MmNkZGU5Li45NjU3NDliMzFhNzMxZTdhYTNiYjhkMjcxYjY5
MGJmYTFjOTJhNzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1Vz
ZXJBZ2VudEdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFn
ZW50R0xpYi5jcHAKQEAgLTg5LDYgKzg5LDkgQEAgc3RhdGljIFN0cmluZyBidWlsZFVzZXJBZ2Vu
dFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykKICAgICBlbHNlIHsKICAgICAg
ICAgdWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtRm9yVUFTdHJpbmcoKSk7CiAgICAgICAgIHVhU3Ry
aW5nLmFwcGVuZExpdGVyYWwoIjsgIik7CisjaWYgZGVmaW5lZChESVNUUklCVVRPUl9CUkFORElO
RykKKyAgICAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJhbChESVNUUklCVVRPUl9CUkFORElORyAi
OyAiKTsKKyNlbmRpZgogICAgICAgICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1WZXJzaW9uRm9y
VUFTdHJpbmcoKSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dU
Sy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYyOGFmYzM2ZDUx
MzA3ZjhjOGNmNzc2YWY1NDM0ZTllZmUxZTRlMWQuLjI5ZjkxZGVlN2Y3OTE1OWEzNGQzNTM1MDdh
NGJlYTk5YzYxZTZlOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl
CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNyw2ICsxNywxMSBAQCBz
ZXQoV0VCS0lUR1RLX0hFQURFUl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0lOQ0xVREVE
SVJ9L3dlYmtpdGd0ay0ke1dFQktJVAogc2V0KElOVFJPU1BFQ1RJT05fSU5TVEFMTF9HSVJESVIg
IiR7Q01BS0VfSU5TVEFMTF9GVUxMX0RBVEFESVJ9L2dpci0xLjAiKQogc2V0KElOVFJPU1BFQ1RJ
T05fSU5TVEFMTF9UWVBFTElCRElSICIke0xJQl9JTlNUQUxMX0RJUn0vZ2lyZXBvc2l0b3J5LTEu
MCIpCiAKK3NldChESVNUUklCVVRPUl9CUkFORElORyAiIiBDQUNIRSBTVFJJTkcgIkJyYW5kaW5n
IHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitpZiAoRElTVFJJQlVUT1JfQlJBTkRJTkcp
CisgICAgYWRkX2RlZmluaXRpb25zKC1ERElTVFJJQlVUT1JfQlJBTkRJTkc9IiR7RElTVFJJQlVU
T1JfQlJBTkRJTkd9IikKK2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShDYWlybyAxLjE0LjAgUkVR
VUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFj
a2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P
cHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKaW5kZXggMWFi
ZTk1MzIwZDVhNjM3OGNmMmE3ZDA5YWE5ZmY4ZDRhN2EwNGM0Yy4uMWFkZmFlOTAzMzkxNjY2ODYz
ODI1NmUxNmI4ZWZkYmQ0Yzk3YjYyZCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNX
UEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKQEAgLTEyLDYgKzEy
LDExIEBAIHNldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJQkRJUn0i
IENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8KIHNldChFWEVDX0lOU1RBTExfRElSICIke0NN
QUtFX0lOU1RBTExfRlVMTF9CSU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGV4
ZWN1dGFibGUgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCiBzZXQoTElCRVhFQ19JTlNUQUxMX0RJ
UiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd3BlLXdlYmtpdC0ke1dQRV9BUElf
VkVSU0lPTn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFsbCBleGVjdXRhYmxl
cyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiAKK3NldChESVNUUklCVVRPUl9CUkFORElORyAi
IiBDQUNIRSBTVFJJTkcgIkJyYW5kaW5nIHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitp
ZiAoe0RJU1RSSUJVVE9SX0JSQU5ESU5HKQorICAgIGFkZF9kZWZpbml0aW9ucygtRERJU1RSSUJV
VE9SX0JSQU5ESU5HPSR7RElTVFJJQlVUT1JfQlJBTkRJTkd9KQorZW5kaWYgKCkKKwogZmluZF9w
YWNrYWdlKENhaXJvIDEuMTQuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShGb250Y29uZmlnIDIu
OC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEZyZWV0eXBlIDIuNC4yIFJFUVVJUkVEKQpkaWZm
IC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDhmODUwMTIzNjA0OTIwNTNmZDAz
M2FkYzVkZDZkOGRkMWIxN2E5ZGQuLjAxMzcxYWZiNjkzMDA4ODIzOGRhNDNiNTNmOGVkNWM4NDdk
ZTM4MjcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
NSBAQAorMjAyMC0wMy0wNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9y
Zz4KKworICAgICAgICBbR1RLXSBBbGxvdyBkaXN0cmlidXRvcnMgdG8gYnJhbmQgdXNlciBhZ2Vu
dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjEx
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGJ1
aWxkIG9wdGlvbiBmb3IgaW5zZXJ0aW5nIGRpc3RyaWJ1dG9yIGJyYW5kaW5nIGludG8gdGhlIHVz
ZXIgYWdlbnQgc3RyaW5nLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h
a2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMjAtMDMt
MDMgIEZ1amlpIEhpcm9ub3JpICA8ZnVqaWkuaGlyb25vcmlAZ21haWwuY29tPgogCiAgICAgICAg
IFtDdXJsXSBBZGQgVExTIGRlYnVnZ2luZyBmZWF0dXJlIHRvIGxvZyBlbmNyeXB0aW9uIGtleXMK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>392785</attachid>
            <date>2020-03-06 15:20:41 -0800</date>
            <delta_ts>2020-03-17 10:48:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20200306172040.patch</filename>
            <type>text/plain</type>
            <size>3818</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2RlNDI2ZDMyNTgyYjEy
ZTMyNzFlODZlMmM4NTMxMTdlOGJiYzg3Yy4uNzkxYmRlZDk5ZGVjNWY2ZGY3MTBjYmU1MjhkNjFj
YWFlNTFiOTQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTA2ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xp
Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKIDIwMjAt
MDMtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg
TWFrZSBpdCBwb3NzaWJsZSB0byBzYWZlbHkgYWNjZXNzIENBTGF5ZXJzIGFuZCBQbGF0Zm9ybUNB
TGF5ZXJDb2NvYSBvYmplY3RzIG9uIHRoZSBzY3JvbGxpbmcgdGhyZWFkCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAppbmRleCA2NzI5MTYyNGVmZmRm
YzExM2JkMWEwODRjMGU3ZGYzODA4MmNkZGU5Li45NjU3NDliMzFhNzMxZTdhYTNiYjhkMjcxYjY5
MGJmYTFjOTJhNzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1Vz
ZXJBZ2VudEdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFn
ZW50R0xpYi5jcHAKQEAgLTg5LDYgKzg5LDkgQEAgc3RhdGljIFN0cmluZyBidWlsZFVzZXJBZ2Vu
dFN0cmluZyhjb25zdCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykKICAgICBlbHNlIHsKICAgICAg
ICAgdWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtRm9yVUFTdHJpbmcoKSk7CiAgICAgICAgIHVhU3Ry
aW5nLmFwcGVuZExpdGVyYWwoIjsgIik7CisjaWYgZGVmaW5lZChESVNUUklCVVRPUl9CUkFORElO
RykKKyAgICAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJhbChESVNUUklCVVRPUl9CUkFORElORyAi
OyAiKTsKKyNlbmRpZgogICAgICAgICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1WZXJzaW9uRm9y
VUFTdHJpbmcoKSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dU
Sy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGYyOGFmYzM2ZDUx
MzA3ZjhjOGNmNzc2YWY1NDM0ZTllZmUxZTRlMWQuLjI5ZjkxZGVlN2Y3OTE1OWEzNGQzNTM1MDdh
NGJlYTk5YzYxZTZlOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl
CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNyw2ICsxNywxMSBAQCBz
ZXQoV0VCS0lUR1RLX0hFQURFUl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0lOQ0xVREVE
SVJ9L3dlYmtpdGd0ay0ke1dFQktJVAogc2V0KElOVFJPU1BFQ1RJT05fSU5TVEFMTF9HSVJESVIg
IiR7Q01BS0VfSU5TVEFMTF9GVUxMX0RBVEFESVJ9L2dpci0xLjAiKQogc2V0KElOVFJPU1BFQ1RJ
T05fSU5TVEFMTF9UWVBFTElCRElSICIke0xJQl9JTlNUQUxMX0RJUn0vZ2lyZXBvc2l0b3J5LTEu
MCIpCiAKK3NldChESVNUUklCVVRPUl9CUkFORElORyAiIiBDQUNIRSBTVFJJTkcgIkJyYW5kaW5n
IHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitpZiAoRElTVFJJQlVUT1JfQlJBTkRJTkcp
CisgICAgYWRkX2RlZmluaXRpb25zKC1ERElTVFJJQlVUT1JfQlJBTkRJTkc9IiR7RElTVFJJQlVU
T1JfQlJBTkRJTkd9IikKK2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShDYWlybyAxLjE0LjAgUkVR
VUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFj
a2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P
cHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKaW5kZXggMWFi
ZTk1MzIwZDVhNjM3OGNmMmE3ZDA5YWE5ZmY4ZDRhN2EwNGM0Yy4uOGNjNGY0MGM5NmZmMTU1OGNm
ZjZiYTMxN2RhZWNlY2UxM2E0OWE5YyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNX
UEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKQEAgLTEyLDYgKzEy
LDExIEBAIHNldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJQkRJUn0i
IENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8KIHNldChFWEVDX0lOU1RBTExfRElSICIke0NN
QUtFX0lOU1RBTExfRlVMTF9CSU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGV4
ZWN1dGFibGUgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCiBzZXQoTElCRVhFQ19JTlNUQUxMX0RJ
UiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd3BlLXdlYmtpdC0ke1dQRV9BUElf
VkVSU0lPTn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFsbCBleGVjdXRhYmxl
cyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiAKK3NldChESVNUUklCVVRPUl9CUkFORElORyAi
IiBDQUNIRSBTVFJJTkcgIkJyYW5kaW5nIHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitp
ZiAoRElTVFJJQlVUT1JfQlJBTkRJTkcpCisgICAgYWRkX2RlZmluaXRpb25zKC1ERElTVFJJQlVU
T1JfQlJBTkRJTkc9JHtESVNUUklCVVRPUl9CUkFORElOR30pCitlbmRpZiAoKQorCiBmaW5kX3Bh
Y2thZ2UoQ2Fpcm8gMS4xNC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEZvbnRjb25maWcgMi44
LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRnJlZXR5cGUgMi40LjIgUkVRVUlSRUQpCmRpZmYg
LS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggOGY4NTAxMjM2MDQ5MjA1M2ZkMDMz
YWRjNWRkNmQ4ZGQxYjE3YTlkZC4uMDEzNzFhZmI2OTMwMDg4MjM4ZGE0M2I1M2Y4ZWQ1Yzg0N2Rl
MzgyNyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDIwLTAzLTA2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn
PgorCisgICAgICAgIFtHVEtdIEFsbG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYnVp
bGQgb3B0aW9uIGZvciBpbnNlcnRpbmcgZGlzdHJpYnV0b3IgYnJhbmRpbmcgaW50byB0aGUgdXNl
ciBhZ2VudCBzdHJpbmcuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr
ZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZToKKwogMjAyMC0wMy0w
MyAgRnVqaWkgSGlyb25vcmkgIDxmdWppaS5oaXJvbm9yaUBnbWFpbC5jb20+CiAKICAgICAgICAg
W0N1cmxdIEFkZCBUTFMgZGVidWdnaW5nIGZlYXR1cmUgdG8gbG9nIGVuY3J5cHRpb24ga2V5cwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393766</attachid>
            <date>2020-03-17 10:48:31 -0700</date>
            <delta_ts>2020-03-17 11:53:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20200317124831.patch</filename>
            <type>text/plain</type>
            <size>4426</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTUzZjZkMWVjMTM4NWRi
YjU2ZmVmZGU2NDE0OWJmNGJkMTJmMzljYy4uZWI3MzRkMjRhYTI4NjlhZjVjMjJjZDZlMDMwYjky
MDVmMGVhZTQwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xp
Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKIDIwMjAt
MDMtMTcgIEphY29iIFVwaG9mZiAgPGphY29iX3VwaG9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg
VW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNTc4NDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAppbmRleCA2NzI5MTYyNGVmZmRmYzExM2JkMWEwODRj
MGU3ZGYzODA4MmNkZGU5Li5mZGQ3YTVhOTUyNTI4MDNkZDA3MWNlN2VjN2JkZGNmMWI5YzM1ZjA1
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIu
Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xpYi5jcHAK
QEAgLTg5LDYgKzg5LDkgQEAgc3RhdGljIFN0cmluZyBidWlsZFVzZXJBZ2VudFN0cmluZyhjb25z
dCBVc2VyQWdlbnRRdWlya3MmIHF1aXJrcykKICAgICBlbHNlIHsKICAgICAgICAgdWFTdHJpbmcu
YXBwZW5kKHBsYXRmb3JtRm9yVUFTdHJpbmcoKSk7CiAgICAgICAgIHVhU3RyaW5nLmFwcGVuZExp
dGVyYWwoIjsgIik7CisjaWYgZGVmaW5lZChVU0VSX0FHRU5UX0JSQU5ESU5HKQorICAgICAgICB1
YVN0cmluZy5hcHBlbmRMaXRlcmFsKFVTRVJfQUdFTlRfQlJBTkRJTkcgIjsgIik7CisjZW5kaWYK
ICAgICAgICAgdWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkpOwog
ICAgIH0KIApAQCAtMTQxLDcgKzE0NCw3IEBAIFN0cmluZyBzdGFuZGFyZFVzZXJBZ2VudChjb25z
dCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlvCiAgICAg
ICAgICAgICBmaW5hbEFwcGxpY2F0aW9uVmVyc2lvbiA9IHZlcnNpb25Gb3JVQVN0cmluZygpOwog
ICAgICAgICB1c2VyQWdlbnQgPSBzdGFuZGFyZFVzZXJBZ2VudFN0YXRpYygpICsgJyAnICsgYXBw
bGljYXRpb25OYW1lICsgJy8nICsgZmluYWxBcHBsaWNhdGlvblZlcnNpb247CiAgICAgfQotICAg
IEFTU0VSVChpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUodXNlckFnZW50KSk7CisgICAgUkVM
RUFTRV9BU1NFUlQoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCkpOwogICAg
IHJldHVybiB1c2VyQWdlbnQ7CiB9CiAKQEAgLTE1Myw3ICsxNTYsNyBAQCBTdHJpbmcgc3RhbmRh
cmRVc2VyQWdlbnRGb3JVUkwoY29uc3QgVVJMJiB1cmwpCiAgICAgICAgIHJldHVybiBTdHJpbmco
KTsKIAogICAgIFN0cmluZyB1c2VyQWdlbnQoYnVpbGRVc2VyQWdlbnRTdHJpbmcocXVpcmtzKSk7
Ci0gICAgQVNTRVJUKGlzVmFsaWRVc2VyQWdlbnRIZWFkZXJWYWx1ZSh1c2VyQWdlbnQpKTsKKyAg
ICBSRUxFQVNFX0FTU0VSVChpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUodXNlckFnZW50KSk7
CiAgICAgcmV0dXJuIHVzZXJBZ2VudDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09w
dGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCBmZDM2
N2I4MjYzOGY5NmUxYzFmOTRlYmVmZTkzZmJiMDQzOWE0ZmJlLi4zNTY2MWFiZDY0NWU2YzFjZjk0
Nzc0ODhlNTk2ODA5NDYzMTI0N2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dU
Sy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMTcsNiArMTcs
MTEgQEAgc2V0KFdFQktJVEdUS19IRUFERVJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9J
TkNMVURFRElSfS93ZWJraXRndGstJHtXRUJLSVQKIHNldChJTlRST1NQRUNUSU9OX0lOU1RBTExf
R0lSRElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9EQVRBRElSfS9naXItMS4wIikKIHNldChJTlRS
T1NQRUNUSU9OX0lOU1RBTExfVFlQRUxJQkRJUiAiJHtMSUJfSU5TVEFMTF9ESVJ9L2dpcmVwb3Np
dG9yeS0xLjAiKQogCitzZXQoVVNFUl9BR0VOVF9CUkFORElORyAiIiBDQUNIRSBTVFJJTkcgIkJy
YW5kaW5nIHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitpZiAoVVNFUl9BR0VOVF9CUkFO
RElORykKKyAgICBhZGRfZGVmaW5pdGlvbnMoLURVU0VSX0FHRU5UX0JSQU5ESU5HPSIke1VTRVJf
QUdFTlRfQlJBTkRJTkd9IikKK2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShDYWlybyAxLjE0LjAg
UkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRf
cGFja2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr
ZS9PcHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKaW5kZXgg
OTVjMzgzYThjMTNjNjZmNzhmNDczYzc2ZTYyMmVhOGZlZDUwYTQzOC4uMWI1M2Q4MTE5NjgxZTkw
NDFiMmQwMDhlYzkxMmRlZDgzODExNTRjNSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlv
bnNXUEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKQEAgLTEyLDYg
KzEyLDExIEBAIHNldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJQkRJ
Un0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8KIHNldChFWEVDX0lOU1RBTExfRElSICIk
e0NNQUtFX0lOU1RBTExfRlVMTF9CSU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRv
IGV4ZWN1dGFibGUgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCiBzZXQoTElCRVhFQ19JTlNUQUxM
X0RJUiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd3BlLXdlYmtpdC0ke1dQRV9B
UElfVkVSU0lPTn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFsbCBleGVjdXRh
YmxlcyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiAKK3NldChVU0VSX0FHRU5UX0JSQU5ESU5H
ICIiIENBQ0hFIFNUUklORyAiQnJhbmRpbmcgdG8gYWRkIHRvIHVzZXIgYWdlbnQgc3RyaW5nIikK
K2lmIChVU0VSX0FHRU5UX0JSQU5ESU5HKQorICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRVJfQUdF
TlRfQlJBTkRJTkc9JHtVU0VSX0FHRU5UX0JSQU5ESU5HfSkKK2VuZGlmICgpCisKIGZpbmRfcGFj
a2FnZShDYWlybyAxLjE0LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjgu
MCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAt
LWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGNmMTk2ZTVlYjM3YTBjMTc2MWRl
MTAxMmE4ZjIzYmU1NjNmOWE0Li40NDFlNGI5YjU1MjFmYWFkYTQ2OTU1MTYwYTMyMTg1MWFiYTFj
NzJkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMjAtMDMtMTcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+
CisKKyAgICAgICAgW0dUS10gQWxsb3cgZGlzdHJpYnV0b3JzIHRvIGJyYW5kIHVzZXIgYWdlbnQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBidWls
ZCBvcHRpb24gZm9yIGluc2VydGluZyBkaXN0cmlidXRvciBicmFuZGluZyBpbnRvIHRoZSB1c2Vy
IGFnZW50IHN0cmluZy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl
OgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorCiAyMDIwLTAzLTE3
ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUxF
QVNFX0xPRyBzaG91bGQgbm90IGJlIENvY29hIHNwZWNpZmljCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393772</attachid>
            <date>2020-03-17 11:53:39 -0700</date>
            <delta_ts>2020-03-17 12:29:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20200317135338.patch</filename>
            <type>text/plain</type>
            <size>4606</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRiNzdkNmFmNmI4NmQ3
YzQ4Y2E5ZTlkZmJkNjM1ZjMxZGU4YThmYi4uZmMzZmI1NTI5N2MwMWU0ZTQ0ZThlZDI2MWM2NDhi
YWM0Yzc0Y2U3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xp
Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKIDIwMjAt
MDMtMTcgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAg
IEFYSXNvbGF0ZWRUcmVlIHJlbW92YWwgc2hvdWxkIHNldCBhbGwgbm9kZXMgdG8gYmUgcmVtb3Zl
ZCBvbiBBWCBzZWNvbmRhcnkgdGhyZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ds
aWIvVXNlckFnZW50R0xpYi5jcHAKaW5kZXggNjcyOTE2MjRlZmZkZmMxMTNiZDFhMDg0YzBlN2Rm
MzgwODJjZGRlOS4uNTlhMTFiNDMzMWM3NDZlZDllMDVjMjQ3MjFmNjY0ZTE5MjhkZmEwOCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwCkBAIC04
OSw2ICs4OSw5IEBAIHN0YXRpYyBTdHJpbmcgYnVpbGRVc2VyQWdlbnRTdHJpbmcoY29uc3QgVXNl
ckFnZW50UXVpcmtzJiBxdWlya3MpCiAgICAgZWxzZSB7CiAgICAgICAgIHVhU3RyaW5nLmFwcGVu
ZChwbGF0Zm9ybUZvclVBU3RyaW5nKCkpOwogICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFs
KCI7ICIpOworI2lmIGRlZmluZWQoVVNFUl9BR0VOVF9CUkFORElORykKKyAgICAgICAgdWFTdHJp
bmcuYXBwZW5kTGl0ZXJhbChVU0VSX0FHRU5UX0JSQU5ESU5HICI7ICIpOworI2VuZGlmCiAgICAg
ICAgIHVhU3RyaW5nLmFwcGVuZChwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpKTsKICAgICB9
CiAKQEAgLTE0MSw3ICsxNDQsNyBAQCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3Ry
aW5nJiBhcHBsaWNhdGlvbk5hbWUsIGNvbnN0IFN0cmluZyYgYXBwbGljYXRpbwogICAgICAgICAg
ICAgZmluYWxBcHBsaWNhdGlvblZlcnNpb24gPSB2ZXJzaW9uRm9yVUFTdHJpbmcoKTsKICAgICAg
ICAgdXNlckFnZW50ID0gc3RhbmRhcmRVc2VyQWdlbnRTdGF0aWMoKSArICcgJyArIGFwcGxpY2F0
aW9uTmFtZSArICcvJyArIGZpbmFsQXBwbGljYXRpb25WZXJzaW9uOwogICAgIH0KLSAgICBBU1NF
UlQoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCkpOworICAgIFJFTEVBU0Vf
QVNTRVJUKGlzVmFsaWRVc2VyQWdlbnRIZWFkZXJWYWx1ZSh1c2VyQWdlbnQpLCAiJXMgaXMgbm90
IGEgdmFsaWQgdXNlciBhZ2VudCBoZWFkZXIiLCB1c2VyQWdlbnQudXRmOCgpLmRhdGEoKSk7CiAg
ICAgcmV0dXJuIHVzZXJBZ2VudDsKIH0KIApAQCAtMTUzLDcgKzE1Niw3IEBAIFN0cmluZyBzdGFu
ZGFyZFVzZXJBZ2VudEZvclVSTChjb25zdCBVUkwmIHVybCkKICAgICAgICAgcmV0dXJuIFN0cmlu
ZygpOwogCiAgICAgU3RyaW5nIHVzZXJBZ2VudChidWlsZFVzZXJBZ2VudFN0cmluZyhxdWlya3Mp
KTsKLSAgICBBU1NFUlQoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCkpOwor
ICAgIFJFTEVBU0VfQVNTRVJUKGlzVmFsaWRVc2VyQWdlbnRIZWFkZXJWYWx1ZSh1c2VyQWdlbnQp
LCAiJXMgaXMgbm90IGEgdmFsaWQgdXNlciBhZ2VudCBoZWFkZXIiLCB1c2VyQWdlbnQudXRmOCgp
LmRhdGEoKSk7CiAgICAgcmV0dXJuIHVzZXJBZ2VudDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl
L2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpp
bmRleCBmZDM2N2I4MjYzOGY5NmUxYzFmOTRlYmVmZTkzZmJiMDQzOWE0ZmJlLi4zNTY2MWFiZDY0
NWU2YzFjZjk0Nzc0ODhlNTk2ODA5NDYzMTI0N2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv
T3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAt
MTcsNiArMTcsMTEgQEAgc2V0KFdFQktJVEdUS19IRUFERVJfSU5TVEFMTF9ESVIgIiR7Q01BS0Vf
SU5TVEFMTF9JTkNMVURFRElSfS93ZWJraXRndGstJHtXRUJLSVQKIHNldChJTlRST1NQRUNUSU9O
X0lOU1RBTExfR0lSRElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9EQVRBRElSfS9naXItMS4wIikK
IHNldChJTlRST1NQRUNUSU9OX0lOU1RBTExfVFlQRUxJQkRJUiAiJHtMSUJfSU5TVEFMTF9ESVJ9
L2dpcmVwb3NpdG9yeS0xLjAiKQogCitzZXQoVVNFUl9BR0VOVF9CUkFORElORyAiIiBDQUNIRSBT
VFJJTkcgIkJyYW5kaW5nIHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitpZiAoVVNFUl9B
R0VOVF9CUkFORElORykKKyAgICBhZGRfZGVmaW5pdGlvbnMoLURVU0VSX0FHRU5UX0JSQU5ESU5H
PSIke1VTRVJfQUdFTlRfQlJBTkRJTkd9IikKK2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShDYWly
byAxLjE0LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJF
RCkKIGZpbmRfcGFja2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21h
a2UKaW5kZXggOTVjMzgzYThjMTNjNjZmNzhmNDczYzc2ZTYyMmVhOGZlZDUwYTQzOC4uMWI1M2Q4
MTE5NjgxZTkwNDFiMmQwMDhlYzkxMmRlZDgzODExNTRjNSAxMDA2NDQKLS0tIGEvU291cmNlL2Nt
YWtlL09wdGlvbnNXUEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UK
QEAgLTEyLDYgKzEyLDExIEBAIHNldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9G
VUxMX0xJQkRJUn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8KIHNldChFWEVDX0lOU1RB
TExfRElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9CSU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0
ZSBwYXRoIHRvIGV4ZWN1dGFibGUgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCiBzZXQoTElCRVhF
Q19JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd3BlLXdlYmtp
dC0ke1dQRV9BUElfVkVSU0lPTn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFs
bCBleGVjdXRhYmxlcyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiAKK3NldChVU0VSX0FHRU5U
X0JSQU5ESU5HICIiIENBQ0hFIFNUUklORyAiQnJhbmRpbmcgdG8gYWRkIHRvIHVzZXIgYWdlbnQg
c3RyaW5nIikKK2lmIChVU0VSX0FHRU5UX0JSQU5ESU5HKQorICAgIGFkZF9kZWZpbml0aW9ucygt
RFVTRVJfQUdFTlRfQlJBTkRJTkc9JHtVU0VSX0FHRU5UX0JSQU5ESU5HfSkKK2VuZGlmICgpCisK
IGZpbmRfcGFja2FnZShDYWlybyAxLjE0LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNv
bmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJF
RCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGNmMTk2ZTVlYjM3
YTBjMTc2MWRlMTAxMmE4ZjIzYmU1NjNmOWE0Li40NDFlNGI5YjU1MjFmYWFkYTQ2OTU1MTYwYTMy
MTg1MWFiYTFjNzJkIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0x
LDMgKzEsMTUgQEAKKzIwMjAtMDMtMTcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn
bm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gQWxsb3cgZGlzdHJpYnV0b3JzIHRvIGJyYW5kIHVz
ZXIgYWdlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE2MjYxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZCBidWlsZCBvcHRpb24gZm9yIGluc2VydGluZyBkaXN0cmlidXRvciBicmFuZGluZyBpbnRv
IHRoZSB1c2VyIGFnZW50IHN0cmluZy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25z
R1RLLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorCiAy
MDIwLTAzLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg
ICAgICBSRUxFQVNFX0xPRyBzaG91bGQgbm90IGJlIENvY29hIHNwZWNpZmljCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393776</attachid>
            <date>2020-03-17 12:35:46 -0700</date>
            <delta_ts>2020-03-23 14:07:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-162611-20200317143545.patch</filename>
            <type>text/plain</type>
            <size>4632</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRiNzdkNmFmNmI4NmQ3
YzQ4Y2E5ZTlkZmJkNjM1ZjMxZGU4YThmYi4uZmMzZmI1NTI5N2MwMWU0ZTQ0ZThlZDI2MWM2NDhi
YWM0Yzc0Y2U3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTE3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xp
Yi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidWlsZFVzZXJBZ2VudFN0cmluZyk6CisKIDIwMjAt
MDMtMTcgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAg
IEFYSXNvbGF0ZWRUcmVlIHJlbW92YWwgc2hvdWxkIHNldCBhbGwgbm9kZXMgdG8gYmUgcmVtb3Zl
ZCBvbiBBWCBzZWNvbmRhcnkgdGhyZWFkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ds
aWIvVXNlckFnZW50R0xpYi5jcHAKaW5kZXggNjcyOTE2MjRlZmZkZmMxMTNiZDFhMDg0YzBlN2Rm
MzgwODJjZGRlOS4uMzM4ZDE0OGU4ODg0MjZhYWJjMjMwYTE1YWQwZTE3MTRlZTlmY2MyMCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwCkBAIC04
OSw2ICs4OSw5IEBAIHN0YXRpYyBTdHJpbmcgYnVpbGRVc2VyQWdlbnRTdHJpbmcoY29uc3QgVXNl
ckFnZW50UXVpcmtzJiBxdWlya3MpCiAgICAgZWxzZSB7CiAgICAgICAgIHVhU3RyaW5nLmFwcGVu
ZChwbGF0Zm9ybUZvclVBU3RyaW5nKCkpOwogICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFs
KCI7ICIpOworI2lmIGRlZmluZWQoVVNFUl9BR0VOVF9CUkFORElORykKKyAgICAgICAgdWFTdHJp
bmcuYXBwZW5kTGl0ZXJhbChVU0VSX0FHRU5UX0JSQU5ESU5HICI7ICIpOworI2VuZGlmCiAgICAg
ICAgIHVhU3RyaW5nLmFwcGVuZChwbGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpKTsKICAgICB9
CiAKQEAgLTE0MSw3ICsxNDQsNyBAQCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3Ry
aW5nJiBhcHBsaWNhdGlvbk5hbWUsIGNvbnN0IFN0cmluZyYgYXBwbGljYXRpbwogICAgICAgICAg
ICAgZmluYWxBcHBsaWNhdGlvblZlcnNpb24gPSB2ZXJzaW9uRm9yVUFTdHJpbmcoKTsKICAgICAg
ICAgdXNlckFnZW50ID0gc3RhbmRhcmRVc2VyQWdlbnRTdGF0aWMoKSArICcgJyArIGFwcGxpY2F0
aW9uTmFtZSArICcvJyArIGZpbmFsQXBwbGljYXRpb25WZXJzaW9uOwogICAgIH0KLSAgICBBU1NF
UlQoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCkpOworICAgIFJFTEVBU0Vf
QVNTRVJUX1dJVEhfTUVTU0FHRShpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUodXNlckFnZW50
KSwgIiVzIGlzIG5vdCBhIHZhbGlkIHVzZXIgYWdlbnQgaGVhZGVyIiwgdXNlckFnZW50LnV0Zjgo
KS5kYXRhKCkpOwogICAgIHJldHVybiB1c2VyQWdlbnQ7CiB9CiAKQEAgLTE1Myw3ICsxNTYsNyBA
QCBTdHJpbmcgc3RhbmRhcmRVc2VyQWdlbnRGb3JVUkwoY29uc3QgVVJMJiB1cmwpCiAgICAgICAg
IHJldHVybiBTdHJpbmcoKTsKIAogICAgIFN0cmluZyB1c2VyQWdlbnQoYnVpbGRVc2VyQWdlbnRT
dHJpbmcocXVpcmtzKSk7Ci0gICAgQVNTRVJUKGlzVmFsaWRVc2VyQWdlbnRIZWFkZXJWYWx1ZSh1
c2VyQWdlbnQpKTsKKyAgICBSRUxFQVNFX0FTU0VSVF9XSVRIX01FU1NBR0UoaXNWYWxpZFVzZXJB
Z2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCksICIlcyBpcyBub3QgYSB2YWxpZCB1c2VyIGFnZW50
IGhlYWRlciIsIHVzZXJBZ2VudC51dGY4KCkuZGF0YSgpKTsKICAgICByZXR1cm4gdXNlckFnZW50
OwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJj
ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZkMzY3YjgyNjM4Zjk2ZTFjMWY5NGViZWZl
OTNmYmIwNDM5YTRmYmUuLjM1NjYxYWJkNjQ1ZTZjMWNmOTQ3NzQ4OGU1OTY4MDk0NjMxMjQ3YWUg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9j
bWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNyw2ICsxNywxMSBAQCBzZXQoV0VCS0lUR1RLX0hF
QURFUl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0lOQ0xVREVESVJ9L3dlYmtpdGd0ay0k
e1dFQktJVAogc2V0KElOVFJPU1BFQ1RJT05fSU5TVEFMTF9HSVJESVIgIiR7Q01BS0VfSU5TVEFM
TF9GVUxMX0RBVEFESVJ9L2dpci0xLjAiKQogc2V0KElOVFJPU1BFQ1RJT05fSU5TVEFMTF9UWVBF
TElCRElSICIke0xJQl9JTlNUQUxMX0RJUn0vZ2lyZXBvc2l0b3J5LTEuMCIpCiAKK3NldChVU0VS
X0FHRU5UX0JSQU5ESU5HICIiIENBQ0hFIFNUUklORyAiQnJhbmRpbmcgdG8gYWRkIHRvIHVzZXIg
YWdlbnQgc3RyaW5nIikKK2lmIChVU0VSX0FHRU5UX0JSQU5ESU5HKQorICAgIGFkZF9kZWZpbml0
aW9ucygtRFVTRVJfQUdFTlRfQlJBTkRJTkc9IiR7VVNFUl9BR0VOVF9CUkFORElOR30iKQorZW5k
aWYgKCkKKwogZmluZF9wYWNrYWdlKENhaXJvIDEuMTQuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2Fn
ZShGb250Y29uZmlnIDIuOC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKEZyZWV0eXBlIDIuNC4y
IFJFUVVJUkVEKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UgYi9T
b3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQppbmRleCA5NWMzODNhOGMxM2M2NmY3OGY0NzNj
NzZlNjIyZWE4ZmVkNTBhNDM4Li4xYjUzZDgxMTk2ODFlOTA0MWIyZDAwOGVjOTEyZGVkODM4MTE1
NGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9Tb3Vy
Y2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQpAQCAtMTIsNiArMTIsMTEgQEAgc2V0KExJQl9JTlNU
QUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRElSfSIgQ0FDSEUgUEFUSCAiQWJzb2x1
dGUgcGF0aCB0bwogc2V0KEVYRUNfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0JJ
TkRJUn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gZXhlY3V0YWJsZSBpbnN0YWxsYXRp
b24gZGlyZWN0b3J5IikKIHNldChMSUJFWEVDX0lOU1RBTExfRElSICIke0NNQUtFX0lOU1RBTExf
RlVMTF9MSUJFWEVDRElSfS93cGUtd2Via2l0LSR7V1BFX0FQSV9WRVJTSU9OfSIgQ0FDSEUgUEFU
SCAiQWJzb2x1dGUgcGF0aCB0byBpbnN0YWxsIGV4ZWN1dGFibGVzIGV4ZWN1dGVkIGJ5IHRoZSBs
aWJyYXJ5IikKIAorc2V0KFVTRVJfQUdFTlRfQlJBTkRJTkcgIiIgQ0FDSEUgU1RSSU5HICJCcmFu
ZGluZyB0byBhZGQgdG8gdXNlciBhZ2VudCBzdHJpbmciKQoraWYgKFVTRVJfQUdFTlRfQlJBTkRJ
TkcpCisgICAgYWRkX2RlZmluaXRpb25zKC1EVVNFUl9BR0VOVF9CUkFORElORz0ke1VTRVJfQUdF
TlRfQlJBTkRJTkd9KQorZW5kaWYgKCkKKwogZmluZF9wYWNrYWdlKENhaXJvIDEuMTQuMCBSRVFV
SVJFRCkKIGZpbmRfcGFja2FnZShGb250Y29uZmlnIDIuOC4wIFJFUVVJUkVEKQogZmluZF9wYWNr
YWdlKEZyZWV0eXBlIDIuNC4yIFJFUVVJUkVEKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh
bmdlTG9nCmluZGV4IDVkY2YxOTZlNWViMzdhMGMxNzYxZGUxMDEyYThmMjNiZTU2M2Y5YTQuLjQ0
MWU0YjliNTUyMWZhYWRhNDY5NTUxNjBhMzIxODUxYWJhMWM3MmQgMTAwNjQ0Ci0tLSBhL0NoYW5n
ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wMy0xNyAgTWljaGFl
bCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KKworICAgICAgICBbR1RLXSBBbGxv
dyBkaXN0cmlidXRvcnMgdG8gYnJhbmQgdXNlciBhZ2VudAorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGJ1aWxkIG9wdGlvbiBmb3IgaW5zZXJ0aW5n
IGRpc3RyaWJ1dG9yIGJyYW5kaW5nIGludG8gdGhlIHVzZXIgYWdlbnQgc3RyaW5nLgorCisgICAg
ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisgICAgICAgICogU291cmNlL2Nt
YWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMjAtMDMtMTcgIFBoaWxpcHBlIE5vcm1hbmQgIDxw
bm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFTEVBU0VfTE9HIHNob3VsZCBub3QgYmUg
Q29jb2Egc3BlY2lmaWMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394301</attachid>
            <date>2020-03-23 14:07:14 -0700</date>
            <delta_ts>2020-03-23 15:19:46 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-162611-20200323160713.patch</filename>
            <type>text/plain</type>
            <size>4550</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc0OTljYzc4ZDcwYjNk
ZWIyOTQxM2U4ZWZlODlhYjQyMjIzY2IwNy4uZTI5NjJmYTRhMTJmZGRkOTg3NzI0ZmYxN2IwMmNk
MzNjZDVmN2NmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIzICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEFs
bG93IGRpc3RyaWJ1dG9ycyB0byBicmFuZCB1c2VyIGFnZW50CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI2MTEKKworICAgICAgICBSZXZpZXdlZCBi
eSBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvLgorCisgICAgICAgICogcGxhdGZvcm0vZ2xpYi9Vc2Vy
QWdlbnRHTGliLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5nKToK
KwogMjAyMC0wMy0yMyAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmVuYW1lIGJsYW5rVVJMIHRvIGFib3V0QmxhbmtVUkwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xpYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3BwCmluZGV4IDY3MjkxNjI0ZWZmZGZjMTEzYmQx
YTA4NGMwZTdkZjM4MDgyY2RkZTkuLmMwNjNhN2YxMDU5YWM2NTFmMzA2MGNlMzZhYzZkNTQ5ODI4
MmY3NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50
R0xpYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGli
LmNwcApAQCAtODksNiArODksOSBAQCBzdGF0aWMgU3RyaW5nIGJ1aWxkVXNlckFnZW50U3RyaW5n
KGNvbnN0IFVzZXJBZ2VudFF1aXJrcyYgcXVpcmtzKQogICAgIGVsc2UgewogICAgICAgICB1YVN0
cmluZy5hcHBlbmQocGxhdGZvcm1Gb3JVQVN0cmluZygpKTsKICAgICAgICAgdWFTdHJpbmcuYXBw
ZW5kTGl0ZXJhbCgiOyAiKTsKKyNpZiBkZWZpbmVkKFVTRVJfQUdFTlRfQlJBTkRJTkcpCisgICAg
ICAgIHVhU3RyaW5nLmFwcGVuZExpdGVyYWwoVVNFUl9BR0VOVF9CUkFORElORyAiOyAiKTsKKyNl
bmRpZgogICAgICAgICB1YVN0cmluZy5hcHBlbmQocGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmco
KSk7CiAgICAgfQogCkBAIC0xNDEsNyArMTQ0LDE1IEBAIFN0cmluZyBzdGFuZGFyZFVzZXJBZ2Vu
dChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3QgU3RyaW5nJiBhcHBsaWNhdGlv
CiAgICAgICAgICAgICBmaW5hbEFwcGxpY2F0aW9uVmVyc2lvbiA9IHZlcnNpb25Gb3JVQVN0cmlu
ZygpOwogICAgICAgICB1c2VyQWdlbnQgPSBzdGFuZGFyZFVzZXJBZ2VudFN0YXRpYygpICsgJyAn
ICsgYXBwbGljYXRpb25OYW1lICsgJy8nICsgZmluYWxBcHBsaWNhdGlvblZlcnNpb247CiAgICAg
fQotICAgIEFTU0VSVChpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUodXNlckFnZW50KSk7CisK
KyAgICBzdGF0aWMgYm9vbCBjaGVja2VkID0gZmFsc2U7CisgICAgaWYgKCFjaGVja2VkKSB7Cisg
ICAgICAgIC8vIEZvciByZWxlYXNlIGJ1aWxkcywgd2UnbGwgb25seSBjaGVjayB0aGUgZmlyc3Qg
cmVzb3VyY2UgbG9hZCwgbWFpbmx5IHRvIGVuc3VyZSB0aGF0IGFueQorICAgICAgICAvLyBjb25m
aWd1cmVkIGFwcGxpY2F0aW9uIGRldGFpbHMgb3IgdXNlciBhZ2VudCBicmFuZGluZyBpcyBPSy4K
KyAgICAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNTQUdFKGlzVmFsaWRVc2VyQWdlbnRIZWFk
ZXJWYWx1ZSh1c2VyQWdlbnQpLCAiJXMgaXMgbm90IGEgdmFsaWQgdXNlciBhZ2VudCBoZWFkZXIi
LCB1c2VyQWdlbnQudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIGNoZWNrZWQgPSB0cnVlOworICAg
IH0KKyAgICBBU1NFUlQoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKHVzZXJBZ2VudCk7CiAg
ICAgcmV0dXJuIHVzZXJBZ2VudDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlv
bnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCBjY2RlMGU3
NzU2OTM1MzYxMDVjZmRmNDI0OWU4NTRiYWQ5NmIwODBhLi40ZjQwMzQ2N2Y3OTVmMGY2Njg3MWQz
ZDkxNzFjZDM4MTljYTQ5OTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j
bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMTcsNiArMTcsMTEg
QEAgc2V0KFdFQktJVEdUS19IRUFERVJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9JTkNM
VURFRElSfS93ZWJraXRndGstJHtXRUJLSVQKIHNldChJTlRST1NQRUNUSU9OX0lOU1RBTExfR0lS
RElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9EQVRBRElSfS9naXItMS4wIikKIHNldChJTlRST1NQ
RUNUSU9OX0lOU1RBTExfVFlQRUxJQkRJUiAiJHtMSUJfSU5TVEFMTF9ESVJ9L2dpcmVwb3NpdG9y
eS0xLjAiKQogCitzZXQoVVNFUl9BR0VOVF9CUkFORElORyAiIiBDQUNIRSBTVFJJTkcgIkJyYW5k
aW5nIHRvIGFkZCB0byB1c2VyIGFnZW50IHN0cmluZyIpCitpZiAoVVNFUl9BR0VOVF9CUkFORElO
RykKKyAgICBhZGRfZGVmaW5pdGlvbnMoLURVU0VSX0FHRU5UX0JSQU5ESU5HPSIke1VTRVJfQUdF
TlRfQlJBTkRJTkd9IikKK2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShDYWlybyAxLjE0LjAgUkVR
VUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFj
a2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P
cHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKaW5kZXggOTcx
YzFhNzFjNTY3YjYxZGQzYzNkZGVkNzI2YWNlMjE2MTgyYjEwMC4uYjMzYTU0Y2QyZTczMDY5ZmU1
ZTlhODFhZGM2YTgzN2UxMWMwYWQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNX
UEUuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKQEAgLTEyLDYgKzEy
LDExIEBAIHNldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJQkRJUn0i
IENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8KIHNldChFWEVDX0lOU1RBTExfRElSICIke0NN
QUtFX0lOU1RBTExfRlVMTF9CSU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGV4
ZWN1dGFibGUgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCiBzZXQoTElCRVhFQ19JTlNUQUxMX0RJ
UiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd3BlLXdlYmtpdC0ke1dQRV9BUElf
VkVSU0lPTn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFsbCBleGVjdXRhYmxl
cyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCiAKK3NldChVU0VSX0FHRU5UX0JSQU5ESU5HICIi
IENBQ0hFIFNUUklORyAiQnJhbmRpbmcgdG8gYWRkIHRvIHVzZXIgYWdlbnQgc3RyaW5nIikKK2lm
IChVU0VSX0FHRU5UX0JSQU5ESU5HKQorICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRVJfQUdFTlRf
QlJBTkRJTkc9JHtVU0VSX0FHRU5UX0JSQU5ESU5HfSkKK2VuZGlmICgpCisKIGZpbmRfcGFja2Fn
ZShDYWlybyAxLjE0LjAgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoRm9udGNvbmZpZyAyLjguMCBS
RVFVSVJFRCkKIGZpbmRfcGFja2FnZShGcmVldHlwZSAyLjQuMiBSRVFVSVJFRCkKZGlmZiAtLWdp
dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmZGNkMzJmODY2ODVhY2VlNDBlMTU3ZTYz
YjIyNGUzMzZmN2ZhNjlkLi42YWJlMDRkZjg4YjI5ZTA5N2FhODE1NzQxYmQyNGNkYmI2Yzg1NWJh
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMjAtMDMtMjMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisK
KyAgICAgICAgW0dUS10gQWxsb3cgZGlzdHJpYnV0b3JzIHRvIGJyYW5kIHVzZXIgYWdlbnQKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMQorCisg
ICAgICAgIFJldmlld2VkIGJ5IEFkcmlhbiBQZXJleiBkZSBDYXN0cm8uCisKKyAgICAgICAgQWRk
IGJ1aWxkIG9wdGlvbiBmb3IgaW5zZXJ0aW5nIGRpc3RyaWJ1dG9yIGJyYW5kaW5nIGludG8gdGhl
IHVzZXIgYWdlbnQgc3RyaW5nLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsu
Y21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2U6CisKIDIwMjAt
MDMtMjMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAg
IFtHVEtdW1dQRV0gRGlzYWJsZSBzeXN0ZW1kIGxvZ2dpbmcgYnkgZGVmYXVsdAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>394311</attachid>
            <date>2020-03-23 15:19:43 -0700</date>
            <delta_ts>2020-03-23 15:59:39 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-162611-20200323171942.patch</filename>
            <type>text/plain</type>
            <size>1409</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZlMmVlZWY2ZWQzMzYz
YzUwNzkxMjE5NWU1NjVkYjIxOGE0ZDAzMS4uMmJmNTZmNDQ0Y2ZkZTk1NWM5OTQ5NmRmZDFhOGQ5
YjVjMzE0YTA3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTIzICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtXUEVdW0dU
S10gQWxsb3cgZGlzdHJpYnV0b3JzIHRvIGJyYW5kIHVzZXIgYWdlbnQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMQorCisgICAgICAgIFVucmV2
aWV3ZWQsIHVuLWJyZWFrIG15IHByZXZpb3VzIGNvbW1pdC4KKworICAgICAgICAqIHBsYXRmb3Jt
L2dsaWIvVXNlckFnZW50R0xpYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzdGFuZGFyZFVzZXJB
Z2VudCk6CisKIDIwMjAtMDMtMjMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9t
ZS5vcmc+CiAKICAgICAgICAgW0dUS10gQWxsb3cgZGlzdHJpYnV0b3JzIHRvIGJyYW5kIHVzZXIg
YWdlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50
R0xpYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIuY3Bw
CmluZGV4IGMwNjNhN2YxMDU5YWM2NTFmMzA2MGNlMzZhYzZkNTQ5ODI4MmY3NDcuLmI2Zjc1MTg4
YjAzOTBjMjAzN2E0M2Y2ZjQwNjIyOTI4ZTdjM2JkMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xpYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcApAQCAtMTUyLDcgKzE1Miw3IEBAIFN0cmlu
ZyBzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW9uTmFtZSwgY29uc3Qg
U3RyaW5nJiBhcHBsaWNhdGlvCiAgICAgICAgIFJFTEVBU0VfQVNTRVJUX1dJVEhfTUVTU0FHRShp
c1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUodXNlckFnZW50KSwgIiVzIGlzIG5vdCBhIHZhbGlk
IHVzZXIgYWdlbnQgaGVhZGVyIiwgdXNlckFnZW50LnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICBj
aGVja2VkID0gdHJ1ZTsKICAgICB9Ci0gICAgQVNTRVJUKGlzVmFsaWRVc2VyQWdlbnRIZWFkZXJW
YWx1ZSh1c2VyQWdlbnQpOworICAgIEFTU0VSVChpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUo
dXNlckFnZW50KSk7CiAgICAgcmV0dXJuIHVzZXJBZ2VudDsKIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>