162610 2016-09-27 08:17:50 -0700 [GTK] User agent should always claim to be Intel 2016-09-28 07:51:38 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 162612 162613 142074 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233858 0 mcatanzaro 2016-09-27 08:17:50 -0700 We should always claim to be running on Intel regardless of actual CPU type. See discussion in bug #162548 for details. In particular, we can never advertise ARM because it causes dumb websites to send mobile pages. 1233870 1 289946 mcatanzaro 2016-09-27 08:43:25 -0700 Created attachment 289946 Patch 1234325 2 289946 cgarcia 2016-09-28 03:46:08 -0700 Comment on attachment 289946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289946&action=review > Source/WebCore/platform/gtk/UserAgentGtk.cpp:96 > - static NeverDestroyed<const String> uaOSVersion(String::format("%s Mac OS X", cpuDescriptionForUAString())); > + static NeverDestroyed<const String> uaOSVersion(ASCIILiteral("Intel Mac OS X")); So, we should update the comment to also explain why we use Intel unconditionally. > Source/WebCore/platform/gtk/UserAgentGtk.cpp:121 > + uaString.appendLiteral("Intel"); > uaString.appendLiteral(" Mac OS X"); These could be a single appendLiteral call now. 1234356 3 290080 mcatanzaro 2016-09-28 05:59:32 -0700 Created attachment 290080 Patch 1234374 4 290080 commit-queue 2016-09-28 07:51:35 -0700 Comment on attachment 290080 Patch Clearing flags on attachment: 290080 Committed r206517: <http://trac.webkit.org/changeset/206517> 1234375 5 commit-queue 2016-09-28 07:51:38 -0700 All reviewed patches have been landed. Closing bug. 289946 2016-09-27 08:43:25 -0700 2016-09-28 05:59:26 -0700 Patch bug-162610-20160927174025.patch text/plain 2555 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBiZTYxMGMxNDMyYmNk Zjg5OWM2YmIyZjVhMDVkY2NiYjBhN2RlNC4uODVmZmU0YmU4ZDliNmJjZDYxYzI3YWIzNDk3MDQz NmJjYmU5ZDgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTI3ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBV c2VyIGFnZW50IHNob3VsZCBhbHdheXMgY2xhaW0gdG8gYmUgSW50ZWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBhbHdheXMgY2xhaW0g dG8gYmUgcnVubmluZyBvbiBJbnRlbCByZWdhcmRsZXNzIG9mIGFjdHVhbCBDUFUgdHlwZS4gU2Vl IGRpc2N1c3Npb24KKyAgICAgICAgaW4gYnVnICMxNjI1NDggZm9yIGRldGFpbHMuIEluIHBhcnRp Y3VsYXIsIHdlIGNhbiBuZXZlciBhZHZlcnRpc2UgQVJNIGJlY2F1c2UgaXQgY2F1c2VzIGR1bWIK KyAgICAgICAgd2Vic2l0ZXMgdG8gc2VuZCBtb2JpbGUgcGFnZXMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBsYXRmb3JtVmVy c2lvbkZvclVBU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5n KToKKyAgICAgICAgKFdlYkNvcmU6OmNwdURlc2NyaXB0aW9uRm9yVUFTdHJpbmcpOiBEZWxldGVk LgorCiAyMDE2LTA5LTI3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBbRmV0Y2ggQVBJXSBSZW1vdmUgUmVhZGFibGVTdHJlYW1Tb3VyY2UgZmlyc3RSZWFkQ2Fs bGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRH dGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKaW5k ZXggMDY4NWZjNTY2YTBmYWRkM2YyNmE4ZDM5ODZhYWQ1ZTMwMDQ2YjNlMi4uNzFkOWZlNjk0OThh ZjM4ZTJkNTBmNGViMDFhZWFiNTAzYzFmZDVkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHAKQEAgLTY5LDE5ICs2OSw2IEBAIHByaXZhdGU6CiAgICAg dWludDMyX3QgbV9xdWlya3M7CiB9OwogCi1zdGF0aWMgY29uc3QgY2hhciogY3B1RGVzY3JpcHRp b25Gb3JVQVN0cmluZygpCi17Ci0jaWYgQ1BVKFBQQykgfHwgQ1BVKFBQQzY0KQotICAgIHJldHVy biAiUFBDIjsKLSNlbGlmIENQVShYODYpIHx8IENQVShYODZfNjQpCi0gICAgcmV0dXJuICJJbnRl bCI7Ci0jZWxpZiBDUFUoQVJNKSB8fCBDUFUoQVJNNjQpCi0gICAgcmV0dXJuICJBUk0iOwotI2Vs c2UKLSAgICByZXR1cm4gIlVua25vd24iOwotI2VuZGlmCi19Ci0KIHN0YXRpYyBjb25zdCBjaGFy KiBwbGF0Zm9ybUZvclVBU3RyaW5nKCkKIHsKICNpZiBQTEFURk9STShYMTEpCkBAIC0xMDYsNyAr OTMsNyBAQCBzdGF0aWMgY29uc3QgU3RyaW5nIHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkK ICAgICByZXR1cm4gdWFPU1ZlcnNpb247CiAjZWxzZQogICAgIC8vIFdlIHdpbGwgYWx3YXlzIGNs YWltIHRvIGJlIFNhZmFyaSBpbiBNYWMgT1MgWCwgc2luY2UgU2FmYXJpIGluIExpbnV4IHRyaWdn ZXJzIHRoZSBpT1MgcGF0aCBvbiBzb21lIHdlYnNpdGVzLgotICAgIHN0YXRpYyBOZXZlckRlc3Ry b3llZDxjb25zdCBTdHJpbmc+IHVhT1NWZXJzaW9uKFN0cmluZzo6Zm9ybWF0KCIlcyBNYWMgT1Mg WCIsIGNwdURlc2NyaXB0aW9uRm9yVUFTdHJpbmcoKSkpOworICAgIHN0YXRpYyBOZXZlckRlc3Ry b3llZDxjb25zdCBTdHJpbmc+IHVhT1NWZXJzaW9uKEFTQ0lJTGl0ZXJhbCgiSW50ZWwgTWFjIE9T IFgiKSk7CiAgICAgcmV0dXJuIHVhT1NWZXJzaW9uOwogI2VuZGlmCiB9CkBAIC0xMzAsNyArMTE3 LDcgQEAgc3RhdGljIFN0cmluZyBidWlsZFVzZXJBZ2VudFN0cmluZyhjb25zdCBVc2VyQWdlbnRR dWlya3MmIHF1aXJrcykKICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCI7ICIpOwogCiAgICAg aWYgKHF1aXJrcy5jb250YWlucyhVc2VyQWdlbnRRdWlya3M6Ok5lZWRzTWFjaW50b3NoUGxhdGZv cm0pKSB7Ci0gICAgICAgIHVhU3RyaW5nLmFwcGVuZChjcHVEZXNjcmlwdGlvbkZvclVBU3RyaW5n KCkpOworICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFsKCJJbnRlbCIpOwogICAgICAgICB1 YVN0cmluZy5hcHBlbmRMaXRlcmFsKCIgTWFjIE9TIFgiKTsKICAgICB9IGVsc2UKICAgICAgICAg dWFTdHJpbmcuYXBwZW5kKHBsYXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkpOwo= 290080 2016-09-28 05:59:32 -0700 2016-09-28 07:51:35 -0700 Patch bug-162610-20160928145631.patch text/plain 2757 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM3ZjNmZTQyZjcxNzI1 OGQ2YTRkMTY0YjNmZWI3Yjk0YWQ4NjI4MC4uYzM5MDVmNmZiMzIzNjYxZjM5NTI3MDBkZTI4MDNm MjNiNzc1N2U3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTI4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBV c2VyIGFnZW50IHNob3VsZCBhbHdheXMgY2xhaW0gdG8gYmUgSW50ZWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjYxMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBhbHdheXMgY2xhaW0g dG8gYmUgcnVubmluZyBvbiBJbnRlbCByZWdhcmRsZXNzIG9mIGFjdHVhbCBDUFUgdHlwZS4gU2Vl IGRpc2N1c3Npb24KKyAgICAgICAgaW4gYnVnICMxNjI1NDggZm9yIGRldGFpbHMuIEluIHBhcnRp Y3VsYXIsIHdlIGNhbiBuZXZlciBhZHZlcnRpc2UgQVJNIGJlY2F1c2UgaXQgY2F1c2VzIGR1bWIK KyAgICAgICAgd2Vic2l0ZXMgdG8gc2VuZCBtb2JpbGUgcGFnZXMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBsYXRmb3JtVmVy c2lvbkZvclVBU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkVXNlckFnZW50U3RyaW5n KToKKyAgICAgICAgKFdlYkNvcmU6OmNwdURlc2NyaXB0aW9uRm9yVUFTdHJpbmcpOiBEZWxldGVk LgorCiAyMDE2LTA5LTI3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIHR5cG8gZml4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCmluZGV4IDc0M2ViYTAwMTFjY2I1NDg0ZmY2ZjYzNmI2 NWUyZDVlYjJhZjc5MzguLjExNDRmYThiZTg1MDU3NWE0MGFmZDczMmQ5N2ExNWJhNTA2MjQzZWYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCkBAIC02 OSwxOSArNjksNiBAQCBwcml2YXRlOgogICAgIHVpbnQzMl90IG1fcXVpcmtzOwogfTsKIAotc3Rh dGljIGNvbnN0IGNoYXIqIGNwdURlc2NyaXB0aW9uRm9yVUFTdHJpbmcoKQotewotI2lmIENQVShQ UEMpIHx8IENQVShQUEM2NCkKLSAgICByZXR1cm4gIlBQQyI7Ci0jZWxpZiBDUFUoWDg2KSB8fCBD UFUoWDg2XzY0KQotICAgIHJldHVybiAiSW50ZWwiOwotI2VsaWYgQ1BVKEFSTSkgfHwgQ1BVKEFS TTY0KQotICAgIHJldHVybiAiQVJNIjsKLSNlbHNlCi0gICAgcmV0dXJuICJVbmtub3duIjsKLSNl bmRpZgotfQotCiBzdGF0aWMgY29uc3QgY2hhciogcGxhdGZvcm1Gb3JVQVN0cmluZygpCiB7CiAj aWYgUExBVEZPUk0oWDExKQpAQCAtMTA2LDcgKzkzLDggQEAgc3RhdGljIGNvbnN0IFN0cmluZyBw bGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZygpCiAgICAgcmV0dXJuIHVhT1NWZXJzaW9uOwogI2Vs c2UKICAgICAvLyBXZSB3aWxsIGFsd2F5cyBjbGFpbSB0byBiZSBTYWZhcmkgaW4gTWFjIE9TIFgs IHNpbmNlIFNhZmFyaSBpbiBMaW51eCB0cmlnZ2VycyB0aGUgaU9TIHBhdGggb24gc29tZSB3ZWJz aXRlcy4KLSAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YU9TVmVyc2lv bihTdHJpbmc6OmZvcm1hdCgiJXMgTWFjIE9TIFgiLCBjcHVEZXNjcmlwdGlvbkZvclVBU3RyaW5n KCkpKTsKKyAgICAvLyBBbmQgd2UgYWx3YXlzIGNsYWltIHRvIGJlIEludGVsIHNpbmNlIEFSTSB0 cmlnZ2VycyBtb2JpbGUgdmVyc2lvbnMgb2Ygc29tZSB3ZWJzaXRlcy4KKyAgICBzdGF0aWMgTmV2 ZXJEZXN0cm95ZWQ8Y29uc3QgU3RyaW5nPiB1YU9TVmVyc2lvbihBU0NJSUxpdGVyYWwoIkludGVs IE1hYyBPUyBYIikpOwogICAgIHJldHVybiB1YU9TVmVyc2lvbjsKICNlbmRpZgogfQpAQCAtMTI5 LDEwICsxMTcsOSBAQCBzdGF0aWMgU3RyaW5nIGJ1aWxkVXNlckFnZW50U3RyaW5nKGNvbnN0IFVz ZXJBZ2VudFF1aXJrcyYgcXVpcmtzKQogCiAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJhbCgiOyAi KTsKIAotICAgIGlmIChxdWlya3MuY29udGFpbnMoVXNlckFnZW50UXVpcmtzOjpOZWVkc01hY2lu dG9zaFBsYXRmb3JtKSkgewotICAgICAgICB1YVN0cmluZy5hcHBlbmQoY3B1RGVzY3JpcHRpb25G b3JVQVN0cmluZygpKTsKLSAgICAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJhbCgiIE1hYyBPUyBY Iik7Ci0gICAgfSBlbHNlCisgICAgaWYgKHF1aXJrcy5jb250YWlucyhVc2VyQWdlbnRRdWlya3M6 Ok5lZWRzTWFjaW50b3NoUGxhdGZvcm0pKQorICAgICAgICB1YVN0cmluZy5hcHBlbmRMaXRlcmFs KCJJbnRlbCBNYWMgT1MgWCIpOworICAgIGVsc2UKICAgICAgICAgdWFTdHJpbmcuYXBwZW5kKHBs YXRmb3JtVmVyc2lvbkZvclVBU3RyaW5nKCkpOwogCiAgICAgdWFTdHJpbmcuYXBwZW5kTGl0ZXJh bCgiKSBBcHBsZVdlYktpdC8iKTsK