162566 2016-09-26 10:26:43 -0700 LayoutTest media/media-source/media-source-delaying-load-event.html is a flaky failure 2016-09-28 13:14:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161881 P2 Normal --- 1 ryanhaddad ryanhaddad commit-queue jer.noble oldest_to_newest 1233456 0 ryanhaddad 2016-09-26 10:26:43 -0700 LayoutTest media/media-source/media-source-delaying-load-event.html is a flaky failure https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r206375%20(15194)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-source%2Fmedia-source-delaying-load-event.html --- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/media/media-source/media-source-delaying-load-event-expected.txt +++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/media/media-source/media-source-delaying-load-event-actual.txt @@ -2,6 +2,6 @@ EXPECTED (source.readyState == 'closed') OK RUN(video.src = URL.createObjectURL(source)) -EVENT(load) +FAIL: did not end fast enough END OF TEST 1233457 1 ryanhaddad 2016-09-26 10:27:07 -0700 This test was added with https://trac.webkit.org/changeset/205863. 1233561 2 ryanhaddad 2016-09-26 13:58:32 -0700 Jer, could you take a look at this? The test is failing quite frequently. 1233575 3 jer.noble 2016-09-26 14:26:15 -0700 (In reply to comment #2) > Jer, could you take a look at this? The test is failing quite frequently. Hm, the test is set to "time out" in 100ms. Maybe that's just too short a timeout for an overworked bot. We should just remove that line and see it if really times out flakily, or if it's occasionally taking just > 100ms. 1233641 4 289887 ryanhaddad 2016-09-26 16:25:11 -0700 Created attachment 289887 Patch 1233704 5 289887 commit-queue 2016-09-26 20:08:46 -0700 Comment on attachment 289887 Patch Clearing flags on attachment: 289887 Committed r206409: <http://trac.webkit.org/changeset/206409> 1233705 6 commit-queue 2016-09-26 20:08:50 -0700 All reviewed patches have been landed. Closing bug. 1233728 7 jer.noble 2016-09-26 21:57:13 -0700 Thanks Ryan! Let me know if this test still flakes and I should go hunting for a timing issue. 1234509 8 ryanhaddad 2016-09-28 13:14:32 -0700 No flakes since r206409, so it looks like we're good. 289887 2016-09-26 16:25:11 -0700 2016-09-26 20:08:46 -0700 Patch bug-162566-20160926162214.patch text/plain 1390 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDAwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDgwYWM4MzNmNjkwYzlkMzQ5ZTk3 NTAxNWQ3NThmYTI0NmY2Y2M1Yy4uZDc4ZjU1ZTU3NTMwZTI1MDRkYzU2ZDZmMjkyZTgyZmZjYjQy ZjNlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTA5LTI2ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCisgICAgICAgIFJlbW92ZSAxMDBtcyB0aW1lb3V0IGZvciBt ZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWRlbGF5aW5nLWxvYWQtZXZlbnQuaHRtbCB0 byB0cnkgdG8gZml4IGZsYWtpbmVzcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MjU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1kZWxheWlu Zy1sb2FkLWV2ZW50Lmh0bWw6CisKKzIwMTYtMDktMjYgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRh ZEBhcHBsZS5jb20+CisKICAgICAgICAgTWFya2luZyBtZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRp by1yZXBhaW50Lmh0bWwgYXMgZmxha3kgb24gU2llcnJhLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NzU3CiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL21lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtZGVsYXlpbmctbG9hZC1ldmVudC5o dG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1kZWxheWlu Zy1sb2FkLWV2ZW50Lmh0bWwKaW5kZXggYzViYTU3MGQ2MzRjZWM2MjExM2ZmODMzMDc0OTU2NzI2 NWE4NDVjMC4uNTcxMzFjNzBkOTVlNzRmYTVkMDMyODViNjM4N2RiNTgzODk0MzE3ZCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1kZWxheWlu Zy1sb2FkLWV2ZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21l ZGlhLXNvdXJjZS1kZWxheWluZy1sb2FkLWV2ZW50Lmh0bWwKQEAgLTE4LDcgKzE4LDYgQEAKIAog ICAgICAgICBydW4oJ3ZpZGVvLnNyYyA9IFVSTC5jcmVhdGVPYmplY3RVUkwoc291cmNlKScpOwog ICAgICAgICB3YWl0Rm9yRXZlbnRPbih3aW5kb3csICdsb2FkJywgZW5kVGVzdCk7Ci0gICAgICAg IGZhaWxUZXN0SW4oMTAwKTsKICAgICA8L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRtbD4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==