162510 2016-09-23 13:36:34 -0700 LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure 2017-04-06 15:50:25 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=114504 https://bugs.webkit.org/show_bug.cgi?id=170572 InRadar P2 Normal --- 1 ryanhaddad cdumez aestes ap cdumez commit-queue jonlee ryanhaddad sabouhallawa webkit-bug-importer zalan oldest_to_newest 1232972 0 ryanhaddad 2016-09-23 13:36:34 -0700 LayoutTest fast/images/animated-gif-restored-from-bfcache.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r206315%20(8366)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fanimated-gif-restored-from-bfcache.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/fast/images/animated-gif-restored-from-bfcache-actual.txt @@ -1,5 +1,5 @@ Test that animated GIFs resume animating after restoring a page from the back forward cache. To test manually, click here to visit about:blank, then press the browser's back button. On success, you should see a square that continuously animates through various shades of green followed by the word 'PASS'. -PASS +FAIL 1232974 1 ryanhaddad 2016-09-23 13:38:58 -0700 This is a very recent regression, with the first occurrence on the flakiness dashboard being with https://trac.webkit.org/changeset/206188 1233066 2 zalan 2016-09-23 17:26:41 -0700 It looks unrelated. 1233292 3 ap 2016-09-25 18:45:23 -0700 This test has been flaky for a long time on some bots, especially on slower ones (like GuardMalloc and ASan). But it clearly got worse in the last couple of weeks. There is a 100 ms timeout in the test, which can't be right. 1234589 4 ryanhaddad 2016-09-28 16:25:47 -0700 Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/206559 1293279 5 ap 2017-03-31 13:20:49 -0700 Looking at other bots, I see that the recent regression in frequency started on or before r214508. Kind of willing to blame <http://trac.webkit.org/r214503>. 1293331 6 webkit-bug-importer 2017-03-31 15:27:18 -0700 <rdar://problem/31380650> 1293333 7 306020 cdumez 2017-03-31 15:33:28 -0700 Created attachment 306020 Patch 1293360 8 306020 ap 2017-03-31 16:31:11 -0700 Comment on attachment 306020 Patch Thank you! Curious if there was something in that change that made it more common. 1293378 9 cdumez 2017-03-31 17:04:27 -0700 (In reply to Alexey Proskuryakov from comment #8) > Comment on attachment 306020 [details] > Patch > > Thank you! > > Curious if there was something in that change that made it more common. I looked again on my change but it is really restricted to SVG animations. I do not see how it would impact the timing of GIF animations. Anyway, the test was inherently flaky any timing change you impact it. 1293390 10 306020 commit-queue 2017-03-31 17:31:37 -0700 Comment on attachment 306020 Patch Clearing flags on attachment: 306020 Committed r214706: <http://trac.webkit.org/changeset/214706> 1293391 11 commit-queue 2017-03-31 17:31:41 -0700 All reviewed patches have been landed. Closing bug. 306020 2017-03-31 15:33:28 -0700 2017-03-31 17:31:37 -0700 Patch bug-162510-20170331153327.patch text/plain 3475 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0Njc2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjI2MDlhZjMxYzI1NTcxMGZlYTNi NDhmNWZjYTNhYzJjM2RlNjRkMy4uZjEyZGU4YWJiOWUzNjliZjhhNDVmZGU5YmEwNzA5NmViMTJl YWJhYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTAzLTMxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdCBmYXN0L2ltYWdlcy9hbmltYXRl ZC1naWYtcmVzdG9yZWQtZnJvbS1iZmNhY2hlLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI1MTAKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzMxMzgwNjUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IHJlc3RvcmVzIGEgcGFnZSBmcm9tIFBhZ2VD YWNoZSBhbmQgd2FudHMgdG8gY2hlY2sgdGhhdCBhbiBhbmltYXRlZAorICAgICAgICBHSUYgaXMg cHJvcGVybHkgYW5pbWF0aW5nLiBUbyBkbyBzbywgaXQgc3RvcmUgdGhlIGRhdGEgb2YgdGhlIGN1 cnJlbnQgaW1hZ2UKKyAgICAgICAgZnJhbWUsIGFuZCB0aGVuIGNoZWNrcyBpbiBhIDEwMG1zIHRp bWVyIHRoYXQgdGhlIGN1cnJlbnQgaW1hZ2UgZnJhbWUgaXMKKyAgICAgICAgZGlmZmVyZW50LiBU aGlzIGlzIGZsYWt5IGJ5IG5hdHVyZSBzaW5jZSB0aGUgaW1hZ2Ugb25seSBoYXMgMTAgZnJhbWVz IGFuZAorICAgICAgICB5b3UgdGhlcmVmb3JlIGhhdmUgYSAxLzEwIGNoYW5jZSB0aGF0IHRoZSBu ZXcgZnJhbWUgd2lsbCBiZSB0aGUgc2FtZSBhcyB0aGUKKyAgICAgICAgcHJldmlvdXMgb25lLCBl dmVuIGlmIHRoZSBpbWFnZSBpcyBwcm9wZXJseSBhbmltYXRpbmcuCisKKyAgICAgICAgVG8gYWRk cmVzcyB0aGUgcHJvYmxlbSwgZG8gYSBzZXRJbnRlcnZhbCBpbnN0ZWFkIG9mIGEgc2V0VGltZW91 dCBhbmQgY2hlY2sKKyAgICAgICAgdW50aWwgdGhlIGZyYW1lIGJlY29tZXMgZGlmZmVyZW50Lgor CisgICAgICAgICogZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lmLXJlc3RvcmVkLWZyb20tYmZjYWNo ZS5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3 LTAzLTMxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIENv cnJlY3Rpb24gZm9yIHRoZSBwcmV2aW91cyBjaGFuZ2UgLSB0aGlzIGlzIGFuIGltYWdlIGZhaWx1 cmUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtcmVz dG9yZWQtZnJvbS1iZmNhY2hlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9hbmltYXRl ZC1naWYtcmVzdG9yZWQtZnJvbS1iZmNhY2hlLmh0bWwKaW5kZXggMjM1OWM3OGUxN2M2NzJjM2Q2 ZjhmNzU5ZDhkZDY0OGI0M2Y5ZTMyZi4uOTAzOGQzZTllMDZiNmIyZWY5ZjE3MGJhM2FjYmFjOGM5 ZjAyNmVjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lm LXJlc3RvcmVkLWZyb20tYmZjYWNoZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2Vz L2FuaW1hdGVkLWdpZi1yZXN0b3JlZC1mcm9tLWJmY2FjaGUuaHRtbApAQCAtMTcsNyArMTcsNyBA QAogICAgICAgICBjb250ZXh0LmRyYXdJbWFnZShpbWFnZSwgMCwgMCk7CiAgICAgICAgIHZhciBm cmFtZU9uZSA9IGNvbnRleHQuZ2V0SW1hZ2VEYXRhKDAsIDAsIDEsIDEpLmRhdGE7CiAKLSAgICAg ICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGhhbmRsZSA9IHdpbmRv dy5zZXRJbnRlcnZhbChmdW5jdGlvbigpIHsKICAgICAgICAgICAgIGNvbnRleHQuZHJhd0ltYWdl KGltYWdlLCAwLCAwKTsKICAgICAgICAgICAgIHZhciBmcmFtZVR3byA9IGNvbnRleHQuZ2V0SW1h Z2VEYXRhKDAsIDAsIDEsIDEpLmRhdGE7CiAKQEAgLTI2LDEzICsyNiwxMyBAQAogICAgICAgICAg ICAgICAgICYmIGZyYW1lT25lWzFdID09IGZyYW1lVHdvWzFdCiAgICAgICAgICAgICAgICAgJiYg ZnJhbWVPbmVbMl0gPT0gZnJhbWVUd29bMl0KICAgICAgICAgICAgICAgICAmJiBmcmFtZU9uZVsz XSA9PSBmcmFtZVR3b1szXSkKLSAgICAgICAgICAgICAgICBjb25zb2xlLmlubmVySFRNTCA9ICI8 c3BhbiBzdHlsZT0nY29sb3I6cmVkJz5GQUlMPC9zcGFuPiI7Ci0gICAgICAgICAgICBlbHNlCi0g ICAgICAgICAgICAgICAgY29uc29sZS5pbm5lckhUTUwgPSAiPHNwYW4gc3R5bGU9J2NvbG9yOmdy ZWVuJz5QQVNTPC9zcGFuPiI7CisgICAgICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgICAg ICB3aW5kb3cuY2xlYXJJbnRlcnZhbChoYW5kbGUpOworICAgICAgICAgICAgY29uc29sZS5pbm5l ckhUTUwgPSAiPHNwYW4gc3R5bGU9J2NvbG9yOmdyZWVuJz5QQVNTPC9zcGFuPiI7CiAgICAgICAg ICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7Ci0gICAgICAgIH0sIDEwMCk7CisgICAgICAgIH0sIDEwKTsKICAgICB9CiAK ICAgICB3aW5kb3cub25wYWdlc2hvdyA9IGZ1bmN0aW9uKGV2ZW50KSB7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGQ4ZjUxNTEyYzlhZDgxZGJhZWRmOTEy NDQ1NzZmMDZiOTNjMGVlOWMuLjM2Nzk3MWQ0OGNjYmU3NzdiODI5MGQ1NGYyMDgwNTY1YmFlNDBj OGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNTE2 LDggKzE1MTYsNiBAQCB3ZWJraXQub3JnL2IvMTY2NjcyIFsgU2llcnJhKyBdIGZhc3QvdGV4dC92 YXJpYXRpb25zL2FkdmFuY2VzLmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2MjUw NyBodHRwL3Rlc3RzL21lZGlhL2hscy9obHMtdmlkZW8tcmVzaXplLmh0bWwgWyBQYXNzIEZhaWx1 cmUgXQogCi13ZWJraXQub3JnL2IvMTYyNTEwIFsgRGVidWcgXSBmYXN0L2ltYWdlcy9hbmltYXRl ZC1naWYtcmVzdG9yZWQtZnJvbS1iZmNhY2hlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiB3ZWJr aXQub3JnL2IvMTY3NjQyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2hhZG93LWRv bS9zbG90Y2hhbmdlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTY3NzU3 IFsgU2llcnJhIFJlbGVhc2UgXSB3b3JrZXJzL2JvbWIuaHRtbCBbIFBhc3MgVGltZW91dCBdCg==