162091 2016-09-16 14:27:25 -0700 Text nodes assigned to a linked slot are not clickable 2016-09-29 12:52:18 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 148695 1 jan rniwa cdumez commit-queue dbates esprehn+autocc kangil.han koivisto rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1230614 0 jan 2016-09-16 14:27:25 -0700 See http://jsbin.com/qinaxo/edit?html,output This shows a link in a Shadow DOM subtree. Half the content is directly inside the anchor element, the other half of the content is assigned via a `<slot>` element. Expect: The entire link should be clickable. Actual: The content assigned to the `<slot>` element is not clickable. 1231578 1 webkit-bug-importer 2016-09-20 02:12:36 -0700 <rdar://problem/28383300> 1234639 2 290153 rniwa 2016-09-28 17:48:15 -0700 Created attachment 290153 Fixes the bug 1234654 3 290159 rniwa 2016-09-28 18:52:32 -0700 Created attachment 290159 Fixes the bug 1234753 4 290159 koivisto 2016-09-29 02:06:34 -0700 Comment on attachment 290159 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=290159&action=review > Source/WebCore/dom/Node.cpp:1845 > - for (Node* node = this; node; node = node->parentOrShadowHostNode()) { > + for (Node* node = this; node; node = node->parentInComposedTree()) { It would be more stylish to use ComposedTreeAncestorIterator. The current composedTreeAncestors() starts from the parent though so dealing with the OrSelf part here would require refactoring a bit (or adding new composedTreeLineage() helper that starts from the current node). I think we should eventually get rid of all these random helpers. On the other hand just switching parentOrShadowHostNode->parentInComposedTree is a good way to make progress fast. 1234922 5 290159 rniwa 2016-09-29 12:42:11 -0700 Comment on attachment 290159 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=290159&action=review >> Source/WebCore/dom/Node.cpp:1845 >> + for (Node* node = this; node; node = node->parentInComposedTree()) { > > It would be more stylish to use ComposedTreeAncestorIterator. The current composedTreeAncestors() starts from the parent though so dealing with the OrSelf part here would require refactoring a bit (or adding new composedTreeLineage() helper that starts from the current node). > > I think we should eventually get rid of all these random helpers. On the other hand just switching parentOrShadowHostNode->parentInComposedTree is a good way to make progress fast. I'd keep parentInComposedTree for now, and we can do this in a separate patch if we'd so wished. 1234925 6 rniwa 2016-09-29 12:52:18 -0700 Committed r206605: <http://trac.webkit.org/changeset/206605> 290153 2016-09-28 17:48:15 -0700 2016-09-28 18:52:27 -0700 Fixes the bug bug-162091-20160928174515.patch text/plain 7170 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIwMTIyNTZiMTVjODM0 ZTIyOThjZjNmNjIyMTFhM2IxMWI4N2FkNS4uYmNkOWMyYmNhMGZiMjgxYjcwOTdmY2RmMTlmNjAy YTNhMTc3ZDQzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA5LTI4ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFRleHQgbm9kZXMgYXNzaWdu ZWQgdG8gYSBsaW5rZWQgc2xvdCBpcyBub3QgY2xpY2thYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIwOTEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI4MzgzMzAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBidWcgd2FzIGNhdXNlZCBieSB1cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZSBh ZGp1c3RpbmcgdGhlIHRhcmdldCB0byBpdHMgcGFyZW50IGVsZW1lbnQgd2hlbgorICAgICAgICB0 aGUgb3JpZ2luYWwgdGFyZ2V0IHdhcyBhIHRleHQgbm9kZS4gRml4ZWQgdGhlIGJ1ZyBieSB1c2lu ZyB0aGUgcGFyZW50IGVsZW1lbnQgaW4gdGhlIGNvbXBvc2VkIHRyZWUuCisKKyAgICAgICAgQWxz byBmaXhlZCB0aGUgYnVnIHRoYXQgdGhlIGhpdCB0ZXN0aW5nIHdhcyBub3QgZmluZGluZyB0aGUg YW5jaG9yIGVsZW1lbnQgYW5kIGtlZXBpbmcgdGhlIGN1cnNvcgorICAgICAgICBpbiBJLWJlYW0g YnkgdHJhdmVyc2luZyB0aGUgY29tcG9zZWQgdHJlZSBpbnN0ZWFkLgorCisgICAgICAgIFRlc3Q6 IGZhc3Qvc2hhZG93LWRvbS9jbGljay10ZXh0LWluc2lkZS1saW5rZWQtc2xvdC5odG1sCisKKyAg ICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOb2RlOjplbmNsb3NpbmdM aW5rRXZlbnRQYXJlbnRPclNlbGYpOiBGaXhlZCB0aGUgY3Vyc29yIHByb2JsZW0uCisgICAgICAg ICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVy Ojp1cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZSk6IEZpeGVkIHRoZSBhY3RpdmF0aW9uIHByb2Js ZW0uCisKIDIwMTYtMDktMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBJdCBzaG91bGQgYmUgcG9zc2libGUgdG8gZGlzcGF0Y2ggZXZlbnRzIG9uIHRlbXBsYXRl IGRvY3VtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGEwZDFjYWIyNzMzZjJmM2ZkN2UxOGNmNThl MjAxN2YwMmM4ZGY2MjIuLjY2MDYwN2I5ZTI2ZTZmYTljMGU4ZWZhYTUzZTM2NWZlNjFiM2Y4YjUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKQEAgLTE4NDIsNyArMTg0Miw3IEBAIHZvaWQgTm9kZTo6Z2V0U3Vi cmVzb3VyY2VVUkxzKExpc3RIYXNoU2V0PFVSTD4mIHVybHMpIGNvbnN0CiAKIEVsZW1lbnQqIE5v ZGU6OmVuY2xvc2luZ0xpbmtFdmVudFBhcmVudE9yU2VsZigpCiB7Ci0gICAgZm9yIChOb2RlKiBu b2RlID0gdGhpczsgbm9kZTsgbm9kZSA9IG5vZGUtPnBhcmVudE9yU2hhZG93SG9zdE5vZGUoKSkg eworICAgIGZvciAoTm9kZSogbm9kZSA9IHRoaXM7IG5vZGU7IG5vZGUgPSBub2RlLT5wYXJlbnRJ bkNvbXBvc2VkVHJlZSgpKSB7CiAgICAgICAgIC8vIEZvciBpbWFnZW1hcHMsIHRoZSBlbmNsb3Np bmcgbGluayBlbGVtZW50IGlzIHRoZSBhc3NvY2lhdGVkIGFyZWEgZWxlbWVudCBub3QgdGhlIGlt YWdlIGl0c2VsZi4KICAgICAgICAgLy8gU28gd2UgZG9uJ3QgbGV0IGltYWdlcyBiZSB0aGUgZW5j bG9zaW5nIGxpbmsgZWxlbWVudCwgZXZlbiB0aG91Z2ggaXNMaW5rIHNvbWV0aW1lcyByZXR1cm5z CiAgICAgICAgIC8vIHRydWUgZm9yIHRoZW0uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAKaW5kZXggNDk0YjExNmI2N2Y4NjcyYWQwYzNhZmNiNTMzOWRlMDllNDBkNWY3NS4uNTBmYzQ4 NWYxZDZiNTJlNTk0NjJhOGE0YzdjYTRmZmZlYWU3NzI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcApAQCAtMjM2MiwxMCArMjM2Miw5IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjp1 cGRhdGVNb3VzZUV2ZW50VGFyZ2V0Tm9kZShOb2RlKiB0YXJnZXROb2RlLCBjb25zdCBQbGF0Zm9y bU1vCiAgICAgICAgIHRhcmdldEVsZW1lbnQgPSBtX2NhcHR1cmluZ01vdXNlRXZlbnRzRWxlbWVu dC5nZXQoKTsKICAgICBlbHNlIGlmICh0YXJnZXROb2RlKSB7CiAgICAgICAgIC8vIElmIHRoZSB0 YXJnZXQgbm9kZSBpcyBhIG5vbi1lbGVtZW50LCBkaXNwYXRjaCBvbiB0aGUgcGFyZW50LiA8cmRh cjovL3Byb2JsZW0vNDE5NjY0Nj4KLSAgICAgICAgaWYgKCFpczxFbGVtZW50PigqdGFyZ2V0Tm9k ZSkpCi0gICAgICAgICAgICB0YXJnZXRFbGVtZW50ID0gdGFyZ2V0Tm9kZS0+cGFyZW50T3JTaGFk b3dIb3N0RWxlbWVudCgpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICB0YXJnZXRFbGVtZW50 ID0gZG93bmNhc3Q8RWxlbWVudD4odGFyZ2V0Tm9kZSk7CisgICAgICAgIHdoaWxlICh0YXJnZXRO b2RlICYmICFpczxFbGVtZW50PigqdGFyZ2V0Tm9kZSkpCisgICAgICAgICAgICB0YXJnZXROb2Rl ID0gdGFyZ2V0Tm9kZS0+cGFyZW50SW5Db21wb3NlZFRyZWUoKTsKKyAgICAgICAgdGFyZ2V0RWxl bWVudCA9IGRvd25jYXN0PEVsZW1lbnQ+KHRhcmdldE5vZGUpOwogICAgIH0KIAogICAgIG1fZWxl bWVudFVuZGVyTW91c2UgPSB0YXJnZXRFbGVtZW50OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxNDc5ZTRlZWI4YTA5ZTll YjhmZTE3NTQyZTE5NmMzYmE4YzlmYjAuLjI0N2E0YjM4ZTE4NTJhZThjZThjNmQ1YzdhOWIyODQ3 MjM0MjgxNmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNi0wOS0yOCAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBUZXh0IG5vZGVzIGFzc2lnbmVkIHRvIGEg bGlua2VkIHNsb3QgaXMgbm90IGNsaWNrYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMDkxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODM4 MzMwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdCBmb3IgY2xpY2tpbmcgaW5zaWRlIGEgdGV4dCBub2RlIGFz c2lnbmVkIHRvIGEgc2xvdCBpbnNpZGUgYSBoeXBlcmxpbmsuCisKKyAgICAgICAgVW5mb3J0dW5h dGVseSwgdGhlcmUgaXMgbm90IGEgd2F5IHRvIG1ha2UgdGhpcyBhIFczQyBzdHlsZSB0ZXN0IHVu dGlsIHRoZSB3ZWIgcGxhdGZvcm0gdGVzdHMKKyAgICAgICAgc3RhcnQgc3VwcG9ydGluZyBXZWJE cml2ZXIuCisKKyAgICAgICAgKiBmYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNpZGUtbGlu a2VkLXNsb3QtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3NoYWRvdy1kb20v Y2xpY2stdGV4dC1pbnNpZGUtbGlua2VkLXNsb3QuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vaW9zLXNpbXVsYXRvci13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNi0wOS0yOCAg UnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgVGVz dEV4cGVjdGF0aW9ucyBmb3IgbW9yZSBjcmFzaGluZyBmYXN0L2ltYWdlcyB0ZXN0cy4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9jbGljay10ZXh0LWluc2lkZS1saW5r ZWQtc2xvdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vY2xpY2st dGV4dC1pbnNpZGUtbGlua2VkLXNsb3QtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFjNDk1YjJh Nzc1MzVmODY4ZDMzZTUzNjU0NTJkZjhkMTIzYTJjNzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNpZGUtbGlua2VkLXNsb3QtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorVGhpcyB0ZXN0cyBjbGlja2luZyBvbiBhIFRleHQg bm9kZSBhc3NpZ25lZCB0byBhIHNsb3QgaW5zaWRlIGFuIGFuY2hvciBlbGVtZW50LiBUaGUgbGlu ayBzaG91bGQgYmUgYWN0aXZhdGVkLgorVG8gbWFudWFsbHkgdGVzdCwgY2xpY2sgImhlcmUiIGJl bG93IGFuZCB5b3Ugc2hvdWxkIHNlZSAiUEFTUyIgYW5kIHRoZSBtb3VzZSBjdXJzb3Igc2hvdWxk IGluZGljYXRlIGl0J3MgYSBoeXBlcmxpbmssIG5vdCB0ZXh0OgorCitjbGljayBoZXJlCitBY3Rp dmF0aW9uOiBQQVNTCitDdXJzb3I6IHR5cGU9SGFuZCBob3RTcG90PTAsMApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2NsaWNrLXRleHQtaW5zaWRlLWxpbmtlZC1zbG90 Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNpZGUtbGlu a2VkLXNsb3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43Y2ExYzA2YzlkYWYxMmRmNWNlYjg0YzFiNjg3ZDk3 NmRlYzljNDY0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9t L2NsaWNrLXRleHQtaW5zaWRlLWxpbmtlZC1zbG90Lmh0bWwKQEAgLTAsMCArMSwzNCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyBjbGlja2luZyBvbiBh IFRleHQgbm9kZSBhc3NpZ25lZCB0byBhIHNsb3QgaW5zaWRlIGFuIGFuY2hvciBlbGVtZW50LiBU aGUgbGluayBzaG91bGQgYmUgYWN0aXZhdGVkLjxicj4KK1RvIG1hbnVhbGx5IHRlc3QsIGNsaWNr ICJoZXJlIiBiZWxvdyBhbmQgeW91IHNob3VsZCBzZWUgIlBBU1MiIGFuZCB0aGUgbW91c2UgY3Vy c29yIHNob3VsZCBpbmRpY2F0ZSBpdCdzIGEgaHlwZXJsaW5rLCBub3QgdGV4dDo8L3A+Cis8c2Ny aXB0PgorCit2YXIgc2hhZG93SG9zdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOwor ZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChzaGFkb3dIb3N0KTsKKworc2hhZG93SG9zdC5pbm5l ckhUTUwgPSBgY2xpY2sgaGVyZWA7Cit2YXIgc2hhZG93Um9vdCA9IHNoYWRvd0hvc3QuYXR0YWNo U2hhZG93KHttb2RlOiAnY2xvc2VkJ30pOworc2hhZG93Um9vdC5pbm5lckhUTUwgPSBgPGEgaHJl Zj0iamF2YXNjcmlwdDphY3RpdmF0ZWQoKSI+PHNsb3Q+PC9zbG90PjwvYT5gOworCitkb2N1bWVu dC53cml0ZSgnPGRpdj5BY3RpdmF0aW9uOiA8c3BhbiBpZD0iYWN0aXZhdGlvbiI+PHNwYW4+PC9k aXY+Jyk7CisKK2Z1bmN0aW9uIGFjdGl2YXRlZCgpIHsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnYWN0aXZhdGlvbicpLnRleHRDb250ZW50ID0gJ1BBU1MnOworICAgIGlmICh3aW5kb3cu aW50ZXJuYWxzKQorICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY3Vyc29yJykudGV4 dENvbnRlbnQgPSBpbnRlcm5hbHMuZ2V0Q3VycmVudEN1cnNvckluZm8oKTsKK30KKworaWYgKHdp bmRvdy5pbnRlcm5hbHMpIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnYWN0aXZhdGlvbicpLnRleHRDb250ZW50ID0gJ0ZBSUwnOwor ICAgIGRvY3VtZW50LndyaXRlKCc8ZGl2PkN1cnNvcjogPHNwYW4gaWQ9ImN1cnNvciI+RkFJTDxz cGFuPjwvZGl2PicpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHNoYWRvd0hvc3Qub2Zm c2V0TGVmdCArIDUsIHNoYWRvd0hvc3Qub2Zmc2V0VG9wICsgNSk7CisgICAgZXZlbnRTZW5kZXIu bW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworfQorCis8L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1z aW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mt c2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDY5MmZkMDEyZDU5YWM0NWMzN2Fk YmI1ZjI4NGFjYjdmYzI0MDA1MjUuLmJmMDI0Yzg2OWQyY2Q0MjNkY2Y0YmU2ZGE3Nzk2ZmI2MTA3 MTQzMjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2sy L1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVsYXRv ci13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTc2NSw2ICsxNzY1LDcgQEAgd2Via2l0Lm9yZy9i LzEyMzQzMSBodHRwL3Rlc3RzL2Nzcy9saW5rLWNzcy1kaXNhYmxlZC12YWx1ZS13aXRoLXNsb3ct bG9hZGluZy1zaGUKIGZhc3QvbG9hZGVyL2xvY2F0aW9uLWhhc2gtdXNlci1nZXN0dXJlLmh0bWwg WyBTa2lwIF0KIGltcG9ydGVkL2JsaW5rL2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdHN0YXJ0LWV2 ZW50LWNyYXNoLmh0bWwgWyBTa2lwIF0KIGZhc3QvZG9tL1dpbmRvdy9wb3N0LW1lc3NhZ2UtdXNl ci1hY3Rpb24uaHRtbCBbIFNraXAgXQorZmFzdC9zaGFkb3ctZG9tL2NsaWNrLXRleHQtaW5zaWRl LWxpbmtlZC1zbG90Lmh0bWwgWyBTa2lwIF0KIAogIyBObyB0b3VjaCBldmVudHMKIGh0dHAvdGVz dHMvY29udGVudGRpc3Bvc2l0aW9uYXR0YWNobWVudHNhbmRib3gvcmVmZXJlci1oZWFkZXItc3Ry aXBwZWQtd2l0aC1tZXRhLXJlZmVyZXItYWx3YXlzLmh0bWwgWyBTa2lwIF0K 290159 2016-09-28 18:52:32 -0700 2016-09-29 02:06:34 -0700 Fixes the bug bug-162091-20160928184932.patch text/plain 7172 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIwMTIyNTZiMTVjODM0 ZTIyOThjZjNmNjIyMTFhM2IxMWI4N2FkNS4uYjBmMjMwNzhjMGYwNTIxZTRlMTRmYmYxYWMxMWE0 YzJmMGM4MzFmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA5LTI4ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFRleHQgbm9kZXMgYXNzaWdu ZWQgdG8gYSBsaW5rZWQgc2xvdCBhcmUgbm90IGNsaWNrYWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMDkxCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yODM4MzMwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgYnVnIHdhcyBjYXVzZWQgYnkgdXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUg YWRqdXN0aW5nIHRoZSB0YXJnZXQgdG8gaXRzIHBhcmVudCBlbGVtZW50IHdoZW4KKyAgICAgICAg dGhlIG9yaWdpbmFsIHRhcmdldCB3YXMgYSB0ZXh0IG5vZGUuIEZpeGVkIHRoZSBidWcgYnkgdXNp bmcgdGhlIHBhcmVudCBlbGVtZW50IGluIHRoZSBjb21wb3NlZCB0cmVlLgorCisgICAgICAgIEFs c28gZml4ZWQgdGhlIGJ1ZyB0aGF0IHRoZSBoaXQgdGVzdGluZyB3YXMgbm90IGZpbmRpbmcgdGhl IGFuY2hvciBlbGVtZW50IGFuZCBrZWVwaW5nIHRoZSBjdXJzb3IKKyAgICAgICAgaW4gSS1iZWFt IGJ5IHRyYXZlcnNpbmcgdGhlIGNvbXBvc2VkIHRyZWUgaW5zdGVhZC4KKworICAgICAgICBUZXN0 OiBmYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNpZGUtbGlua2VkLXNsb3QuaHRtbAorCisg ICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZW5jbG9zaW5n TGlua0V2ZW50UGFyZW50T3JTZWxmKTogRml4ZWQgdGhlIGN1cnNvciBwcm9ibGVtLgorICAgICAg ICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxl cjo6dXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUpOiBGaXhlZCB0aGUgYWN0aXZhdGlvbiBwcm9i bGVtLgorCiAyMDE2LTA5LTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGRpc3BhdGNoIGV2ZW50cyBvbiB0ZW1wbGF0 ZSBkb2N1bWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCBhMGQxY2FiMjczM2YyZjNmZDdlMThjZjU4 ZTIwMTdmMDJjOGRmNjIyLi42NjA2MDdiOWUyNmU2ZmE5YzBlOGVmYWE1M2UzNjVmZTYxYjNmOGI1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL05vZGUuY3BwCkBAIC0xODQyLDcgKzE4NDIsNyBAQCB2b2lkIE5vZGU6OmdldFN1 YnJlc291cmNlVVJMcyhMaXN0SGFzaFNldDxVUkw+JiB1cmxzKSBjb25zdAogCiBFbGVtZW50KiBO b2RlOjplbmNsb3NpbmdMaW5rRXZlbnRQYXJlbnRPclNlbGYoKQogewotICAgIGZvciAoTm9kZSog bm9kZSA9IHRoaXM7IG5vZGU7IG5vZGUgPSBub2RlLT5wYXJlbnRPclNoYWRvd0hvc3ROb2RlKCkp IHsKKyAgICBmb3IgKE5vZGUqIG5vZGUgPSB0aGlzOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50 SW5Db21wb3NlZFRyZWUoKSkgewogICAgICAgICAvLyBGb3IgaW1hZ2VtYXBzLCB0aGUgZW5jbG9z aW5nIGxpbmsgZWxlbWVudCBpcyB0aGUgYXNzb2NpYXRlZCBhcmVhIGVsZW1lbnQgbm90IHRoZSBp bWFnZSBpdHNlbGYuCiAgICAgICAgIC8vIFNvIHdlIGRvbid0IGxldCBpbWFnZXMgYmUgdGhlIGVu Y2xvc2luZyBsaW5rIGVsZW1lbnQsIGV2ZW4gdGhvdWdoIGlzTGluayBzb21ldGltZXMgcmV0dXJu cwogICAgICAgICAvLyB0cnVlIGZvciB0aGVtLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCmluZGV4IDQ5NGIxMTZiNjdmODY3MmFkMGMzYWZjYjUzMzlkZTA5ZTQwZDVmNzUuLjUwZmM0 ODVmMWQ2YjUyZTU5NDYyYThhNGM3Y2E0ZmZmZWFlNzcyNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKQEAgLTIzNjIsMTAgKzIzNjIsOSBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6 dXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUoTm9kZSogdGFyZ2V0Tm9kZSwgY29uc3QgUGxhdGZv cm1NbwogICAgICAgICB0YXJnZXRFbGVtZW50ID0gbV9jYXB0dXJpbmdNb3VzZUV2ZW50c0VsZW1l bnQuZ2V0KCk7CiAgICAgZWxzZSBpZiAodGFyZ2V0Tm9kZSkgewogICAgICAgICAvLyBJZiB0aGUg dGFyZ2V0IG5vZGUgaXMgYSBub24tZWxlbWVudCwgZGlzcGF0Y2ggb24gdGhlIHBhcmVudC4gPHJk YXI6Ly9wcm9ibGVtLzQxOTY2NDY+Ci0gICAgICAgIGlmICghaXM8RWxlbWVudD4oKnRhcmdldE5v ZGUpKQotICAgICAgICAgICAgdGFyZ2V0RWxlbWVudCA9IHRhcmdldE5vZGUtPnBhcmVudE9yU2hh ZG93SG9zdEVsZW1lbnQoKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgdGFyZ2V0RWxlbWVu dCA9IGRvd25jYXN0PEVsZW1lbnQ+KHRhcmdldE5vZGUpOworICAgICAgICB3aGlsZSAodGFyZ2V0 Tm9kZSAmJiAhaXM8RWxlbWVudD4oKnRhcmdldE5vZGUpKQorICAgICAgICAgICAgdGFyZ2V0Tm9k ZSA9IHRhcmdldE5vZGUtPnBhcmVudEluQ29tcG9zZWRUcmVlKCk7CisgICAgICAgIHRhcmdldEVs ZW1lbnQgPSBkb3duY2FzdDxFbGVtZW50Pih0YXJnZXROb2RlKTsKICAgICB9CiAKICAgICBtX2Vs ZW1lbnRVbmRlck1vdXNlID0gdGFyZ2V0RWxlbWVudDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMTQ3OWU0ZWViOGEwOWU5 ZWI4ZmUxNzU0MmUxOTZjM2JhOGM5ZmIwLi5lN2MyZDU3MDZhYzNjZTBhMmYzZTFmOWZmNjdiZmZm OTJkM2U3OWU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTYtMDktMjggIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGV4dCBub2RlcyBhc3NpZ25lZCB0byBh IGxpbmtlZCBzbG90IGFyZSBub3QgY2xpY2thYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIwOTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4 MzgzMzAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGEgcmVncmVzc2lvbiB0ZXN0IGZvciBjbGlja2luZyBpbnNpZGUgYSB0ZXh0IG5vZGUg YXNzaWduZWQgdG8gYSBzbG90IGluc2lkZSBhIGh5cGVybGluay4KKworICAgICAgICBVbmZvcnR1 bmF0ZWx5LCB0aGVyZSBpcyBub3QgYSB3YXkgdG8gbWFrZSB0aGlzIGEgVzNDIHN0eWxlIHRlc3Qg dW50aWwgdGhlIHdlYiBwbGF0Zm9ybSB0ZXN0cworICAgICAgICBzdGFydCBzdXBwb3J0aW5nIFdl YkRyaXZlci4KKworICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9jbGljay10ZXh0LWluc2lkZS1s aW5rZWQtc2xvdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93LWRv bS9jbGljay10ZXh0LWluc2lkZS1saW5rZWQtc2xvdC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBw bGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE2LTA5LTI4 ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBU ZXN0RXhwZWN0YXRpb25zIGZvciBtb3JlIGNyYXNoaW5nIGZhc3QvaW1hZ2VzIHRlc3RzLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2NsaWNrLXRleHQtaW5zaWRlLWxp bmtlZC1zbG90LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9jbGlj ay10ZXh0LWluc2lkZS1saW5rZWQtc2xvdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWM0OTVi MmE3NzUzNWY4NjhkMzNlNTM2NTQ1MmRmOGQxMjNhMmM3MQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9jbGljay10ZXh0LWluc2lkZS1saW5rZWQtc2xvdC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACitUaGlzIHRlc3RzIGNsaWNraW5nIG9uIGEgVGV4 dCBub2RlIGFzc2lnbmVkIHRvIGEgc2xvdCBpbnNpZGUgYW4gYW5jaG9yIGVsZW1lbnQuIFRoZSBs aW5rIHNob3VsZCBiZSBhY3RpdmF0ZWQuCitUbyBtYW51YWxseSB0ZXN0LCBjbGljayAiaGVyZSIg YmVsb3cgYW5kIHlvdSBzaG91bGQgc2VlICJQQVNTIiBhbmQgdGhlIG1vdXNlIGN1cnNvciBzaG91 bGQgaW5kaWNhdGUgaXQncyBhIGh5cGVybGluaywgbm90IHRleHQ6CisKK2NsaWNrIGhlcmUKK0Fj dGl2YXRpb246IFBBU1MKK0N1cnNvcjogdHlwZT1IYW5kIGhvdFNwb3Q9MCwwCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNpZGUtbGlua2VkLXNs b3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9jbGljay10ZXh0LWluc2lkZS1s aW5rZWQtc2xvdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdjYTFjMDZjOWRhZjEyZGY1Y2ViODRjMWI2ODdk OTc2ZGVjOWM0NjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1k b20vY2xpY2stdGV4dC1pbnNpZGUtbGlua2VkLXNsb3QuaHRtbApAQCAtMCwwICsxLDM0IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8cD5UaGlzIHRlc3RzIGNsaWNraW5nIG9u IGEgVGV4dCBub2RlIGFzc2lnbmVkIHRvIGEgc2xvdCBpbnNpZGUgYW4gYW5jaG9yIGVsZW1lbnQu IFRoZSBsaW5rIHNob3VsZCBiZSBhY3RpdmF0ZWQuPGJyPgorVG8gbWFudWFsbHkgdGVzdCwgY2xp Y2sgImhlcmUiIGJlbG93IGFuZCB5b3Ugc2hvdWxkIHNlZSAiUEFTUyIgYW5kIHRoZSBtb3VzZSBj dXJzb3Igc2hvdWxkIGluZGljYXRlIGl0J3MgYSBoeXBlcmxpbmssIG5vdCB0ZXh0OjwvcD4KKzxz Y3JpcHQ+CisKK3ZhciBzaGFkb3dIb3N0ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7 Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHNoYWRvd0hvc3QpOworCitzaGFkb3dIb3N0Lmlu bmVySFRNTCA9IGBjbGljayBoZXJlYDsKK3ZhciBzaGFkb3dSb290ID0gc2hhZG93SG9zdC5hdHRh Y2hTaGFkb3coe21vZGU6ICdjbG9zZWQnfSk7CitzaGFkb3dSb290LmlubmVySFRNTCA9IGA8YSBo cmVmPSJqYXZhc2NyaXB0OmFjdGl2YXRlZCgpIj48c2xvdD48L3Nsb3Q+PC9hPmA7CisKK2RvY3Vt ZW50LndyaXRlKCc8ZGl2PkFjdGl2YXRpb246IDxzcGFuIGlkPSJhY3RpdmF0aW9uIj48c3Bhbj48 L2Rpdj4nKTsKKworZnVuY3Rpb24gYWN0aXZhdGVkKCkgeworICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdhY3RpdmF0aW9uJykudGV4dENvbnRlbnQgPSAnUEFTUyc7CisgICAgaWYgKHdpbmRv dy5pbnRlcm5hbHMpCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjdXJzb3InKS50 ZXh0Q29udGVudCA9IGludGVybmFscy5nZXRDdXJyZW50Q3Vyc29ySW5mbygpOworfQorCitpZiAo d2luZG93LmludGVybmFscykgeworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdhY3RpdmF0aW9uJykudGV4dENvbnRlbnQgPSAnRkFJTCc7 CisgICAgZG9jdW1lbnQud3JpdGUoJzxkaXY+Q3Vyc29yOiA8c3BhbiBpZD0iY3Vyc29yIj5GQUlM PHNwYW4+PC9kaXY+Jyk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc2hhZG93SG9zdC5v ZmZzZXRMZWZ0ICsgNSwgc2hhZG93SG9zdC5vZmZzZXRUb3AgKyA1KTsKKyAgICBldmVudFNlbmRl ci5tb3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cit9CisKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9z LXNpbXVsYXRvci13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy1zaW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNjkyZmQwMTJkNTlhYzQ1YzM3 YWRiYjVmMjg0YWNiN2ZjMjQwMDUyNS4uYmYwMjRjODY5ZDJjZDQyM2RjZjRiZTZkYTc3OTZmYjYx MDcxNDMyNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVsYXRvci13 azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxh dG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNzY1LDYgKzE3NjUsNyBAQCB3ZWJraXQub3Jn L2IvMTIzNDMxIGh0dHAvdGVzdHMvY3NzL2xpbmstY3NzLWRpc2FibGVkLXZhbHVlLXdpdGgtc2xv dy1sb2FkaW5nLXNoZQogZmFzdC9sb2FkZXIvbG9jYXRpb24taGFzaC11c2VyLWdlc3R1cmUuaHRt bCBbIFNraXAgXQogaW1wb3J0ZWQvYmxpbmsvZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0c3RhcnQt ZXZlbnQtY3Jhc2guaHRtbCBbIFNraXAgXQogZmFzdC9kb20vV2luZG93L3Bvc3QtbWVzc2FnZS11 c2VyLWFjdGlvbi5odG1sIFsgU2tpcCBdCitmYXN0L3NoYWRvdy1kb20vY2xpY2stdGV4dC1pbnNp ZGUtbGlua2VkLXNsb3QuaHRtbCBbIFNraXAgXQogCiAjIE5vIHRvdWNoIGV2ZW50cwogaHR0cC90 ZXN0cy9jb250ZW50ZGlzcG9zaXRpb25hdHRhY2htZW50c2FuZGJveC9yZWZlcmVyLWhlYWRlci1z dHJpcHBlZC13aXRoLW1ldGEtcmVmZXJlci1hbHdheXMuaHRtbCBbIFNraXAgXQo=