162090 2016-09-16 14:26:42 -0700 [Win][Direct2D] Provide Color support for Direct2D 2016-09-16 17:16:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All Windows 10 RESOLVED FIXED P2 Normal --- 161817 1 bfulgham bfulgham bfulgham commit-queue oldest_to_newest 1230613 0 bfulgham 2016-09-16 14:26:42 -0700 Add some casting operators to Color to allow conversion to/from native Direct2D types. 1230616 1 289113 bfulgham 2016-09-16 14:32:54 -0700 Created attachment 289113 Patch 1230617 2 commit-queue 2016-09-16 14:34:38 -0700 Attachment 289113 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/Color.h:45: D2D_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/Color.h:46: D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/graphics/win/ColorDirect2D.cpp:41: D2D1_COLOR_F is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1230719 3 bfulgham 2016-09-16 17:16:24 -0700 Committed r206056: <http://trac.webkit.org/changeset/206056> 289113 2016-09-16 14:32:54 -0700 2016-09-16 14:35:14 -0700 Patch bug-162090-20160916143014.patch text/plain 4803 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjA0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA5LTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dW0RpcmVjdDJEXSBQ cm92aWRlIENvbG9yIHN1cHBvcnQgZm9yIERpcmVjdDJECisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIwOTAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2FzdGluZyBvcGVyYXRpb25zIHRvIHRoZSBD b2xvciBjbGFzcyB0byBhbGxvdyBlYXN5IGludGVyb3B0aW9uIHdpdGgKKyAgICAgICAgbmF0aXZl IERpcmVjdDJEIG9wZXJhdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBQbGF0Zm9ybVdpbi5jbWFrZTogQWRkIG5ldyBXaW5k b3dzIGltcGxlbWVudGF0aW9uIGZpbGUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29s b3IuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vQ29sb3JEaXJlY3QyRC5jcHA6 IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6Q29sb3I6OkNvbG9yKToKKyAgICAgICAgKFdlYkNv cmU6OkNvbG9yOjpvcGVyYXRvciBEMkQxX0NPTE9SX0YpOgorCiAyMDE2LTA5LTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhcHRpb25Vc2VyUHJlZmVy ZW5jZXMncyB1c2Ugb2YgdGhlIFBhZ2VHcm91cCdzIHBhZ2UgbWFwIGlzIGluY29ycmVjdApJbmRl eDogU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UJKHJldmlzaW9uIDIwNjA0NykKKysrIFNvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4Niw3IEBA IGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3Bl bnR5cGUvT3BlblR5cGVVdGlsaXRpZXMuY3BwCiAKKyAgICBwbGF0Zm9ybS9ncmFwaGljcy93aW4v Q29sb3JEaXJlY3QyRC5jcHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy93aW4vRElCUGl4ZWxEYXRh LmNwcAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9GbG9hdFBvaW50RGlyZWN0MkQuY3BwCiAg ICAgcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0Zsb2F0UmVjdERpcmVjdDJELmNwcApJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvci5oCShyZXZpc2lvbiAyMDYwNDcpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvci5oCSh3b3JraW5nIGNvcHkp CkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwMy0yMDA2LCAyMDEwLCAy MDE1IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAw My0yMDE2IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucwpAQCAtMzksNiArMzksMTMgQEAKIHR5cGVkZWYgc3RydWN0IENHQ29sb3Iq IENHQ29sb3JSZWY7CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKFdJTikKK3N0cnVjdCBfRDNEQ09M T1JWQUxVRTsKK3R5cGVkZWYgX0QzRENPTE9SVkFMVUUgRDNEQ09MT1JWQUxVRTsKK3R5cGVkZWYg RDNEQ09MT1JWQUxVRSBEMkRfQ09MT1JfRjsKK3R5cGVkZWYgRDJEX0NPTE9SX0YgRDJEMV9DT0xP Ul9GOworI2VuZGlmCisKICNpZiBQTEFURk9STShHVEspCiB0eXBlZGVmIHN0cnVjdCBfR2RrQ29s b3IgR2RrQ29sb3I7CiAjaWZuZGVmIEdUS19BUElfVkVSU0lPTl8yCkBAIC0xNzQsNiArMTgxLDEx IEBAIHB1YmxpYzoKICAgICBXRUJDT1JFX0VYUE9SVCBDb2xvcihDR0NvbG9yUmVmKTsKICNlbmRp ZgogCisjaWYgUExBVEZPUk0oV0lOKQorICAgIFdFQkNPUkVfRVhQT1JUIENvbG9yKEQyRDFfQ09M T1JfRik7CisgICAgV0VCQ09SRV9FWFBPUlQgb3BlcmF0b3IgRDJEMV9DT0xPUl9GKCkgY29uc3Q7 CisjZW5kaWYKKwogICAgIHN0YXRpYyBib29sIHBhcnNlSGV4Q29sb3IoY29uc3QgU3RyaW5nJiwg UkdCQTMyJik7CiAgICAgc3RhdGljIGJvb2wgcGFyc2VIZXhDb2xvcihjb25zdCBTdHJpbmdWaWV3 JiwgUkdCQTMyJik7CiAgICAgc3RhdGljIGJvb2wgcGFyc2VIZXhDb2xvcihjb25zdCBMQ2hhcios IHVuc2lnbmVkLCBSR0JBMzImKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3dpbi9Db2xvckRpcmVjdDJELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93aW4vQ29sb3JEaXJlY3QyRC5jcHAJKG5vbmV4aXN0ZW50KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0NvbG9yRGlyZWN0MkQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNTAgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDMs IDIwMDQsIDIwMDUsIDIwMDYsIDIwMDcsIDIwMTAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4g UmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5 cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xs b3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBt dXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAg ICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUg ZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUg SU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMs IElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElF UyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVS UE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IKKyAq IENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVO VEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVU RSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRTOyBP UiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZ CisgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFks IE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcg SU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4gCisgKi8KKworI2luY2x1 ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkNvbG9yLmgiCisKKyNpZiBQTEFURk9STShXSU4pCisK KyNpbmNsdWRlIDxkMmQxLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworQ29sb3I6OkNvbG9y KEQyRDFfQ09MT1JfRiBjb2xvcikKK3sKKyAgICBtX2NvbG9yID0gbWFrZVJHQkEoY29sb3IuciAq IDI1NSwgY29sb3IuZyAqIDI1NSwgY29sb3IuYiAqIDI1NSwgY29sb3IuYSAqIDI1NSk7CisgICAg bV92YWxpZCA9IHRydWU7Cit9CisKK0NvbG9yOjpvcGVyYXRvciBEMkQxX0NPTE9SX0YoKSBjb25z dAoreworICAgIGZsb2F0IGNvbG9yQWxwaGEgPSBhbHBoYSgpIC8gMjU1LjBmOworCisgICAgcmV0 dXJuIEQyRDE6OkNvbG9yRihyZ2IoKSwgY29sb3JBbHBoYSk7Cit9CisKK30KKworI2VuZGlmIC8v IFBMQVRGT1JNKFdJTikK