161843 2016-09-10 14:36:56 -0700 REGRESSION (?): background-position animation is broken in transitions/background-position-transitions.html 2016-09-10 17:52:31 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 154551 P2 Normal --- 1 simon.fraser webkit-unassigned dino simon.fraser oldest_to_newest 1228542 0 simon.fraser 2016-09-10 14:36:56 -0700 The top box fails to animate its background-position in transitions/background-position-transitions.html 1228543 1 288500 simon.fraser 2016-09-10 14:41:13 -0700 Created attachment 288500 Testcase Actually that's just a test case I have locally. 1228544 2 simon.fraser 2016-09-10 14:41:52 -0700 Parking this here: diff --git a/LayoutTests/transitions/resources/transition-test-helpers.js b/LayoutTests/transitions/resources/transition-test-helpers.js index 069986e60a08e37eb06e87ed96b1f22fa1d14cb0..b8a14b97db0f71051c82ce0f9d9918c22a5296be 100644 --- a/LayoutTests/transitions/resources/transition-test-helpers.js +++ b/LayoutTests/transitions/resources/transition-test-helpers.js @@ -110,6 +110,52 @@ function parseClipPath(s) return null; } +function hasFloatValue(valueType) +{ + switch (valueType) { + case CSSPrimitiveValue.CSS_FR: + case CSSPrimitiveValue.CSS_NUMBER: + case CSSPrimitiveValue.CSS_PARSER_INTEGER: + case CSSPrimitiveValue.CSS_PERCENTAGE: + case CSSPrimitiveValue.CSS_EMS: + case CSSPrimitiveValue.CSS_EXS: + case CSSPrimitiveValue.CSS_CHS: + case CSSPrimitiveValue.CSS_REMS: + case CSSPrimitiveValue.CSS_PX: + case CSSPrimitiveValue.CSS_CM: + case CSSPrimitiveValue.CSS_MM: + case CSSPrimitiveValue.CSS_IN: + case CSSPrimitiveValue.CSS_PT: + case CSSPrimitiveValue.CSS_PC: + case CSSPrimitiveValue.CSS_DEG: + case CSSPrimitiveValue.CSS_RAD: + case CSSPrimitiveValue.CSS_GRAD: + case CSSPrimitiveValue.CSS_TURN: + case CSSPrimitiveValue.CSS_MS: + case CSSPrimitiveValue.CSS_S: + case CSSPrimitiveValue.CSS_HZ: + case CSSPrimitiveValue.CSS_KHZ: + case CSSPrimitiveValue.CSS_DIMENSION: + case CSSPrimitiveValue.CSS_VW: + case CSSPrimitiveValue.CSS_VH: + case CSSPrimitiveValue.CSS_VMIN: + case CSSPrimitiveValue.CSS_VMAX: + case CSSPrimitiveValue.CSS_DPPX: + case CSSPrimitiveValue.CSS_DPI: + case CSSPrimitiveValue.CSS_DPCM: + return true; + } + return false; +} + +function getNumericValue(cssValue) +{ + if (hasFloatValue(cssValue.primitiveType)) + return cssValue.getFloatValue(cssValue.primitiveType); + + return -1; +} + function checkExpectedValue(expected, index) { var time = expected[index][0]; @@ -196,7 +242,8 @@ function checkExpectedValue(expected, index) for (var i = 0; i < computedStyle.length; ++i) { switch (computedStyle[i].cssValueType) { case CSSValue.CSS_PRIMITIVE_VALUE: - values.push(computedStyle[i].getFloatValue(CSSPrimitiveValue.CSS_NUMBER)); + if (hasFloatValue(computedStyle[i])) + values.push(computedStyle[i].getFloatValue(CSSPrimitiveValue.CSS_NUMBER)); break; case CSSValue.CSS_CUSTOM: // arbitrarily pick shadow-x and shadow-y 1228569 3 simon.fraser 2016-09-10 17:52:31 -0700 Never mind, this was just my test case for bug 154551. *** This bug has been marked as a duplicate of bug 154551 *** 288500 2016-09-10 14:41:13 -0700 2016-09-10 14:41:13 -0700 Testcase background-position-transitions.html text/html 1409 simon.fraser PCFET0NUWVBFPgoKPGh0bWw+CjxoZWFkPgogIDxzdHlsZT4KICAgIC5ib3ggewogICAgICBoZWln aHQ6IDEwMHB4OwogICAgICB3aWR0aDogMTAwcHg7CiAgICAgIG1hcmdpbjogMTBweDsKICAgICAg dHJhbnNpdGlvbi1kdXJhdGlvbjogMXM7CiAgICAgIHRyYW5zaXRpb24tdGltaW5nLWZ1bmN0aW9u OiBsaW5lYXI7CiAgICB9CiAgICAKICAgICNib3ggewogICAgICBiYWNrZ3JvdW5kOiB1cmwoJy4u L2Zhc3QvYmFja2dyb3VuZHMvcmVwZWF0L3Jlc291cmNlcy9ncmFkaWVudC5naWYnKSByZXBlYXQg MCAwOwogICAgICB0cmFuc2l0aW9uLXByb3BlcnR5OiBiYWNrZ3JvdW5kLXBvc2l0aW9uOwogICAg ICBiYWNrZ3JvdW5kLXBvc2l0aW9uOiAyMHB4IDIwcHg7CiAgICB9CiAgICAKICAgICNib3guZmlu YWwgewogICAgICBiYWNrZ3JvdW5kLXBvc2l0aW9uOiBib3R0b20gMjBweCByaWdodCAyMHB4Owog ICAgfQoKICAgICNib3gyIHsKICAgICAgYmFja2dyb3VuZDogdXJsKCcuLi9mYXN0L2JhY2tncm91 bmRzL3JlcGVhdC9yZXNvdXJjZXMvZ3JhZGllbnQuZ2lmJykgcmVwZWF0IDAgMDsKICAgICAgdHJh bnNpdGlvbi1wcm9wZXJ0eTogYmFja2dyb3VuZC1zaXplOwogICAgICBiYWNrZ3JvdW5kLXNpemU6 IDEwcHggMTBweDsKICAgIH0KICAgIAogICAgI2JveDIuZmluYWwgewogICAgICBiYWNrZ3JvdW5k LXNpemU6IDMwcHggMzBweDsKICAgIH0KICAgIAogIDwvc3R5bGU+CiAgPHNjcmlwdCBzcmM9InJl c291cmNlcy90cmFuc2l0aW9uLXRlc3QtaGVscGVycy5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0 Ij48L3NjcmlwdD4KICA8c2NyaXB0PgoKICAgIGNvbnN0IGV4cGVjdGVkVmFsdWVzID0gWwogICAg ICAvLyBbdGltZSwgZWxlbWVudC1pZCwgcHJvcGVydHksIGV4cGVjdGVkLXZhbHVlLCB0b2xlcmFu Y2VdCiAgICAgIFswLjUsICdib3gnLCAnYmFja2dyb3VuZC1wb3NpdGlvbicsIFsxMCwgMTBdLCAy XSwKICAgICAgWzAuNSwgJ2JveDInLCAnYmFja2dyb3VuZC1zaXplJywgWzIwLCAyMF0sIDJdLAog ICAgXTsKICAKICAgIGZ1bmN0aW9uIHNldHVwVGVzdCgpCiAgICB7CiAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdib3gnKS5jbGFzc05hbWUgPSAnYm94IGZpbmFsJzsKICAgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ2JveDInKS5jbGFzc05hbWUgPSAnYm94IGZpbmFsJzsKICAgIH0K ICAKICAgIHJ1blRyYW5zaXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzLCBzZXR1cFRlc3QsIHVzZVBh dXNlQVBJKTsKICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KCiAgPGRpdiBpZD0iYm94IiBjbGFz cz0iYm94Ij48L2Rpdj4KICA8ZGl2IGlkPSJib3gyIiBjbGFzcz0iYm94Ij48L2Rpdj4KCiAgPGRp diBpZD0icmVzdWx0Ij4KICA8L2Rpdj4KCjwvYm9keT4KPC9odG1sPgo=