161427 2016-08-30 23:06:38 -0700 [JSC] AbstractValue can contain padding which is not zero-filled 2016-08-31 10:02:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 161268 161308 1 ysuzuki ysuzuki cgarcia commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1224878 0 ysuzuki 2016-08-30 23:06:38 -0700 [JSC][GTK] AbstractValue can contain padding which is not zero-filled 1224880 1 287489 ysuzuki 2016-08-30 23:11:29 -0700 Created attachment 287489 Patch 1224883 2 cgarcia 2016-08-30 23:22:25 -0700 Note that this is not GTK+ specific, JSCOnly compiled with GCC also fails, so it's more GCC vs clang issue. 1224887 3 287493 ysuzuki 2016-08-30 23:26:19 -0700 Created attachment 287493 Patch 1224888 4 ysuzuki 2016-08-30 23:26:44 -0700 (In reply to comment #2) > Note that this is not GTK+ specific, JSCOnly compiled with GCC also fails, > so it's more GCC vs clang issue. Renamed the issue & ChangeLog :) 1224889 5 287489 cgarcia 2016-08-30 23:27:17 -0700 Comment on attachment 287489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287489&action=review Thanks for working on this! > Source/JavaScriptCore/ChangeLog:12 > + So debug assertion fails in GTK port. So debug assertion fails when building with GCC. > Source/JavaScriptCore/dfg/DFGAbstractValue.cpp:547 > +void AbstractValue::ensureCanInitializeWithZeros() > +{ > + std::aligned_storage<sizeof(AbstractValue), alignof(AbstractValue)>::type zeroFilledStorage; > + memset(static_cast<void*>(&zeroFilledStorage), 0, sizeof(AbstractValue)); > + ASSERT(*this == *static_cast<AbstractValue*>(static_cast<void*>(&zeroFilledStorage))); > +} This is only used inside a #if USE(JSVALUE64) && !defined(NDEBUG) block, so maybe it should be defined using the same #if. > Source/JavaScriptCore/dfg/DFGAbstractValue.h:461 > + void ensureCanInitializeWithZeros(); Ditto. 1224892 6 287495 ysuzuki 2016-08-30 23:31:06 -0700 Created attachment 287495 Patch 1224894 7 287489 ysuzuki 2016-08-30 23:31:18 -0700 Comment on attachment 287489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287489&action=review >> Source/JavaScriptCore/ChangeLog:12 >> + So debug assertion fails in GTK port. > > So debug assertion fails when building with GCC. Thanks. Fixed. >> Source/JavaScriptCore/dfg/DFGAbstractValue.cpp:547 >> +} > > This is only used inside a #if USE(JSVALUE64) && !defined(NDEBUG) block, so maybe it should be defined using the same #if. OK, wrapped. >> Source/JavaScriptCore/dfg/DFGAbstractValue.h:461 >> + void ensureCanInitializeWithZeros(); > > Ditto. Done. 1224946 8 287495 saam 2016-08-31 08:19:16 -0700 Comment on attachment 287495 Patch r=me 1224952 9 287495 ysuzuki 2016-08-31 08:45:03 -0700 Comment on attachment 287495 Patch Thanks! 1224984 10 287495 commit-queue 2016-08-31 10:02:12 -0700 Comment on attachment 287495 Patch Clearing flags on attachment: 287495 Committed r205254: <http://trac.webkit.org/changeset/205254> 1224985 11 commit-queue 2016-08-31 10:02:21 -0700 All reviewed patches have been landed. Closing bug. 287489 2016-08-30 23:11:29 -0700 2016-08-30 23:27:51 -0700 Patch bug-161427-20160831150917.patch text/plain 3291 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Njg0YjlmOWM1Y2U3Y2Q1MTI3OGM2NGNkNjRiMmM5MWEzNDczNTEzLi40Y2QxMjI0NzM0YTU5OWMx NzI1YmE5ZmUzNjJhMjY3N2U5MGFjOTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wOC0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXVtHVEtdIEFic3RyYWN0VmFsdWUgY2FuIGNvbnRhaW4gcGFk ZGluZyB3aGljaCBpcyBub3QgemVyby1maWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIGNoZWNrZWQgdGhhdCBBYnN0cmFjdFZhbHVlIGlzIHpl cm8tZmlsbGVkIHdoZW4gaW5pdGlhbGl6aW5nIGl0IHRvIGVuc3VyZQorICAgICAgICB0aGF0IHpl cm8tZmlsbGVkIG1lbW9yeSBjYW4gYmUgdXNlZCBhcyB0aGUgaW5pdGlhbGl6ZWQgQWJzdHJhY3RW YWx1ZS4KKyAgICAgICAgSG93ZXZlciwgc2luY2UgdGhlIHNpemUgb2YgU3BlY3VsYXRlZFR5cGUg YmVjb21lcyA2NGJpdCwgQWJzdHJhY3RWYWx1ZSBjYW4gaGF2ZQorICAgICAgICBwYWRkaW5nIG5v dy4gQW5kIHRoaXMgcGFkZGluZyBpcyBub3QgZW5zdXJlZCB0aGF0IGl0IGlzIGluaXRpYWxpemVk IHdpdGggemVyb3MuCisgICAgICAgIFNvIGRlYnVnIGFzc2VydGlvbiBmYWlscyBpbiBHVEsgcG9y dC4KKworICAgICAgICBTbyB0aGlzIHBhdGNoIGNoYW5nZXMgdGhlIHN0cmF0ZWd5LiBJbnN0ZWFk IG9mIGNoZWNraW5nIHRoZSBpbml0aWFsaXplZAorICAgICAgICBBYnN0cmFjdFZhbHVlIGlzIHpl cm8tZmlsbGVkLCB3ZSBlbnN1cmUgdGhhdCB6ZXJvLWZpbGxlZCBBYnN0cmFjdFZhbHVlIGNhbiBi ZQorICAgICAgICBjb25zaWRlcmVkIHRvIGJlIGVxdWFsIHRvIHRoZSBpbml0aWFsaXplZCBBYnN0 cmFjdFZhbHVlLgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0VmFsdWUuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OkFic3RyYWN0VmFsdWU6OmVuc3VyZUNhbkluaXRpYWxpemVXaXRoWmVyb3Mp OgorICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFZhbHVlLmg6CisgICAgICAgIChKU0M6OkRGRzo6 QWJzdHJhY3RWYWx1ZTo6QWJzdHJhY3RWYWx1ZSk6CisKIDIwMTYtMDgtMzAgIEJlbmphbWluIFBv dWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gU29tZSBhcml0aCBu b2RlcyBhcmUgdG9vIHBlc3NpbWlzdGljIHdpdGggdGhlIHR5cGVzIHN1cHBvcnRlZCBvbiB0aGUg ZmFzdCBwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3Ry YWN0VmFsdWUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZhbHVl LmNwcAppbmRleCBmMTk0NGI0M2ZjOWI4MzgxZjllYTJlMDMyZGM3ZmVkYTExMTg0NGIyLi40Y2E3 NjVkY2Y1YTc3MzYyMjQzOTJjMWYyZjRlY2YyNTc2OTAzOTI4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAKQEAgLTUzOSw2ICs1MzksMTMgQEAg dm9pZCBBYnN0cmFjdFZhbHVlOjp2YWxpZGF0ZVJlZmVyZW5jZXMoY29uc3QgVHJhY2tlZFJlZmVy ZW5jZXMmIHRyYWNrZWRSZWZlcmVuY2UKICAgICBtX3N0cnVjdHVyZS52YWxpZGF0ZVJlZmVyZW5j ZXModHJhY2tlZFJlZmVyZW5jZXMpOwogfQogCit2b2lkIEFic3RyYWN0VmFsdWU6OmVuc3VyZUNh bkluaXRpYWxpemVXaXRoWmVyb3MoKQoreworICAgIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVv ZihBYnN0cmFjdFZhbHVlKSwgYWxpZ25vZihBYnN0cmFjdFZhbHVlKT46OnR5cGUgemVyb0ZpbGxl ZFN0b3JhZ2U7CisgICAgbWVtc2V0KHN0YXRpY19jYXN0PHZvaWQqPigmemVyb0ZpbGxlZFN0b3Jh Z2UpLCAwLCBzaXplb2YoQWJzdHJhY3RWYWx1ZSkpOworICAgIEFTU0VSVCgqdGhpcyA9PSAqc3Rh dGljX2Nhc3Q8QWJzdHJhY3RWYWx1ZSo+KHN0YXRpY19jYXN0PHZvaWQqPigmemVyb0ZpbGxlZFN0 b3JhZ2UpKSk7Cit9CisKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpERkcKIAogI2VuZGlmIC8vIEVO QUJMRShERkdfSklUKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB YnN0cmFjdFZhbHVlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFs dWUuaAppbmRleCBhYWVmNzZiODFkMjBmYjZjNTQ0YjYwMjcwODNhNWQxN2Y4OGFiNjBmLi40NjQ1 NTgyMDQxYmE1ZWU1NTM2ODE3Y2Q0YTAxYmJjYTkyY2FiNzdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuaApAQCAtNjEsOSArNjEsNyBAQCBzdHJ1Y3Qg QWJzdHJhY3RWYWx1ZSB7CiAgICAgICAgIHN0YXRpYyBib29sIG5lZWRzRGVmYXVsdENvbnN0cnVj dG9yQ2hlY2sgPSB0cnVlOwogICAgICAgICBpZiAobmVlZHNEZWZhdWx0Q29uc3RydWN0b3JDaGVj aykgewogICAgICAgICAgICAgbmVlZHNEZWZhdWx0Q29uc3RydWN0b3JDaGVjayA9IGZhbHNlOwot Ci0gICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2l6ZW9mKEFic3RyYWN0VmFs dWUpOyArK2kpCi0gICAgICAgICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxjaGFy Kj4odGhpcylbaV0pKTsKKyAgICAgICAgICAgIGVuc3VyZUNhbkluaXRpYWxpemVXaXRoWmVyb3Mo KTsKICAgICAgICAgfQogI2VuZGlmCiAgICAgfQpAQCAtNDU5LDYgKzQ1Nyw4IEBAIHN0cnVjdCBB YnN0cmFjdFZhbHVlIHsKICAgICAKICAgICB2b2lkIGZpbHRlclZhbHVlQnlUeXBlKCk7CiAgICAg dm9pZCBmaWx0ZXJBcnJheU1vZGVzQnlUeXBlKCk7CisKKyAgICB2b2lkIGVuc3VyZUNhbkluaXRp YWxpemVXaXRoWmVyb3MoKTsKICAgICAKICAgICBib29sIHNob3VsZEJlQ2xlYXIoKSBjb25zdDsK ICAgICBGaWx0cmF0aW9uUmVzdWx0IG5vcm1hbGl6ZUNsYXJpdHkoKTsK 287493 2016-08-30 23:26:19 -0700 2016-08-30 23:31:00 -0700 Patch bug-161427-20160831152407.patch text/plain 3322 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Njg0YjlmOWM1Y2U3Y2Q1MTI3OGM2NGNkNjRiMmM5MWEzNDczNTEzLi5hNzkzNWJiYzc5MGZmNjEx MTgzY2U0M2JlMDYyMjVjMTZiZmFmY2RkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wOC0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBYnN0cmFjdFZhbHVlIGNhbiBjb250YWluIHBhZGRpbmcg d2hpY2ggaXMgbm90IHplcm8tZmlsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjE0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBjaGVja2VkIHRoYXQgQWJzdHJhY3RWYWx1ZSBpcyB6ZXJvLWZp bGxlZCB3aGVuIGluaXRpYWxpemluZyBpdCB0byBlbnN1cmUKKyAgICAgICAgdGhhdCB6ZXJvLWZp bGxlZCBtZW1vcnkgY2FuIGJlIHVzZWQgYXMgdGhlIGluaXRpYWxpemVkIEFic3RyYWN0VmFsdWUu CisgICAgICAgIEhvd2V2ZXIsIHNpbmNlIHRoZSBzaXplIG9mIFNwZWN1bGF0ZWRUeXBlIGJlY29t ZXMgNjRiaXQsIEFic3RyYWN0VmFsdWUgY2FuIGhhdmUKKyAgICAgICAgcGFkZGluZyBub3cuIEFu ZCB0aGlzIHBhZGRpbmcgaXMgbm90IGVuc3VyZWQgdGhhdCBpdCBpcyBpbml0aWFsaXplZCB3aXRo IHplcm9zLgorICAgICAgICBTbyBkZWJ1ZyBhc3NlcnRpb24gZmFpbHMgaW4gR1RLIGFuZCBKU0NP bmx5IHBvcnQsIG5hbWVseSBwb3J0cyB1c2luZyBHQ0MuCisKKyAgICAgICAgU28gdGhpcyBwYXRj aCBjaGFuZ2VzIHRoZSBzdHJhdGVneS4gSW5zdGVhZCBvZiBjaGVja2luZyB0aGUgaW5pdGlhbGl6 ZWQKKyAgICAgICAgQWJzdHJhY3RWYWx1ZSBpcyB6ZXJvLWZpbGxlZCwgd2UgZW5zdXJlIHRoYXQg emVyby1maWxsZWQgQWJzdHJhY3RWYWx1ZSBjYW4gYmUKKyAgICAgICAgY29uc2lkZXJlZCB0byBi ZSBlcXVhbCB0byB0aGUgaW5pdGlhbGl6ZWQgQWJzdHJhY3RWYWx1ZS4KKworICAgICAgICAqIGRm Zy9ERkdBYnN0cmFjdFZhbHVlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFZhbHVl OjplbnN1cmVDYW5Jbml0aWFsaXplV2l0aFplcm9zKToKKyAgICAgICAgKiBkZmcvREZHQWJzdHJh Y3RWYWx1ZS5oOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0VmFsdWU6OkFic3RyYWN0VmFs dWUpOgorCiAyMDE2LTA4LTMwICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtKU0NdIFNvbWUgYXJpdGggbm9kZXMgYXJlIHRvbyBwZXNzaW1pc3RpYyB3 aXRoIHRoZSB0eXBlcyBzdXBwb3J0ZWQgb24gdGhlIGZhc3QgcGF0aApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZhbHVlLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAKaW5kZXggZjE5NDRiNDNmYzliODM4 MWY5ZWEyZTAzMmRjN2ZlZGExMTE4NDRiMi4uNGNhNzY1ZGNmNWE3NzM2MjI0MzkyYzFmMmY0ZWNm MjU3NjkwMzkyOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0 VmFsdWUuY3BwCkBAIC01MzksNiArNTM5LDEzIEBAIHZvaWQgQWJzdHJhY3RWYWx1ZTo6dmFsaWRh dGVSZWZlcmVuY2VzKGNvbnN0IFRyYWNrZWRSZWZlcmVuY2VzJiB0cmFja2VkUmVmZXJlbmNlCiAg ICAgbV9zdHJ1Y3R1cmUudmFsaWRhdGVSZWZlcmVuY2VzKHRyYWNrZWRSZWZlcmVuY2VzKTsKIH0K IAordm9pZCBBYnN0cmFjdFZhbHVlOjplbnN1cmVDYW5Jbml0aWFsaXplV2l0aFplcm9zKCkKK3sK KyAgICBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2YoQWJzdHJhY3RWYWx1ZSksIGFsaWdub2Yo QWJzdHJhY3RWYWx1ZSk+Ojp0eXBlIHplcm9GaWxsZWRTdG9yYWdlOworICAgIG1lbXNldChzdGF0 aWNfY2FzdDx2b2lkKj4oJnplcm9GaWxsZWRTdG9yYWdlKSwgMCwgc2l6ZW9mKEFic3RyYWN0VmFs dWUpKTsKKyAgICBBU1NFUlQoKnRoaXMgPT0gKnN0YXRpY19jYXN0PEFic3RyYWN0VmFsdWUqPihz dGF0aWNfY2FzdDx2b2lkKj4oJnplcm9GaWxsZWRTdG9yYWdlKSkpOworfQorCiB9IH0gLy8gbmFt ZXNwYWNlIEpTQzo6REZHCiAKICNlbmRpZiAvLyBFTkFCTEUoREZHX0pJVCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZhbHVlLmgKaW5kZXggYWFlZjc2YjgxZDIwZmI2 YzU0NGI2MDI3MDgzYTVkMTdmODhhYjYwZi4uNDY0NTU4MjA0MWJhNWVlNTUzNjgxN2NkNGEwMWJi Y2E5MmNhYjc3ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdFZhbHVlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZh bHVlLmgKQEAgLTYxLDkgKzYxLDcgQEAgc3RydWN0IEFic3RyYWN0VmFsdWUgewogICAgICAgICBz dGF0aWMgYm9vbCBuZWVkc0RlZmF1bHRDb25zdHJ1Y3RvckNoZWNrID0gdHJ1ZTsKICAgICAgICAg aWYgKG5lZWRzRGVmYXVsdENvbnN0cnVjdG9yQ2hlY2spIHsKICAgICAgICAgICAgIG5lZWRzRGVm YXVsdENvbnN0cnVjdG9yQ2hlY2sgPSBmYWxzZTsKLQotICAgICAgICAgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IHNpemVvZihBYnN0cmFjdFZhbHVlKTsgKytpKQotICAgICAgICAgICAgICAg IEFTU0VSVCghKHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KHRoaXMpW2ldKSk7CisgICAgICAgICAg ICBlbnN1cmVDYW5Jbml0aWFsaXplV2l0aFplcm9zKCk7CiAgICAgICAgIH0KICNlbmRpZgogICAg IH0KQEAgLTQ1OSw2ICs0NTcsOCBAQCBzdHJ1Y3QgQWJzdHJhY3RWYWx1ZSB7CiAgICAgCiAgICAg dm9pZCBmaWx0ZXJWYWx1ZUJ5VHlwZSgpOwogICAgIHZvaWQgZmlsdGVyQXJyYXlNb2Rlc0J5VHlw ZSgpOworCisgICAgdm9pZCBlbnN1cmVDYW5Jbml0aWFsaXplV2l0aFplcm9zKCk7CiAgICAgCiAg ICAgYm9vbCBzaG91bGRCZUNsZWFyKCkgY29uc3Q7CiAgICAgRmlsdHJhdGlvblJlc3VsdCBub3Jt YWxpemVDbGFyaXR5KCk7Cg== 287495 2016-08-30 23:31:06 -0700 2016-08-31 10:02:12 -0700 Patch bug-161427-20160831152854.patch text/plain 3391 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi Njg0YjlmOWM1Y2U3Y2Q1MTI3OGM2NGNkNjRiMmM5MWEzNDczNTEzLi45Y2NhMDZlMTc1YWE3NDVl YzUwOTVhMTQzYWY0MTA1ZWU4ZTVmMzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wOC0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBYnN0cmFjdFZhbHVlIGNhbiBjb250YWluIHBhZGRpbmcg d2hpY2ggaXMgbm90IHplcm8tZmlsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjE0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBjaGVja2VkIHRoYXQgQWJzdHJhY3RWYWx1ZSBpcyB6ZXJvLWZp bGxlZCB3aGVuIGluaXRpYWxpemluZyBpdCB0byBlbnN1cmUKKyAgICAgICAgdGhhdCB6ZXJvLWZp bGxlZCBtZW1vcnkgY2FuIGJlIHVzZWQgYXMgdGhlIGluaXRpYWxpemVkIEFic3RyYWN0VmFsdWUu CisgICAgICAgIEhvd2V2ZXIsIHNpbmNlIHRoZSBzaXplIG9mIFNwZWN1bGF0ZWRUeXBlIGJlY29t ZXMgNjRiaXQsIEFic3RyYWN0VmFsdWUgY2FuIGhhdmUKKyAgICAgICAgcGFkZGluZyBub3cuIEFu ZCB0aGlzIHBhZGRpbmcgaXMgbm90IGVuc3VyZWQgdGhhdCBpdCBpcyBpbml0aWFsaXplZCB3aXRo IHplcm9zLgorICAgICAgICBTbyBkZWJ1ZyBhc3NlcnRpb24gZmFpbHMgd2hlbiBidWlsZGluZyB3 aXRoIEdDQy4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIHN0cmF0ZWd5LiBJbnN0 ZWFkIG9mIGNoZWNraW5nIHRoZSBpbml0aWFsaXplZAorICAgICAgICBBYnN0cmFjdFZhbHVlIGlz IHplcm8tZmlsbGVkLCB3ZSBlbnN1cmUgdGhhdCB6ZXJvLWZpbGxlZCBBYnN0cmFjdFZhbHVlIGNh biBiZQorICAgICAgICBjb25zaWRlcmVkIHRvIGJlIGVxdWFsIHRvIHRoZSBpbml0aWFsaXplZCBB YnN0cmFjdFZhbHVlLgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0VmFsdWUuY3BwOgorICAg ICAgICAoSlNDOjpERkc6OkFic3RyYWN0VmFsdWU6OmVuc3VyZUNhbkluaXRpYWxpemVXaXRoWmVy b3MpOgorICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFZhbHVlLmg6CisgICAgICAgIChKU0M6OkRG Rzo6QWJzdHJhY3RWYWx1ZTo6QWJzdHJhY3RWYWx1ZSk6CisKIDIwMTYtMDgtMzAgIEJlbmphbWlu IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gU29tZSBhcml0 aCBub2RlcyBhcmUgdG9vIHBlc3NpbWlzdGljIHdpdGggdGhlIHR5cGVzIHN1cHBvcnRlZCBvbiB0 aGUgZmFzdCBwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fi c3RyYWN0VmFsdWUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZh bHVlLmNwcAppbmRleCBmMTk0NGI0M2ZjOWI4MzgxZjllYTJlMDMyZGM3ZmVkYTExMTg0NGIyLi5j M2VmZGFjZWU3OGQ2YWNlZWY2NWE5ODMyODQxYmQ2ZjQxYmNhNDdmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAKQEAgLTUzOSw2ICs1MzksMTUg QEAgdm9pZCBBYnN0cmFjdFZhbHVlOjp2YWxpZGF0ZVJlZmVyZW5jZXMoY29uc3QgVHJhY2tlZFJl ZmVyZW5jZXMmIHRyYWNrZWRSZWZlcmVuY2UKICAgICBtX3N0cnVjdHVyZS52YWxpZGF0ZVJlZmVy ZW5jZXModHJhY2tlZFJlZmVyZW5jZXMpOwogfQogCisjaWYgVVNFKEpTVkFMVUU2NCkgJiYgIWRl ZmluZWQoTkRFQlVHKQordm9pZCBBYnN0cmFjdFZhbHVlOjplbnN1cmVDYW5Jbml0aWFsaXplV2l0 aFplcm9zKCkKK3sKKyAgICBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2YoQWJzdHJhY3RWYWx1 ZSksIGFsaWdub2YoQWJzdHJhY3RWYWx1ZSk+Ojp0eXBlIHplcm9GaWxsZWRTdG9yYWdlOworICAg IG1lbXNldChzdGF0aWNfY2FzdDx2b2lkKj4oJnplcm9GaWxsZWRTdG9yYWdlKSwgMCwgc2l6ZW9m KEFic3RyYWN0VmFsdWUpKTsKKyAgICBBU1NFUlQoKnRoaXMgPT0gKnN0YXRpY19jYXN0PEFic3Ry YWN0VmFsdWUqPihzdGF0aWNfY2FzdDx2b2lkKj4oJnplcm9GaWxsZWRTdG9yYWdlKSkpOworfQor I2VuZGlmCisKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpERkcKIAogI2VuZGlmIC8vIEVOQUJMRShE RkdfSklUKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dFZhbHVlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuaApp bmRleCBhYWVmNzZiODFkMjBmYjZjNTQ0YjYwMjcwODNhNWQxN2Y4OGFiNjBmLi4wZDk5ZDFiYmNj NWNiMzg0MDc4YmZiNmNmMGFmNTNjMmZiMzQ0MDFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0Fic3RyYWN0VmFsdWUuaApAQCAtNjEsOSArNjEsNyBAQCBzdHJ1Y3QgQWJzdHJh Y3RWYWx1ZSB7CiAgICAgICAgIHN0YXRpYyBib29sIG5lZWRzRGVmYXVsdENvbnN0cnVjdG9yQ2hl Y2sgPSB0cnVlOwogICAgICAgICBpZiAobmVlZHNEZWZhdWx0Q29uc3RydWN0b3JDaGVjaykgewog ICAgICAgICAgICAgbmVlZHNEZWZhdWx0Q29uc3RydWN0b3JDaGVjayA9IGZhbHNlOwotCi0gICAg ICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2l6ZW9mKEFic3RyYWN0VmFsdWUpOyAr K2kpCi0gICAgICAgICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxjaGFyKj4odGhp cylbaV0pKTsKKyAgICAgICAgICAgIGVuc3VyZUNhbkluaXRpYWxpemVXaXRoWmVyb3MoKTsKICAg ICAgICAgfQogI2VuZGlmCiAgICAgfQpAQCAtNDU5LDYgKzQ1NywxMCBAQCBzdHJ1Y3QgQWJzdHJh Y3RWYWx1ZSB7CiAgICAgCiAgICAgdm9pZCBmaWx0ZXJWYWx1ZUJ5VHlwZSgpOwogICAgIHZvaWQg ZmlsdGVyQXJyYXlNb2Rlc0J5VHlwZSgpOworCisjaWYgVVNFKEpTVkFMVUU2NCkgJiYgIWRlZmlu ZWQoTkRFQlVHKQorICAgIHZvaWQgZW5zdXJlQ2FuSW5pdGlhbGl6ZVdpdGhaZXJvcygpOworI2Vu ZGlmCiAgICAgCiAgICAgYm9vbCBzaG91bGRCZUNsZWFyKCkgY29uc3Q7CiAgICAgRmlsdHJhdGlv blJlc3VsdCBub3JtYWxpemVDbGFyaXR5KCk7Cg==