161223 2016-08-25 18:54:56 -0700 ews queues should update status server when they start processing patch 2016-08-25 22:35:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161222 https://bugs.webkit.org/show_bug.cgi?id=161220 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates glenn lforschler oldest_to_newest 1223363 0 aakash_jain 2016-08-25 18:54:56 -0700 Currently EWS status page (or bubbles on bug) does not indicate clearly when the patch is started processing (and by which bot). Bots should update the status to status-server when they start processing patch. This would also help in https://bugs.webkit.org/show_bug.cgi?id=161222 1223367 1 287059 aakash_jain 2016-08-25 18:59:21 -0700 Created attachment 287059 Proposed patch 1223381 2 287059 dbates 2016-08-25 19:28:22 -0700 Comment on attachment 287059 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287059&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:448 > + self._update_status("Started processing patch", patch) Does it make sense to add a unit test for this change? 1223387 3 287066 aakash_jain 2016-08-25 20:03:53 -0700 Created attachment 287066 Updated patch Yes, you are right, I missed updating the unit tests. We should start running test-webkitpy on every patch in EWS. 1223412 4 287066 commit-queue 2016-08-25 22:35:43 -0700 Comment on attachment 287066 Updated patch Clearing flags on attachment: 287066 Committed r205003: <http://trac.webkit.org/changeset/205003> 1223413 5 commit-queue 2016-08-25 22:35:48 -0700 All reviewed patches have been landed. Closing bug. 287059 2016-08-25 18:59:21 -0700 2016-08-25 20:03:53 -0700 Proposed patch ews-queue-start-inform-server text/plain 1223 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTAwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA4LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBld3MgcXVldWVzIHNob3VsZCB1cGRhdGUgc3RhdHVzIHNlcnZlciB3aGVu IHRoZXkgc3RhcnQgcHJvY2Vzc2luZyBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVl dWVzLnB5OgorICAgICAgICAoQWJzdHJhY3RSZXZpZXdRdWV1ZS5wcm9jZXNzX3dvcmtfaXRlbSk6 IFVwZGF0ZSBzdGF0dXMgc2VydmVyIHRoYXQgdGhlIGJvdCBzdGFydGVkIHByb2Nlc3NpbmcgdGhl IHBhdGNoLgorCiAyMDE2LTA4LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQ01ha2UgYnVpbGQgZml4LgpJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CShyZXZpc2lvbiAyMDUwMDEp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC00NDUsNiArNDQ1LDcgQEAgY2xhc3MgQWJzdHJhY3RSZXZpZXdRdWV1ZShQ YXRjaFByb2Nlc3NpbgogICAgICAgICByZXR1cm4gc2VsZi5fbmV4dF9wYXRjaCgpCiAKICAgICBk ZWYgcHJvY2Vzc193b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgorICAgICAgICBzZWxmLl91cGRhdGVf c3RhdHVzKCJTdGFydGVkIHByb2Nlc3NpbmcgcGF0Y2giLCBwYXRjaCkKICAgICAgICAgcGFzc2Vk ID0gc2VsZi5yZXZpZXdfcGF0Y2gocGF0Y2gpCiAgICAgICAgIGlmIHBhc3NlZDoKICAgICAgICAg ICAgIHNlbGYuX2RpZF9wYXNzKHBhdGNoKQo= 287066 2016-08-25 20:03:53 -0700 2016-08-25 22:35:43 -0700 Updated patch ews-queue-start-inform-server1 text/plain 5063 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTAwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE2LTA4LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBld3MgcXVldWVzIHNob3VsZCB1cGRhdGUgc3RhdHVzIHNlcnZlciB3aGVu IHRoZXkgc3RhcnQgcHJvY2Vzc2luZyBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuaWVs IEJhdGVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVl cy5weToKKyAgICAgICAgKEFic3RyYWN0UmV2aWV3UXVldWUucHJvY2Vzc193b3JrX2l0ZW0pOiBV cGRhdGUgc3RhdHVzIHNlcnZlciB0aGF0IHRoZSBib3Qgc3RhcnRlZCBwcm9jZXNzaW5nIHRoZSBw YXRjaC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJu aW5nc3lzdGVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAoRWFybHlXYXJuaW5nU3lzdGVtVGVzdC5f ZGVmYXVsdF9leHBlY3RlZF9sb2dzKTogVXBkYXRlZCB0aGUgdW5pdCB0ZXN0IGFjY29yZGluZ2x5 LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRl c3QucHk6CisgICAgICAgIChTdHlsZVF1ZXVlVGVzdC50ZXN0X3N0eWxlX3F1ZXVlX3dpdGhfc3R5 bGVfZXhjZXB0aW9uKTogU2FtZS4KKyAgICAgICAgKHRlc3Rfc3R5bGVfcXVldWVfd2l0aF93YXRj aF9saXN0X2V4Y2VwdGlvbik6IFNhbWUuCisgICAgICAgICh0ZXN0X25vbl92YWxpZF9wYXRjaCk6 IFNhbWUuCisKIDIwMTYtMDgtMjUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBDTWFrZSBidWlsZCBmaXguCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdh cm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJKHJldmlzaW9uIDIwNTAwMikKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkJ KHdvcmtpbmcgY29weSkKQEAgLTc3LDcgKzc3LDggQEAgY2xhc3MgRWFybHlXYXJuaW5nU3lzdGVt VGVzdChRdWV1ZXNUZXN0KQogCiAgICAgICAgIGV4cGVjdGVkX2xvZ3MgPSB7CiAgICAgICAgICAg ICAiYmVnaW5fd29ya19xdWV1ZSI6IHNlbGYuX2RlZmF1bHRfYmVnaW5fd29ya19xdWV1ZV9sb2dz KGV3cy5uYW1lKSwKLSAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRlbSI6ICIiIlJ1bm5pbmc6 IHdlYmtpdC1wYXRjaCAtLXN0YXR1cy1ob3N0PWV4YW1wbGUuY29tIGNsZWFuIC0tcG9ydD0lKHBv cnQpcyUoYXJjaGl0ZWN0dXJlKXMKKyAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRlbSI6ICIi Ik1PQ0s6IHVwZGF0ZV9zdGF0dXM6ICUobmFtZSlzIFN0YXJ0ZWQgcHJvY2Vzc2luZyBwYXRjaAor UnVubmluZzogd2Via2l0LXBhdGNoIC0tc3RhdHVzLWhvc3Q9ZXhhbXBsZS5jb20gY2xlYW4gLS1w b3J0PSUocG9ydClzJShhcmNoaXRlY3R1cmUpcwogUnVubmluZzogd2Via2l0LXBhdGNoIC0tc3Rh dHVzLWhvc3Q9ZXhhbXBsZS5jb20gdXBkYXRlIC0tcG9ydD0lKHBvcnQpcyUoYXJjaGl0ZWN0dXJl KXMKIFJ1bm5pbmc6IHdlYmtpdC1wYXRjaCAtLXN0YXR1cy1ob3N0PWV4YW1wbGUuY29tIGFwcGx5 LWF0dGFjaG1lbnQgLS1uby11cGRhdGUgLS1ub24taW50ZXJhY3RpdmUgMTAwMDAgLS1wb3J0PSUo cG9ydClzJShhcmNoaXRlY3R1cmUpcwogUnVubmluZzogd2Via2l0LXBhdGNoIC0tc3RhdHVzLWhv c3Q9ZXhhbXBsZS5jb20gYnVpbGQgLS1uby1jbGVhbiAtLW5vLXVwZGF0ZSAtLWJ1aWxkLXN0eWxl PSUoYnVpbGRfc3R5bGUpcyAtLXBvcnQ9JShwb3J0KXMlKGFyY2hpdGVjdHVyZSlzCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkJKHJldmlz aW9uIDIwNTAwMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1 ZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ0NSw2ICs0NDUsNyBAQCBjbGFzcyBBYnN0cmFjdFJl dmlld1F1ZXVlKFBhdGNoUHJvY2Vzc2luCiAgICAgICAgIHJldHVybiBzZWxmLl9uZXh0X3BhdGNo KCkKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6CisgICAgICAgIHNl bGYuX3VwZGF0ZV9zdGF0dXMoIlN0YXJ0ZWQgcHJvY2Vzc2luZyBwYXRjaCIsIHBhdGNoKQogICAg ICAgICBwYXNzZWQgPSBzZWxmLnJldmlld19wYXRjaChwYXRjaCkKICAgICAgICAgaWYgcGFzc2Vk OgogICAgICAgICAgICAgc2VsZi5fZGlkX3Bhc3MocGF0Y2gpCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXNfdW5pdHRlc3QucHkJ KHJldmlzaW9uIDIwNTAwMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9xdWV1ZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ3MSw3ICs0NzEsOCBAQCBj bGFzcyBTdHlsZVF1ZXVlVGVzdChRdWV1ZXNUZXN0KToKICAgICBkZWYgdGVzdF9zdHlsZV9xdWV1 ZV93aXRoX3N0eWxlX2V4Y2VwdGlvbihzZWxmKToKICAgICAgICAgZXhwZWN0ZWRfbG9ncyA9IHsK ICAgICAgICAgICAgICJiZWdpbl93b3JrX3F1ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3Jr X3F1ZXVlX2xvZ3MoInN0eWxlLXF1ZXVlIiksCi0gICAgICAgICAgICAicHJvY2Vzc193b3JrX2l0 ZW0iOiAiIiJSdW5uaW5nOiB3ZWJraXQtcGF0Y2ggLS1zdGF0dXMtaG9zdD1leGFtcGxlLmNvbSBj bGVhbgorICAgICAgICAgICAgInByb2Nlc3Nfd29ya19pdGVtIjogIiIiTU9DSzogdXBkYXRlX3N0 YXR1czogc3R5bGUtcXVldWUgU3RhcnRlZCBwcm9jZXNzaW5nIHBhdGNoCitSdW5uaW5nOiB3ZWJr aXQtcGF0Y2ggLS1zdGF0dXMtaG9zdD1leGFtcGxlLmNvbSBjbGVhbgogTU9DSzogdXBkYXRlX3N0 YXR1czogc3R5bGUtcXVldWUgQ2xlYW5lZCB3b3JraW5nIGRpcmVjdG9yeQogUnVubmluZzogd2Vi a2l0LXBhdGNoIC0tc3RhdHVzLWhvc3Q9ZXhhbXBsZS5jb20gdXBkYXRlCiBNT0NLOiB1cGRhdGVf c3RhdHVzOiBzdHlsZS1xdWV1ZSBVcGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5CkBAIC00OTMsNyAr NDk0LDggQEAgTU9DSzogcmVsZWFzZV93b3JrX2l0ZW06IHN0eWxlLXF1ZXVlIDEwMAogICAgIGRl ZiB0ZXN0X3N0eWxlX3F1ZXVlX3dpdGhfd2F0Y2hfbGlzdF9leGNlcHRpb24oc2VsZik6CiAgICAg ICAgIGV4cGVjdGVkX2xvZ3MgPSB7CiAgICAgICAgICAgICAiYmVnaW5fd29ya19xdWV1ZSI6IHNl bGYuX2RlZmF1bHRfYmVnaW5fd29ya19xdWV1ZV9sb2dzKCJzdHlsZS1xdWV1ZSIpLAotICAgICAg ICAgICAgInByb2Nlc3Nfd29ya19pdGVtIjogIiIiUnVubmluZzogd2Via2l0LXBhdGNoIC0tc3Rh dHVzLWhvc3Q9ZXhhbXBsZS5jb20gY2xlYW4KKyAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRl bSI6ICIiIk1PQ0s6IHVwZGF0ZV9zdGF0dXM6IHN0eWxlLXF1ZXVlIFN0YXJ0ZWQgcHJvY2Vzc2lu ZyBwYXRjaAorUnVubmluZzogd2Via2l0LXBhdGNoIC0tc3RhdHVzLWhvc3Q9ZXhhbXBsZS5jb20g Y2xlYW4KIE1PQ0s6IHVwZGF0ZV9zdGF0dXM6IHN0eWxlLXF1ZXVlIENsZWFuZWQgd29ya2luZyBk aXJlY3RvcnkKIFJ1bm5pbmc6IHdlYmtpdC1wYXRjaCAtLXN0YXR1cy1ob3N0PWV4YW1wbGUuY29t IHVwZGF0ZQogTU9DSzogdXBkYXRlX3N0YXR1czogc3R5bGUtcXVldWUgVXBkYXRlZCB3b3JraW5n IGRpcmVjdG9yeQpAQCAtNTIwLDcgKzUyMiw4IEBAIE1PQ0s6IHJlbGVhc2Vfd29ya19pdGVtOiBz dHlsZS1xdWV1ZSAxMDAKICAgICAgICAgcGF0Y2ggPSB0b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVu dCgxMDAwNykgICMgX3BhdGNoOCwgcmVzb2x2ZWQgYnVnLCB3aXRob3V0IHJldmlldyBmbGFnLCBu b3QgbWFya2VkIG9ic29sZXRlIChtYXliZSBhbHJlYWR5IGxhbmRlZCkKICAgICAgICAgZXhwZWN0 ZWRfbG9ncyA9IHsKICAgICAgICAgICAgICJiZWdpbl93b3JrX3F1ZXVlIjogc2VsZi5fZGVmYXVs dF9iZWdpbl93b3JrX3F1ZXVlX2xvZ3MoInN0eWxlLXF1ZXVlIiksCi0gICAgICAgICAgICAicHJv Y2Vzc193b3JrX2l0ZW0iOiAiIiJNT0NLOiB1cGRhdGVfc3RhdHVzOiBzdHlsZS1xdWV1ZSBFcnJv cjogc3R5bGUtcXVldWUgZGlkIG5vdCBwcm9jZXNzIHBhdGNoLiBSZWFzb246IEJ1ZyBpcyBhbHJl YWR5IGNsb3NlZC4KKyAgICAgICAgICAgICJwcm9jZXNzX3dvcmtfaXRlbSI6ICIiIk1PQ0s6IHVw ZGF0ZV9zdGF0dXM6IHN0eWxlLXF1ZXVlIFN0YXJ0ZWQgcHJvY2Vzc2luZyBwYXRjaAorTU9DSzog dXBkYXRlX3N0YXR1czogc3R5bGUtcXVldWUgRXJyb3I6IHN0eWxlLXF1ZXVlIGRpZCBub3QgcHJv Y2VzcyBwYXRjaC4gUmVhc29uOiBCdWcgaXMgYWxyZWFkeSBjbG9zZWQuCiBNT0NLOiByZWxlYXNl X3dvcmtfaXRlbTogc3R5bGUtcXVldWUgMTAwMDcKICIiIiwKICAgICAgICAgfQo=