161052 2016-08-22 12:37:20 -0700 [WK2] http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html fails 2024-06-20 11:24:56 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED WORKSFORME https://bugs.webkit.org/show_bug.cgi?id=160445 InRadar P2 Normal --- 1 ap youennf ben_schwartz bfulgham commit-queue dbates lforschler mkwst ryanhaddad webkit-bug-importer youennf oldest_to_newest 1221936 0 ap 2016-08-22 12:37:20 -0700 http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html fails every time on my machine (that has macOS Sierra): @@ -1,2 +1,2 @@ -ALERT: PASS: load was not blocked +ALERT: FAIL: load is not successful This test opens a HTTPS window that loads insecure data via the Fetch API. We should upgrade this request and thereby avoid a mixed content resource load. Not sure why it's not failing on the bots. I just run it like this, no fancy options: run-webkit-tests http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html 1221938 1 bfulgham 2016-08-22 12:45:01 -0700 (In reply to comment #0) > http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade- > insecure-fetch-in-main-frame.html fails every time on my machine (that has > macOS Sierra): Do all the other tests pass? I.e., do you have a working local SSL configuration and so forth? We might need Youenn's help to figure out what might be wrong. 1221941 2 youennf 2016-08-22 12:51:59 -0700 It is working on my setup. I'll try it tomorrow on an updated setup 1221942 3 bfulgham 2016-08-22 12:52:37 -0700 (In reply to comment #2) > It is working on my setup. I'll try it tomorrow on an updated setup Yes, it works for me as well -- and I'm using Sierra as well. 1221944 4 ap 2016-08-22 12:56:44 -0700 Yes, all other tests pass. 1221946 5 youennf 2016-08-22 13:05:28 -0700 Can the apache log provide some useful information? 1221963 6 ap 2016-08-22 13:54:17 -0700 Debugged this down to an actual HTTPS connection failure. Will follow up in e-mail. 1221973 7 webkit-bug-importer 2016-08-22 14:16:41 -0700 <rdar://problem/27954577> 1221997 8 ap 2016-08-22 15:14:25 -0700 What changed here is that Fetch got enabled in r204705. These tests should have been disabled in the past, but they were not. The actual issue will be tracked in Radar. 1222183 9 youennf 2016-08-23 04:09:53 -0700 (In reply to comment #8) > What changed here is that Fetch got enabled in r204705. These tests should > have been disabled in the past, but they were not. This test works fine in WK1. It does not work as expected on WK2 as the test runtime flag (on) was different from the web view runtime flag (off until r204705). When creating the new frame, fetch runtime flag was set to off and fetch API was disappearing. I am now hitting the same issue as ap. I will add Fail to mac-wk2 TestExpectations, similarly to http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html I will wait some more time to remove the 'Timeout' expectation for those tests. 1222184 10 youennf 2016-08-23 04:10:21 -0700 Reopened (see above comment) 1222186 11 286697 youennf 2016-08-23 04:16:39 -0700 Created attachment 286697 Updating TestExpectations 1222195 12 286697 commit-queue 2016-08-23 05:15:48 -0700 Comment on attachment 286697 Updating TestExpectations Clearing flags on attachment: 286697 Committed r204817: <http://trac.webkit.org/changeset/204817> 1222196 13 commit-queue 2016-08-23 05:15:52 -0700 All reviewed patches have been landed. Closing bug. 1222205 14 youennf 2016-08-23 06:18:40 -0700 Reopened to follow on the bug. 1222257 15 286697 ap 2016-08-23 10:07:58 -0700 Comment on attachment 286697 Updating TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=286697&action=review > LayoutTests/platform/mac-wk2/TestExpectations:381 > webkit.org/b/160445 http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html [ Failure Timeout ] > +webkit.org/b/160445 http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html [ Failure Timeout ] Why are we allowing for Timeout here? Also, shouldn't the expectation be Sierra only? 1222261 16 youennf 2016-08-23 10:24:18 -0700 (In reply to comment #15) > Comment on attachment 286697 [details] > Updating TestExpectations > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286697&action=review > > > LayoutTests/platform/mac-wk2/TestExpectations:381 > > webkit.org/b/160445 http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html [ Failure Timeout ] > > +webkit.org/b/160445 http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html [ Failure Timeout ] > > Why are we allowing for Timeout here? Test was timing out previously due to fetch runtime flag issue. I am just leaving the Timeout to ensure there is no issue here. The bots seem to like that, I'll update it tomorrow if there is no issue. > Also, shouldn't the expectation be Sierra only? Probably, I'll fix that when removing the Timeout expectation. 2042258 17 ben_schwartz 2024-06-20 11:24:56 -0700 This no longer seems to be occurring. Please file a new bug if issues persist. 286697 2016-08-23 04:16:39 -0700 2016-08-23 05:15:48 -0700 Updating TestExpectations bug-161052-20160823131439.patch text/plain 2753 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0Nzk1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTljNTVmMTkwZWRmOWQ5ZmE3OWIy OGY2ZDhiZTFlMDAyZTY4ZjMzNi4uYTJmMmUxZjZkMDYwN2FmN2I5NTM3OGZhOGNkOTQ4MWZiZTQ5 OTI0YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA4LTIzICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBbV0syXSBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nv bnRlbnRTZWN1cml0eVBvbGljeS91cGdyYWRlLWluc2VjdXJlLXJlcXVlc3RzL3VwZ3JhZGUtaW5z ZWN1cmUtZmV0Y2gtaW4tbWFpbi1mcmFtZS5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEwNTIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI3OTU0NTc3PgorCisgICAgICAgIFVucmV2aWV3ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IEFkZGluZyBGYWlsdXJlL1RpbWVvdXQgZXhwZWN0 YXRpb24gdG8KKyAgICAgICAgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xp Y3kvdXBncmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy91cGdyYWRlLWluc2VjdXJlLWZldGNoLWluLW1h aW4tZnJhbWUuaHRtbAorICAgICAgICAqIHBsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zOiBS ZW1vdmluZyBUaW1lb3V0IGV4cGVjdGF0aW9uIGZyb20KKyAgICAgICAgaHR0cC90ZXN0cy9zZWN1 cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvdXBncmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy91cGdy YWRlLWluc2VjdXJlLWZldGNoLWluLW1haW4tZnJhbWUuaHRtbAorCisyMDE2LTA4LTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKwogICAgICAgICBJbXBsZW1lbnQgcmVkaXJl Y3Qgc3VwcG9ydCBwb3N0IENPUlMtcHJlZmxpZ2h0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkwNTYKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGI2YzJkM2M1NWRlMzZmYzBlNDQwOTI4NzA2 YmFjNjE0MThiYWM5NGIuLjhhOTMwMGFkZmYyYjQ5MjA5N2ZiNzdhMDEwMDk5YWYwZGE4NjQ0ODkg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAg LTM3OCw2ICszNzgsNyBAQCB3ZWJraXQub3JnL2IvMTQyNzI2IFsgWW9zZW1pdGUgXSBmYXN0L2lt YWdlcy9hbmltYXRlZC1wbmcuaHRtbCBbIFNraXAgXQogCiAjIEhpdHRpbmcgIlRoZSBjZXJ0aWZp Y2F0ZSBmb3IgdGhpcyBzZXJ2ZXIgaXMgaW52YWxpZCIgbG9hZGluZyBlcnJvciAobm90IGhhcHBl bmluZyBpbiBXSzEpCiB3ZWJraXQub3JnL2IvMTYwNDQ1IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29u dGVudFNlY3VyaXR5UG9saWN5L3VwZ3JhZGUtaW5zZWN1cmUtcmVxdWVzdHMvdXBncmFkZS1pbnNl Y3VyZS1mZXRjaC1pbi13b3JrZXIuaHRtbCBbIEZhaWx1cmUgVGltZW91dCBdCit3ZWJraXQub3Jn L2IvMTYwNDQ1IGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3VwZ3Jh ZGUtaW5zZWN1cmUtcmVxdWVzdHMvdXBncmFkZS1pbnNlY3VyZS1mZXRjaC1pbi1tYWluLWZyYW1l Lmh0bWwgWyBGYWlsdXJlIFRpbWVvdXQgXQogCiAjIyMgRU5EIE9GICgzKSBVbmNsYXNzaWZpZWQg ZmFpbHVyZXMKICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOGRiMGM2OWRjNDFiYzFm NmNhZTM4OTg4ZTBlMGUxMGU4MWQ1ZjY0ZS4uOTMyMTkxNzc4MGMwNjI5MGU1MjhkNmYwYmUwYTdm MWYyOGNkMjIyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTQyLDggKzQyLDYgQEAKICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMKICMjIyBTVEFSVCBPRiAoMSkgQ2xhc3NpZmllZCBmYWlsdXJlcyB3aXRoIGJ1ZyByZXBvcnRz CiAKLXdlYmtpdC5vcmcvYi8xNjA0NDUgaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJp dHlQb2xpY3kvdXBncmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy91cGdyYWRlLWluc2VjdXJlLWZldGNo LWluLW1haW4tZnJhbWUuaHRtbCBbIFRpbWVvdXQgXQotCiB3ZWJraXQub3JnL2IvMTU2NjEyIGh0 dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L2VtYmVkLXJlZGlyZWN0LWJs b2NrZWQzLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNTY2MTIgaHR0cC90ZXN0cy9z ZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvb2JqZWN0LXJlZGlyZWN0LWJsb2NrZWQzLmh0 bWwgWyBGYWlsdXJlIF0KIAo=