160810 2016-08-12 11:55:34 -0700 Web Inspector: Command-Shift-O causes infinite loop if web page has frames 2016-08-12 15:34:30 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P1 Blocker --- 1 nvasilyev nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1219636 0 nvasilyev 2016-08-12 11:55:34 -0700 Steps: 1. Open Web Inspector on this page. 2. Press Command-Shift-O 1219637 1 webkit-bug-importer 2016-08-12 11:56:03 -0700 <rdar://problem/27827557> 1219638 2 285924 nvasilyev 2016-08-12 11:59:48 -0700 Created attachment 285924 Patch 1219643 3 285924 joepeck 2016-08-12 12:10:53 -0700 Comment on attachment 285924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285924&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + "frame" doens't change inside the loop. Typo: "doesn't" 1219645 4 285928 nvasilyev 2016-08-12 12:24:18 -0700 Created attachment 285928 Patch 1219646 5 285929 nvasilyev 2016-08-12 12:26:03 -0700 Created attachment 285929 Patch 1219669 6 commit-queue 2016-08-12 13:04:31 -0700 The commit-queue encountered the following flaky tests while processing attachment 285929: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. 1219670 7 commit-queue 2016-08-12 13:04:33 -0700 The commit-queue encountered the following flaky tests while processing attachment 285929: The commit-queue is continuing to process your patch. 1219745 8 285929 commit-queue 2016-08-12 15:34:26 -0700 Comment on attachment 285929 Patch Clearing flags on attachment: 285929 Committed r204428: <http://trac.webkit.org/changeset/204428> 1219746 9 commit-queue 2016-08-12 15:34:30 -0700 All reviewed patches have been landed. Closing bug. 285924 2016-08-12 11:59:48 -0700 2016-08-12 12:24:18 -0700 Patch patch.txt text/plain 1470 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkOWRhYzMuLjQyMzg3ZWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTEyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1h bmQtU2hpZnQtTyBjYXVzZXMgaW5maW5pdGUgbG9vcCBpZiB3ZWIgcGFnZSBoYXMgZnJhbWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA4MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y Lk9wZW5SZXNvdXJjZURpYWxvZy5wcm90b3R5cGUuX2FkZFJlc291cmNlc0ZvckZyYW1lKToKKyAg ICAgICAgImZyYW1lIiBkb2Vucyd0IGNoYW5nZSBpbnNpZGUgdGhlIGxvb3AuCisKIDIwMTYtMDgt MTEgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAocjIwNDI2NCk6IFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbiBpbiBO ZXR3b3JrIHRhYiB3aGVuIHJlbG9hZGluZyBhIHdlYiBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VEaWFsb2cuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VE aWFsb2cuanMKaW5kZXggNjdiOTYzNy4uM2E4YmQ1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURp YWxvZy5qcwpAQCAtMjU3LDcgKzI1Nyw3IEBAIFdlYkluc3BlY3Rvci5PcGVuUmVzb3VyY2VEaWFs b2cgPSBjbGFzcyBPcGVuUmVzb3VyY2VEaWFsb2cgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAg ICAgICAgICBmb3IgKGxldCByZXNvdXJjZSBvZiByZXNvdXJjZXMpCiAgICAgICAgICAgICAgICAg dGhpcy5fYWRkUmVzb3VyY2UocmVzb3VyY2UsIHN1cHByZXNzRmlsdGVyVXBkYXRlKTsKIAotICAg ICAgICAgICAgZnJhbWVzID0gZnJhbWVzLmNvbmNhdChmcmFtZS5jaGlsZEZyYW1lcyk7CisgICAg ICAgICAgICBmcmFtZXMgPSBmcmFtZXMuY29uY2F0KGN1cnJlbnRGcmFtZS5jaGlsZEZyYW1lcyk7 CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl91cGRhdGVGaWx0ZXIoKTsK 285928 2016-08-12 12:24:18 -0700 2016-08-12 12:26:03 -0700 Patch patch.txt text/plain 1477 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkOWRhYzMuLmE2MDhmZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTEyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1h bmQtU2hpZnQtTyBjYXVzZXMgaW5maW5pdGUgbG9vcCBpZiB3ZWIgcGFnZSBoYXMgZnJhbWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA4MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5PcGVuUmVzb3VyY2VEaWFsb2cucHJvdG90eXBlLl9hZGRSZXNvdXJjZXNGb3JGcmFtZSk6Cisg ICAgICAgICJmcmFtZSIgaXMgYW4gZG9lc24ndCBjaGFuZ2UgaW5zaWRlIHRoZSBsb29wLgorCiAy MDE2LTA4LTExICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIyMDQyNjQpOiBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRp b24gaW4gTmV0d29yayB0YWIgd2hlbiByZWxvYWRpbmcgYSB3ZWIgcGFnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlh bG9nLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJl c291cmNlRGlhbG9nLmpzCmluZGV4IDY3Yjk2MzcuLjNhOGJkNTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVz b3VyY2VEaWFsb2cuanMKQEAgLTI1Nyw3ICsyNTcsNyBAQCBXZWJJbnNwZWN0b3IuT3BlblJlc291 cmNlRGlhbG9nID0gY2xhc3MgT3BlblJlc291cmNlRGlhbG9nIGV4dGVuZHMgV2ViSW5zcGVjdG9y LgogICAgICAgICAgICAgZm9yIChsZXQgcmVzb3VyY2Ugb2YgcmVzb3VyY2VzKQogICAgICAgICAg ICAgICAgIHRoaXMuX2FkZFJlc291cmNlKHJlc291cmNlLCBzdXBwcmVzc0ZpbHRlclVwZGF0ZSk7 CiAKLSAgICAgICAgICAgIGZyYW1lcyA9IGZyYW1lcy5jb25jYXQoZnJhbWUuY2hpbGRGcmFtZXMp OworICAgICAgICAgICAgZnJhbWVzID0gZnJhbWVzLmNvbmNhdChjdXJyZW50RnJhbWUuY2hpbGRG cmFtZXMpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlRmlsdGVyKCk7Cg== 285929 2016-08-12 12:26:03 -0700 2016-08-12 15:34:26 -0700 Patch patch.txt text/plain 1471 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZkOWRhYzMuLjM2ZTcyMmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTEyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1h bmQtU2hpZnQtTyBjYXVzZXMgaW5maW5pdGUgbG9vcCBpZiB3ZWIgcGFnZSBoYXMgZnJhbWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA4MTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5PcGVuUmVzb3VyY2VEaWFsb2cucHJvdG90eXBlLl9hZGRSZXNvdXJjZXNGb3JGcmFtZSk6Cisg ICAgICAgICJmcmFtZSIgZG9lc24ndCBjaGFuZ2UgaW5zaWRlIHRoZSBsb29wLgorCiAyMDE2LTA4 LTExICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyMDQyNjQpOiBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gaW4g TmV0d29yayB0YWIgd2hlbiByZWxvYWRpbmcgYSB3ZWIgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlhbG9nLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNl RGlhbG9nLmpzCmluZGV4IDY3Yjk2MzcuLjNhOGJkNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VE aWFsb2cuanMKQEAgLTI1Nyw3ICsyNTcsNyBAQCBXZWJJbnNwZWN0b3IuT3BlblJlc291cmNlRGlh bG9nID0gY2xhc3MgT3BlblJlc291cmNlRGlhbG9nIGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogICAg ICAgICAgICAgZm9yIChsZXQgcmVzb3VyY2Ugb2YgcmVzb3VyY2VzKQogICAgICAgICAgICAgICAg IHRoaXMuX2FkZFJlc291cmNlKHJlc291cmNlLCBzdXBwcmVzc0ZpbHRlclVwZGF0ZSk7CiAKLSAg ICAgICAgICAgIGZyYW1lcyA9IGZyYW1lcy5jb25jYXQoZnJhbWUuY2hpbGRGcmFtZXMpOworICAg ICAgICAgICAgZnJhbWVzID0gZnJhbWVzLmNvbmNhdChjdXJyZW50RnJhbWUuY2hpbGRGcmFtZXMp OwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlRmlsdGVyKCk7Cg==