160782 2016-08-11 14:04:13 -0700 REGRESSION (r204226): LayoutTest editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html "crashing" without a crashlog 2016-08-23 11:58:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157977 https://bugs.webkit.org/show_bug.cgi?id=122475 https://bugs.webkit.org/show_bug.cgi?id=157990 P2 Normal --- 1 ryanhaddad webkit-unassigned andersca ap barraclough cdumez commit-queue jbedard oldest_to_newest 1219407 0 ryanhaddad 2016-08-11 14:04:13 -0700 LayoutTest editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html "crashing" without a crashlog Most recent "crash": https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/7275 Flakiness dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fdeleting%2Fdelete-empty-line-breaks-at-end-of-textarea.html 1219589 1 jbedard 2016-08-12 08:46:38 -0700 Let's wait on https://bugs.webkit.org/show_bug.cgi?id=160779, I suspect that this is the same bug we were seeing there, although I can't be sure because the --no-sample-on-timeout disables the output we would see before the test gets marked as having crashed. Even if https://bugs.webkit.org/show_bug.cgi?id=160779 is the issue we're seeing here, we are still going to have a timeout occurring. Why is this suite disabling sample on timeout? 1220587 2 ryanhaddad 2016-08-16 15:07:46 -0700 It looks like this happened again after https://trac.webkit.org/changeset/204514 landed https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/8541 1220614 3 jbedard 2016-08-16 15:37:16 -0700 I guess send that Radar back my way. https://trac.webkit.org/changeset/204514 definitely fixed a problem, I guess it just wasn't this one. 1220623 4 ryanhaddad 2016-08-16 15:47:18 -0700 (In reply to comment #2) > It looks like this happened again after > https://trac.webkit.org/changeset/204514 landed > > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/8541 Sorry, that link should have been: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/8539 1220877 5 jbedard 2016-08-17 10:05:14 -0700 Taking a closer look at the history of editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html, this seems to be a separate problem from radar 27786762. I'm not sure what's causing this test to be marked as crashed, it's quite possible this is a true crash and it simply can't match the crash log. Taking a look at https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/8296/steps/layout-test/logs/stdio (which is where this bug first starts showing up) we can see process 78827 crashing, then 78817 is killed, then an attempt to find the crashlog of 78827 (which would seem to fail, otherwise the results would be attached) and then 78827 crashing for a second time in the next test. This second piece should not be possible, as 78827 should have already crashed. 1220892 6 jbedard 2016-08-17 10:54:27 -0700 https://bugs.webkit.org/show_bug.cgi?id=160943 should help debug this. 1220996 7 jbedard 2016-08-17 16:29:31 -0700 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/8583 has this bug again. None of the logging added in <http://trac.webkit.org/changeset/204577> caught it, so somehow, a test is being erroneously marked as crashed outside of the framework we are using for marking tests as crashed. 1221103 8 286374 jbedard 2016-08-18 10:16:06 -0700 Created attachment 286374 Patch 1221107 9 286374 ap 2016-08-18 10:25:26 -0700 Comment on attachment 286374 Patch Discussed in person. 1221237 10 jbedard 2016-08-18 16:17:45 -0700 Some additional information on this: This particular bug does not seem to be in the testing rig, but rather the test itself. This particular error also seems to be related to the preceding test, editing/deleting/delete-emoji.html. In short, the WebProcess is exiting unexpectedly, but with an exit() instead of an abort(), meaning no crash-log is generated. On one occasion, I have managed to reproduced this error locally, but without the debugger enabled. 1221458 11 ryanhaddad 2016-08-19 13:36:01 -0700 Marked test as flaky on El Capitan in http://trac.webkit.org/projects/webkit/changeset/204650 to get the bots back to green. 1222245 12 ap 2016-08-23 09:34:27 -0700 What happens here is that editing/deleting/delete-emoji.html is extremely slow to repaint, and sometimes it repaints after finishing. When this happens, WebKitTestRunner cannot reset WebContent process for the next test, and attempts to terminate it, and to launch a new one. However, calling WKPageTerminate() results in a processDidCrash() callback, and then WebKitTestRunner itself terminates with an exit(). It seems suspicious that we get a processDidCrash() when intentionally terminating. frame #12: 0x00007fff9857c767 libsystem_c.dylib`exit + 55 frame #13: 0x00000001002f5b30 WebKitTestRunner`WTR::TestController::processDidCrash(this=0x00007fff5f9667a0) + 576 at TestController.cpp:1730 frame #14: 0x00000001002daf2c WebKitTestRunner`WTR::TestController::processDidCrash(page=0x000061d000039880, clientInfo=0x00007fff5f9667a0) + 28 at TestController.cpp:1518 frame #15: 0x00000001099ef958 WebKit`WKPageSetPageNavigationClient::NavigationClient::processDidCrash(this=0x0000610000049540, page=0x000061d000039898) + 264 at WKPage.cpp:2325 frame #16: 0x000000010902b6c8 WebKit`WebKit::WebPageProxy::processDidCrash(this=0x000061d000039898) + 792 at WebPageProxy.cpp:5190 frame #17: 0x00000001095cce52 WebKit`WebKit::WebProcessProxy::didClose(this=0x0000619000035780, (null)=0x000061400009d240) + 434 at WebProcessProxy.cpp:541 frame #18: 0x00000001095d19d5 WebKit`WebKit::WebProcessProxy::requestTermination(this=0x0000619000035780) + 197 at WebProcessProxy.cpp:808 frame #19: 0x0000000109000366 WebKit`WebKit::WebPageProxy::terminateProcess(this=0x000061d000039898) + 230 at WebPageProxy.cpp:2355 frame #20: 0x00000001099bfdfd WebKit`::WKPageTerminate(pageRef=0x000061d000039880) + 29 at WKPage.cpp:409 frame #21: 0x00000001002e2c8d WebKitTestRunner`WTR::TestController::terminateWebContentProcess(this=0x00007fff5f9667a0) + 109 at TestController.cpp:805 frame #22: 0x00000001003389ec WebKitTestRunner`WTR::TestInvocation::invoke(this=0x0000611000079d00) + 2940 at TestInvocation.cpp:180 frame #23: 0x00000001002ef2b9 WebKitTestRunner`WTR::TestController::runTest(this=<unavailable>, inputLine=<unavailable>) + 4873 at TestController.cpp:1098 frame #24: 0x00000001002f1f5c WebKitTestRunner`WTR::TestController::runTestingServerLoop(this=0x00007fff5f9667a0) + 524 at TestController.cpp:1115 frame #25: 0x00000001002d8a2f WebKitTestRunner`WTR::TestController::run(this=0x00007fff5f9667a0) + 159 at TestController.cpp:1123 frame #26: 0x00000001002d7645 WebKitTestRunner`WTR::TestController::TestController(this=<unavailable>, argc=<unavailable>, argv=<unavailable>) + 8069 at TestController.cpp:126 frame #27: 0x00000001002d8d73 WebKitTestRunner`WTR::TestController::TestController(this=0x00007fff5f9667a0, argc=2, argv=0x00007fff5f966a30) + 35 at TestController.cpp:123 1222249 13 ap 2016-08-23 09:45:14 -0700 What's still unclear is why this only started to happen recently, around August 5th. 1222260 14 ap 2016-08-23 10:18:44 -0700 Found it, regressed with <https://trac.webkit.org/changeset/204226>. The crash a few hours prior to that was a real one, a gamepad patch was making lots of tests crash. 1222292 15 286738 jbedard 2016-08-23 11:07:20 -0700 Created attachment 286738 Patch 1222295 16 286738 cdumez 2016-08-23 11:08:41 -0700 Comment on attachment 286738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286738&action=review > Source/WebKit2/ChangeLog:8 > + Backing out r204226. r204243 is the last version of this change. 1222297 17 286738 cdumez 2016-08-23 11:09:30 -0700 Comment on attachment 286738 Patch This should also remove the change to WebPageProxy, please see: https://trac.webkit.org/changeset/204243 1222301 18 cdumez 2016-08-23 11:11:26 -0700 I did a roll out in <http://trac.webkit.org/changeset/204841>. Just unskip the test. 1222316 19 286747 jbedard 2016-08-23 11:25:09 -0700 Created attachment 286747 Patch 1222336 20 286747 commit-queue 2016-08-23 11:58:40 -0700 Comment on attachment 286747 Patch Clearing flags on attachment: 286747 Committed r204845: <http://trac.webkit.org/changeset/204845> 1222337 21 commit-queue 2016-08-23 11:58:47 -0700 All reviewed patches have been landed. Closing bug. 286374 2016-08-18 10:16:06 -0700 2016-08-23 11:07:14 -0700 Patch bug-160782-20160818101416.patch text/plain 1341 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDU5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA4LTE4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBMYXlvdXRUZXN0IGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWVtcHR5LWxp bmUtYnJlYWtzLWF0LWVuZC1vZi10ZXh0YXJlYS5odG1sICJjcmFzaGluZyIgd2l0aG91dCBhIGNy YXNobG9nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjA3ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGZpeGVzIGEgY2xhc3Mgb2YgZXJyb3JzIHdoZXJlIGRlY2xhcmVkIGNyYXNoZXMgaW4gdGhl IFdlYlByb2Nlc3MgZG9u4oCZdCBnZW5lcmF0ZSBjcmFzaGxvZ3MuCisKKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRy b2xsZXI6OnByb2Nlc3NEaWRDcmFzaCk6IEhhdmUgV2ViUHJvY2VzcyBhYm9ydCgpIHRvIGdlbmVy YXRlIGNyYXNobG9nIGluc3RlYWQgb2YgZXhpdC4KKwogMjAxNi0wOC0xNyAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gTWlncmF0ZSBv ZmYgb2YgZGVwcmVjYXRlZCBDb3JlR3JhcGhpY3MgQVBJIENHQ29udGV4dFNlbGVjdEZvbnQoKSBh bmQgQ0dDb250ZXh0U2hvd1RleHRBdFBvaW50KCkKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAyMDQ1OTYpCisrKyBUb29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcyNyw3ICsx NzI3LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6cHJvY2Vzc0RpZENyYXNoKCkKICAgICB9CiAK ICAgICBpZiAobV9zaG91bGRFeGl0V2hlbldlYlByb2Nlc3NDcmFzaGVzKQotICAgICAgICBleGl0 KDEpOworICAgICAgICBhYm9ydCgpOwogfQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpkaWRCZWdp bk5hdmlnYXRpb25HZXN0dXJlKFdLUGFnZVJlZikK 286738 2016-08-23 11:07:20 -0700 2016-08-23 11:25:05 -0700 Patch bug-160782-20160823110521.patch text/plain 6835 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDgzNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA4LTIzICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjA0 MjI2KTogTGF5b3V0VGVzdCBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1lbXB0eS1saW5lLWJyZWFr cy1hdC1lbmQtb2YtdGV4dGFyZWEuaHRtbCAiY3Jhc2hpbmciIHdpdGhvdXQgYSBjcmFzaGxvZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzgyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFja2luZyBv dXQgcjIwNDIyNi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OnJlcXVlc3RUZXJtaW5hdGlvbik6IFJl dmVydCB0byBwcmV2aW91cyBmdW5jdGlvbmFsaXR5LgorCiAyMDE2LTA4LTIzICBIdW5zZW9wIEpl b25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBVUlRCRiBhZnRl ciByMjA0NzQzLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQ cm94eS5jcHAJKHJldmlzaW9uIDIwNDgzNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQcm9jZXNzUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MDUsNyArODA1LDEwIEBAIHZv aWQgV2ViUHJvY2Vzc1Byb3h5OjpyZXF1ZXN0VGVybWluYXRpb24KIAogICAgIENoaWxkUHJvY2Vz c1Byb3h5Ojp0ZXJtaW5hdGUoKTsKIAotICAgIGRpZENsb3NlKCpjb25uZWN0aW9uKCkpOworICAg IGlmICh3ZWJDb25uZWN0aW9uKCkpIAorICAgICAgICB3ZWJDb25uZWN0aW9uKCktPmRpZENsb3Nl KCk7IAorCisgICAgc2h1dERvd24oKTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzUHJveHk6OmVuYWJs ZVN1ZGRlblRlcm1pbmF0aW9uKCkKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDg0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA4LTIzICBKb25hdGhhbiBCZWRh cmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjA0MjI2KTog TGF5b3V0VGVzdCBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1lbXB0eS1saW5lLWJyZWFrcy1hdC1l bmQtb2YtdGV4dGFyZWEuaHRtbCAiY3Jhc2hpbmciIHdpdGhvdXQgYSBjcmFzaGxvZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzgyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFja2luZyBvdXQgcjIw NDIyNi4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL05hdmln YXRpb24ubW06CisgICAgICAgICgtW05hdmlnYXRpb25EZWxlZ2F0ZSB3ZWJWaWV3V2ViQ29udGVu dFByb2Nlc3NEaWRUZXJtaW5hdGU6XSk6IERlbGV0ZWQuCisgICAgICAgIChURVNUKTogRGVsZXRl ZC4KKwogMjAxNi0wOC0yMyAgUmF3aW5kZXIgU2luZ2ggIDxyYXdpbmRlci5zaW5naC13ZWJraXRA Y2lzcmEuY2Fub24uY29tLmF1PgogCiAgICAgICAgIE9yZGVyIGZlYXR1cmUgb3B0aW9uIGxpc3Qg aW4gRmVhdHVyZUxpc3QucG0KSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 MkNvY29hL05hdmlnYXRpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyQ29jb2EvTmF2aWdhdGlvbi5tbQkocmV2aXNpb24gMjA0ODM3KQorKysgVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvTmF2aWdhdGlvbi5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMjcsMTEgKzI3LDcgQEAKIAogI2ltcG9ydCA8V2ViS2l0L1dLTmF2aWdhdGlv blByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9XS05hdmlnYXRpb25EZWxlZ2F0ZS5oPgotI2lt cG9ydCA8V2ViS2l0L1dLUHJvY2Vzc1Bvb2xQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tX ZWJWaWV3Lmg+Ci0jaW1wb3J0IDxXZWJLaXQvV0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUu aD4KLSNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXdQcml2YXRlLmg+Ci0jaW1wb3J0IDxXZWJLaXQv X1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+ CiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5oIgogI2ltcG9ydCAiVGVzdC5oIgpAQCAtMzks NyArMzUsNiBAQAogI2lmIFdLX0FQSV9FTkFCTEVECiAKIHN0YXRpYyBib29sIGlzRG9uZTsKLXN0 YXRpYyBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4gY3Jhc2hIYW5kbGVyOwogc3RhdGljIFJldGFpblB0 cjxXS05hdmlnYXRpb24+IGN1cnJlbnROYXZpZ2F0aW9uOwogCiBAaW50ZXJmYWNlIE5hdmlnYXRp b25EZWxlZ2F0ZSA6IE5TT2JqZWN0IDxXS05hdmlnYXRpb25EZWxlZ2F0ZT4KQEAgLTY1LDExICs2 MCw2IEBAIC0gKHZvaWQpd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWQKICAgICBpc0Rv bmUgPSB0cnVlOwogfQogCi0tICh2b2lkKXdlYlZpZXdXZWJDb250ZW50UHJvY2Vzc0RpZFRlcm1p bmF0ZTooV0tXZWJWaWV3ICopd2ViVmlldwotewotICAgIGNyYXNoSGFuZGxlcigpOwotfQotCiBA ZW5kCiAKIFRFU1QoV0tOYXZpZ2F0aW9uLCBOYXZpZ2F0aW9uRGVsZWdhdGUpCkBAIC0xOTcsNDgg KzE4Nyw0IEBAIFRFU1QoV0tOYXZpZ2F0aW9uLCBEZWNpZGVQb2xpY3lGb3JQYWdlQ2EKICAgICBB U1NFUlRfVFJVRShbZGVsZWdhdGUgZGVjaWRlZFBvbGljeUZvckJhY2tGb3J3YXJkTmF2aWdhdGlv bl0pOwogfQogCi1URVNUKFdLTmF2aWdhdGlvbiwgV2ViQ29udGVudFByb2Nlc3NEaWRUZXJtaW5h dGUpCi17Ci0gICAgTlNBdXRvcmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29s IGFsbG9jXSBpbml0XTsKLSAgICBSZXRhaW5QdHI8X1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9u PiBwb29sQ29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tfV0tQcm9jZXNzUG9vbENvbmZpZ3VyYXRp b24gYWxsb2NdIGluaXRdKTsKLSAgICBwb29sQ29uZmlndXJhdGlvbi5nZXQoKS5tYXhpbXVtUHJv Y2Vzc0NvdW50ID0gMTsKLSAgICBSZXRhaW5QdHI8V0tQcm9jZXNzUG9vbD4gcHJvY2Vzc1Bvb2wg PSBhZG9wdE5TKFtbV0tQcm9jZXNzUG9vbCBhbGxvY10gX2luaXRXaXRoQ29uZmlndXJhdGlvbjpw b29sQ29uZmlndXJhdGlvbi5nZXQoKV0pOwotCi0gICAgUmV0YWluUHRyPFdLV2ViVmlld0NvbmZp Z3VyYXRpb24+IGNvbmZpZ3VyYXRpb24xID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3VyYXRp b24gYWxsb2NdIGluaXRdKTsKLSAgICBjb25maWd1cmF0aW9uMS5nZXQoKS5wcm9jZXNzUG9vbCA9 IHByb2Nlc3NQb29sLmdldCgpOwotICAgIFJldGFpblB0cjxXS1dlYlZpZXc+IHdlYlZpZXcxID0g YWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAs IDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24xLmdldCgpXSk7Ci0KLSAgICBS ZXRhaW5QdHI8TmF2aWdhdGlvbkRlbGVnYXRlPiBkZWxlZ2F0ZTEgPSBhZG9wdE5TKFtbTmF2aWdh dGlvbkRlbGVnYXRlIGFsbG9jXSBpbml0XSk7Ci0gICAgW3dlYlZpZXcxIHNldE5hdmlnYXRpb25E ZWxlZ2F0ZTpkZWxlZ2F0ZTEuZ2V0KCldOwotCi0gICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0g W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAImRhdGE6 dGV4dC9odG1sLDEiXV07Ci0KLSAgICBpc0RvbmUgPSBmYWxzZTsKLSAgICBjdXJyZW50TmF2aWdh dGlvbiA9IFt3ZWJWaWV3MSBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKLSAgICBUZXN0V2ViS2l0QVBJ OjpVdGlsOjpydW4oJmlzRG9uZSk7Ci0KLSAgICBSZXRhaW5QdHI8V0tXZWJWaWV3Q29uZmlndXJh dGlvbj4gY29uZmlndXJhdGlvbjIgPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBh bGxvY10gaW5pdF0pOwotICAgIGNvbmZpZ3VyYXRpb24yLmdldCgpLnByb2Nlc3NQb29sID0gcHJv Y2Vzc1Bvb2wuZ2V0KCk7Ci0gICAgY29uZmlndXJhdGlvbjIuZ2V0KCkuX3JlbGF0ZWRXZWJWaWV3 ID0gd2ViVmlldzEuZ2V0KCk7Ci0gICAgUmV0YWluUHRyPFdLV2ViVmlldz4gd2ViVmlldzIgPSBh ZG9wdE5TKFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwg ODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbjIuZ2V0KCldKTsKLQotICAgIFJl dGFpblB0cjxOYXZpZ2F0aW9uRGVsZWdhdGU+IGRlbGVnYXRlMiA9IGFkb3B0TlMoW1tOYXZpZ2F0 aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKLSAgICBbd2ViVmlldzIgc2V0TmF2aWdhdGlvbkRl bGVnYXRlOmRlbGVnYXRlMi5nZXQoKV07Ci0KLSAgICBpc0RvbmUgPSBmYWxzZTsKLSAgICBjdXJy ZW50TmF2aWdhdGlvbiA9IFt3ZWJWaWV3MiBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKLSAgICBUZXN0 V2ViS2l0QVBJOjpVdGlsOjpydW4oJmlzRG9uZSk7Ci0KLSAgICBib29sIGRpZFRlcm1pbmF0ZSA9 IGZhbHNlOwotICAgIGNyYXNoSGFuZGxlciA9IFsmXSB7Ci0gICAgICAgIHdlYlZpZXcxID0gbnVs bHB0cjsKLSAgICAgICAgd2ViVmlldzIgPSBudWxscHRyOwotICAgICAgICBbcG9vbCBkcmFpbl07 IC8vIE1ha2Ugc3VyZSB0aGUgdmlld3MgZ2V0IGRlYWxsb2NhdGVkLgotICAgICAgICBkaWRUZXJt aW5hdGUgPSB0cnVlOwotICAgIH07Ci0KLSAgICBbd2ViVmlldzIgX2tpbGxXZWJDb250ZW50UHJv Y2Vzc0FuZFJlc2V0U3RhdGVdOwotICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZGlkVGVy bWluYXRlKTsKLX0KLQogI2VuZGlmCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDQ4MzcpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0w OC0yMyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVH UkVTU0lPTiAocjIwNDIyNik6IExheW91dFRlc3QgZWRpdGluZy9kZWxldGluZy9kZWxldGUtZW1w dHktbGluZS1icmVha3MtYXQtZW5kLW9mLXRleHRhcmVhLmh0bWwgImNyYXNoaW5nIiB3aXRob3V0 IGEgY3Jhc2hsb2cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MDc4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJhY2tpbmcgb3V0IHIyMDQ2NTAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgZWRpdGluZy9kZWxldGluZy9kZWxldGUtZW1wdHktbGlu ZS1icmVha3MtYXQtZW5kLW9mLXRleHRhcmVhLmh0bWwgZnJvbSBmbGFrZXkgdGVzdCBsaXN0Lgor CiAyMDE2LTA4LTIzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV0syXSBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS91cGdyYWRl LWluc2VjdXJlLXJlcXVlc3RzL3VwZ3JhZGUtaW5zZWN1cmUtZmV0Y2gtaW4tbWFpbi1mcmFtZS5o dG1sIGZhaWxzCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3Rh dGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhw ZWN0YXRpb25zCShyZXZpc2lvbiAyMDQ4MzcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTU0MCw1ICs1NDAsMyBAQCB3 ZWJraXQub3JnL2IvMTYwMDQyIFsgRWxDYXBpdGFuIF0gYWNjZXNzCiB3ZWJraXQub3JnL2IvMTU5 NDI3IGh0dHAvdGVzdHMvbG9hZGluZy9iYXNpYy1jcmVkZW50aWFscy1zZW50LWF1dG9tYXRpY2Fs bHkuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNjAzMDkgZmFzdC9kb20v V2luZG93L2NoaWxkLXdpbmRvdy1mb2N1cy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0 Lm9yZy9iLzE2MDc4MiBbIEVsQ2FwaXRhbiBdIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWVtcHR5 LWxpbmUtYnJlYWtzLWF0LWVuZC1vZi10ZXh0YXJlYS5odG1sIFsgUGFzcyBDcmFzaCBdCg== 286747 2016-08-23 11:25:09 -0700 2016-08-23 11:58:40 -0700 Patch bug-160782-20160823112311.patch text/plain 1360 jbedard SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNDg0MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTIzICBKb25hdGhhbiBCZWRhcmQg IDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjA0MjI2KTogTGF5 b3V0VGVzdCBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1lbXB0eS1saW5lLWJyZWFrcy1hdC1lbmQt b2YtdGV4dGFyZWEuaHRtbCAiY3Jhc2hpbmciIHdpdGhvdXQgYSBjcmFzaGxvZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzgyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUm9sbGluZyBvdXQgcjIwNDY1 MC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczogZWRpdGlu Zy9kZWxldGluZy9kZWxldGUtZW1wdHktbGluZS1icmVha3MtYXQtZW5kLW9mLXRleHRhcmVhLmh0 bWwgcmVtb3ZlZCBmcm9tIGxpc3Qgb2YgZmxha2V5IHRlc3RzLgorCiAyMDE2LTA4LTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBodHRwL3Rlc3Rz L3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS91cGdyYWRlLWluc2VjdXJlLXJlcXVlc3Rz L3VwZ3JhZGUtaW5zZWN1cmUtZmV0Y2gtaW4tbWFpbi1mcmFtZS5odG1sIGZhaWxzCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lv biAyMDQ4NDIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMJKHdvcmtpbmcgY29weSkKQEAgLTU0MSw0ICs1NDEsMyBAQCB3ZWJraXQub3JnL2IvMTU5NDI3 IGh0dHAvdGVzdHMvbG9hZGluZy9iCiAKIHdlYmtpdC5vcmcvYi8xNjAzMDkgZmFzdC9kb20vV2lu ZG93L2NoaWxkLXdpbmRvdy1mb2N1cy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9y Zy9iLzE2MDc4MiBbIEVsQ2FwaXRhbiBdIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWVtcHR5LWxp bmUtYnJlYWtzLWF0LWVuZC1vZi10ZXh0YXJlYS5odG1sIFsgUGFzcyBDcmFzaCBdCg==