160779 2016-08-11 13:13:56 -0700 False crashes in fast/text/emoji-gender-* tests 2016-08-16 11:13:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Major --- 1 jbedard webkit-unassigned commit-queue glenn lforschler simon.fraser oldest_to_newest 1219382 0 jbedard 2016-08-11 13:13:56 -0700 Run-webkit-tests is falsely reporting crashes in some tests due to a bug in webkitpy. From radar 27786762. 1219386 1 285847 jbedard 2016-08-11 13:22:59 -0700 Created attachment 285847 Patch 1219397 2 285847 ap 2016-08-11 13:32:40 -0700 Comment on attachment 285847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285847&action=review Good catch! > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here. This comment does not explain why we need to ignore a failure to write. How can it be improved to explain it? 1219404 3 285852 jbedard 2016-08-11 13:49:32 -0700 Created attachment 285852 Patch 1219409 4 285852 ap 2016-08-11 14:06:19 -0700 Comment on attachment 285852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285852&action=review > Tools/Scripts/webkitpy/port/driver.py:447 > + self._server_process.write('#SAMPLE FINISHED\n', True) # Must be able to ignore a broken pipe here, target process may already be closed. A slightly shorter way to say the same is "Ignoring write errors, as target process may already be terminated." 1220495 5 285852 commit-queue 2016-08-16 11:05:13 -0700 Comment on attachment 285852 Patch Clearing flags on attachment: 285852 Committed r204514: <http://trac.webkit.org/changeset/204514> 1220496 6 commit-queue 2016-08-16 11:05:18 -0700 All reviewed patches have been landed. Closing bug. 1220499 7 simon.fraser 2016-08-16 11:13:58 -0700 I feel like this could have had a better changelog entry. I can't easily tell what the bug was and how you fixed it. 285847 2016-08-11 13:22:59 -0700 2016-08-11 13:49:29 -0700 Patch bug-160779-20160811132121.patch text/plain 3468 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDM4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA4LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGYWxzZSBjcmFzaGVzIGluIGZhc3QvdGV4dC9lbW9qaS1nZW5kZXItKiB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYw Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGZyb20gPHJkYXI6Ly9wcm9ibGVtLzI3Nzg2NzYyPiwgd2hlcmUgdGltZWQgb3V0IHRlc3RzIGZh bHNlbHkgcmVwb3J0IGFzIGNyYXNoZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9jaGVja19mb3JfZHJpdmVyX2NyYXNoX29y X3VucmVzcG9uc2l2ZW5lc3MpOiBDaGFuZ2UgY2FsbCB0byDigJh3cml0ZeKAmSB0byBkaXNhYmxl IGNyYXNoIGZsYWcuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0 dGVzdC5weTogQWRkZWQgMyB2YXJpYWJsZSB0byB0ZXN0IHZlcnNpb24gb2Yg4oCYd3JpdGUu4oCZ CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAg ICAgICAoU2VydmVyUHJvY2Vzcy53cml0ZSk6IEFsbG93IGNhbGxlciB0byBkaXNhYmxlIGNyYXNo IGZsYWcgb24gZXhjZXB0aW9uLgorCiAyMDE2LTA4LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBFV1Mgc2hvdWxkIGNoZWNrIGlmIHRoZSBwYXRjaCBp cyBzdGlsbCB2YWxpZCBiZWZvcmUgZXhlY3V0aW5nIGV2ZXJ5IG1ham9yIHN0ZXAKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkocmV2aXNpb24gMjA0Mzc0KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkod29ya2luZyBjb3B5KQpAQCAtNDQ0 LDcgKzQ0NCw3IEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAgICAgICAgICAgaWYgY2hpbGRf cHJvY2Vzc19waWQ6CiAgICAgICAgICAgICAgICAgc2VsZi5fcG9ydC5zYW1wbGVfcHJvY2Vzcyhj aGlsZF9wcm9jZXNzX25hbWUsIGNoaWxkX3Byb2Nlc3NfcGlkKQogICAgICAgICAgICAgc2VsZi5l cnJvcl9mcm9tX3Rlc3QgKz0gZXJyb3JfbGluZQotICAgICAgICAgICAgc2VsZi5fc2VydmVyX3By b2Nlc3Mud3JpdGUoJyNTQU1QTEUgRklOSVNIRURcbicpCisgICAgICAgICAgICBzZWxmLl9zZXJ2 ZXJfcHJvY2Vzcy53cml0ZSgnI1NBTVBMRSBGSU5JU0hFRFxuJywgVHJ1ZSkgICMgTXVzdCBiZSBh YmxlIHRvIGlnbm9yZSBhIGJyb2tlbiBwaXBlIGhlcmUuCiAgICAgICAgICAgICByZXR1cm4gVHJ1 ZQogICAgICAgICByZXR1cm4gc2VsZi5oYXNfY3Jhc2hlZCgpCiAKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9kcml2ZXJfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0dGVzdC5weQkocmV2aXNpb24gMjA0Mzc0 KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0dGVzdC5weQkod29y a2luZyBjb3B5KQpAQCAtMjA2LDcgKzIwNiw3IEBAIGNsYXNzIERyaXZlclRlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgICAgICAgICAgZGVmIHN0b3Aoc2VsZiwgdGltZW91dCk6CiAgICAgICAg ICAgICAgICAgcGFzcwogCi0gICAgICAgICAgICBkZWYgd3JpdGUoc2VsZiwgc3RyKToKKyAgICAg ICAgICAgIGRlZiB3cml0ZShzZWxmLCBieXRlcywgaWdub3JlX2NyYXNoPUZhbHNlKToKICAgICAg ICAgICAgICAgICBwYXNzCiAKICAgICAgICAgZGVmIGFzc2VydF9jcmFzaChkcml2ZXIsIGVycm9y X2xpbmUsIGNyYXNoZWQsIG5hbWUsIHBpZCwgdW5yZXNwb25zaXZlPUZhbHNlKToKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9u IDIwNDM3NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5w eQkod29ya2luZyBjb3B5KQpAQCAtMTQ0LDcgKzE0NCw3IEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mo b2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9wcm9jLnBvbGwoKQogICAgICAgICBy ZXR1cm4gTm9uZQogCi0gICAgZGVmIHdyaXRlKHNlbGYsIGJ5dGVzKToKKyAgICBkZWYgd3JpdGUo c2VsZiwgYnl0ZXMsIGlnbm9yZV9jcmFzaD1GYWxzZSk6CiAgICAgICAgICIiIldyaXRlIGEgcmVx dWVzdCB0byB0aGUgc3VicHJvY2Vzcy4gVGhlIHN1YnByb2Nlc3MgaXMgKHJlLSlzdGFydCgpJ2Vk CiAgICAgICAgIGlmIGlzIG5vdCBhbHJlYWR5IHJ1bm5pbmcuIiIiCiAgICAgICAgIGlmIG5vdCBz ZWxmLl9wcm9jOgpAQCAtMTUzLDggKzE1MywxMCBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVj dCk6CiAgICAgICAgICAgICBzZWxmLl9wcm9jLnN0ZGluLndyaXRlKGJ5dGVzKQogICAgICAgICBl eGNlcHQgSU9FcnJvciwgZToKICAgICAgICAgICAgIHNlbGYuc3RvcCgwLjApCi0gICAgICAgICAg ICAjIHN0b3AoKSBjYWxscyBfcmVzZXQoKSwgc28gd2UgaGF2ZSB0byBzZXQgY3Jhc2hlZCB0byBU cnVlIGFmdGVyIGNhbGxpbmcgc3RvcCgpLgotICAgICAgICAgICAgc2VsZi5fY3Jhc2hlZCA9IFRy dWUKKyAgICAgICAgICAgICMgc3RvcCgpIGNhbGxzIF9yZXNldCgpLCBzbyB3ZSBoYXZlIHRvIHNl dCBjcmFzaGVkIHRvIFRydWUgYWZ0ZXIgY2FsbGluZyBzdG9wKCkKKyAgICAgICAgICAgICMgdW5s ZXNzIHdlIGFscmVhZHkga25vdyB0aGF0IHRoaXMgaXMgYSB0aW1lb3V0LgorICAgICAgICAgICAg aWYgbm90IGlnbm9yZV9jcmFzaDoKKyAgICAgICAgICAgICAgICBzZWxmLl9jcmFzaGVkID0gVHJ1 ZQogCiAgICAgZGVmIF9wb3Bfc3Rkb3V0X2xpbmVfaWZfcmVhZHkoc2VsZik6CiAgICAgICAgIGlu ZGV4X2FmdGVyX25ld2xpbmUgPSBzZWxmLl9vdXRwdXQuZmluZCgnXG4nKSArIDEK 285852 2016-08-11 13:49:32 -0700 2016-08-16 11:05:13 -0700 Patch bug-160779-20160811134754.patch text/plain 3506 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDM4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA4LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGYWxzZSBjcmFzaGVzIGluIGZhc3QvdGV4dC9lbW9qaS1nZW5kZXItKiB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYw Nzc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGZyb20gPHJkYXI6Ly9wcm9ibGVtLzI3Nzg2NzYyPiwgd2hlcmUgdGltZWQgb3V0IHRlc3RzIGZh bHNlbHkgcmVwb3J0IGFzIGNyYXNoZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9jaGVja19mb3JfZHJpdmVyX2NyYXNoX29y X3VucmVzcG9uc2l2ZW5lc3MpOiBDaGFuZ2UgY2FsbCB0byDigJh3cml0ZeKAmSB0byBkaXNhYmxl IGNyYXNoIGZsYWcuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlcl91bml0 dGVzdC5weTogQWRkZWQgMyB2YXJpYWJsZSB0byB0ZXN0IHZlcnNpb24gb2Yg4oCYd3JpdGUu4oCZ CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5OgorICAg ICAgICAoU2VydmVyUHJvY2Vzcy53cml0ZSk6IEFsbG93IGNhbGxlciB0byBkaXNhYmxlIGNyYXNo IGZsYWcgb24gZXhjZXB0aW9uLgorCiAyMDE2LTA4LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBFV1Mgc2hvdWxkIGNoZWNrIGlmIHRoZSBwYXRjaCBp cyBzdGlsbCB2YWxpZCBiZWZvcmUgZXhlY3V0aW5nIGV2ZXJ5IG1ham9yIHN0ZXAKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkocmV2aXNpb24gMjA0Mzc0KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkod29ya2luZyBjb3B5KQpAQCAtNDQ0 LDcgKzQ0NCw3IEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAgICAgICAgICAgaWYgY2hpbGRf cHJvY2Vzc19waWQ6CiAgICAgICAgICAgICAgICAgc2VsZi5fcG9ydC5zYW1wbGVfcHJvY2Vzcyhj aGlsZF9wcm9jZXNzX25hbWUsIGNoaWxkX3Byb2Nlc3NfcGlkKQogICAgICAgICAgICAgc2VsZi5l cnJvcl9mcm9tX3Rlc3QgKz0gZXJyb3JfbGluZQotICAgICAgICAgICAgc2VsZi5fc2VydmVyX3By b2Nlc3Mud3JpdGUoJyNTQU1QTEUgRklOSVNIRURcbicpCisgICAgICAgICAgICBzZWxmLl9zZXJ2 ZXJfcHJvY2Vzcy53cml0ZSgnI1NBTVBMRSBGSU5JU0hFRFxuJywgVHJ1ZSkgICMgTXVzdCBiZSBh YmxlIHRvIGlnbm9yZSBhIGJyb2tlbiBwaXBlIGhlcmUsIHRhcmdldCBwcm9jZXNzIG1heSBhbHJl YWR5IGJlIGNsb3NlZC4KICAgICAgICAgICAgIHJldHVybiBUcnVlCiAgICAgICAgIHJldHVybiBz ZWxmLmhhc19jcmFzaGVkKCkKIApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Ry aXZlcl91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvZHJpdmVyX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMDQzNzQpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvZHJpdmVyX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMDYs NyArMjA2LDcgQEAgY2xhc3MgRHJpdmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAg ICAgICBkZWYgc3RvcChzZWxmLCB0aW1lb3V0KToKICAgICAgICAgICAgICAgICBwYXNzCiAKLSAg ICAgICAgICAgIGRlZiB3cml0ZShzZWxmLCBzdHIpOgorICAgICAgICAgICAgZGVmIHdyaXRlKHNl bGYsIGJ5dGVzLCBpZ25vcmVfY3Jhc2g9RmFsc2UpOgogICAgICAgICAgICAgICAgIHBhc3MKIAog ICAgICAgICBkZWYgYXNzZXJ0X2NyYXNoKGRyaXZlciwgZXJyb3JfbGluZSwgY3Jhc2hlZCwgbmFt ZSwgcGlkLCB1bnJlc3BvbnNpdmU9RmFsc2UpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkocmV2aXNpb24gMjA0Mzc0KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0xNDQsNyArMTQ0LDcgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgogICAgICAgICAg ICAgcmV0dXJuIHNlbGYuX3Byb2MucG9sbCgpCiAgICAgICAgIHJldHVybiBOb25lCiAKLSAgICBk ZWYgd3JpdGUoc2VsZiwgYnl0ZXMpOgorICAgIGRlZiB3cml0ZShzZWxmLCBieXRlcywgaWdub3Jl X2NyYXNoPUZhbHNlKToKICAgICAgICAgIiIiV3JpdGUgYSByZXF1ZXN0IHRvIHRoZSBzdWJwcm9j ZXNzLiBUaGUgc3VicHJvY2VzcyBpcyAocmUtKXN0YXJ0KCknZWQKICAgICAgICAgaWYgaXMgbm90 IGFscmVhZHkgcnVubmluZy4iIiIKICAgICAgICAgaWYgbm90IHNlbGYuX3Byb2M6CkBAIC0xNTMs OCArMTUzLDEwIEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mob2JqZWN0KToKICAgICAgICAgICAgIHNl bGYuX3Byb2Muc3RkaW4ud3JpdGUoYnl0ZXMpCiAgICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBlOgog ICAgICAgICAgICAgc2VsZi5zdG9wKDAuMCkKLSAgICAgICAgICAgICMgc3RvcCgpIGNhbGxzIF9y ZXNldCgpLCBzbyB3ZSBoYXZlIHRvIHNldCBjcmFzaGVkIHRvIFRydWUgYWZ0ZXIgY2FsbGluZyBz dG9wKCkuCi0gICAgICAgICAgICBzZWxmLl9jcmFzaGVkID0gVHJ1ZQorICAgICAgICAgICAgIyBz dG9wKCkgY2FsbHMgX3Jlc2V0KCksIHNvIHdlIGhhdmUgdG8gc2V0IGNyYXNoZWQgdG8gVHJ1ZSBh ZnRlciBjYWxsaW5nIHN0b3AoKQorICAgICAgICAgICAgIyB1bmxlc3Mgd2UgYWxyZWFkeSBrbm93 IHRoYXQgdGhpcyBpcyBhIHRpbWVvdXQuCisgICAgICAgICAgICBpZiBub3QgaWdub3JlX2NyYXNo OgorICAgICAgICAgICAgICAgIHNlbGYuX2NyYXNoZWQgPSBUcnVlCiAKICAgICBkZWYgX3BvcF9z dGRvdXRfbGluZV9pZl9yZWFkeShzZWxmKToKICAgICAgICAgaW5kZXhfYWZ0ZXJfbmV3bGluZSA9 IHNlbGYuX291dHB1dC5maW5kKCdcbicpICsgMQo=