160606 2016-08-05 13:46:49 -0700 Implement constrainable type ConstrainDoubleRange 2017-08-30 11:47:15 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build All Other RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 160524 1 gruan gruan cdumez jonlee sam webkit-bug-importer oldest_to_newest 1218041 0 gruan 2016-08-05 13:46:49 -0700 https://w3c.github.io/mediacapture-main/#idl-def-constraindoublerange 1218042 1 webkit-bug-importer 2016-08-05 13:47:52 -0700 <rdar://problem/27725318> 1218046 2 285449 gruan 2016-08-05 14:07:06 -0700 Created attachment 285449 Patch 1218048 3 285449 cdumez 2016-08-05 14:14:20 -0700 Comment on attachment 285449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285449&action=review > Source/WebCore/Modules/mediastream/ConstrainDoubleRange.idl:27 > +Conditional=MEDIA_STREAM, Should be indented. > Source/WebCore/Modules/mediastream/ConstrainDoubleRange.idl:28 > +] dictionary ConstrainDoubleRange : DoubleRange { Can you check the generated bindings, I doubt we support dictionary inheritance currently. > Source/WebCore/Modules/mediastream/DoubleRange.idl:28 > +] dictionary DoubleRange { I am not aware that we support dictionaries defined in their own IDL file. AFAIK, the dictionary needs to be defined in the IDL of the interface where it is used (e.g. MediaDevices.idl). > Source/WebCore/Modules/mediastream/MediaDevices.h:58 > +struct ConstrainDoubleRange : DoubleRange { Shouldn't this be public inheritance? 1218051 4 285449 cdumez 2016-08-05 14:17:20 -0700 Comment on attachment 285449 Patch I don't think it makes sense to add IDL files for which we do not generate any code. 1218052 5 cdumez 2016-08-05 14:18:41 -0700 (In reply to comment #4) > Comment on attachment 285449 [details] > Patch > > I don't think it makes sense to add IDL files for which we do not generate > any code. FYI, Source/WebCore/DerivedSources.make is where we add the IDL files so that we actually generate code for them. However, in your case, you probably don't need additional IDL files if you move those dictionaries to the existing IDL file where they are used. 1218082 6 285457 gruan 2016-08-05 15:45:47 -0700 Created attachment 285457 Patch 1218083 7 285457 cdumez 2016-08-05 15:53:06 -0700 Comment on attachment 285457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285457&action=review > Source/WebCore/ChangeLog:10 > + patch. While this patch seems correct, I am not sure how helpful this is. This adds support for a ConstrainDoubleRange dictionary. However, this type is not used directly. I looked at the specification and there is no API taking a ConstrainDoubleRange. However, there is a MediaTrackConstraintSet dictionary with a member of type ConstrainDouble. ContrainDouble is defined as so: typedef (double or ConstrainDoubleRange) ConstrainDouble; However, since we don't support union types, you'll either need to add support for union types first or more likely use the following: typedef any ConstrainDouble; And do the conversion of this member on native side. In which case the ConstrainDoubleRange type you're adding would not end up being used. 285449 2016-08-05 14:07:06 -0700 2016-08-05 15:45:43 -0700 Patch bug-160606-20160805140539.patch text/plain 7572 gruan U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThhYTUwYjA5NjM0OWQ3 Y2Q4Yjk4OTNkMTZkNTU3ZDNhZDJlMzU4OC4uZGE3NDk0OTQ3YjMzNWQ5ZWY5YzM4ZDM1ZDFmNTZl NTZhNDU0YzkzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA4LTA1ICBHZW9y Z2UgUnVhbiAgPGdydWFuQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgY29uc3RyYWlu YWJsZSB0eXBlIENvbnN0cmFpbkRvdWJsZVJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA2MDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3 NzI1MzE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgY3VycmVudGx5IG5vdCB0ZXN0YWJsZS4gVGVzdHMgd2lsbCBmb2xsb3cg aW4KKyAgICAgICAgYSBmdXR1cmUgcGF0Y2guCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3Ry ZWFtL0NvbnN0cmFpbkRvdWJsZVJhbmdlLmlkbDogQWRkZWQuCisgICAgICAgICogTW9kdWxlcy9t ZWRpYXN0cmVhbS9Eb3VibGVSYW5nZS5pZGw6IEFkZGVkLgorICAgICAgICAqIE1vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFEZXZpY2VzLmg6IEFkZCBDb25zdHJhaW5Eb3VibGVSYW5nZSBhbmQKKyAg ICAgICAgRG91YmxlUmFuZ2Ugc3RydWN0cy4KKyAgICAgICAgKiBXZWJDb3JlLnhjb2RlcHJvai9w cm9qZWN0LnBieHByb2o6CisKIDIwMTYtMDctMjcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBGaXJzdCBwYXJhbWV0ZXIgdG8gSFRNTE1lZGlhRWxlbWVudC5jYW5Q bGF5VHlwZSgpIHNob3VsZCBiZSBtYW5kYXRvcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbWVkaWFzdHJlYW0vQ29uc3RyYWluRG91YmxlUmFuZ2UuaWRsIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Db25zdHJhaW5Eb3VibGVSYW5nZS5pZGwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uOWViMjVmYjE2NGI1Y2I0YmI4Y2ZkMzc4M2MzYTQyNzkwMDJiYWVlYQotLS0gL2Rldi9u dWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vQ29uc3RyYWluRG91 YmxlUmFuZ2UuaWRsCkBAIC0wLDAgKzEsMzEgQEAKKy8qCisqIENvcHlyaWdodCAoQykgMjAxNiBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisqCisqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKKyogYXJlIG1ldDoKKyogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3Qg cmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorKiAyLiBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorKiAg ICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIgaW4gdGhlCisqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisqCisqIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgQVBQTEUgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorKiBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorKiBJTVBM SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIKKyogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEdPT0dM RSBJTkMuIE9SCisqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisqIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorKiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkgVEhFT1JZCisqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyogT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyovCisKK1sK K0NvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKK10gZGljdGlvbmFyeSBDb25zdHJhaW5Eb3VibGVS YW5nZSA6IERvdWJsZVJhbmdlIHsKKyAgICBkb3VibGUgZXhhY3Q7CisgICAgZG91YmxlIGlkZWFs OworfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vRG91 YmxlUmFuZ2UuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Eb3VibGVS YW5nZS5pZGwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYTNhZDQ5NjgyNTJjMWNiNjY5NjdiNzg5ZjQ0Y2M1ODY1YTgz ZGE0NgotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vRG91YmxlUmFuZ2UuaWRsCkBAIC0wLDAgKzEsMzEgQEAKKy8qCisqIENvcHlyaWdodCAoQykg MjAxNiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisqCisqIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorKiBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKKyogYXJlIG1ldDoKKyogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyogICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorKiAyLiBSZWRpc3Ry aWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdo dAorKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIgaW4gdGhlCisqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisqCisqIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorKiBFWFBSRVNTIE9S IElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQor KiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIKKyogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxM IEdPT0dMRSBJTkMuIE9SCisqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1Qs IElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorKiBFWEVNUExBUlksIE9SIENPTlNFUVVF TlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisqIFBST0NVUkVN RU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBP UgorKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFO RCBPTiBBTlkgVEhFT1JZCisqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RS SUNUIExJQUJJTElUWSwgT1IgVE9SVAorKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJX SVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyogT0YgVEhJUyBTT0ZUV0FS RSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyov CisKK1sKK0NvbmRpdGlvbmFsPU1FRElBX1NUUkVBTSwKK10gZGljdGlvbmFyeSBEb3VibGVSYW5n ZSB7CisgICAgZG91YmxlIG1heDsKKyAgICBkb3VibGUgbWluOworfTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFEZXZpY2VzLmggYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRGV2aWNlcy5oCmluZGV4IGQzY2JhNmMw Njc3ZjEyMGYxOTkyMjY4ZGRkZThkNjZjZmEzMjBkOWMuLjc4Mjc1YTBjZmUzYjYzZTJlMGU2YjRk YzAzYzZmMmI3NWI3NTU4MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzdHJlYW0vTWVkaWFEZXZpY2VzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9NZWRpYURldmljZXMuaApAQCAtNTAsNiArNTAsMTYgQEAgY2xhc3MgTWVkaWFUcmFj a1N1cHBvcnRlZENvbnN0cmFpbnRzOwogCiB0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwogCitz dHJ1Y3QgRG91YmxlUmFuZ2UgeworICAgIGRvdWJsZSBtYXg7CisgICAgZG91YmxlIG1pbjsKK307 CisKK3N0cnVjdCBDb25zdHJhaW5Eb3VibGVSYW5nZSA6IERvdWJsZVJhbmdlIHsKKyAgICBkb3Vi bGUgZXhhY3Q7CisgICAgZG91YmxlIGlkZWFsOworfTsKKwogY2xhc3MgTWVkaWFEZXZpY2VzIDog cHVibGljIFNjcmlwdFdyYXBwYWJsZSwgcHVibGljIFJlZkNvdW50ZWQ8TWVkaWFEZXZpY2VzPiwg cHVibGljIENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyIHsKIHB1YmxpYzoKICAgICBzdGF0aWMg UmVmPE1lZGlhRGV2aWNlcz4gY3JlYXRlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCBj ZDY5ODk3NDY5MGNkNmMyNWMwYjI0MjVjYzVmMWY4Mzc3NTM2NDA0Li43N2IyNDU2NzJhMGI3ZjVk N2YxNTA1MDY4NjhjNWQyNjM1YTBhYTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC04NTUxLDYgKzg1NTEsOCBAQAogCQkxQUZF MTE5ODBDQkZGQ0M0MDAzMDE3RkEgLyogSlNTUUxSZXN1bHRTZXRSb3dMaXN0LmggKi8gPSB7aXNh ID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUg PSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9IEpTU1FMUmVzdWx0U2V0Um93TGlzdC5oOyBzb3VyY2VU cmVlID0gIjxncm91cD4iOyB9OwogCQkxQjEyNEQ4QzFEMzgwQjcwMDBFQ0RGQjAgLyogTWVkaWFT YW1wbGVBVkZPYmpDLmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5n ID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgbmFtZSA9IE1lZGlhU2Ft cGxlQVZGT2JqQy5oOyBwYXRoID0gLi4vTWVkaWFTYW1wbGVBVkZPYmpDLmg7IHNvdXJjZVRyZWUg PSAiPGdyb3VwPiI7IH07CiAJCTFCMTI0RDhFMUQzODBCQjYwMEVDREZCMCAvKiBNZWRpYVNhbXBs ZUFWRk9iakMubW0gKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0g NDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5vYmpjcHA7IHBhdGggPSBNZWRp YVNhbXBsZUFWRk9iakMubW07IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCTFCRTc5RDg3 MUQ1NTM0M0EwMEU2MTEzRSAvKiBEb3VibGVSYW5nZS5pZGwgKi8gPSB7aXNhID0gUEJYRmlsZVJl ZmVyZW5jZTsgbGFzdEtub3duRmlsZVR5cGUgPSB0ZXh0OyBwYXRoID0gRG91YmxlUmFuZ2UuaWRs OyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OworCQkxQkU3OUQ4ODFENTUzNDc5MDBFNjExM0Ug LyogQ29uc3RyYWluRG91YmxlUmFuZ2UuaWRsICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7 IGxhc3RLbm93bkZpbGVUeXBlID0gdGV4dDsgcGF0aCA9IENvbnN0cmFpbkRvdWJsZVJhbmdlLmlk bDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJMUMwMTA2RkUxOTI1OTRERjAwOEE0MjAx IC8qIElubGluZVRleHRCb3hTdHlsZS5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsg ZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7 IHBhdGggPSBJbmxpbmVUZXh0Qm94U3R5bGUuY3BwOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9 OwogCQkxQzAxMDZGRjE5MjU5NERGMDA4QTQyMDEgLyogSW5saW5lVGV4dEJveFN0eWxlLmggKi8g PSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmls ZVR5cGUgPSBzb3VyY2Vjb2RlLmMuaDsgcGF0aCA9IElubGluZVRleHRCb3hTdHlsZS5oOyBzb3Vy Y2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkxQzA5MzlFODFBMTNFMTI5MDBCNzg4RTUgLyogQ2Fj aGVkU1ZHRm9udC5jcHAgKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5n ID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBDYWNo ZWRTVkdGb250LmNwcDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKQEAgLTE1NTU3LDYgKzE1 NTU5LDggQEAKIAkJMDcyMjFCNDYxN0NFQzMyNzAwODQ4RTUxIC8qIG1lZGlhc3RyZWFtICovID0g ewogCQkJaXNhID0gUEJYR3JvdXA7CiAJCQljaGlsZHJlbiA9ICgKKwkJCQkxQkU3OUQ4NzFENTUz NDNBMDBFNjExM0UgLyogRG91YmxlUmFuZ2UuaWRsICovLAorCQkJCTFCRTc5RDg4MUQ1NTM0Nzkw MEU2MTEzRSAvKiBDb25zdHJhaW5Eb3VibGVSYW5nZS5pZGwgKi8sCiAJCQkJMkUzQzhDNjYxQkZC RjhFMTAwMzA5NTY2IC8qIENhcHR1cmVEZXZpY2VJbmZvLmggKi8sCiAJCQkJMkUzQzhDNjMxQkZC Qjc1RDAwMzA5NTY2IC8qIENhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcCAqLywKIAkJCQkyRTNDOEM2 MTFCRkJBOERDMDAzMDk1NjYgLyogQ2FwdHVyZURldmljZU1hbmFnZXIuaCAqLywK 285457 2016-08-05 15:45:47 -0700 2016-08-05 15:59:20 -0700 Patch bug-160606-20160805154420.patch text/plain 2976 gruan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWViNjRhNWI1MDdiYTg1 MGIyNWRkZGIxZmM1Y2E5NmU1NmI3ZWE5YS4uMjgzYTIxOWM0N2RmODE1ZmMyNDc3YTc2Yjk2ZWEz M2RhOWU0YjhmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA4LTA1ICBHZW9y Z2UgUnVhbiAgPGdydWFuQGFwcGxlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgY29uc3RyYWlu YWJsZSB0eXBlIENvbnN0cmFpbkRvdWJsZVJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA2MDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3 NzI1MzE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gQ3VycmVudGx5IHVudGVzdGFibGUsIHRlc3RzIHdpbGwgY29tZSBpbiBm dXR1cmUKKyAgICAgICAgcGF0Y2guCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01l ZGlhRGV2aWNlcy5oOiBBZGRlZCBEb3VibGVSYW5nZSBhbmQKKyAgICAgICAgQ29uc3RyYWluRG91 YmxlUmFuZ2UgZGljdGlvbmFyeSBzdHJ1Y3RzLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFEZXZp Y2VzOjpEb3VibGVSYW5nZTo6RG91YmxlUmFuZ2UpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFE ZXZpY2VzOjpDb25zdHJhaW5Eb3VibGVSYW5nZTo6Q29uc3RyYWluRG91YmxlUmFuZ2UpOgorICAg ICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFEZXZpY2VzLmlkbDogQWRkIERvdWJsZVJh bmdlIGFuZAorICAgICAgICBDb25zdHJhaW5Eb3VibGVSYW5nZSBkaWN0aW9uYXJpZXMuCisKIDIw MTYtMDgtMDUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDQxMjguCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRGV2aWNlcy5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYURldmljZXMuaAppbmRleCBkM2NiYTZjMDY3N2Yx MjBmMTk5MjI2OGRkZGU4ZDY2Y2ZhMzIwZDljLi5hYmZmYTJkZTA2ZDUzNGNhY2I0MzJmMDg0YTI1 N2MyZjE0MWMzODcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL01lZGlhRGV2aWNlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vTWVkaWFEZXZpY2VzLmgKQEAgLTUyLDYgKzUyLDI5IEBAIHR5cGVkZWYgaW50IEV4Y2VwdGlv bkNvZGU7CiAKIGNsYXNzIE1lZGlhRGV2aWNlcyA6IHB1YmxpYyBTY3JpcHRXcmFwcGFibGUsIHB1 YmxpYyBSZWZDb3VudGVkPE1lZGlhRGV2aWNlcz4sIHB1YmxpYyBDb250ZXh0RGVzdHJ1Y3Rpb25P YnNlcnZlciB7CiBwdWJsaWM6CisgICAgc3RydWN0IERvdWJsZVJhbmdlIHsKKyAgICAgICAgRG91 YmxlUmFuZ2UoT3B0aW9uYWw8ZG91YmxlPiBtYXggPSBOdWxsb3B0LCBPcHRpb25hbDxkb3VibGU+ IG1pbiA9IE51bGxvcHQpCisgICAgICAgICAgICA6IG1heChtYXgpCisgICAgICAgICAgICAsIG1p bihtaW4pCisgICAgICAgIHsKKyAgICAgICAgfQorCisgICAgICAgIE9wdGlvbmFsPGRvdWJsZT4g bWF4OworICAgICAgICBPcHRpb25hbDxkb3VibGU+IG1pbjsKKyAgICB9OworICAgIAorICAgIHN0 cnVjdCBDb25zdHJhaW5Eb3VibGVSYW5nZSA6IHB1YmxpYyBEb3VibGVSYW5nZSB7CisgICAgICAg IENvbnN0cmFpbkRvdWJsZVJhbmdlKE9wdGlvbmFsPGRvdWJsZT4gbWF4ID0gTnVsbG9wdCwgT3B0 aW9uYWw8ZG91YmxlPiBtaW4gPSBOdWxsb3B0LCBPcHRpb25hbDxkb3VibGU+IGV4YWN0ID0gTnVs bG9wdCwgT3B0aW9uYWw8ZG91YmxlPiBpZGVhbCA9IE51bGxvcHQpCisgICAgICAgICAgICA6IERv dWJsZVJhbmdlKG1heCwgbWluKQorICAgICAgICAgICAgLCBleGFjdChleGFjdCkKKyAgICAgICAg ICAgICwgaWRlYWwoaWRlYWwpCisgICAgICAgIHsKKyAgICAgICAgfQorCisgICAgICAgIE9wdGlv bmFsPGRvdWJsZT4gZXhhY3Q7CisgICAgICAgIE9wdGlvbmFsPGRvdWJsZT4gaWRlYWw7CisgICAg fTsKKwogICAgIHN0YXRpYyBSZWY8TWVkaWFEZXZpY2VzPiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9u Q29udGV4dCopOwogICAgIHZpcnR1YWwgfk1lZGlhRGV2aWNlcygpOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRGV2aWNlcy5pZGwgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhRGV2aWNlcy5pZGwKaW5kZXggOGFk MjMyNDc0NjdjNGE1MzRjZGEzNzkxYWY2NjIyMTkwNGRmNjI5Mi4uYmRlMmVjZjk3YWJmNWNkYjZh NjE3MTAyYzk5YmZjMjQ3NGE1NjU3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYXN0cmVhbS9NZWRpYURldmljZXMuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzdHJlYW0vTWVkaWFEZXZpY2VzLmlkbApAQCAtMzksMyArMzksMTUgQEAKIAogICAg IFtQcml2YXRlSWRlbnRpZmllciwgUmFpc2VzRXhjZXB0aW9uLCBJbXBsZW1lbnRlZEFzPWdldFVz ZXJNZWRpYV0gUHJvbWlzZSBnZXRVc2VyTWVkaWFGcm9tSlMoRGljdGlvbmFyeSBvcHRpb25zKTsK IH07CisKK2RpY3Rpb25hcnkgRG91YmxlUmFuZ2UgeworICAgIGRvdWJsZSBtYXg7CisgICAgZG91 YmxlIG1pbjsKK307CisKK2RpY3Rpb25hcnkgQ29uc3RyYWluRG91YmxlUmFuZ2UgeworICAgIGRv dWJsZSBtYXg7CisgICAgZG91YmxlIG1pbjsKKyAgICBkb3VibGUgZXhhY3Q7CisgICAgZG91Ymxl IGlkZWFsOworfTsK