160453 2016-08-02 09:02:55 -0700 [MathML] Use more auto for local variables 2016-08-02 10:29:00 -0700 1 1 1 Unclassified WebKit MathML WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 159090 1 fred.wang fred.wang commit-queue dbarton esprehn+autocc glenn kondapallykalyan oldest_to_newest 1216496 0 fred.wang 2016-08-02 09:02:55 -0700 Follow-up of bug 159090. This use auto for more variables (mostly string objects). 1216497 1 285113 fred.wang 2016-08-02 09:05:18 -0700 Created attachment 285113 Patch 1216519 2 285113 commit-queue 2016-08-02 10:28:57 -0700 Comment on attachment 285113 Patch Clearing flags on attachment: 285113 Committed r204030: <http://trac.webkit.org/changeset/204030> 1216520 3 commit-queue 2016-08-02 10:29:00 -0700 All reviewed patches have been landed. Closing bug. 285113 2016-08-02 09:05:18 -0700 2016-08-02 10:28:57 -0700 Patch bug-160453-20160802180355.patch text/plain 6503 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjRiODRlYmIzZDZjNDUw YWRkY2M0M2IxNWEwOGIxMDI4ZGM4OTg5MC4uZGZiODRlN2M4MmU4ZTFjNDQwMjMyOWZiZWExYWRk ZWVlMmI3MTEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA4LTAyICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBbTWF0aE1MXSBVc2UgbW9y ZSBhdXRvIGZvciBsb2NhbCB2YXJpYWJsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MDQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3IgaXMgdW5jaGFuZ2VkLgor CisgICAgICAgICogbWF0aG1sL01hdGhNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWF0aE1MRWxlbWVudDo6Y29sU3Bhbik6CisgICAgICAgIChXZWJDb3JlOjpNYXRoTUxFbGVtZW50 Ojpyb3dTcGFuKToKKyAgICAgICAgKFdlYkNvcmU6Ok1hdGhNTEVsZW1lbnQ6OmNoaWxkU2hvdWxk Q3JlYXRlUmVuZGVyZXIpOgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1MRWxlbWVudDo6ZGVmYXVs dEV2ZW50SGFuZGxlcik6CisgICAgICAgICogbWF0aG1sL01hdGhNTFNlbGVjdEVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1MU2VsZWN0RWxlbWVudDo6Z2V0U2VsZWN0ZWRBY3Rp b25DaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpNYXRoTUxTZWxlY3RFbGVtZW50OjpnZXRTZWxl Y3RlZFNlbWFudGljc0NoaWxkKToKKyAgICAgICAgKiByZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1h dGhNTEZlbmNlZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNYXRoTUxGZW5jZWQ6OnVw ZGF0ZUZyb21FbGVtZW50KToKKwogMjAxNi0wNy0yOCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGln YWxpYS5jb20+CiAKICAgICAgICAgTW92ZSBwYXJzaW5nIG9mIHRoZSBmb3JtIGF0dHJpYnV0ZSB0 byBNYXRoTUxPcGVyYXRvckVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hdGht bC9NYXRoTUxFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVtZW50 LmNwcAppbmRleCAxMWY2ZTQ5NTg2NDk4ZWE1ZDZiYWYyMzEzMDUzNzhkZjIwMmY2ZWVhLi45ZTA3 NWNlZTFiNmY4NTY5YTk2ZGE0Yzk3OThhZTA5OThhYWJmNTU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9tYXRobWwvTWF0aE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbWF0 aG1sL01hdGhNTEVsZW1lbnQuY3BwCkBAIC0yMDcsNyArMjA3LDcgQEAgdW5zaWduZWQgTWF0aE1M RWxlbWVudDo6Y29sU3BhbigpIGNvbnN0CiB7CiAgICAgaWYgKCFoYXNUYWdOYW1lKG10ZFRhZykp CiAgICAgICAgIHJldHVybiAxdTsKLSAgICBjb25zdCBBdG9taWNTdHJpbmcmIGNvbFNwYW5WYWx1 ZSA9IGF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oY29sdW1uc3BhbkF0dHIpOworICAg IGF1dG8mIGNvbFNwYW5WYWx1ZSA9IGF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oY29s dW1uc3BhbkF0dHIpOwogICAgIHJldHVybiBzdGQ6Om1heCgxdSwgbGltaXRUb09ubHlIVE1MTm9u TmVnYXRpdmUoY29sU3BhblZhbHVlLCAxdSkpOwogfQogCkBAIC0yMTUsNyArMjE1LDcgQEAgdW5z aWduZWQgTWF0aE1MRWxlbWVudDo6cm93U3BhbigpIGNvbnN0CiB7CiAgICAgaWYgKCFoYXNUYWdO YW1lKG10ZFRhZykpCiAgICAgICAgIHJldHVybiAxdTsKLSAgICBjb25zdCBBdG9taWNTdHJpbmcm IHJvd1NwYW5WYWx1ZSA9IGF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24ocm93c3BhbkF0 dHIpOworICAgIGF1dG8mIHJvd1NwYW5WYWx1ZSA9IGF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6 YXRpb24ocm93c3BhbkF0dHIpOwogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBtYXhSb3dzcGFu ID0gODE5MDsgLy8gVGhpcyBjb25zdGFudCBjb21lcyBmcm9tIEhUTUxUYWJsZUNlbGxFbGVtZW50 LgogICAgIHJldHVybiBzdGQ6Om1heCgxdSwgc3RkOjptaW4obGltaXRUb09ubHlIVE1MTm9uTmVn YXRpdmUocm93U3BhblZhbHVlLCAxdSksIG1heFJvd3NwYW4pKTsKIH0KQEAgLTI4MCw3ICsyODAs NyBAQCB2b2lkIE1hdGhNTEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJp YnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYQogYm9vbCBNYXRoTUxFbGVtZW50OjpjaGlsZFNo b3VsZENyZWF0ZVJlbmRlcmVyKGNvbnN0IE5vZGUmIGNoaWxkKSBjb25zdAogewogICAgIGlmICho YXNUYWdOYW1lKGFubm90YXRpb25feG1sVGFnKSkgewotICAgICAgICBjb25zdCBBdG9taWNTdHJp bmcmIHZhbHVlID0gYXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihNYXRoTUxOYW1lczo6 ZW5jb2RpbmdBdHRyKTsKKyAgICAgICAgYXV0byYgdmFsdWUgPSBhdHRyaWJ1dGVXaXRob3V0U3lu Y2hyb25pemF0aW9uKE1hdGhNTE5hbWVzOjplbmNvZGluZ0F0dHIpOwogCiAgICAgICAgIC8vIFNl ZSBhbm5vdGF0aW9uLXhtbC5tb2RlbC5tYXRobWwsIGFubm90YXRpb24teG1sLm1vZGVsLnN2ZyBh bmQgYW5ub3RhdGlvbi14bWwubW9kZWwueGh0bWwgaW4gdGhlIEhUTUw1IFJlbGF4Tkcgc2NoZW1h LgogCkBAIC0zMzAsMTAgKzMzMCwxMCBAQCB2b2lkIE1hdGhNTEVsZW1lbnQ6OmRlZmF1bHRFdmVu dEhhbmRsZXIoRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAg ICAgICAgIGlmIChNb3VzZUV2ZW50OjpjYW5UcmlnZ2VyQWN0aXZhdGlvbkJlaGF2aW9yKCpldmVu dCkpIHsKLSAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgaHJlZiA9IGF0dHJpYnV0ZVdp dGhvdXRTeW5jaHJvbml6YXRpb24oaHJlZkF0dHIpOwotICAgICAgICAgICAgU3RyaW5nIHVybCA9 IHN0cmlwTGVhZGluZ0FuZFRyYWlsaW5nSFRNTFNwYWNlcyhocmVmKTsKKyAgICAgICAgICAgIGF1 dG8mIGhyZWYgPSBhdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKGhyZWZBdHRyKTsKKyAg ICAgICAgICAgIGNvbnN0IGF1dG8mIHVybCA9IHN0cmlwTGVhZGluZ0FuZFRyYWlsaW5nSFRNTFNw YWNlcyhocmVmKTsKICAgICAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0SGFuZGxlZCgpOwotICAg ICAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50KCkuZnJhbWUoKSkKKyAgICAgICAg ICAgIGlmIChhdXRvKiBmcmFtZSA9IGRvY3VtZW50KCkuZnJhbWUoKSkKICAgICAgICAgICAgICAg ICBmcmFtZS0+bG9hZGVyKCkudXJsU2VsZWN0ZWQoZG9jdW1lbnQoKS5jb21wbGV0ZVVSTCh1cmwp LCAiX3NlbGYiLCBldmVudCwgTG9ja0hpc3Rvcnk6Ok5vLCBMb2NrQmFja0ZvcndhcmRMaXN0OjpO bywgTWF5YmVTZW5kUmVmZXJyZXIsIGRvY3VtZW50KCkuc2hvdWxkT3BlbkV4dGVybmFsVVJMc1Bv bGljeVRvUHJvcGFnYXRlKCkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MU2VsZWN0RWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MU2VsZWN0RWxlbWVudC5jcHAKaW5kZXggYzE0MTRk NDZiMzM3MWY0NzNlMDU0OTQzYWNiYzFlY2Q1MWUzMWQ4NC4uNzFiODMyZTUyMzRjNWQyNGNlYzhk YmYzZjYxMzMxOTI1M2FlNTA5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWF0aG1sL01h dGhNTFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxT ZWxlY3RFbGVtZW50LmNwcApAQCAtMTM2LDcgKzEzNiw3IEBAIEVsZW1lbnQqIE1hdGhNTFNlbGVj dEVsZW1lbnQ6OmdldFNlbGVjdGVkQWN0aW9uQ2hpbGQoKQogICAgICAgICByZXR1cm4gY2hpbGQ7 CiAKICAgICAvLyBUaGUgdmFsdWUgb2YgdGhlIGFjdGlvbnR5cGUgYXR0cmlidXRlIGlzIGNhc2Ut c2Vuc2l0aXZlLgotICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYWN0aW9udHlwZSA9IGF0dHJpYnV0 ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oTWF0aE1MTmFtZXM6OmFjdGlvbnR5cGVBdHRyKTsKKyAg ICBhdXRvJiBhY3Rpb250eXBlID0gYXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihNYXRo TUxOYW1lczo6YWN0aW9udHlwZUF0dHIpOwogICAgIGlmIChhY3Rpb250eXBlID09ICJzdGF0dXNs aW5lIikKICAgICAgICAgLy8gRklYTUU6IGltcGxlbWVudCB1c2VyIGludGVyYWN0aW9uIGZvciB0 aGUgInN0YXR1c2xpbmUiIGFjdGlvbiB0eXBlIChodHRwOi8vd2tidWcvMTI0OTIyKS4KICAgICAg ICAgeyB9CkBAIC0xODUsNyArMTg1LDcgQEAgRWxlbWVudCogTWF0aE1MU2VsZWN0RWxlbWVudDo6 Z2V0U2VsZWN0ZWRTZW1hbnRpY3NDaGlsZCgpCiAgICAgICAgICAgICBpZiAoY2hpbGQtPmhhc0F0 dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oTWF0aE1MTmFtZXM6OnNyY0F0dHIpKQogICAg ICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgLy8gSWYgdGhlIDxhbm5vdGF0aW9u LXhtbD4gZWxlbWVudCBoYXMgYW4gZW5jb2RpbmcgYXR0cmlidXRlIGRlc2NyaWJpbmcgcHJlc2Vu dGF0aW9uIE1hdGhNTCwgU1ZHIG9yIEhUTUwgd2UgYXNzdW1lIHRoZSBjb250ZW50IGNhbiBiZSBk aXNwbGF5ZWQgYW5kIHdlIHN0b3AgaGVyZS4KLSAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmlu ZyYgdmFsdWUgPSBjaGlsZC0+YXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihNYXRoTUxO YW1lczo6ZW5jb2RpbmdBdHRyKTsKKyAgICAgICAgICAgIGF1dG8mIHZhbHVlID0gY2hpbGQtPmF0 dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oTWF0aE1MTmFtZXM6OmVuY29kaW5nQXR0cik7 CiAgICAgICAgICAgICBpZiAoaXNNYXRoTUxFbmNvZGluZyh2YWx1ZSkgfHwgaXNTVkdFbmNvZGlu Zyh2YWx1ZSkgfHwgaXNIVE1MRW5jb2RpbmcodmFsdWUpKQogICAgICAgICAgICAgICAgIHJldHVy biBjaGlsZDsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L21hdGhtbC9SZW5kZXJNYXRoTUxGZW5jZWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L21hdGhtbC9SZW5kZXJNYXRoTUxGZW5jZWQuY3BwCmluZGV4IGIxODQ1Y2ExODIxMDk3YTlkM2Ux MGFjZGIwNjU2ZGExNmYzYTEzN2YuLjM4MzcyMTlkZWM3OTMyMDkyMzBiNzdmZDIxYjQxMzM5ZjNh MzVmYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVy TWF0aE1MRmVuY2VkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1Jl bmRlck1hdGhNTEZlbmNlZC5jcHAKQEAgLTU0LDE0ICs1NCwxNCBAQCB2b2lkIFJlbmRlck1hdGhN TEZlbmNlZDo6dXBkYXRlRnJvbUVsZW1lbnQoKQogICAgIGNvbnN0IGF1dG8mIGZlbmNlZCA9IGVs ZW1lbnQoKTsKIAogICAgIC8vIFRoZSBvcGVuIG9wZXJhdG9yIGRlZmF1bHRzIHRvIGEgbGVmdCBw YXJlbnRoZXNpcy4KLSAgICBBdG9taWNTdHJpbmcgb3BlbiA9IGZlbmNlZC5hdHRyaWJ1dGVXaXRo b3V0U3luY2hyb25pemF0aW9uKE1hdGhNTE5hbWVzOjpvcGVuQXR0cik7CisgICAgYXV0byYgb3Bl biA9IGZlbmNlZC5hdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKE1hdGhNTE5hbWVzOjpv cGVuQXR0cik7CiAgICAgbV9vcGVuID0gb3Blbi5pc051bGwoKSA/IGdPcGVuaW5nQnJhY2VDaGFy IDogb3BlbjsKIAogICAgIC8vIFRoZSBjbG9zZSBvcGVyYXRvciBkZWZhdWx0cyB0byBhIHJpZ2h0 IHBhcmVudGhlc2lzLgotICAgIEF0b21pY1N0cmluZyBjbG9zZSA9IGZlbmNlZC5hdHRyaWJ1dGVX aXRob3V0U3luY2hyb25pemF0aW9uKE1hdGhNTE5hbWVzOjpjbG9zZUF0dHIpOworICAgIGF1dG8m IGNsb3NlID0gZmVuY2VkLmF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oTWF0aE1MTmFt ZXM6OmNsb3NlQXR0cik7CiAgICAgbV9jbG9zZSA9IGNsb3NlLmlzTnVsbCgpID8gZ0Nsb3NpbmdC cmFjZUNoYXIgOiBjbG9zZTsKIAotICAgIEF0b21pY1N0cmluZyBzZXBhcmF0b3JzID0gZmVuY2Vk LmF0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oTWF0aE1MTmFtZXM6OnNlcGFyYXRvcnNB dHRyKTsKKyAgICBhdXRvJiBzZXBhcmF0b3JzID0gZmVuY2VkLmF0dHJpYnV0ZVdpdGhvdXRTeW5j aHJvbml6YXRpb24oTWF0aE1MTmFtZXM6OnNlcGFyYXRvcnNBdHRyKTsKICAgICBpZiAoIXNlcGFy YXRvcnMuaXNOdWxsKCkpIHsKICAgICAgICAgU3RyaW5nQnVpbGRlciBjaGFyYWN0ZXJzOwogICAg ICAgICBmb3IgKHVuc2lnbmVkIGludCBpID0gMDsgaSA8IHNlcGFyYXRvcnMubGVuZ3RoKCk7IGkr Kykgewo=