16032 2007-11-17 14:07:47 -0800 JS minidom is not portable 2007-11-17 15:20:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 16029 1 alp webkit-unassigned darin oldest_to_newest 61479 0 alp 2007-11-17 14:07:47 -0800 JavaScriptCore/API/minidom.c is not portable. It has a trivial dependency on CFString and is missing a couple of includes. JavaScriptCore.h also needs to be fixed as described in #16029 for this to actually build on non-CF platforms. 61482 1 17330 alp 2007-11-17 14:33:32 -0800 Created attachment 17330 Make minidom.c portable Note that it will not actually compile until JavaScriptCore.h is also fixed (see #16029) 61483 2 17331 alp 2007-11-17 15:02:24 -0800 Created attachment 17331 Make minidom.c portable This also fixes exception output which was being sent to stderr instead of stdout. 61484 3 17331 eric 2007-11-17 15:05:29 -0800 Comment on attachment 17331 Make minidom.c portable Looks fine to me. r=me. 61485 4 alp 2007-11-17 15:15:21 -0800 Landed in r27879. 61487 5 17330 darin 2007-11-17 15:20:35 -0800 Comment on attachment 17330 Make minidom.c portable Looks fine. It's going to be tricky to make this truly platform-independent though, because Mac OS X uses a special include style for frameworks (#include <JavaScriptCore/JavaScriptCore.h>), and I would not expect the library to work this way on other platforms. 17330 2007-11-17 14:33:32 -0800 2007-11-17 15:20:35 -0800 Make minidom.c portable minidom-fix.patch text/plain 2072 alp SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODc4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMTEtMTcgIEFscCBUb2tl ciAgPGFscEBhdG9rZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDMy CisgICAgICAgIEpTIG1pbmlkb20gaXMgbm90IHBvcnRhYmxlCisKKyAgICAgICAgVXNlIGEgcGxh aW4gVVRGLTggc3RyaW5nIGluc3RlYWQgb2YgYSBDRlN0cmluZy4KKworICAgICAgICBQcmludCB0 byBzdGRlcnIgdG8gbWF0Y2ggdGhlIGZ1bmN0aW9uYWxpdHkgb2YgQ0ZTaG93KCkuCisKKyAgICAg ICAgKiBBUEkvbWluaWRvbS5jOgorICAgICAgICAobWFpbik6CisKIDIwMDctMTEtMTcgIFN0ZXZl IEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxk IGZpeC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0FQSS9taW5pZG9tLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvQVBJL21pbmlkb20uYwkocmV2aXNpb24gMjc4NzgpCisrKyBKYXZhU2Ny aXB0Q29yZS9BUEkvbWluaWRvbS5jCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNyBAQAogLy8g LSotIG1vZGU6IGMrKzsgYy1iYXNpYy1vZmZzZXQ6IDQgLSotCiAvKgogICogQ29weXJpZ2h0IChD KSAyMDA2IEFwcGxlIENvbXB1dGVyLCBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29w eXJpZ2h0IChDKSAyMDA3IEFscCBUb2tlciA8YWxwQGF0b2tlci5jb20+CiAgKgogICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTI1LDYgKzI2LDggQEAKICAqLwogCiAjaW5jbHVkZSAiSlNO b2RlLmgiCisjaW5jbHVkZSA8c3RkaW8uaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRl IDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogCkBAIC01 Niw5ICs1OSwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgIGVsc2Ug ewogICAgICAgICBwcmludGYoIkZBSUw6IFRlc3Qgc2NyaXB0IHRocmV3IGV4Y2VwdGlvbjpcbiIp OwogICAgICAgICBKU1N0cmluZ1JlZiBleGNlcHRpb25JU3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5n Q29weShjb250ZXh0LCBleGNlcHRpb24sIE5VTEwpOwotICAgICAgICBDRlN0cmluZ1JlZiBleGNl cHRpb25DRiA9IEpTU3RyaW5nQ29weUNGU3RyaW5nKGtDRkFsbG9jYXRvckRlZmF1bHQsIGV4Y2Vw dGlvbklTdHJpbmcpOwotICAgICAgICBDRlNob3coZXhjZXB0aW9uQ0YpOwotICAgICAgICBDRlJl bGVhc2UoZXhjZXB0aW9uQ0YpOworICAgICAgICBzaXplX3QgZXhjZXB0aW9uVVRGOFNpemUgPSBK U1N0cmluZ0dldE1heGltdW1VVEY4Q1N0cmluZ1NpemUoZXhjZXB0aW9uSVN0cmluZyk7CisgICAg ICAgIGNoYXIqIGV4Y2VwdGlvblVURjggPSAoY2hhciopbWFsbG9jKGV4Y2VwdGlvblVURjhTaXpl KTsKKyAgICAgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhleGNlcHRpb25JU3RyaW5nLCBleGNl cHRpb25VVEY4LCBleGNlcHRpb25VVEY4U2l6ZSk7CisgICAgICAgIGZwcmludGYoc3RkZXJyLCAi JXNcbiIsIGV4Y2VwdGlvblVURjgpOworICAgICAgICBmcmVlKGV4Y2VwdGlvblVURjgpOwogICAg ICAgICBKU1N0cmluZ1JlbGVhc2UoZXhjZXB0aW9uSVN0cmluZyk7CiAgICAgfQogICAgIEpTU3Ry aW5nUmVsZWFzZShzY3JpcHQpOwo= 17331 2007-11-17 15:02:24 -0800 2007-11-17 15:05:29 -0800 Make minidom.c portable minidom-fix-2.patch text/plain 2117 alp SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODc4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEtMTcgIEFscCBUb2tl ciAgPGFscEBhdG9rZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDMy CisgICAgICAgIEpTIG1pbmlkb20gaXMgbm90IHBvcnRhYmxlCisKKyAgICAgICAgVXNlIGEgcGxh aW4gVVRGLTggc3RyaW5nIGluc3RlYWQgb2YgYSBDRlN0cmluZy4KKworICAgICAgICBQcmludCB0 byBzdGRvdXQsIG5vdCBzdGRlcnIgbGlrZSBDRlNob3coKSB3b3VsZCBoYXZlIGRvbmUsIHNpbmNl IHRoYXQKKyAgICAgICAgYmVoYXZpb3VyIHNlZW1zIHVuaW50ZW50aW9uYWwuCisKKyAgICAgICAg KiBBUEkvbWluaWRvbS5jOgorICAgICAgICAobWFpbik6CisKIDIwMDctMTEtMTcgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZp eC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0FQSS9taW5pZG9tLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2 YVNjcmlwdENvcmUvQVBJL21pbmlkb20uYwkocmV2aXNpb24gMjc4NzgpCisrKyBKYXZhU2NyaXB0 Q29yZS9BUEkvbWluaWRvbS5jCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNyBAQAogLy8gLSot IG1vZGU6IGMrKzsgYy1iYXNpYy1vZmZzZXQ6IDQgLSotCiAvKgogICogQ29weXJpZ2h0IChDKSAy MDA2IEFwcGxlIENvbXB1dGVyLCBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDA3IEFscCBUb2tlciA8YWxwQGF0b2tlci5jb20+CiAgKgogICogUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKQEAgLTI1LDYgKzI2LDggQEAKICAqLwogCiAjaW5jbHVkZSAiSlNOb2Rl LmgiCisjaW5jbHVkZSA8c3RkaW8uaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDx3 dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogCkBAIC01Niw5 ICs1OSwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgIGVsc2Ugewog ICAgICAgICBwcmludGYoIkZBSUw6IFRlc3Qgc2NyaXB0IHRocmV3IGV4Y2VwdGlvbjpcbiIpOwog ICAgICAgICBKU1N0cmluZ1JlZiBleGNlcHRpb25JU3RyaW5nID0gSlNWYWx1ZVRvU3RyaW5nQ29w eShjb250ZXh0LCBleGNlcHRpb24sIE5VTEwpOwotICAgICAgICBDRlN0cmluZ1JlZiBleGNlcHRp b25DRiA9IEpTU3RyaW5nQ29weUNGU3RyaW5nKGtDRkFsbG9jYXRvckRlZmF1bHQsIGV4Y2VwdGlv bklTdHJpbmcpOwotICAgICAgICBDRlNob3coZXhjZXB0aW9uQ0YpOwotICAgICAgICBDRlJlbGVh c2UoZXhjZXB0aW9uQ0YpOworICAgICAgICBzaXplX3QgZXhjZXB0aW9uVVRGOFNpemUgPSBKU1N0 cmluZ0dldE1heGltdW1VVEY4Q1N0cmluZ1NpemUoZXhjZXB0aW9uSVN0cmluZyk7CisgICAgICAg IGNoYXIqIGV4Y2VwdGlvblVURjggPSAoY2hhciopbWFsbG9jKGV4Y2VwdGlvblVURjhTaXplKTsK KyAgICAgICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhleGNlcHRpb25JU3RyaW5nLCBleGNlcHRp b25VVEY4LCBleGNlcHRpb25VVEY4U2l6ZSk7CisgICAgICAgIHByaW50ZigiJXNcbiIsIGV4Y2Vw dGlvblVURjgpOworICAgICAgICBmcmVlKGV4Y2VwdGlvblVURjgpOwogICAgICAgICBKU1N0cmlu Z1JlbGVhc2UoZXhjZXB0aW9uSVN0cmluZyk7CiAgICAgfQogICAgIEpTU3RyaW5nUmVsZWFzZShz Y3JpcHQpOwo=