160080 2016-07-22 03:06:27 -0700 Fix the Windows 64-bit build after r203537 2016-07-22 08:56:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 159649 1 ossy pvollan achristensen benjamin bfulgham commit-queue keith_miller mark.lam msaboff pvollan saam oldest_to_newest 1213534 0 ossy 2016-07-22 03:06:27 -0700 https://trac.webkit.org/changeset/203537 broke the 64-bit Windows build, the only one 64 bit Windows bot is the WinCairo bot: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/59268 C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\JavaScriptCore\jit\CCallHelpers.h(2259): error C2664: 'void JSC::CCallHelpers::setupArgumentsWithExecState(JSC::JSValueRegs,JSC::JSValueRegs,JSC::AbstractMacroAssembler<JSC::X86Assembler,JSC::MacroAssemblerX86Common>::TrustedImmPtr,JSC::AbstractMacroAssembler<JSC::X86Assembler,JSC::MacroAssemblerX86Common>::TrustedImmPtr)': cannot convert argument 3 from 'JSC::AbstractMacroAssembler<JSC::X86Assembler,JSC::MacroAssemblerX86Common>::TrustedImmPtr' to 'JSC::GPRReg' C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Source\JavaScriptCore\jit\CCallHelpers.h(2259): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called (not: I don't plan to investigate this bug, just reported to let you know) 1213572 1 284335 pvollan 2016-07-22 08:24:51 -0700 Created attachment 284335 Patch 1213573 2 284335 ossy 2016-07-22 08:25:36 -0700 Comment on attachment 284335 Patch rs=me 1213575 3 pvollan 2016-07-22 08:35:25 -0700 Thanks for reviewing :) 1213578 4 284335 commit-queue 2016-07-22 08:56:19 -0700 Comment on attachment 284335 Patch Clearing flags on attachment: 284335 Committed r203600: <http://trac.webkit.org/changeset/203600> 1213579 5 commit-queue 2016-07-22 08:56:23 -0700 All reviewed patches have been landed. Closing bug. 284335 2016-07-22 08:24:51 -0700 2016-07-22 08:56:19 -0700 Patch bug-160080-20160722082352.patch text/plain 1426 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzNTk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTA3LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggdGhlIFdpbmRvd3MgNjQtYml0IGJ1aWxkIGFmdGVyIHIyMDM1MzcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDA4MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG5ldyB2ZXJzaW9u IG9mIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSBtZXRob2QuCisKKyAgICAgICAgKiBqaXQv Q0NhbGxIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OkNDYWxsSGVscGVyczo6c2V0dXBBcmd1bWVu dHNXaXRoRXhlY1N0YXRlKToKKwogMjAxNi0wNy0yMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtBUk1dIFVucmV2aWV3ZWQgRUFCSSBidWlsZGZpeCBh ZnRlciByMjAzNTM3LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBl cnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVy cy5oCShyZXZpc2lvbiAyMDM1OTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxs SGVscGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzg5LDYgKzE3ODksMTIgQEAgcHVibGljOgog ICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CiAg ICAgfQogCisgICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0 ZShHUFJSZWcgYXJnMSwgR1BSUmVnIGFyZzIsIFRydXN0ZWRJbW1QdHIgYXJnMywgVHJ1c3RlZElt bVB0ciBhcmc0KQorICAgIHsKKyAgICAgICAgcG9rZShhcmc0LCBQT0tFX0FSR1VNRU5UX09GRlNF VCk7CisgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBhcmcyLCBhcmcz KTsKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVudHNXaXRoRXhl Y1N0YXRlKEdQUlJlZyBhcmcxLCBHUFJSZWcgYXJnMiwgVHJ1c3RlZEltbTMyIGFyZzMsIEdQUlJl ZyBhcmc0KQogICAgIHsKICAgICAgICAgcG9rZShhcmc0LCBQT0tFX0FSR1VNRU5UX09GRlNFVCk7 Cg==