159297 2016-06-30 06:42:25 -0700 [image-decoders] Make ImageDecoder::size() lazily decode the image if needed to return a valid size 2016-07-03 23:31:10 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159089 P2 Normal --- 1 cgarcia webkit-unassigned sabouhallawa tonikitoo oldest_to_newest 1206703 0 cgarcia 2016-06-30 06:42:25 -0700 It's otherwise confusing leading to bugs like #159089. 1206705 1 282434 cgarcia 2016-06-30 06:46:32 -0700 Created attachment 282434 Patch 1206807 2 282434 sabouhallawa 2016-06-30 12:28:14 -0700 Comment on attachment 282434 Patch Looks good to me. Unofficial r=me. 1206812 3 282434 tonikitoo 2016-06-30 12:36:57 -0700 Comment on attachment 282434 Patch Thanks Said. 1207575 4 cgarcia 2016-07-03 23:31:10 -0700 Committed r202800: <http://trac.webkit.org/changeset/202800> 282434 2016-06-30 06:46:32 -0700 2016-06-30 12:36:57 -0700 Patch wcore-image-decoder-size.diff text/plain 5491 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZWQ0MDIxLi4wZjQwMDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYg QEAKIDIwMTYtMDYtMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtpbWFnZS1kZWNvZGVyc10gTWFrZSBJbWFnZURlY29kZXI6OnNpemUoKSBs YXppbHkgZGVjb2RlIHRoZSBpbWFnZSBpZiBuZWVkZWQgdG8gcmV0dXJuIGEgdmFsaWQgc2l6ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5Mjk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBvdGhl cndpc2UgY29uZnVzaW5nIGxlYWRpbmcgdG8gYnVncyBsaWtlICMxNTkwODkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29kZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW1hZ2VEZWNvZGVyOjpjcmVhdGVGcmFtZUltYWdlQXRJbmRleCk6IENoZWNrIHRoZSBz aXplIGF0IHRoZSBiZWdpbm5pbmcgYW5kIHJldHVybiBlYXJseSBpZiBpdCdzCisgICAgICAgIGVt cHR5LiBXZSBubyBsb25nZXIgbmVlZCB0byBjaGVjayB0aGUgc2l6ZSBhZnRlciBjYWxsaW5nIGZy YW1lQnVmZmVyQXRJbmRleCgpLgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0lt YWdlRGVjb2Rlci5oOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyOjpzaXplKTogQ2hl Y2sgZmlyc3QgaXMgc2l6ZSBpcyBhdmFpbGFibGUsIHdoaWNoIGxhemlseSBkZWNvZGVzIHRoZSBp bWFnZS4KKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVjb2Rlcjo6c2NhbGVkU2l6ZSk6IFJlbW92 ZSBjb25zdC4KKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRGVjb2Rlcjo6ZnJhbWVTaXplQXRJbmRl eCk6IERpdHRvLgorICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFn ZURlY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SUNPSW1hZ2VEZWNvZGVyOjpzaXplKTog RGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpJQ09JbWFnZURlY29kZXI6OmZyYW1lU2l6ZUF0SW5k ZXgpOiBEaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9pY28vSUNPSW1h Z2VEZWNvZGVyLmg6CisKKzIwMTYtMDYtMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtpbWFnZS1kZWNvZGVyc10gVXNlIGZpbmFsIGFuZCBv dmVycmlkZSBpbiBJbWFnZURlY29kZXIgc3ViY2xhc3NlcwogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5MjkxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29kZXIuY3BwCmluZGV4IDZm YzFhMjIuLjIxNzUzYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL0ltYWdlRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcApAQCAtMzEyLDExICszMTIsMTIgQEAgZmxv YXQgSW1hZ2VEZWNvZGVyOjpmcmFtZUR1cmF0aW9uQXRJbmRleChzaXplX3QgaW5kZXgpCiAKIE5h dGl2ZUltYWdlUHRyIEltYWdlRGVjb2Rlcjo6Y3JlYXRlRnJhbWVJbWFnZUF0SW5kZXgoc2l6ZV90 IGluZGV4LCBTdWJzYW1wbGluZ0xldmVsKQogewotICAgIEltYWdlRnJhbWUqIGJ1ZmZlciA9IGZy YW1lQnVmZmVyQXRJbmRleChpbmRleCk7CiAgICAgLy8gWmVyby1oZWlnaHQgaW1hZ2VzIGNhbiBj YXVzZSBwcm9ibGVtcyBmb3Igc29tZSBwb3J0cy4gSWYgd2UgaGF2ZSBhbiBlbXB0eSBpbWFnZSBk aW1lbnNpb24sIGp1c3QgYmFpbC4KLSAgICAvLyBJdCdzIGltcG9ydGFudCB0byBjaGVjayB0aGUg c2l6ZSBhZnRlciBjYWxsaW5nIGZyYW1lQnVmZmVyQXRJbmRleCgpIHRvIGVuc3VyZSB0aGUgZGVj b2RlciBoYXMgdXBkYXRlZCB0aGUgc2l6ZS4KLSAgICAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTA4OS4KLSAgICBpZiAoIWJ1ZmZlciB8fCBidWZmZXIt PnN0YXR1cygpID09IEltYWdlRnJhbWU6OkZyYW1lRW1wdHkgfHwgc2l6ZSgpLmlzRW1wdHkoKSkK KyAgICBpZiAoc2l6ZSgpLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAg ICBJbWFnZUZyYW1lKiBidWZmZXIgPSBmcmFtZUJ1ZmZlckF0SW5kZXgoaW5kZXgpOworICAgIGlm ICghYnVmZmVyIHx8IGJ1ZmZlci0+c3RhdHVzKCkgPT0gSW1hZ2VGcmFtZTo6RnJhbWVFbXB0eSkK ICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKICAgICAvLyBSZXR1cm4gdGhlIGJ1ZmZlciBjb250 ZW50cyBhcyBhIG5hdGl2ZSBpbWFnZS4gRm9yIHNvbWUgcG9ydHMsIHRoZSBkYXRhCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29kZXIu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5o CmluZGV4IGQxNmY0ODQuLjJmOGVlZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oCkBAIC0yNzEsOSArMjcxLDkgQEAg dXNpbmcgQ29sb3JQcm9maWxlID0gVmVjdG9yPGNoYXI+OwogICAgICAgICAgICAgcmV0dXJuICFt X2ZhaWxlZCAmJiBtX3NpemVBdmFpbGFibGU7CiAgICAgICAgIH0KIAotICAgICAgICB2aXJ0dWFs IEludFNpemUgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc2l6ZTsgfQorICAgICAgICB2aXJ0dWFs IEludFNpemUgc2l6ZSgpIHsgcmV0dXJuIGlzU2l6ZUF2YWlsYWJsZSgpID8gbV9zaXplIDogSW50 U2l6ZSgpOyB9CiAKLSAgICAgICAgSW50U2l6ZSBzY2FsZWRTaXplKCkgY29uc3QKKyAgICAgICAg SW50U2l6ZSBzY2FsZWRTaXplKCkKICAgICAgICAgewogICAgICAgICAgICAgcmV0dXJuIG1fc2Nh bGVkID8gSW50U2l6ZShtX3NjYWxlZENvbHVtbnMuc2l6ZSgpLCBtX3NjYWxlZFJvd3Muc2l6ZSgp KSA6IHNpemUoKTsKICAgICAgICAgfQpAQCAtMjgzLDcgKzI4Myw3IEBAIHVzaW5nIENvbG9yUHJv ZmlsZSA9IFZlY3RvcjxjaGFyPjsKICAgICAgICAgLy8gc2l6ZXMuICBUaGlzIGRvZXMgTk9UIGRp ZmZlciBmcm9tIHNpemUoKSBmb3IgR0lGLCBzaW5jZSBkZWNvZGluZyBHSUZzCiAgICAgICAgIC8v IGNvbXBvc2l0ZXMgYW55IHNtYWxsZXIgZnJhbWVzIGFnYWluc3QgcHJldmlvdXMgZnJhbWVzIHRv IGNyZWF0ZSBmdWxsLQogICAgICAgICAvLyBzaXplIGZyYW1lcy4KLSAgICAgICAgdmlydHVhbCBJ bnRTaXplIGZyYW1lU2l6ZUF0SW5kZXgoc2l6ZV90LCBTdWJzYW1wbGluZ0xldmVsKSBjb25zdAor ICAgICAgICB2aXJ0dWFsIEludFNpemUgZnJhbWVTaXplQXRJbmRleChzaXplX3QsIFN1YnNhbXBs aW5nTGV2ZWwpCiAgICAgICAgIHsKICAgICAgICAgICAgIHJldHVybiBzaXplKCk7CiAgICAgICAg IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2lj by9JQ09JbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVj b2RlcnMvaWNvL0lDT0ltYWdlRGVjb2Rlci5jcHAKaW5kZXggZWI0ZGFhNC4uYTU5MjAxYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvaWNvL0lDT0lt YWdlRGVjb2Rlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2Rl cnMvaWNvL0lDT0ltYWdlRGVjb2Rlci5jcHAKQEAgLTc4LDEyICs3OCwxMiBAQCBib29sIElDT0lt YWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkKICAgICByZXR1cm4gSW1hZ2VEZWNvZGVyOjpp c1NpemVBdmFpbGFibGUoKTsKIH0KIAotSW50U2l6ZSBJQ09JbWFnZURlY29kZXI6OnNpemUoKSBj b25zdAorSW50U2l6ZSBJQ09JbWFnZURlY29kZXI6OnNpemUoKQogewogICAgIHJldHVybiBtX2Zy YW1lU2l6ZS5pc0VtcHR5KCkgPyBJbWFnZURlY29kZXI6OnNpemUoKSA6IG1fZnJhbWVTaXplOwog fQogCi1JbnRTaXplIElDT0ltYWdlRGVjb2Rlcjo6ZnJhbWVTaXplQXRJbmRleChzaXplX3QgaW5k ZXgsIFN1YnNhbXBsaW5nTGV2ZWwpIGNvbnN0CitJbnRTaXplIElDT0ltYWdlRGVjb2Rlcjo6ZnJh bWVTaXplQXRJbmRleChzaXplX3QgaW5kZXgsIFN1YnNhbXBsaW5nTGV2ZWwpCiB7CiAgICAgcmV0 dXJuIChpbmRleCAmJiAoaW5kZXggPCBtX2RpckVudHJpZXMuc2l6ZSgpKSkgPyBtX2RpckVudHJp ZXNbaW5kZXhdLm1fc2l6ZSA6IHNpemUoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFnZURlY29kZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL2ljby9JQ09JbWFnZURlY29kZXIuaAppbmRl eCA1NWVlMTI2Li41ODBjNjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9pY28vSUNPSW1hZ2VEZWNvZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvaWNvL0lDT0ltYWdlRGVjb2Rlci5oCkBAIC00Nyw4ICs0 Nyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgU3RyaW5nIGZpbGVuYW1lRXh0ZW5z aW9uKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gImljbyI7IH0KICAgICAgICAgdm9pZCBzZXRE YXRhKFNoYXJlZEJ1ZmZlciYsIGJvb2wgYWxsRGF0YVJlY2VpdmVkKSBvdmVycmlkZTsKICAgICAg ICAgYm9vbCBpc1NpemVBdmFpbGFibGUoKSBvdmVycmlkZTsKLSAgICAgICAgSW50U2l6ZSBzaXpl KCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgICAgIEludFNpemUgZnJhbWVTaXplQXRJbmRleChzaXpl X3QsIFN1YnNhbXBsaW5nTGV2ZWwpIGNvbnN0IG92ZXJyaWRlOworICAgICAgICBJbnRTaXplIHNp emUoKSBvdmVycmlkZTsKKyAgICAgICAgSW50U2l6ZSBmcmFtZVNpemVBdEluZGV4KHNpemVfdCwg U3Vic2FtcGxpbmdMZXZlbCkgb3ZlcnJpZGU7CiAgICAgICAgIGJvb2wgc2V0U2l6ZSh1bnNpZ25l ZCB3aWR0aCwgdW5zaWduZWQgaGVpZ2h0KSBvdmVycmlkZTsKICAgICAgICAgc2l6ZV90IGZyYW1l Q291bnQoKSBvdmVycmlkZTsKICAgICAgICAgSW1hZ2VGcmFtZSogZnJhbWVCdWZmZXJBdEluZGV4 KHNpemVfdCkgb3ZlcnJpZGU7Cg==