159205 2016-06-28 02:42:26 -0700 AX: Remove dead code for RenderText and RenderMathMLOperator in AccessibilityRenderObject::textUnderElement 2016-06-28 07:17:01 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 139582 155018 1 fred.wang fred.wang aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1205970 0 fred.wang 2016-06-28 02:42:26 -0700 RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token elements. Hence the code in AccessibilityRenderObject::textUnderElement to handle this specific render tree structure is never executed and can be safely removed. 1205971 1 webkit-bug-importer 2016-06-28 02:42:47 -0700 <rdar://problem/27051681> 1205974 2 282232 fred.wang 2016-06-28 02:48:40 -0700 Created attachment 282232 Patch 1206022 3 fred.wang 2016-06-28 07:17:01 -0700 Committed r202562: <http://trac.webkit.org/changeset/202562> 282232 2016-06-28 02:48:40 -0700 2016-06-28 06:36:12 -0700 Patch bug-159205-20160628114823.patch text/plain 2580 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE5MGMyNDE3Yjc3MzY1 MjMyYTBmZmVhODQ1Mjc2YzJjMjc1Nzg0Yi4uZTRlYzhmM2NjNzgwZDhmMzRkM2JmNDJiODg4OGQx M2FmOTBjZjQyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA2LTI4ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogUmVtb3ZlIGRlYWQg Y29kZSBpbiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0ZXh0VW5kZXJFbGVtZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTkyMDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJNYXRoTUxP cGVyYXRvciB1c2VkIHRvIGRlc3Ryb3kgaXRzIGRlc2NlbmRhbnRzIGFuZCB0byByZXBsYWNlIHRo ZW0gd2l0aCBhbiBhbm9ueW1vdXMKKyAgICAgICAgdGV4dCBub2RlIHdyYXBwZWQgaW5zaWRlIGFu b255bW91cyBibG9ja3MuIEFmdGVyIHIyMDI0MjAsIGl0IGp1c3QgYmVoYXZlcyBhcyBhbnkgb3Ro ZXIgdG9rZW4KKyAgICAgICAgZWxlbWVudHMuIEhlbmNlIHdlIHJlbW92ZSB0aGUgY29kZSBpbiBB Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojp0ZXh0VW5kZXJFbGVtZW50IHRoYXQgd2FzCisgICAg ICAgIHVzZWQgdG8gaGFuZGxlIHRoaXMgc3BlY2lmaWMgcmVuZGVyIHRyZWUgc3RydWN0dXJlLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5IGFjY2Vzc2liaWxpdHkv bWF0aC10ZXh0Lmh0bWwuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdDo6dGV4dFVuZGVyRWxlbWVudCk6IFJlbW92ZSBkZWFkIGNvZGUgZm9yIFJlbmRlclRleHQg YW5kIFJlbmRlck1hdGhNTE9wZXJhdG9yLgorCiAyMDE2LTA2LTI4ICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBCaW5kaW5nIGdlbmVyYXRvciBzaG91bGQgZ2Vu ZXJhdGUgYWNjZXNzb3JzIGZvciBjb25zdHJ1Y3RvcnMgc2FmZWx5IGFjY2Vzc2VkIGZyb20gSlMg YnVpbHRpbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKaW5kZXggMDFlOWVhNzFhMmI3NmFkNDdhMDYwMTM3 YmNiNjZlNDk2N2YzYWNkMy4uNmUxNmFlMmE5OTY4MDkwYjI4ODliNzVkMWNkZTA3Mzc2ZDJlNzQz MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 UmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCkBAIC02MzIsMTYgKzYzMiwxMCBAQCBTdHJpbmcgQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGV4dFVuZGVyRWxlbWVudChBY2Nlc3NpYmlsaXR5VGV4 dFVuZGVyRWxlbWVudAogICAgIGJvb2wgaXNSZW5kZXJUZXh0ID0gaXM8UmVuZGVyVGV4dD4oKm1f cmVuZGVyZXIpOwogCiAjaWYgRU5BQkxFKE1BVEhNTCkKLSAgICAvLyBNYXRoIG9wZXJhdG9ycyBj cmVhdGUgUmVuZGVyVGV4dCBub2RlcyBvbiB0aGUgZmx5IHRoYXQgYXJlIG5vdCB0aWVkIGludG8g dGhlIERPTSBpbiBhIHJlYXNvbmFibGUgd2F5LAotICAgIC8vIHNvIHJhbmdlT2ZDb250ZW50cyBk b2VzIG5vdCB3b3JrIGZvciB0aGVtIChub3IgZG9lcyByZWd1bGFyIHRleHQgc2VsZWN0aW9uKS4K LSAgICBpZiAoaXNSZW5kZXJUZXh0ICYmIG1fcmVuZGVyZXItPmlzQW5vbnltb3VzKCkgJiYgYW5j ZXN0b3JzT2ZUeXBlPFJlbmRlck1hdGhNTE9wZXJhdG9yPigqbV9yZW5kZXJlcikuZmlyc3QoKSkK LSAgICAgICAgcmV0dXJuIGRvd25jYXN0PFJlbmRlclRleHQ+KCptX3JlbmRlcmVyKS50ZXh0KCk7 CiAgICAgaWYgKGlzQW5vbnltb3VzTWF0aE9wZXJhdG9yKCkpIHsKICAgICAgICAgVUNoYXIgb3Bl cmF0b3JDaGFyID0gZG93bmNhc3Q8UmVuZGVyTWF0aE1MT3BlcmF0b3I+KCptX3JlbmRlcmVyKS50 ZXh0Q29udGVudCgpOwogICAgICAgICByZXR1cm4gb3BlcmF0b3JDaGFyID8gU3RyaW5nKCZvcGVy YXRvckNoYXIsIDEpIDogU3RyaW5nKCk7CiAgICAgfQotICAgIGlmIChpczxSZW5kZXJNYXRoTUxP cGVyYXRvcj4oKm1fcmVuZGVyZXIpICYmICFtX3JlbmRlcmVyLT5pc0Fub255bW91cygpKQotICAg ICAgICByZXR1cm4gZG93bmNhc3Q8UmVuZGVyTWF0aE1MT3BlcmF0b3I+KCptX3JlbmRlcmVyKS5l bGVtZW50KCkudGV4dENvbnRlbnQoKTsKICNlbmRpZgogCiAgICAgaWYgKHNob3VsZEdldFRleHRG cm9tTm9kZShtb2RlKSkK