159108 2016-06-24 16:42:42 -0700 B3 should die sooner if a Value has the wrong number of children 2016-06-24 17:04:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1205264 0 fpizlo 2016-06-24 16:42:42 -0700 Patch forthcoming. 1205266 1 282031 fpizlo 2016-06-24 16:46:05 -0700 Created attachment 282031 the patch 1205269 2 commit-queue 2016-06-24 16:48:08 -0700 Attachment 282031 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3Value.h:373: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3Value.h:379: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3Value.h:385: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3Value.h:391: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/b3/B3Value.h:397: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1205272 3 282031 mark.lam 2016-06-24 16:50:36 -0700 Comment on attachment 282031 the patch r=me 1205279 4 fpizlo 2016-06-24 17:04:30 -0700 Landed in https://trac.webkit.org/changeset/202463 282031 2016-06-24 16:46:05 -0700 2016-06-24 16:50:36 -0700 the patch blah.patch text/plain 7389 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAyNDYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE2LTA2LTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QjMgc2hvdWxkIGRpZSBzb29uZXIgaWYgYSBWYWx1ZSBoYXMgdGhlIHdyb25nIG51bWJlciBvZiBj aGlsZHJlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU5MTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBJJ3ZlIGJlZW4gbG9va2luZyBhdCBhIGJ1ZyAocmRhcjovL3Byb2JsZW0vMjY1MDA3 NDMpIHRoYXQncyBhYm91dCBhIFZlY3RvciBPT0IgY3Jhc2ggaW4KKyAgICAgICAgUmVkdWNlU3Ry ZW5ndGg6OnJhbmdlRm9yKCkuIFRoZSBvbmx5IFZlY3RvciBhY2Nlc3NlcyBhcmUgdG8gVmFsdWU6 Om1fY2hpbGRyZW4sIGFuZCBhbGwgb2YKKyAgICAgICAgdGhlIGFjY2Vzc2VzIGluIHJhbmdlRm9y KCkgYXJlIGZvciBjaGlsZCgwKSBvciBjaGlsZCgxKSBvZiBiaW5hcnkgYXJpdGhtZXRpYyBvcGNv ZGVzLgorICAgICAgICBDbGVhcmx5IHRob3NlIHNob3VsZCBuZXZlciBnbyBvdXQtb2YtYm91bmRz LgorICAgICAgICAKKyAgICAgICAgTWF5YmUgd2UgaGF2ZSBob3JyaWJsZSBtZW1vcnkgY29ycnVw dGlvbi4gT3IgbWF5YmUgc29tZSBwYXRoIGNyZWF0ZXMgYSBWYWx1ZSB3aXRoIHRoZQorICAgICAg ICB3cm9uZyBudW1iZXIgb2YgY2hpbGRyZW4sIGFuZCB0aGF0IHBhdGggaXMgbm90IHRlc3RlZCBi eSBhbnkgb2Ygb3VyIHRlc3RzLiBUaGlzIHBhdGNoIGFkZHMKKyAgICAgICAgcmVsZWFzZSBhc3Nl cnRpb25zIHRoYXQgd2lsbCBjYXRjaCB0aGUgbGF0dGVyLgorICAgICAgICAKKyAgICAgICAgSSd2 ZSB0ZXN0ZWQgdGhpcyBhIGxvdC4gSXQncyBub3QgYSByZWdyZXNzaW9uIG9uIG91ciBiZW5jaG1h cmtzLgorCisgICAgICAgICogYjMvQjNPcGNvZGUuaDoKKyAgICAgICAgKiBiMy9CM1ZhbHVlLmNw cDoKKyAgICAgICAgKEpTQzo6QjM6OlZhbHVlOjpkdW1wTWV0YSk6CisgICAgICAgIChKU0M6OkIz OjpWYWx1ZTo6dHlwZUZvcik6CisgICAgICAgIChKU0M6OkIzOjpWYWx1ZTo6YmFkT3Bjb2RlKToK KyAgICAgICAgKEpTQzo6QjM6OlZhbHVlOjpjaGVja09wY29kZSk6IERlbGV0ZWQuCisgICAgICAg ICogYjMvQjNWYWx1ZS5oOgorCiAyMDE2LTA2LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBbSlNDXSBFcnJvciBwcm90b3R5cGVzIGFyZSBjYWxsZWQgb24gcmVt b3RlIHNjcmlwdHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNPcGNvZGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNPcGNvZGUuaAkocmV2aXNp b24gMjAyNDA2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzT3Bjb2RlLmgJKHdvcmtp bmcgY29weSkKQEAgLTI2NSw3ICsyNjUsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogY2xhc3MgUHJp bnRTdHJlYW07CiAKLXZvaWQgcHJpbnRJbnRlcm5hbChQcmludFN0cmVhbSYsIEpTQzo6QjM6Ok9w Y29kZSk7CitKU19FWFBPUlRfUFJJVkFURSB2b2lkIHByaW50SW50ZXJuYWwoUHJpbnRTdHJlYW0m LCBKU0M6OkIzOjpPcGNvZGUpOwogCiB9IC8vIG5hbWVzcGFjZSBXVEYKIApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL0IzVmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy9CM1ZhbHVlLmNwcAkocmV2aXNpb24gMjAyNDA2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL0IzVmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MzMsMjUgKzYz Myw2IEBAIHZvaWQgVmFsdWU6OmR1bXBNZXRhKENvbW1hUHJpbnRlciYsIFByaW4KIHsKIH0KIAot I2lmICFBU1NFUlRfRElTQUJMRUQKLXZvaWQgVmFsdWU6OmNoZWNrT3Bjb2RlKE9wY29kZSBvcGNv ZGUpCi17Ci0gICAgQVNTRVJUKCFBcmd1bWVudFJlZ1ZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwot ICAgIEFTU0VSVCghQ0NhbGxWYWx1ZTo6YWNjZXB0cyhvcGNvZGUpKTsKLSAgICBBU1NFUlQoIUNo ZWNrVmFsdWU6OmFjY2VwdHMob3Bjb2RlKSk7Ci0gICAgQVNTRVJUKCFDb25zdDMyVmFsdWU6OmFj Y2VwdHMob3Bjb2RlKSk7Ci0gICAgQVNTRVJUKCFDb25zdDY0VmFsdWU6OmFjY2VwdHMob3Bjb2Rl KSk7Ci0gICAgQVNTRVJUKCFDb25zdERvdWJsZVZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwotICAg IEFTU0VSVCghQ29uc3RGbG9hdFZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwotICAgIEFTU0VSVCgh Q29udHJvbFZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwotICAgIEFTU0VSVCghTWVtb3J5VmFsdWU6 OmFjY2VwdHMob3Bjb2RlKSk7Ci0gICAgQVNTRVJUKCFQYXRjaHBvaW50VmFsdWU6OmFjY2VwdHMo b3Bjb2RlKSk7Ci0gICAgQVNTRVJUKCFTbG90QmFzZVZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwot ICAgIEFTU0VSVCghVXBzaWxvblZhbHVlOjphY2NlcHRzKG9wY29kZSkpOwotICAgIEFTU0VSVCgh VmFyaWFibGVWYWx1ZTo6YWNjZXB0cyhvcGNvZGUpKTsKLX0KLSNlbmRpZiAvLyAhQVNTRVJUX0RJ U0FCTEVECi0KIFR5cGUgVmFsdWU6OnR5cGVGb3IoT3Bjb2RlIG9wY29kZSwgVmFsdWUqIGZpcnN0 Q2hpbGQsIFZhbHVlKiBzZWNvbmRDaGlsZCkKIHsKICAgICBzd2l0Y2ggKG9wY29kZSkgewpAQCAt NzI5LDYgKzcxMCwxMiBAQCBUeXBlIFZhbHVlOjp0eXBlRm9yKE9wY29kZSBvcGNvZGUsIFZhbHVl CiAgICAgfQogfQogCit2b2lkIFZhbHVlOjpiYWRPcGNvZGUoT3Bjb2RlIG9wY29kZSwgdW5zaWdu ZWQgbnVtQXJncykKK3sKKyAgICBkYXRhTG9nKCJCYWQgb3Bjb2RlICIsIG9wY29kZSwgIiB3aXRo ICIsIG51bUFyZ3MsICIgYXJncy5cbiIpOworICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE KCk7Cit9CisKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpCMwogCiAjZW5kaWYgLy8gRU5BQkxFKEIz X0pJVCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1ZhbHVlLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzVmFsdWUuaAkocmV2aXNpb24gMjAyNDA2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzVmFsdWUuaAkod29ya2luZyBjb3B5KQpA QCAtMjM1LDExICsyMzUsNzEgQEAgcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgU3BhcnNlQ29s bGVjdGlvbjxWYWx1ZT47CiAKICAgICAvLyBDaGVja3MgdGhhdCB0aGlzIG9wY29kZSBpcyB2YWxp ZCBmb3IgdXNlIHdpdGggQjM6OlZhbHVlLgotI2lmIEFTU0VSVF9ESVNBQkxFRAotICAgIHN0YXRp YyB2b2lkIGNoZWNrT3Bjb2RlKE9wY29kZSkgeyB9Ci0jZWxzZQotICAgIHN0YXRpYyB2b2lkIGNo ZWNrT3Bjb2RlKE9wY29kZSk7Ci0jZW5kaWYKKyAgICBBTFdBWVNfSU5MSU5FIHN0YXRpYyB2b2lk IGNoZWNrT3Bjb2RlKE9wY29kZSBvcGNvZGUsIHVuc2lnbmVkIG51bUFyZ3MpCisgICAgeworICAg ICAgICBzd2l0Y2ggKG9wY29kZSkgeworICAgICAgICBjYXNlIEZyYW1lUG9pbnRlcjoKKyAgICAg ICAgY2FzZSBOb3A6CisgICAgICAgIGNhc2UgUGhpOgorICAgICAgICAgICAgaWYgKFVOTElLRUxZ KG51bUFyZ3MpKQorICAgICAgICAgICAgICAgIGJhZE9wY29kZShvcGNvZGUsIG51bUFyZ3MpOwor ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgSWRlbnRpdHk6CisgICAgICAgIGNhc2Ug TmVnOgorICAgICAgICBjYXNlIENsejoKKyAgICAgICAgY2FzZSBBYnM6CisgICAgICAgIGNhc2Ug Q2VpbDoKKyAgICAgICAgY2FzZSBGbG9vcjoKKyAgICAgICAgY2FzZSBTcXJ0OgorICAgICAgICBj YXNlIFNFeHQ4OgorICAgICAgICBjYXNlIFNFeHQxNjoKKyAgICAgICAgY2FzZSBUcnVuYzoKKyAg ICAgICAgY2FzZSBTRXh0MzI6CisgICAgICAgIGNhc2UgWkV4dDMyOgorICAgICAgICBjYXNlIEZs b2F0VG9Eb3VibGU6CisgICAgICAgIGNhc2UgSVRvRDoKKyAgICAgICAgY2FzZSBEb3VibGVUb0Zs b2F0OgorICAgICAgICBjYXNlIElUb0Y6CisgICAgICAgIGNhc2UgQml0d2lzZUNhc3Q6CisgICAg ICAgICAgICBpZiAoVU5MSUtFTFkobnVtQXJncyAhPSAxKSkKKyAgICAgICAgICAgICAgICBiYWRP cGNvZGUob3Bjb2RlLCBudW1BcmdzKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNl IEFkZDoKKyAgICAgICAgY2FzZSBTdWI6CisgICAgICAgIGNhc2UgTXVsOgorICAgICAgICBjYXNl IERpdjoKKyAgICAgICAgY2FzZSBNb2Q6CisgICAgICAgIGNhc2UgQ2hpbGxEaXY6CisgICAgICAg IGNhc2UgQ2hpbGxNb2Q6CisgICAgICAgIGNhc2UgQml0QW5kOgorICAgICAgICBjYXNlIEJpdE9y OgorICAgICAgICBjYXNlIEJpdFhvcjoKKyAgICAgICAgY2FzZSBTaGw6CisgICAgICAgIGNhc2Ug U1NocjoKKyAgICAgICAgY2FzZSBaU2hyOgorICAgICAgICBjYXNlIEVxdWFsOgorICAgICAgICBj YXNlIE5vdEVxdWFsOgorICAgICAgICBjYXNlIExlc3NUaGFuOgorICAgICAgICBjYXNlIEdyZWF0 ZXJUaGFuOgorICAgICAgICBjYXNlIExlc3NFcXVhbDoKKyAgICAgICAgY2FzZSBHcmVhdGVyRXF1 YWw6CisgICAgICAgIGNhc2UgQWJvdmU6CisgICAgICAgIGNhc2UgQmVsb3c6CisgICAgICAgIGNh c2UgQWJvdmVFcXVhbDoKKyAgICAgICAgY2FzZSBCZWxvd0VxdWFsOgorICAgICAgICBjYXNlIEVx dWFsT3JVbm9yZGVyZWQ6CisgICAgICAgICAgICBpZiAoVU5MSUtFTFkobnVtQXJncyAhPSAyKSkK KyAgICAgICAgICAgICAgICBiYWRPcGNvZGUob3Bjb2RlLCBudW1BcmdzKTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICBjYXNlIFNlbGVjdDoKKyAgICAgICAgICAgIGlmIChVTkxJS0VMWShu dW1BcmdzICE9IDMpKQorICAgICAgICAgICAgICAgIGJhZE9wY29kZShvcGNvZGUsIG51bUFyZ3Mp OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBiYWRP cGNvZGUob3Bjb2RlLCBudW1BcmdzKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9Cisg ICAgfQogCiBwcm90ZWN0ZWQ6CiAgICAgZW51bSBDaGVja2VkT3Bjb2RlVGFnIHsgQ2hlY2tlZE9w Y29kZSB9OwpAQCAtMzA5LDEwICszNjksMzQgQEAgcHJvdGVjdGVkOgogICAgIC8vIFRoaXMgaXMg dGhlIGNvbnN0cnVjdG9yIHlvdSBlbmQgdXAgYWN0dWFsbHkgY2FsbGluZywgaWYgeW91J3JlIGlu c3RhbnRpYXRpbmcgVmFsdWUKICAgICAvLyBkaXJlY3RseS4KICAgICB0ZW1wbGF0ZTx0eXBlbmFt ZS4uLiBBcmd1bWVudHM+Ci0gICAgZXhwbGljaXQgVmFsdWUoT3Bjb2RlIG9wY29kZSwgQXJndW1l bnRzJiYuLi4gYXJndW1lbnRzKQotICAgICAgICA6IFZhbHVlKENoZWNrZWRPcGNvZGUsIG9wY29k ZSwgc3RkOjpmb3J3YXJkPEFyZ3VtZW50cz4oYXJndW1lbnRzKS4uLikKKyAgICAgICAgZXhwbGlj aXQgVmFsdWUoT3Bjb2RlIG9wY29kZSwgVHlwZSB0eXBlLCBPcmlnaW4gb3JpZ2luKQorICAgICAg ICA6IFZhbHVlKENoZWNrZWRPcGNvZGUsIG9wY29kZSwgdHlwZSwgb3JpZ2luKQorICAgIHsKKyAg ICAgICAgY2hlY2tPcGNvZGUob3Bjb2RlLCAwKTsKKyAgICB9CisgICAgdGVtcGxhdGU8dHlwZW5h bWUuLi4gQXJndW1lbnRzPgorICAgICAgICBleHBsaWNpdCBWYWx1ZShPcGNvZGUgb3Bjb2RlLCBU eXBlIHR5cGUsIE9yaWdpbiBvcmlnaW4sIFZhbHVlKiBmaXJzdENoaWxkLCBBcmd1bWVudHMmJi4u LiBhcmd1bWVudHMpCisgICAgICAgIDogVmFsdWUoQ2hlY2tlZE9wY29kZSwgb3Bjb2RlLCB0eXBl LCBvcmlnaW4sIGZpcnN0Q2hpbGQsIHN0ZDo6Zm9yd2FyZDxBcmd1bWVudHM+KGFyZ3VtZW50cyku Li4pCisgICAgeworICAgICAgICBjaGVja09wY29kZShvcGNvZGUsIDEgKyBzaXplb2YuLi4oYXJn dW1lbnRzKSk7CisgICAgfQorICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3VtZW50cz4KKyAg ICAgICAgZXhwbGljaXQgVmFsdWUoT3Bjb2RlIG9wY29kZSwgVHlwZSB0eXBlLCBPcmlnaW4gb3Jp Z2luLCBjb25zdCBBZGphY2VuY3lMaXN0JiBjaGlsZHJlbikKKyAgICAgICAgOiBWYWx1ZShDaGVj a2VkT3Bjb2RlLCBvcGNvZGUsIHR5cGUsIG9yaWdpbiwgY2hpbGRyZW4pCiAgICAgewotICAgICAg ICBjaGVja09wY29kZShvcGNvZGUpOworICAgICAgICBjaGVja09wY29kZShvcGNvZGUsIGNoaWxk cmVuLnNpemUoKSk7CisgICAgfQorICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3VtZW50cz4K KyAgICAgICAgZXhwbGljaXQgVmFsdWUoT3Bjb2RlIG9wY29kZSwgVHlwZSB0eXBlLCBPcmlnaW4g b3JpZ2luLCBBZGphY2VuY3lMaXN0JiYgY2hpbGRyZW4pCisgICAgICAgIDogVmFsdWUoQ2hlY2tl ZE9wY29kZSwgb3Bjb2RlLCB0eXBlLCBvcmlnaW4sIFdURk1vdmUoY2hpbGRyZW4pKQorICAgIHsK KyAgICAgICAgY2hlY2tPcGNvZGUob3Bjb2RlLCBtX2NoaWxkcmVuLnNpemUoKSk7CisgICAgfQor ICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3VtZW50cz4KKyAgICAgICAgZXhwbGljaXQgVmFs dWUoT3Bjb2RlIG9wY29kZSwgT3JpZ2luIG9yaWdpbiwgQXJndW1lbnRzJiYuLi4gYXJndW1lbnRz KQorICAgICAgICA6IFZhbHVlKENoZWNrZWRPcGNvZGUsIG9wY29kZSwgb3JpZ2luLCBzdGQ6OmZv cndhcmQ8QXJndW1lbnRzPihhcmd1bWVudHMpLi4uKQorICAgIHsKKyAgICAgICAgY2hlY2tPcGNv ZGUob3Bjb2RlLCBzaXplb2YuLi4oYXJndW1lbnRzKSk7CiAgICAgfQogCiBwcml2YXRlOgpAQCAt MzMwLDYgKzQxNCw4IEBAIHByaXZhdGU6CiAgICAgT3JpZ2luIG1fb3JpZ2luOwogICAgIEFkamFj ZW5jeUxpc3QgbV9jaGlsZHJlbjsKIAorICAgIEpTX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9E VUVfVE9fQ1JBU0ggc3RhdGljIHZvaWQgYmFkT3Bjb2RlKE9wY29kZSwgdW5zaWduZWQpOworCiBw dWJsaWM6CiAgICAgQmFzaWNCbG9jayogb3duZXIgeyBudWxscHRyIH07IC8vIGNvbXB1dGVkIGJ5 IFByb2NlZHVyZTo6cmVzZXRWYWx1ZU93bmVycygpLgogfTsK