158888 2016-06-17 14:31:39 -0700 LinkBuffer should place a nop sled at the end of the code it generates when it generates code into already allocated executable memory and the assembly it memcpy is smaller than the allocated size 2016-06-17 17:35:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED DUPLICATE 158719 P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1203423 0 saam 2016-06-17 14:31:39 -0700 I don't think this comes up at all now, but it's probably the right contract for the API to have. 1203424 1 ggaren 2016-06-17 14:33:54 -0700 Can we do a breakpoint sled instead? NOP sleds can be attack vectors because you can jump into the middle of them. But breakpoint sleds crash. 1203426 2 fpizlo 2016-06-17 14:35:07 -0700 (In reply to comment #1) > Can we do a breakpoint sled instead? NOP sleds can be attack vectors because > you can jump into the middle of them. But breakpoint sleds crash. That would mean that if an IC emits less code than the allowed size, we would crash at a breakpoint. A nop sled means that if an IC emits less code than the allowed size, it runs correctly. 1203432 3 ggaren 2016-06-17 14:45:40 -0700 I see. OK. 1203487 4 saam 2016-06-17 17:35:59 -0700 This will be fixed as part of another bug *** This bug has been marked as a duplicate of bug 158719 ***