158782 2016-06-15 06:29:15 -0700 `all: unset` prevents `color` from being set 2020-04-04 00:21:45 -0700 1 1 1 Unclassified WebKit CSS Safari 9 Unspecified All RESOLVED DUPLICATE 193171 https://bugs.webkit.org/show_bug.cgi?id=193171 BrowserCompat, InRadar P2 Normal --- 1 me jh718.park ashvayka dino esprehn+autocc ews-watchlist glenn graouts gusgarzaki gyuyoung.kim jaffathecake jh718.park joepeck koivisto macpherson menard pvollan rob simon.fraser vepomoc webkit-bug-importer oldest_to_newest 1202553 0 281356 me 2016-06-15 06:29:15 -0700 Created attachment 281356 Example of broken `color` with `all: unset` When `all: unset` is defined, the color value is set to black and cannot be changed with future CSS color declarations. This works in Chrome. 1467998 1 jaffathecake 2018-10-11 03:39:47 -0700 I just ran into this issue too. Another demo: https://jsbin.com/noselib/edit?css,output 1483867 2 rob 2018-11-30 17:24:20 -0800 I’m also running into this in an HTML diffing tool I work on — we use some CSS like: ins.our-special-differ, del.our-special-differ { all: unset; } to make sure there are no conflicting styles on <ins>/<del> elements, and then use a script to adjust the text colors in order to make sure they have enough contrast with the green/red backgrounds of the insertions and deletions. We can't adjust the text color on Safari with this bug, though. 1492084 3 simon.fraser 2019-01-05 11:26:46 -0800 This is happening because the "all: unset" is setting -webkit-text-fill-color to black, and that overrides color. 1492085 4 simon.fraser 2019-01-05 11:34:25 -0800 ... and our initial value for -webkit-text-fill-color isn't 'current color', as it should be if it followed fill-color. 1492086 5 simon.fraser 2019-01-05 11:34:38 -0800 ^ 'currentcolor' 1492087 6 simon.fraser 2019-01-05 11:49:20 -0800 I guess this is really about how 'currentColor' inherits. The initial value of -webkit-text-fill-color on the root element is 'currentColor', and "all:unset" on the body should thefefore set -webkit-text-fill-color to "inherit" which should inherit currentColor as the keyword, rather than the resolved color value (according to the new currentColor inheritance rules in https://drafts.csswg.org/css-color/#resolving-color-values). 1513020 7 gusgarzaki 2019-03-06 04:05:34 -0800 Blink had this issue before too, as described in it's bug tacker: https://bugs.chromium.org/p/chromium/issues/detail?id=420781 I don't see any reason why this cannot be patched. 1533212 8 webkit-bug-importer 2019-05-04 07:59:39 -0700 <rdar://problem/50471104> 1543562 9 jh718.park 2019-06-10 19:08:13 -0700 (In reply to Gustavo Millasaky from comment #7) > Blink had this issue before too, as described in it's bug tacker: > https://bugs.chromium.org/p/chromium/issues/detail?id=420781 > > I don't see any reason why this cannot be patched. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-fill-color says, "The -webkit-text-fill-color CSS property specifies the fill color of characters of text. If this property is not set, the value of the color property is used." In case of Blink, they drop the support for -webkit-text-fill-color. But WebKit still maintain the support for the css property, so as long as WebKit keep the support this behavior will be maintained as it is currently. The decision whether to keep this property or not should be discussed in WebKit community through this jira comments or via webkit-dev mailing list I think. If community want to keep this property in WebKit then we could resolve this issue as wontfix, otherwise we could drop the support for -webkit-text-fill-color for interoperability I guess. 1543567 10 jh718.park 2019-06-10 19:25:43 -0700 I saw the blocking issue for this one, and as Simon commented, if currentcolor works as keyword then this issue can be resolved. So it seems that dropping -webkit-text-fill-color is nothing to do with this issue. I will take the blocking issue to solve this one. 1543573 11 jh718.park 2019-06-10 19:42:57 -0700 To be clear, Blink still support -webkit-text-fill-color. 1631779 12 394006 ashvayka 2020-03-19 12:50:25 -0700 Created attachment 394006 Patch 1631971 13 394006 simon.fraser 2020-03-19 20:06:13 -0700 Comment on attachment 394006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394006&action=review > Source/WebCore/css/CSSProperties.json:6315 > + "no-default-color": true What's the justification for using this for -webkit-text-fill-color, but not, say, -webkit-text-stroke-color, -webkit-text-emphasis-color, text-decoration-color etc? 1631985 14 jh718.park 2020-03-19 20:41:17 -0700 (In reply to Alexey Shvayka from comment #12) > Created attachment 394006 [details] > Patch Hi, Alexey, I think the root cause is 'currentcolor', as Simon said in comment #6. I'm currently working on https://bugs.webkit.org/show_bug.cgi?id=107380, and as soon as it is done I will work on https://bugs.webkit.org/show_bug.cgi?id=193171, which is the bug for 'currentcolor'. So I think it could be good to see this issue's state after having the 'currentcolor' behavior follow the spec in comment #6. 1636483 15 graouts 2020-04-01 07:46:05 -0700 *** Bug 209854 has been marked as a duplicate of this bug. *** 1637305 16 394006 koivisto 2020-04-03 04:29:24 -0700 Comment on attachment 394006 Patch The right fix here is make 'currentcolor' work correctly. 1637660 17 koivisto 2020-04-04 00:21:45 -0700 *** This bug has been marked as a duplicate of bug 193171 *** 281356 2016-06-15 06:29:15 -0700 2016-06-15 06:29:15 -0700 Example of broken `color` with `all: unset` all-unset-color.html text/html 291 me PGh0bWw+CiAgPGhlYWQ+CiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgICBib2R5IHsK ICAgICAgICBhbGw6IHVuc2V0OwogICAgICAgIGNvbG9yOiByZWQ7CiAgICAgICAgYmFja2dyb3Vu ZDogbGltZTsKICAgICAgfQogICAgICAvKiBIaWdoZXIgc3BlY2lmaWNpdHkgZG9lc24ndCBoZWxw ICovCiAgICAgIDpyb290IGJvZHkgewogICAgICAgIGNvbG9yOiByZWQ7CiAgICAgIH0KICAgIDwv c3R5bGU+CiAgPC9oZWFkPgogIDxib2R5PgogICAgVGhpcyBpcyBhIHRlc3QKICA8L2JvZHk+Cjwv aHRtbD4K 394006 2020-03-19 12:50:25 -0700 2020-04-03 04:29:24 -0700 Patch bug-158782-20200319215024.patch text/plain 5026 ashvayka SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODcwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAzLTE5ICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKworICAgICAgICBgYWxsOiB1bnNldGAg cHJldmVudHMgYGNvbG9yYCBmcm9tIGJlaW5nIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4NzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHRoaXMgY2hhbmdlLCBgYWxsOiB1bnNldGAg aGFkIG5vIGVmZmVjdCBvbiBgY29sb3JgIGlmIHRoZXJlIHdhcyBhbiBhbmNlc3RvciB3aXRoCisg ICAgICAgIGBjb2xvcmAgc2V0LiBUaGF0IHdhcyBoYXBwZW5pbmcgYmVjYXVzZSBgLXdlYmtpdC10 ZXh0LWZpbGwtY29sb3JgIGEpIGhhcyBwcmVjZWRlbmNlIG92ZXIKKyAgICAgICAgYGNvbG9yYCBh bmQgYikgZmFsbHMgYmFjayB0byB2YWx1ZSBvZiBwYXJlbnQncyBgY29sb3JgIChub3QgYGN1cnJl bnRDb2xvcmApIHdoZW4gaW5oZXJpdHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRo aXMgZmFsbGJhY2ssIGFsaWduaW5nIGJlaGF2aW9yIG9mIGAtd2Via2l0LXRleHQtZmlsbC1jb2xv cjogaW5oZXJpdGAKKyAgICAgICAgd2l0aCBCbGluayBhbmQgR2Vja28sIGFuZCBtYWtlcyBgYWxs YCBwcm9wZXJ0eSB3b3JrIHdpdGggYGNvbG9yYCBjb3JyZWN0bHkuCisKKyAgICAgICAgVGVzdHM6 IGZhc3QvY3NzL3dlYmtpdC10ZXh0LWZpbGwtY29sb3ItaW5oZXJpdC5odG1sCisgICAgICAgICAg ICAgICBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtY2FzY2FkZS9hbGwt cHJvcC1pbmhlcml0LWNvbG9yLmh0bWwKKyAgICAgICAgICAgICAgIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1jYXNjYWRlL2FsbC1wcm9wLXJldmVydC1jb2xvci5odG1s CisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt Y2FzY2FkZS9hbGwtcHJvcC11bnNldC1jb2xvci5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUHJv cGVydGllcy5qc29uOiBFbmFibGUgIm5vLWRlZmF1bHQtY29sb3IiIGZvciAiLXdlYmtpdC10ZXh0 LWZpbGwtY29sb3IiLgorCiAyMDIwLTAzLTE5ICBBbmRyZXMgR29uemFsZXogIDxhbmRyZXNnXzIy QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgcmVt b3RlQWNjZXNzaWJpbGl0eVBhcmVudE9iamVjdF0gbXVzdCBydW4gb24gdGhlIG1haW4gdGhyZWFk LgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1Byb3BlcnRpZXMuanNvbgo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydGllcy5qc29uCShyZXZpc2lvbiAyNTg2 ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJvcGVydGllcy5qc29uCSh3b3JraW5nIGNv cHkpCkBAIC02MzExLDcgKzYzMTEsOCBAQAogICAgICAgICAgICAgImluaGVyaXRlZCI6IHRydWUs CiAgICAgICAgICAgICAiY29kZWdlbi1wcm9wZXJ0aWVzIjogewogICAgICAgICAgICAgICAgICJp bml0aWFsIjogImludmFsaWRDb2xvciIsCi0gICAgICAgICAgICAgICAgInZpc2l0ZWQtbGluay1j b2xvci1zdXBwb3J0IjogdHJ1ZQorICAgICAgICAgICAgICAgICJ2aXNpdGVkLWxpbmstY29sb3It c3VwcG9ydCI6IHRydWUsCisgICAgICAgICAgICAgICAgIm5vLWRlZmF1bHQtY29sb3IiOiB0cnVl CiAgICAgICAgICAgICB9LAogICAgICAgICAgICAgInN0YXR1cyI6IHsKICAgICAgICAgICAgICAg ICAic3RhdHVzIjogIm5vbi1zdGFuZGFyZCIsCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTg2ODkpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAor MjAyMC0wMy0xOSAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5jb20+CisKKyAg ICAgICAgYGFsbDogdW5zZXRgIHByZXZlbnRzIGBjb2xvcmAgZnJvbSBiZWluZyBzZXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODc4MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1h a2VzIGAtd2Via2l0LXRleHQtZmlsbC1jb2xvcjogaW5oZXJpdGAgaWdub3JlIHBhcmVudCdzIGBj b2xvcmAgdmFsdWUsCisgICAgICAgIGFsaWduaW5nIFdlYktpdCB3aXRoIEJsaW5rIGFuZCBHZWNr by4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IE1hcmsgMyB0ZXN0IGNhc2VzIGFzIHBh c3NpbmcuCisgICAgICAgICogZmFzdC9jc3Mvd2Via2l0LXRleHQtZmlsbC1jb2xvci1pbmhlcml0 LWV4cGVjdGVkLmh0bWw6CisgICAgICAgICogZmFzdC9jc3Mvd2Via2l0LXRleHQtZmlsbC1jb2xv ci1pbmhlcml0Lmh0bWw6CisKIDIwMjAtMDMtMTkgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nLgpJbmRleDogTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9UZXN0 RXhwZWN0YXRpb25zCShyZXZpc2lvbiAyNTg2ODkpCisrKyBMYXlvdXRUZXN0cy9UZXN0RXhwZWN0 YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xODAzLDkgKzE4MDMsNiBAQCB3ZWJraXQub3JnL2Iv MTQ4MDI2IFsgRGVidWcgXSBhbmltYXRpb25zCiAKIHdlYmtpdC5vcmcvYi8xNDg2NTAgZmFzdC9y ZXBhaW50L2FkZC10YWJsZS1vdmVycGFpbnQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLWltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1jYXNjYWRlL2FsbC1wcm9wLWluaGVy aXQtY29sb3IuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9jc3MvY3NzLWNhc2NhZGUvYWxsLXByb3AtcmV2ZXJ0LWNvbG9yLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KLWltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nz cy1jYXNjYWRlL2FsbC1wcm9wLXVuc2V0LWNvbG9yLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1jYXNjYWRlL2ltcG9ydGFu dC1wcm9wLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xODcwOTMgWyBE ZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1jYXNjYWRlL2Fs bC1wcm9wLWluaXRpYWwteG1sLmh0bWwgWyBTa2lwIF0KIApJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9jc3Mvd2Via2l0LXRleHQtZmlsbC1jb2xvci1pbmhlcml0LWV4cGVjdGVkLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3Mvd2Via2l0LXRleHQtZmlsbC1jb2xvci1pbmhl cml0LWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDI1ODY4OSkKKysrIExheW91dFRlc3RzL2Zhc3Qv Y3NzL3dlYmtpdC10ZXh0LWZpbGwtY29sb3ItaW5oZXJpdC1leHBlY3RlZC5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxib2R5Pgot ICAgIDxkaXYgc3R5bGU9Ii13ZWJraXQtdGV4dC1maWxsLWNvbG9yOiBncmVlbiI+R3JlZW48L2Rp dj4KKyAgICA8ZGl2IHN0eWxlPSItd2Via2l0LXRleHQtZmlsbC1jb2xvcjogcmVkIj5SZWQ8L2Rp dj4KICAgICA8ZGl2IHN0eWxlPSItd2Via2l0LXRleHQtZmlsbC1jb2xvcjogZ3JlZW4iPkdyZWVu PC9kaXY+CiA8L2JvZHk+CiA8aHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL3dlYmtp dC10ZXh0LWZpbGwtY29sb3ItaW5oZXJpdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvY3NzL3dlYmtpdC10ZXh0LWZpbGwtY29sb3ItaW5oZXJpdC5odG1sCShyZXZpc2lvbiAy NTg2ODkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy93ZWJraXQtdGV4dC1maWxsLWNvbG9yLWlu aGVyaXQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMiw3ICsyLDcgQEAKIDxodG1sPgogPGJvZHk+ CiAgICAgPGRpdiBzdHlsZT0iY29sb3I6IGdyZWVuIj4KLSAgICAgICAgPGRpdiBpZD0idW5kZWZp bmVkLXBhcmVudCIgc3R5bGU9ImNvbG9yOiByZWQ7IC13ZWJraXQtdGV4dC1maWxsLWNvbG9yOiBp bmhlcml0Ij5HcmVlbjwvZGl2PgorICAgICAgICA8ZGl2IGlkPSJ1bmRlZmluZWQtcGFyZW50IiBz dHlsZT0iY29sb3I6IHJlZDsgLXdlYmtpdC10ZXh0LWZpbGwtY29sb3I6IGluaGVyaXQiPlJlZDwv ZGl2PgogICAgIDwvZGl2PgogICAgIDxkaXYgc3R5bGU9ImNvbG9yOiBwdXJwbGU7IC13ZWJraXQt dGV4dC1maWxsLWNvbG9yOiBncmVlbiI+CiAgICAgICAgIDxkaXYgaWQ9ImRlZmluZWQtcGFyZW50 IiBzdHlsZT0iY29sb3I6IHJlZDsgLXdlYmtpdC10ZXh0LWZpbGwtY29sb3I6IGluaGVyaXQiPkdy ZWVuPC9kaXY+Cg==