158694 2016-06-13 09:37:50 -0700 Modern IDB: IDBOpenDBRequest objects leak 2016-06-13 10:31:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154015 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1201860 0 beidson 2016-06-13 09:37:50 -0700 Modern IDB: IDBOpenDBRequest objects leak I traced through the various refs/derefs of a particular opendbrequest and noticed it was left hanging with a ref count of 1. The ref that never gets cleared out is the m_openDBRequestMap of IDBConnectionProxy. The only time anything is ever cleared from that map is when a worker thread is torn down, but it never gets anything removed under main thread use. 1201864 1 281178 beidson 2016-06-13 09:46:26 -0700 Created attachment 281178 Patch v1 1201880 2 281178 commit-queue 2016-06-13 10:31:14 -0700 Comment on attachment 281178 Patch v1 Clearing flags on attachment: 281178 Committed r201995: <http://trac.webkit.org/changeset/201995> 1201881 3 commit-queue 2016-06-13 10:31:17 -0700 All reviewed patches have been landed. Closing bug. 281178 2016-06-13 09:46:26 -0700 2016-06-13 10:31:14 -0700 Patch v1 patch text/plain 1545 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTE4YWNiLi4zZDAwZGNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTYtMDYtMTMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE1vZGVybiBJREI6IElEQk9wZW5EQlJlcXVlc3Qgb2JqZWN0cyBsZWFrLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4Njk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChDdXJy ZW50bHkgaGF2ZSBubyB0ZXN0aW5nIHN0cmF0ZWd5IGZvciBndWFyYW50ZWVpbmcgbGlmZXRpbWUg b2YgV2ViQ29yZSBET00gb2JqZWN0cykKKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL2Ns aWVudC9JREJDb25uZWN0aW9uUHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50 OjpJREJDb25uZWN0aW9uUHJveHk6OmNvbXBsZXRlT3BlbkRCUmVxdWVzdCk6IEF0IHRoaXMgcG9p bnQgd2UgbmV2ZXIgbmVlZCB0aGUKKyAgICAgICAgICAgIHJlcXVlc3QgYWdhaW4sIHNvIHJlbW92 ZSBpdCBmcm9tIHRoZSBtYXAuCisKIDIwMTYtMDYtMTAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4u ZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBPcmlnaW4gaGVhZGVyIGlzIG5vdCBpbmNs dWRlZCBpbiBDT1JTIHJlcXVlc3RzIGZvciBwcmVsb2FkZWQgY3Jvc3Mtb3JpZ2luIHJlc291cmNl cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lE QkNvbm5lY3Rpb25Qcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9j bGllbnQvSURCQ29ubmVjdGlvblByb3h5LmNwcAppbmRleCBiYjU2MGIxLi5hMWIxZjQ0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCQ29ubmVj dGlvblByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGll bnQvSURCQ29ubmVjdGlvblByb3h5LmNwcApAQCAtMTA3LDcgKzEwNyw3IEBAIHZvaWQgSURCQ29u bmVjdGlvblByb3h5Ojpjb21wbGV0ZU9wZW5EQlJlcXVlc3QoY29uc3QgSURCUmVzdWx0RGF0YSYg cmVzdWx0RGF0YSkKICAgICBSZWZQdHI8SURCT3BlbkRCUmVxdWVzdD4gcmVxdWVzdDsKICAgICB7 CiAgICAgICAgIExvY2tlcjxMb2NrPiBsb2NrZXIobV9vcGVuREJSZXF1ZXN0TWFwTG9jayk7Ci0g ICAgICAgIHJlcXVlc3QgPSBtX29wZW5EQlJlcXVlc3RNYXAuZ2V0KHJlc3VsdERhdGEucmVxdWVz dElkZW50aWZpZXIoKSk7CisgICAgICAgIHJlcXVlc3QgPSBtX29wZW5EQlJlcXVlc3RNYXAudGFr ZShyZXN1bHREYXRhLnJlcXVlc3RJZGVudGlmaWVyKCkpOwogICAgIH0KIAogICAgIGlmICghcmVx dWVzdCkK