158078 2016-05-25 11:43:55 -0700 Fix Win64 build after r201335 2016-05-25 11:58:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue fpizlo keith_miller mark.lam msaboff peavo saam oldest_to_newest 1196400 0 achristensen 2016-05-25 11:43:55 -0700 Fix Win64 build after r201335 1196401 1 279788 achristensen 2016-05-25 11:44:50 -0700 Created attachment 279788 Patch 1196402 2 achristensen 2016-05-25 11:50:09 -0700 This is the generated assembly: movsx eax, byte ptr [0 + r9 + rdx * 1] ; C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1504 ... movsx eax, word ptr [0 + r9 + rdx * 2] ; C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1508 1196403 3 279788 mark.lam 2016-05-25 11:52:21 -0700 Comment on attachment 279788 Patch r=me if tests / bots are happy. 1196404 4 achristensen 2016-05-25 11:58:43 -0700 http://trac.webkit.org/changeset/201392 279788 2016-05-25 11:44:50 -0700 2016-05-25 11:52:21 -0700 Patch bug-158078-20160525114558.patch text/plain 2862 achristensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAxMzkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE2LTA1LTI1ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgRml4IFdpbjY0IGJ1aWxkIGFmdGVyIHIyMDEzMzUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1ODA3OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2ZmbGluZWFzbS94ODYucmI6Cisg ICAgICAgIEFkZCBpbnRlbCBpbXBsZW1lbnRhdGlvbnMgZm9yIGxvYWRicyBhbmQgbG9hZGhzCisK IDIwMTYtMDUtMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04ocjIwMTA2Nik6IFtHVEtdIFNldmVyYWwgaW50bCB0ZXN0cyBz dGFydGVkIHRvIGZhaWwgaW4gR1RLKyBib3QgYWZ0ZXIgcjIwMTA2NgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5yYgkocmV2aXNpb24gMjAxMzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2LnJiCSh3b3JraW5nIGNvcHkpCkBAIC02NDgs NyArNjQ4LDcgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgICRhc20ucHV0cyAieGNo ZyN7eDg2U3VmZml4KDpwdHIpfSAje29wZXJhbmQueDg2T3BlcmFuZCg6cHRyKX0sICN7YXgueDg2 T3BlcmFuZCg6cHRyKX0iCiAgICAgICAgICAgICAkYXNtLnB1dHMgIiN7c2V0T3Bjb2RlfSAje2F4 Lng4Nk9wZXJhbmQoOmJ5dGUpfSIKICAgICAgICAgICAgIGlmICFpc0ludGVsU3ludGF4Ci0JCSRh c20ucHV0cyAibW92emJsICN7YXgueDg2T3BlcmFuZCg6Ynl0ZSl9LCAje2F4Lng4Nk9wZXJhbmQo OmludCl9IgorICAgICAgICAgICAgICAgICRhc20ucHV0cyAibW92emJsICN7YXgueDg2T3BlcmFu ZCg6Ynl0ZSl9LCAje2F4Lng4Nk9wZXJhbmQoOmludCl9IgogICAgICAgICAgICAgZWxzZQogICAg ICAgICAgICAgICAgICRhc20ucHV0cyAibW92enggI3theC54ODZPcGVyYW5kKDppbnQpfSwgI3th eC54ODZPcGVyYW5kKDpieXRlKX0iCiAgICAgICAgICAgICBlbmQKQEAgLTk1NCw3ICs5NTQsMTEg QEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdnp4ICN7 b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKDpieXRlKSwgb3BlcmFuZHNbMV0u eDg2T3BlcmFuZCg6aW50KSl9IgogICAgICAgICAgICAgZW5kCiAgICAgICAgIHdoZW4gImxvYWRi cyIKLSAgICAgICAgICAgICRhc20ucHV0cyAibW92c2JsICN7b3BlcmFuZHNbMF0ueDg2T3BlcmFu ZCg6Ynl0ZSl9LCAje29wZXJhbmRzWzFdLng4Nk9wZXJhbmQoOmludCl9IgorICAgICAgICAgICAg aWYgIWlzSW50ZWxTeW50YXgKKyAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1vdnNibCAje29y ZGVyT3BlcmFuZHMob3BlcmFuZHNbMF0ueDg2T3BlcmFuZCg6Ynl0ZSksIG9wZXJhbmRzWzFdLng4 Nk9wZXJhbmQoOmludCkpfSIKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAkYXNt LnB1dHMgIm1vdnN4ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKDpieXRl KSwgb3BlcmFuZHNbMV0ueDg2T3BlcmFuZCg6aW50KSl9IgorICAgICAgICAgICAgZW5kCiAgICAg ICAgIHdoZW4gImxvYWRoIgogICAgICAgICAgICAgaWYgIWlzSW50ZWxTeW50YXgKICAgICAgICAg ICAgICAgICAkYXNtLnB1dHMgIm1vdnp3bCAje29yZGVyT3BlcmFuZHMob3BlcmFuZHNbMF0ueDg2 T3BlcmFuZCg6aGFsZiksIG9wZXJhbmRzWzFdLng4Nk9wZXJhbmQoOmludCkpfSIKQEAgLTk2Miw3 ICs5NjYsMTEgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgICAgICAkYXNtLnB1dHMg Im1vdnp4ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVyYW5kKDpoYWxmKSwgb3Bl cmFuZHNbMV0ueDg2T3BlcmFuZCg6aW50KSl9IgogICAgICAgICAgICAgZW5kCiAgICAgICAgIHdo ZW4gImxvYWRocyIKLSAgICAgICAgICAgICRhc20ucHV0cyAibW92c3dsICN7b3BlcmFuZHNbMF0u eDg2T3BlcmFuZCg6aGFsZil9LCAje29wZXJhbmRzWzFdLng4Nk9wZXJhbmQoOmludCl9IgorICAg ICAgICAgICAgaWYgIWlzSW50ZWxTeW50YXgKKyAgICAgICAgICAgICAgICAkYXNtLnB1dHMgIm1v dnN3bCAje29yZGVyT3BlcmFuZHMob3BlcmFuZHNbMF0ueDg2T3BlcmFuZCg6aGFsZiksIG9wZXJh bmRzWzFdLng4Nk9wZXJhbmQoOmludCkpfSIKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg ICAgICAkYXNtLnB1dHMgIm1vdnN4ICN7b3JkZXJPcGVyYW5kcyhvcGVyYW5kc1swXS54ODZPcGVy YW5kKDpoYWxmKSwgb3BlcmFuZHNbMV0ueDg2T3BlcmFuZCg6aW50KSl9IgorICAgICAgICAgICAg ZW5kCiAgICAgICAgIHdoZW4gInN0b3JlYiIKICAgICAgICAgICAgICRhc20ucHV0cyAibW92I3t4 ODZTdWZmaXgoOmJ5dGUpfSAje3g4Nk9wZXJhbmRzKDpieXRlLCA6Ynl0ZSl9IgogICAgICAgICB3 aGVuICJsb2FkZCIK