158066 2016-05-25 05:23:46 -0700 REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066 2016-05-25 08:22:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154530 Gtk, LayoutTestFailure P2 Normal --- 157755 1 cgarcia webkit-unassigned fpizlo keith_miller ossy oldest_to_newest 1196296 0 cgarcia 2016-05-25 05:23:46 -0700 This is because since r201066 JSC also uses the preferred language from the system locale instead of falling back to "en" and those tests expect the locale to be en_US. run-javascriptcore-tests does $ENV{LANG}="en_US.UTF-8"; but we are not actually honoring the environment variables at all when using jsc binary. We are using setlocale with a nullptr locale to get the current one, but the current one is always "C", because to set the locale according to the environment variables we need to call setlocale with an empty string as locale. That's done by gtk_init(), which is called by all our binaries (web process, network process, etc.), but not by jsc (because jsc doesn't depend on GTK+). The reason why it has always worked for EFL is because they call ecore_init() in jsc that calls setlocale. 1196297 1 279759 cgarcia 2016-05-25 05:26:30 -0700 Created attachment 279759 Patch for landing 1196303 2 ossy 2016-05-25 05:48:01 -0700 r201066 made the following tests fail on JSCOnly ARM bots: mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint but fixed these tests: jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-llint 1196344 3 cgarcia 2016-05-25 08:22:40 -0700 Committed r201383: <http://trac.webkit.org/changeset/201383> 279759 2016-05-25 05:26:30 -0700 2016-05-25 05:26:30 -0700 Patch for landing jsc-intl-setlocale.diff text/plain 1996 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU5NTFiM2MuLjYzMTA3NmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA1LTI1ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyMDEw NjYpOiBbR1RLXSBTZXZlcmFsIGludGwgdGVzdHMgc3RhcnRlZCB0byBmYWlsIGluIEdUSysgYm90 IGFmdGVyIHIyMDEwNjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1ODA2NgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAg ICAgIHJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBkb2VzICRFTlZ7TEFOR309ImVuX1VTLlVURi04 IjsgYnV0IHdlIGFyZSBub3QgYWN0dWFsbHkgaG9ub3JpbmcgdGhlIGVudmlyb25tZW50CisgICAg ICAgIHZhcmlhYmxlcyBhdCBhbGwgd2hlbiB1c2luZyBqc2MgYmluYXJ5LiBXZSBhcmUgdXNpbmcg c2V0bG9jYWxlKCkgd2l0aCBhIG51bGxwdHIgbG9jYWxlIHRvIGdldCB0aGUgY3VycmVudCBvbmUs IGJ1dAorICAgICAgICB0aGUgY3VycmVudCBvbmUgaXMgYWx3YXlzICJDIiwgYmVjYXVzZSB0byBz ZXQgdGhlIGxvY2FsZSBhY2NvcmRpbmcgdG8gdGhlIGVudmlyb25tZW50IHZhcmlhYmxlcyB3ZSBu ZWVkIHRvIGNhbGwKKyAgICAgICAgc2V0bG9jYWxlIHdpdGggYW4gZW1wdHkgc3RyaW5nIGFzIGxv Y2FsZS4gVGhhdCdzIGRvbmUgYnkgZ3RrX2luaXQoKSwgd2hpY2ggaXMgY2FsbGVkIGJ5IGFsbCBv dXIgYmluYXJpZXMgKHdlYgorICAgICAgICBwcm9jZXNzLCBuZXR3b3JrIHByb2Nlc3MsIGV0Yy4p LCBidXQgbm90IGJ5IGpzYyAoYmVjYXVzZSBqc2MgZG9lc24ndCBkZXBlbmQgb24gR1RLKykuIFRo ZSByZWFzb24gd2h5IGl0IGhhcworICAgICAgICBhbHdheXMgd29ya2VkIGZvciBFRkwgaXMgYmVj YXVzZSB0aGV5IGNhbGwgZWNvcmVfaW5pdCgpIGluIGpzYyB0aGF0IGNhbGxzIHNldGxvY2FsZS4K KworICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgIChtYWluKTogQ2FsbCBzZXRsb2NhbGUoTENf QUxMLCAiIikgb24gR1RLKy4KKwogMjAxNi0wNS0yNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWls bGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBlZEFycmF5LnByb3RvdHlwZS5zbGljZSBzaG91 bGQgbm90IHRocm93IGlmIG5vIGFyZ3VtZW50cyBhcmUgcHJvdmlkZWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j cHAKaW5kZXggNDA5NzM4NC4uYjAyMWQxMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKQEAgLTE5MzEs NiArMTkzMSwxMSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgZWNvcmVf aW5pdCgpOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCisgICAgaWYgKCFzZXRsb2NhbGUo TENfQUxMLCAiIikpCisgICAgICAgIFdURkxvZ0Fsd2F5cygiTG9jYWxlIG5vdCBzdXBwb3J0ZWQg YnkgQyBsaWJyYXJ5LlxuXHRVc2luZyB0aGUgZmFsbGJhY2sgJ0MnIGxvY2FsZS4iKTsKKyNlbmRp ZgorCiAgICAgLy8gTmVlZCB0byBpbml0aWFsaXplIFdURiB0aHJlYWRpbmcgYmVmb3JlIHdlIHN0 YXJ0IGFueSB0aHJlYWRzLiBDYW5ub3QgaW5pdGlhbGl6ZSBKU0MKICAgICAvLyB0aHJlYWRpbmcg eWV0LCBzaW5jZSB0aGF0IHdvdWxkIGRvIHNvbWV0aGluZ3MgdGhhdCB3ZSdkIGxpa2UgdG8gZGVm ZXIgdW50aWwgYWZ0ZXIgd2UKICAgICAvLyBoYXZlIGEgY2hhbmNlIHRvIHBhcnNlIG9wdGlvbnMu Cg==