158060 2016-05-25 00:18:28 -0700 [css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default 2016-05-25 12:38:41 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego cgarcia commit-queue gyuyoung.kim jfernandez jh718.park mcatanzaro ossy rego svillar oldest_to_newest 1196233 0 rego 2016-05-25 00:18:28 -0700 [css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default 1196234 1 279746 rego 2016-05-25 00:21:08 -0700 Created attachment 279746 Patch As @mcatanzaro suggested on bug #157391, I'm enabling CSS Grid Layout build flag by default. 1196264 2 279746 darin 2016-05-25 03:32:15 -0700 Comment on attachment 279746 Patch This only affects platforms using CMake. Is this already correct on Mac and iOS? 1196301 3 ossy 2016-05-25 05:36:58 -0700 (In reply to comment #2) > Comment on attachment 279746 [details] > Patch > > This only affects platforms using CMake. Is this already correct on Mac and > iOS? It is already enabled in FeatureDefines.xcconfig files. What about the EFL port? Don't you guys want to enable this feature? It seems EFL port is the last one disabling CSS Grid Layout. 1196302 4 ossy 2016-05-25 05:38:22 -0700 Ah, I was wrong, it is already enabled on EFL too because of FeatureList.pm. But in this case there is no reason to disable it in cmake. 1196357 5 279746 darin 2016-05-25 09:22:14 -0700 Comment on attachment 279746 Patch OK. 1196414 6 279746 commit-queue 2016-05-25 12:38:37 -0700 Comment on attachment 279746 Patch Clearing flags on attachment: 279746 Committed r201396: <http://trac.webkit.org/changeset/201396> 1196415 7 commit-queue 2016-05-25 12:38:41 -0700 All reviewed patches have been landed. Closing bug. 279746 2016-05-25 00:21:08 -0700 2016-05-25 12:38:37 -0700 Patch bug-158060-20160525092214.patch text/plain 1845 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggOWMxY2EwNTExZTkzZWY4MDhmZWVkMmIzODRhYzMyZjc3NDFmOTQ3My4uMTY2MzFmMjRkOWQx ODIwMTM0NjRhMWNkMGIxYTIwMjc3OTI4MTc2MiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtODAsNyArODAsNyBAQCBtYWNybyhXRUJLSVRfT1BUSU9OX0JFR0lOKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUsgIlRvZ2dsZSBC b3ggRGVjb3JhdGlvbiBicmVhayAoQ1NTIEJhY2tncm91bmRzIGFuZCBCb3JkZXJzKSBzdXBwb3J0 IiBQUklWQVRFIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfQ09NUE9T SVRJTkcgIlRvZ2dsZSBDU1MgQ09NUE9TSVRJTkcgc3VwcG9ydCIgUFJJVkFURSBPRkYpCiAgICAg V0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTiAiVG9nZ2xl IENTUyBEZXZpY2UgQWRhcHRhdGlvbiBzdXBwb3J0IiBQUklWQVRFIE9GRikKLSAgICBXRUJLSVRf T1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX0dSSURfTEFZT1VUICJUb2dnbGUgQ1NTIEdyaWQgTGF5 b3V0IHN1cHBvcnQiIFBSSVZBVEUgT0ZGKQorICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJM RV9DU1NfR1JJRF9MQVlPVVQgIlRvZ2dsZSBDU1MgR3JpZCBMYXlvdXQgc3VwcG9ydCIgUFJJVkFU RSBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ1NTX0lNQUdFX09SSUVOVEFU SU9OICJUb2dnbGUgQ1NTIGltYWdlLW9yaWVudGF0aW9uIHN1cHBvcnQiIFBSSVZBVEUgT0ZGKQog ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfUkVTT0xVVElPTiAiVG9n Z2xlIENTUyBpbWFnZS1yZXNvbHV0aW9uIHN1cHBvcnQiIFBSSVZBVEUgT0ZGKQogICAgIFdFQktJ VF9PUFRJT05fREVGSU5FKEVOQUJMRV9DU1NfSU1BR0VfU0VUICJUb2dnbGUgQ1NTIGltYWdlLXNl dCBzdXBwb3J0IiBQUklWQVRFIE9GRikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCAzMjhmOTg2NWQ2OWMwMmIzOGFhMDE3YWQ5OTI1NzFiOGM2YzdiZWQyLi5kM2U0ZDc1 MTM0NDk1MzQ1M2E0N2I3YjY1MWJmZWE2ZjZkMjAxODUzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDUtMjUgIE1hbnVlbCBSZWdv IENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1ncmlkXSBUdXJu IG9uIEVOQUJMRV9DU1NfR1JJRF9MQVlPVVQgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU4MDYwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHJ1bnRpbWUgZmxhZyBpcyBkaXNhYmxl ZCBieSBkZWZhdWx0LAorICAgICAgICBidXQgd2Ugd2FudCB0byBidWlsZCBDU1MgR3JpZCBMYXlv dXQgYnkgZGVmYXVsdC4KKyAgICAgICAgT3RoZXJ3aXNlIHRoZSBydW50aW1lIGZsYWcgd291bGQg YmUgdXNlbGVzcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZToKKwogMjAxNi0wNS0yMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgTW92ZSB0byBDKysxNC4K