157943 2016-05-20 06:16:18 -0700 Small improvements to RenderBox/LayoutUnit casting in MathML 2016-05-26 02:16:18 -0700 1 1 1 Unclassified WebKit MathML WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 153208 153742 153917 1 fred.wang fred.wang commit-queue dbarton esprehn+autocc glenn kondapallykalyan mrobinson svillar oldest_to_newest 1195127 0 fred.wang 2016-05-20 06:16:18 -0700 This is a small follow-up of the ​RenderMathMLRow/​RenderMathMLUnderOver/​RenderMathMLFraction refactoring. Since these MathML renderers can only contain other MathML renderers, we can just considerer RenderBox children and prevent unnecessary casts. Similarly, when the two arguments of std::max are LayoutUnit's, we do not need to specialize to std::max<LayoutUnit>. 1195128 1 279480 fred.wang 2016-05-20 06:23:50 -0700 Created attachment 279480 Patch 1195858 2 279480 darin 2016-05-24 09:03:02 -0700 Comment on attachment 279480 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279480&action=review > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:58 > + RenderBox* base = firstChildBox(); Typically in new code, we would use auto* here instead of writing RenderBox*. > Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp:78 > + for (RenderBox* child = firstChildBox(); child; child = child->nextSiblingBox()) { Ditto. 1196683 3 fred.wang 2016-05-26 02:16:18 -0700 https://trac.webkit.org/changeset/201418 279480 2016-05-20 06:23:50 -0700 2016-05-24 09:03:02 -0700 Patch bug-157943-20160520152450.patch text/plain 6114 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjAxMjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjYxMWI5OWJlZjkwMmZm OGFiMmFjMzIyZWE2MTE0MWFlMDU2OTczNC4uZjEwODE2YTcxNGJiZDIxZjZhYmZkMWU4OTU4NjE0 N2M5MGNlNDk2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTA1LTIwICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBTbWFsbCBpbXByb3ZlbWVu dHMgdG8gUmVuZGVyQm94L0xheW91dFVuaXQgY2FzdGluZyBpbiBNYXRoTUwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Nzk0MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBzbWFsbCBmb2xs b3ctdXAgb2YgdGhlIFJlbmRlck1hdGhNTFJvdy9SZW5kZXJNYXRoTUxVbmRlck92ZXIvUmVuZGVy TWF0aE1MRnJhY3Rpb24KKyAgICAgICAgcmVmYWN0b3JpbmcuIFNpbmNlIHRoZXNlIE1hdGhNTCBy ZW5kZXJlcnMgY2FuIG9ubHkgY29udGFpbiBvdGhlciBNYXRoTUwgcmVuZGVyZXJzLCB3ZSBjYW4K KyAgICAgICAganVzdCBjb25zaWRlcmVyIFJlbmRlckJveCBjaGlsZHJlbiBhbmQgYXZvaWQgdW5u ZWNlc3NhcnkgY2FzdHMuIFNpbWlsYXJseSwgd2hlbiB0aGUgdHdvCisgICAgICAgIGFyZ3VtZW50 cyBvZiBzdGQ6Om1heCBhcmUgTGF5b3V0VW5pdCdzLCB3ZSBkbyBub3QgbmVlZCB0byBzcGVjaWFs aXplIHRvIHN0ZDo6bWF4PExheW91dFVuaXQ+LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVo YXZpb3IgaXMgbm90IGNoYW5nZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvbWF0aG1sL1JlbmRl ck1hdGhNTEZyYWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1hdGhNTEZyYWN0 aW9uOjpsYXlvdXRCbG9jayk6IERvIG5vdCB0byBzcGVjaWFsaXplIHRvIHN0ZDo6bWF4PExheW91 dFVuaXQ+LgorICAgICAgICAqIHJlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1hdGhNTFJvdzo6dXBkYXRlT3BlcmF0b3JQcm9wZXJ0 aWVzKTogQnJvd3NlIHRoZSBsaXN0IG9mIFJlbmRlckJveCBjaGlsZHJlbi4KKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlck1hdGhNTFJvdzo6Y29tcHV0ZUxpbmVWZXJ0aWNhbFN0cmV0Y2gpOiBEbyBu b3QgdG8gc3BlY2lhbGl6ZSB0byBzdGQ6Om1heDxMYXlvdXRVbml0Pi4KKyAgICAgICAgKiByZW5k ZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhNTFVuZGVyT3Zlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJNYXRoTUxVbmRlck92ZXI6OnVuZW1iZWxsaXNoZWRPcGVyYXRvcik6IEdldCB0aGUg UmVuZGVyQm94IGNoaWxkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTWF0aE1MVW5kZXJPdmVy Ojpjb21wdXRlT3BlcmF0b3JzSG9yaXpvbnRhbFN0cmV0Y2gpOiBCcm93c2UgdGhlIGxpc3Qgb2YK KyAgICAgICAgUmVuZGVyQm94IGNoaWxkcmVuIGFuZCByZW1vdmUgdW5uZWNlc3NhcnkgY2FzdHMu IERvIG5vdCB0byBzcGVjaWFsaXplIHRvIHN0ZDo6bWF4PExheW91dFVuaXQ+LgorCiAyMDE2LTA1 LTE5ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyMDA2MzgpOiAtW0RPTUhUTUxWaWRlb0VsZW1lbnQgcGxheV0gZGlzYXBwZWFy ZWQgZnJvbSBPYmpDIGJpbmRpbmdzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvbWF0aG1sL1JlbmRlck1hdGhNTEZyYWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9tYXRobWwvUmVuZGVyTWF0aE1MRnJhY3Rpb24uY3BwCmluZGV4IGVlMjBkNGI5OWMyZjIw YjZmNTg4OTY4NDI3Njg3MDdlOTk5OTIxZmYuLjVjYTc3MDVmZjFhMDA1YjUyMjg1Y2EwYjVkZGI2 ODRlZGE0NjUyNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwv UmVuZGVyTWF0aE1MRnJhY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9t YXRobWwvUmVuZGVyTWF0aE1MRnJhY3Rpb24uY3BwCkBAIC0xODcsNyArMTg3LDcgQEAgdm9pZCBS ZW5kZXJNYXRoTUxGcmFjdGlvbjo6bGF5b3V0QmxvY2soYm9vbCByZWxheW91dENoaWxkcmVuLCBM YXlvdXRVbml0KQogICAgIG51bWVyYXRvcigpLmxheW91dElmTmVlZGVkKCk7CiAgICAgZGVub21p bmF0b3IoKS5sYXlvdXRJZk5lZWRlZCgpOwogCi0gICAgc2V0TG9naWNhbFdpZHRoKHN0ZDo6bWF4 PExheW91dFVuaXQ+KG51bWVyYXRvcigpLmxvZ2ljYWxXaWR0aCgpLCBkZW5vbWluYXRvcigpLmxv Z2ljYWxXaWR0aCgpKSk7CisgICAgc2V0TG9naWNhbFdpZHRoKHN0ZDo6bWF4KG51bWVyYXRvcigp LmxvZ2ljYWxXaWR0aCgpLCBkZW5vbWluYXRvcigpLmxvZ2ljYWxXaWR0aCgpKSk7CiAKICAgICBM YXlvdXRQb2ludCBudW1lcmF0b3JMb2NhdGlvbihob3Jpem9udGFsT2Zmc2V0KG51bWVyYXRvcigp LCBtX251bWVyYXRvckFsaWduKSwgdmVydGljYWxPZmZzZXQpOwogICAgIG51bWVyYXRvcigpLnNl dExvY2F0aW9uKG51bWVyYXRvckxvY2F0aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MUm93LmNwcAppbmRleCA2ZDMxOGNkYTA4ODlkOWRl MTRhNmMyMTc0NjA0ZDM4YjkyZjBlY2MxLi5mYWRlZTBlNWE4ZTU4ZDczODU5ZTZkNjAyODJkZDIy ZWYxMzljNTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1Jl bmRlck1hdGhNTFJvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9S ZW5kZXJNYXRoTUxSb3cuY3BwCkBAIC01MSw3ICs1MSw3IEBAIFJlbmRlck1hdGhNTFJvdzo6UmVu ZGVyTWF0aE1MUm93KERvY3VtZW50JiBkb2N1bWVudCwgUmVuZGVyU3R5bGUmJiBzdHlsZSkKIAog dm9pZCBSZW5kZXJNYXRoTUxSb3c6OnVwZGF0ZU9wZXJhdG9yUHJvcGVydGllcygpCiB7Ci0gICAg Zm9yIChSZW5kZXJPYmplY3QqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBj aGlsZC0+bmV4dFNpYmxpbmcoKSkgeworICAgIGZvciAoUmVuZGVyQm94KiBjaGlsZCA9IGZpcnN0 Q2hpbGRCb3goKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nQm94KCkpIHsKICAg ICAgICAgaWYgKGlzPFJlbmRlck1hdGhNTEJsb2NrPigqY2hpbGQpKSB7CiAgICAgICAgICAgICBp ZiAoYXV0byogcmVuZGVyT3BlcmF0b3IgPSBkb3duY2FzdDxSZW5kZXJNYXRoTUxCbG9jaz4oKmNo aWxkKS51bmVtYmVsbGlzaGVkT3BlcmF0b3IoKSkKICAgICAgICAgICAgICAgICByZW5kZXJPcGVy YXRvci0+dXBkYXRlT3BlcmF0b3JQcm9wZXJ0aWVzKCk7CkBAIC04NCw4ICs4NCw4IEBAIHZvaWQg UmVuZGVyTWF0aE1MUm93Ojpjb21wdXRlTGluZVZlcnRpY2FsU3RyZXRjaChMYXlvdXRVbml0JiBh c2NlbnQsIExheW91dFVuaXQmCiAgICAgICAgIExheW91dFVuaXQgY2hpbGRIZWlnaHRBYm92ZUJh c2VsaW5lID0gYXNjZW50Rm9yQ2hpbGQoKmNoaWxkKTsKICAgICAgICAgTGF5b3V0VW5pdCBjaGls ZERlcHRoQmVsb3dCYXNlbGluZSA9IGNoaWxkLT5sb2dpY2FsSGVpZ2h0KCkgLSBjaGlsZEhlaWdo dEFib3ZlQmFzZWxpbmU7CiAKLSAgICAgICAgYXNjZW50ID0gc3RkOjptYXg8TGF5b3V0VW5pdD4o YXNjZW50LCBjaGlsZEhlaWdodEFib3ZlQmFzZWxpbmUpOwotICAgICAgICBkZXNjZW50ID0gc3Rk OjptYXg8TGF5b3V0VW5pdD4oZGVzY2VudCwgY2hpbGREZXB0aEJlbG93QmFzZWxpbmUpOworICAg ICAgICBhc2NlbnQgPSBzdGQ6Om1heChhc2NlbnQsIGNoaWxkSGVpZ2h0QWJvdmVCYXNlbGluZSk7 CisgICAgICAgIGRlc2NlbnQgPSBzdGQ6Om1heChkZXNjZW50LCBjaGlsZERlcHRoQmVsb3dCYXNl bGluZSk7CiAgICAgfQogCiAgICAgLy8gV2UgZW5zdXJlIGEgbWluaW1hbCBzdHJldGNoIHNpemUu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhN TFVuZGVyT3Zlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1h dGhNTFVuZGVyT3Zlci5jcHAKaW5kZXggYTI1ZTU5Mzg5YzRkNGVhYTA1YThkZTA3YzlkYTZiMmM0 ZGYyNGJhMC4uNjA2MWIxOWIzMzE1ODFiMzZiZDU2MWQ5ZDVjYTk4MDFkNjc5M2UzMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9SZW5kZXJNYXRoTUxVbmRlck92 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1M VW5kZXJPdmVyLmNwcApAQCAtNTUsNyArNTUsNyBAQCBSZW5kZXJNYXRoTUxVbmRlck92ZXI6OlJl bmRlck1hdGhNTFVuZGVyT3ZlcihFbGVtZW50JiBlbGVtZW50LCBSZW5kZXJTdHlsZSYmIHN0eQog CiBSZW5kZXJNYXRoTUxPcGVyYXRvciogUmVuZGVyTWF0aE1MVW5kZXJPdmVyOjp1bmVtYmVsbGlz aGVkT3BlcmF0b3IoKQogewotICAgIFJlbmRlck9iamVjdCogYmFzZSA9IGZpcnN0Q2hpbGQoKTsK KyAgICBSZW5kZXJCb3gqIGJhc2UgPSBmaXJzdENoaWxkQm94KCk7CiAgICAgaWYgKCFpczxSZW5k ZXJNYXRoTUxCbG9jaz4oYmFzZSkpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVy biBkb3duY2FzdDxSZW5kZXJNYXRoTUxCbG9jaz4oKmJhc2UpLnVuZW1iZWxsaXNoZWRPcGVyYXRv cigpOwpAQCAtNzUsNyArNzUsNyBAQCB2b2lkIFJlbmRlck1hdGhNTFVuZGVyT3Zlcjo6Y29tcHV0 ZU9wZXJhdG9yc0hvcml6b250YWxTdHJldGNoKCkKICAgICBMYXlvdXRVbml0IHN0cmV0Y2hXaWR0 aCA9IDA7CiAgICAgVmVjdG9yPFJlbmRlck1hdGhNTE9wZXJhdG9yKiwgMj4gcmVuZGVyT3BlcmF0 b3JzOwogCi0gICAgZm9yIChSZW5kZXJPYmplY3QqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGls ZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgeworICAgIGZvciAoUmVuZGVyQm94KiBj aGlsZCA9IGZpcnN0Q2hpbGRCb3goKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5n Qm94KCkpIHsKICAgICAgICAgaWYgKGNoaWxkLT5uZWVkc0xheW91dCgpKSB7CiAgICAgICAgICAg ICBpZiAoaXM8UmVuZGVyTWF0aE1MQmxvY2s+KGNoaWxkKSkgewogICAgICAgICAgICAgICAgIGlm IChhdXRvIHJlbmRlck9wZXJhdG9yID0gZG93bmNhc3Q8UmVuZGVyTWF0aE1MQmxvY2s+KCpjaGls ZCkudW5lbWJlbGxpc2hlZE9wZXJhdG9yKCkpIHsKQEAgLTg2LDEzICs4NiwxMiBAQCB2b2lkIFJl bmRlck1hdGhNTFVuZGVyT3Zlcjo6Y29tcHV0ZU9wZXJhdG9yc0hvcml6b250YWxTdHJldGNoKCkK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGRvd25jYXN0 PFJlbmRlckVsZW1lbnQ+KCpjaGlsZCkubGF5b3V0KCk7CisgICAgICAgICAgICBjaGlsZC0+bGF5 b3V0KCk7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBTa2lwcGluZyB0aGUgZW1iZWxsaXNoZWQg b3AgZG9lcyBub3Qgd29yayBmb3IgbmVzdGVkIHN0cnVjdHVyZXMgbGlrZQogICAgICAgICAvLyA8 bXVuZGVyPjxtb3Zlcj48bW8+XzwvbW8+Li4uPC9tb3Zlcj4gPG1vPl88L21vPjwvbXVuZGVyPi4K LSAgICAgICAgaWYgKGlzPFJlbmRlckJveD4oKmNoaWxkKSkKLSAgICAgICAgICAgIHN0cmV0Y2hX aWR0aCA9IHN0ZDo6bWF4PExheW91dFVuaXQ+KHN0cmV0Y2hXaWR0aCwgZG93bmNhc3Q8UmVuZGVy Qm94PigqY2hpbGQpLmxvZ2ljYWxXaWR0aCgpKTsKKyAgICAgICAgc3RyZXRjaFdpZHRoID0gc3Rk OjptYXgoc3RyZXRjaFdpZHRoLCBjaGlsZC0+bG9naWNhbFdpZHRoKCkpOwogICAgIH0KIAogICAg IC8vIFNldCB0aGUgc2l6ZXMgb2YgKHBvc3NpYmx5IGVtYmVsbGlzaGVkKSBzdHJldGNoeSBvcGVy YXRvciBjaGlsZHJlbi4K