157733 2016-05-15 17:51:07 -0700 [GTK][CMake] DerivedSources should be compiled with -Wno-unused-parameter 2017-07-13 11:42:44 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 155047 1 mcatanzaro mcatanzaro achristensen bugs-noreply darin mcatanzaro mrobinson ossy oldest_to_newest 1193301 0 mcatanzaro 2016-05-15 17:51:07 -0700 DerivedSources should be compiled with -Wno-unused-parameter, to avoid useless warnings in Geoclue2Interface.c. 1193312 1 278989 mcatanzaro 2016-05-15 18:39:09 -0700 Created attachment 278989 Patch 1195712 2 darin 2016-05-23 20:54:34 -0700 (In reply to comment #0) > DerivedSources should be compiled with -Wno-unused-parameter, to avoid > useless warnings in Geoclue2Interface.c. We really want to compile all derived sources this way, just because of that one file? 1195776 3 278989 ossy 2016-05-24 00:53:30 -0700 Comment on attachment 278989 Patch I haven't seen this warning, maybe geoclue is disabled in my build. But I agree with Darin, we shouldn't disable unused parameter warnings because of one file. I prefer set_source_file_properties() for this problematic generated source. 1328526 4 mcatanzaro 2017-07-13 11:42:44 -0700 (In reply to Csaba Osztrogonác from comment #3) > Comment on attachment 278989 [details] > Patch > > I haven't seen this warning, maybe geoclue is disabled in my build. > > But I agree with Darin, we shouldn't disable unused parameter warnings > because of > one file. I prefer set_source_file_properties() for this problematic > generated source. I guess I must have done this at some point in a different bug, because I think I remember fixing it, and it definitely does not occur anymore. 278989 2016-05-15 18:39:09 -0700 2016-05-24 00:53:30 -0700 Patch bug-157733-20160515204003.patch text/plain 1351 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY5ZTViZWYwMjY3NjAx M2JlMWUyOTEwOWQwZDEzYTYzNTIwN2NhYS4uNjFmMTk3MzEwNTEzYTY1ZjQ0OTJhM2NmNTQ2ZGJh ODI5ZWFhOGEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA1LTE1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtD TWFrZV0gRGVyaXZlZFNvdXJjZXMgc2hvdWxkIGJlIGNvbXBpbGVkIHdpdGggLVduby11bnVzZWQt cGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTc3MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE2LTA1LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgVXNlIG1vcmUgcmVmZXJlbmNlcyBpbiBKUyB3cmFwcGVycyBy ZWxhdGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIv U291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNDNmZGExMmIyNDM3NzliMThmMTRj MzViZWI5NTk1MDIzZWU0MWMzMi4uYTkwMGI1NDA3OTIyMjljOTZiYWY1MDI1NDNlMzY0MmJiNjdk NWE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTM4NDIsNiArMzg0MiwxMCBAQCBpZiAoV0lO MzIpCiAgICAgYWRkX2RlcGVuZGVuY2llcyhXZWJDb3JlIFdlYkNvcmVEZXJpdmVkU291cmNlcykK IGVuZGlmICgpCiAKK2lmIChDTUFLRV9DT01QSUxFUl9JU19HTlVDWFggT1IgIiR7Q01BS0VfQ1hY X0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKKyAgICBBRERfVEFSR0VUX1BST1BFUlRJ RVMoV2ViQ29yZURlcml2ZWRTb3VyY2VzIENPTVBJTEVfRkxBR1MgIi1Xbm8tdW51c2VkLXBhcmFt ZXRlciIpCitlbmRpZiAoKQorCiAjIFRoZSAtZnRyZWUtc3JhIG9wdGltaXphdGlvbiAoaW1wbGlj aXQgd2l0aCAtTzIpIGNhdXNlcyBjcmFzaGVzIHdoZW4KICMgYWxsb2NhdGluZyBsYXJnZSBjaHVu a3Mgb2YgbWVtb3J5IHVzaW5nIGJtYWxsb2Mgb24gSW50ZWwgMzJiaXQuCiAjIFNlZSBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2NDQwCg==