157732 2016-05-15 17:50:02 -0700 woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable 2016-05-23 18:53:49 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 155047 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1193300 0 mcatanzaro 2016-05-15 17:50:02 -0700 woff2_dec.cc triggers -Wsign-compare 1193308 1 mcatanzaro 2016-05-15 18:06:16 -0700 It's also triggering -Wunused-but-set-variable Instead of fixing these, let's suppress them, since it's third-party code. We could use a heavy hammer and use -w to suppress all warnings from third-party code, but let's start with suppressing just the problematic ones so we can see if new warnings get introduced in the future. 1193309 2 278987 mcatanzaro 2016-05-15 18:07:54 -0700 Created attachment 278987 Patch 1195682 3 278987 commit-queue 2016-05-23 18:53:44 -0700 Comment on attachment 278987 Patch Clearing flags on attachment: 278987 Committed r201313: <http://trac.webkit.org/changeset/201313> 1195683 4 commit-queue 2016-05-23 18:53:49 -0700 All reviewed patches have been landed. Closing bug. 278987 2016-05-15 18:07:54 -0700 2016-05-23 18:53:44 -0700 Patch bug-157732-20160515200848.patch text/plain 1199 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwOTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggZTJkOGNlOGVl YzY0NDAxY2Q3MDBjZWZjM2NhMGM0NmE1M2EyMTBjMS4uNzU5ZTczNDVkMzQzYzRlM2MxYmZmNzQw YzA0M2ZiNDNlZmJlYzBkMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2 LTA1LTE1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAg ICAgICB3b2ZmMl9kZWMuY2MgdHJpZ2dlcnMgLVdzaWduLWNvbXBhcmUsIC1XdW51c2VkLWJ1dC1z ZXQtdmFyaWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NzczMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogd29mZjIvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTYtMDMtMTcgIENzYWJhIE9zenRyb2dv bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBsaW5lIGVuZGlu ZyBmaXhlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L3dvZmYyL0NNYWtlTGlzdHMu dHh0IGIvU291cmNlL1RoaXJkUGFydHkvd29mZjIvQ01ha2VMaXN0cy50eHQKaW5kZXggMzU4NGE4 OTYwNDYxNTRkMTQxNmQwMzg5ZGYwZjk1YzBiMGVmZGI0ZS4uZTY4NmJkNDY2Y2JlYjJhYzRlNmJh MWJjNzljZmE4ZDJiNzM0NDkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvd29mZjIv Q01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFydHkvd29mZjIvQ01ha2VMaXN0cy50 eHQKQEAgLTE2LDMgKzE2LDQgQEAgaW5jbHVkZV9kaXJlY3RvcmllcygiJHtXT0ZGMl9JTkNMVURF X0RJUkVDVE9SSUVTfSIpCiBhZGRfbGlicmFyeSh3b2ZmMiBTVEFUSUMgJHtXT0ZGMl9TT1VSQ0VT fSkKIHRhcmdldF9saW5rX2xpYnJhcmllcyh3b2ZmMiBicm90bGkpCiBXRUJLSVRfU0VUX0VYVFJB X0NPTVBJTEVSX0ZMQUdTKHdvZmYyKQorQUREX1RBUkdFVF9QUk9QRVJUSUVTKHdvZmYyIENPTVBJ TEVfRkxBR1MgIi1Xbm8tc2lnbi1jb21wYXJlIC1Xbm8tdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUi KQo=