157662 2016-05-12 20:57:21 -0700 Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation 2016-05-12 23:27:50 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154257 1 cdumez cdumez barraclough cdumez commit-queue darin esprehn+autocc ggaren kondapallykalyan oldest_to_newest 1192614 0 cdumez 2016-05-12 20:57:21 -0700 Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as it is no longer needed after <http://trac.webkit.org/changeset/196678>. JSC::getStaticPropertySlot() now properly checks for overrides *before* checking the static table. 1192616 1 278809 cdumez 2016-05-12 21:00:02 -0700 Created attachment 278809 Patch 1192617 2 cdumez 2016-05-12 21:00:41 -0700 The generated bindings look like so: bool JSWorkerGlobalScope::getOwnPropertySlot(JSObject* object, ExecState* state, PropertyName propertyName, PropertySlot& slot) { auto* thisObject = jsCast<JSWorkerGlobalScope*>(object); ASSERT_GC_OBJECT_INHERITS(thisObject, info()); if (getStaticPropertySlot<JSWorkerGlobalScope, Base>(state, JSWorkerGlobalScopeTable, thisObject, propertyName, slot)) return true; return false; } 1192670 3 278809 commit-queue 2016-05-12 23:27:44 -0700 Comment on attachment 278809 Patch Clearing flags on attachment: 278809 Committed r200814: <http://trac.webkit.org/changeset/200814> 1192671 4 commit-queue 2016-05-12 23:27:50 -0700 All reviewed patches have been landed. Closing bug. 278809 2016-05-12 21:00:02 -0700 2016-05-12 23:27:44 -0700 Patch bug-157662-20160512210053.patch text/plain 2587 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJlYWQ3ZjQxNGU1ZjA1 YjViMDhiY2NmZTEwOGFjZGMzNWJmM2M4MC4uNzNjYjRiMjUyOTZkMmYwMDcyMjg0MjZlYjAzOGVj MmEzNjg3YTkwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA1LTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBXb3JrZXJHbG9iYWxT Y29wZSdzIGN1c3RvbSBHZXRPd25Qcm9wZXJ0eVNsb3QoKSBpbXBsZW1lbnRhdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3NjYyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBXb3JrZXJHbG9i YWxTY29wZSdzIGN1c3RvbSBHZXRPd25Qcm9wZXJ0eVNsb3QoKSBpbXBsZW1lbnRhdGlvbiBhcwor ICAgICAgICBpdCBpcyBubyBsb25nZXIgbmVlZGVkIGFmdGVyIDxodHRwOi8vdHJhYy53ZWJraXQu b3JnL2NoYW5nZXNldC8xOTY2Nzg+LgorCisgICAgICAgIEpTQzo6Z2V0U3RhdGljUHJvcGVydHlT bG90KCkgbm93IHByb3Blcmx5IGNoZWNrcyBmb3Igb3ZlcnJpZGVzICpiZWZvcmUqCisgICAgICAg IGNoZWNraW5nIHRoZSBzdGF0aWMgdGFibGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyB3 ZWItZXhwb3NlZCBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1dv cmtlckdsb2JhbFNjb3BlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTV29ya2VyR2xv YmFsU2NvcGU6OmdldE93blByb3BlcnR5U2xvdERlbGVnYXRlKTogRGVsZXRlZC4KKyAgICAgICAg KiB3b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmlkbDoKKwogMjAxNi0wNS0xMiAgQWRhIENoYW4g IDxhZGFjaGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBQcmV2ZW50IGNsaWNrcyBpbiB0aGUgcGxh Y2Vob2xkZXIgZnJvbSBwbGF5aW5nIG9yIHBhdXNpbmcgdGhlIHZpZGVvIGluIGEgTWVkaWFEb2N1 bWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyR2xv YmFsU2NvcGVDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXb3JrZXJH bG9iYWxTY29wZUN1c3RvbS5jcHAKaW5kZXggOWI4ZTg1YzZhMzc4YTQyMjY0ZGM3MmU4YzhlOTc2 MWYzNmFmY2QyOS4uZDBmZTRhYmIyZDA0N2E0ODc3YWViZjlhZTZkN2I3MmVlMThhOTNhNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXb3JrZXJHbG9iYWxTY29wZUN1 c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXb3JrZXJHbG9iYWxT Y29wZUN1c3RvbS5jcHAKQEAgLTU5LDE0ICs1OSw2IEBAIHZvaWQgSlNXb3JrZXJHbG9iYWxTY29w ZTo6dmlzaXRBZGRpdGlvbmFsQ2hpbGRyZW4oU2xvdFZpc2l0b3ImIHZpc2l0b3IpCiAgICAgICAg IHZpc2l0b3IuYWRkT3BhcXVlUm9vdChuYXZpZ2F0b3IpOwogfQogCi1ib29sIEpTV29ya2VyR2xv YmFsU2NvcGU6OmdldE93blByb3BlcnR5U2xvdERlbGVnYXRlKEV4ZWNTdGF0ZSogZXhlYywgUHJv cGVydHlOYW1lIHByb3BlcnR5TmFtZSwgUHJvcGVydHlTbG90JiBzbG90KQotewotICAgIC8vIExv b2sgZm9yIG92ZXJyaWRlcyBiZWZvcmUgbG9va2luZyBhdCBhbnkgb2Ygb3VyIG93biBwcm9wZXJ0 aWVzLgotICAgIGlmIChKU0dsb2JhbE9iamVjdDo6Z2V0T3duUHJvcGVydHlTbG90KHRoaXMsIGV4 ZWMsIHByb3BlcnR5TmFtZSwgc2xvdCkpCi0gICAgICAgIHJldHVybiB0cnVlOwotICAgIHJldHVy biBmYWxzZTsKLX0KLQogSlNWYWx1ZSBKU1dvcmtlckdsb2JhbFNjb3BlOjppbXBvcnRTY3JpcHRz KEV4ZWNTdGF0ZSYgc3RhdGUpCiB7CiAgICAgaWYgKCFzdGF0ZS5hcmd1bWVudENvdW50KCkpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNjb3BlLmlkbCBi L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyR2xvYmFsU2NvcGUuaWRsCmluZGV4IDY4MWRl M2E3OGIzMmY1Nzc5ODZiY2QzMjc4OGYzM2YzOTU5ZjU5OTEuLjQzZWFmOWU2OTE1MjRmNDNkZDVl YTY4OGUxNTEyYzJmZThhZDkzNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VyR2xvYmFsU2NvcGUuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy R2xvYmFsU2NvcGUuaWRsCkBAIC0yOCw3ICsyOCw2IEBACiAgICAgRXhwb3NlZD1Xb3JrZXIsCiAg ICAgQ3VzdG9tUHJveHlUb0pTT2JqZWN0LAogICAgIEpTQ3VzdG9tTWFya0Z1bmN0aW9uLAotICAg IEpTQ3VzdG9tR2V0T3duUHJvcGVydHlTbG90QW5kRGVzY3JpcHRvciwKICAgICBKU0xlZ2FjeVBh cmVudD1KU1dvcmtlckdsb2JhbFNjb3BlQmFzZSwKIF0gaW50ZXJmYWNlIFdvcmtlckdsb2JhbFNj b3BlIDogRXZlbnRUYXJnZXQgewogCg==