157391 2016-05-05 15:08:22 -0700 [GTK] Add CSS Grid Layout as experimental feature 2016-05-24 05:55:25 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 157393 1 rego rego berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson svillar oldest_to_newest 1190468 0 rego 2016-05-05 15:08:22 -0700 Now that we've a runtime feature for CSS Grid Layout again (bug #157134), we can recover the old patch to enable it from an env variable (bug #127089). 1190469 1 278194 rego 2016-05-05 15:09:30 -0700 Created attachment 278194 Patch 1190476 2 commit-queue 2016-05-05 15:14:17 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1190494 3 278194 mcatanzaro 2016-05-05 16:09:05 -0700 Comment on attachment 278194 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278194&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:157 > + ExperimentalFeatures features; I usually prefer to leave one blank line above variable declarations, especially when they're not initialized. It's easier to read IMO. 1190524 4 278194 commit-queue 2016-05-05 16:59:13 -0700 Comment on attachment 278194 Patch Clearing flags on attachment: 278194 Committed r200497: <http://trac.webkit.org/changeset/200497> 1190525 5 commit-queue 2016-05-05 16:59:17 -0700 All reviewed patches have been landed. Closing bug. 1193304 6 mcatanzaro 2016-05-15 17:56:24 -0700 The compile flag is still off by default. I don't think the runtime flag serves any useful purpose if this functionality is compiled out by default. Presumably, you would only change the build flags if you really want to test CSS grid layout, so it's currently just another obstacle to overcome. I think we should flip ENABLE_CSS_GRID_LAYOUT to be on by default. 1195788 7 rego 2016-05-24 02:09:31 -0700 (In reply to comment #6) > The compile flag is still off by default. I don't think the runtime flag > serves any useful purpose if this functionality is compiled out by default. > Presumably, you would only change the build flags if you really want to test > CSS grid layout, so it's currently just another obstacle to overcome. > > I think we should flip ENABLE_CSS_GRID_LAYOUT to be on by default. Yeah I agree, at least for WebKitGTK+ we want to build it by default (and keep the runtime flag disabled by default). Should we modify Source/cmake/WebKitFeatures.cmake to make it ON by default? Or the change should go somewhere else? 1195823 8 mcatanzaro 2016-05-24 05:55:25 -0700 (In reply to comment #7) > Should we modify Source/cmake/WebKitFeatures.cmake to make it ON by default? Yes. Also in FeatureList.pm if it's not already. 278194 2016-05-05 15:09:30 -0700 2016-05-05 16:59:13 -0700 Patch bug-157391-20160506001010.patch text/plain 3177 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjAwNDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGFhZTU3MTQ1Nzc1MjQ0 NTBkZThhNmQ1YTZkYTI3NjQ4ZjVhYTNmMi4uODU4NDg4ODgzMjkwZmFiYmY5MzMzN2E4ZWMyMGE3 ZTkyNjA0YWM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA1LTA1ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFk ZCBDU1MgR3JpZCBMYXlvdXQgYXMgZXhwZXJpbWVudGFsIGZlYXR1cmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzM5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0aGF0IHdlJ3ZlIGEgcnVudGlt ZSBmZWF0dXJlIGFnYWluIGZvciBDU1MgR3JpZCBMYXlvdXQgKHIyMDAyMTUpLAorICAgICAgICB3 ZSBjYW4gcmVjb3ZlciB0aGUgb2xkIHBhdGNoIChyMTYyMjE1KSB0aGF0IGFsbG93cyB0byBlbmFi bGUvZGlzYWJsZQorICAgICAgICBDU1MgR3JpZCBMYXlvdXQgdGhyb3VnaCB0aGUgZW52aXJvbm1l bnQgdmFyaWFibGUKKyAgICAgICAgV0VCS0lUR1RLX0VYUEVSSU1FTlRBTF9GRUFUVVJFUy4KKwor ICAgICAgICBFeGFtcGxlOiBXRUJLSVRHVEtfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTPSJDU1NfR1JJ RF9MQVlPVVQ9MSIKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdz LmNwcDoKKyAgICAgICAgKHdlYktpdFNldHRpbmdzQ29uc3RydWN0ZWQpOiBVc2UgbmV3IGV4cGVy aW1lbnRhbCBmZWF0dXJlIHRvIGVuYWJsZQorICAgICAgICBvciBkaXNhYmxlIENTUyBHcmlkIExh eW91dC4KKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL0V4cGVyaW1lbnRhbEZlYXR1cmVzLmNwcDog QWRkIG5ldyBleHBlcmltZW50YWwgZmVhdHVyZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL0V4 cGVyaW1lbnRhbEZlYXR1cmVzLmg6IERpdHRvLgorCiAyMDE2LTA1LTA1ICBEZWFuIEphY2tzb24g IDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBTaGFkb3cgRE9NIHNob3VsZCBub3QgYmUgZXhw ZXJpbWVudGFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRTZXR0aW5ncy5jcHAKaW5kZXggYjI5MGE2NTk2MDdjNmZkNjAwMGYwM2M4MGU2ZGQ3NzBmZThm ZDhmZC4uNGJhNGFjNjQ4ZjdmNzg0YmJkMGM4YjIwNzA3ZDk1NzJlMzM5YjE3NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcApA QCAtMTU0LDYgKzE1NCwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc0NvbnN0cnVjdGVk KEdPYmplY3QqIG9iamVjdCkKIAogICAgIFdlYlByZWZlcmVuY2VzKiBwcmVmcyA9IFdFQktJVF9T RVRUSU5HUyhvYmplY3QpLT5wcml2LT5wcmVmZXJlbmNlcy5nZXQoKTsKICAgICBwcmVmcy0+c2V0 U2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb24odHJ1ZSk7CisgICAgRXhwZXJpbWVudGFsRmVh dHVyZXMgZmVhdHVyZXM7CisgICAgYm9vbCBjc3NHcmlkTGF5b3V0RW5hYmxlZCA9IGZlYXR1cmVz LmlzRW5hYmxlZChFeHBlcmltZW50YWxGZWF0dXJlczo6Q1NTR3JpZExheW91dCk7CisgICAgaWYg KHByZWZzLT5jc3NHcmlkTGF5b3V0RW5hYmxlZCgpICE9IGNzc0dyaWRMYXlvdXRFbmFibGVkKQor ICAgICAgICBwcmVmcy0+c2V0Q1NTR3JpZExheW91dEVuYWJsZWQoY3NzR3JpZExheW91dEVuYWJs ZWQpOwogfQogCiBzdGF0aWMgdm9pZCB3ZWJLaXRTZXR0aW5nc1NldFByb3BlcnR5KEdPYmplY3Qq IG9iamVjdCwgZ3VpbnQgcHJvcElkLCBjb25zdCBHVmFsdWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBw YXJhbVNwZWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0V4cGVy aW1lbnRhbEZlYXR1cmVzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhwZXJp bWVudGFsRmVhdHVyZXMuY3BwCmluZGV4IDJiNDVmYjYxZjI4NzYyYWMzZDgzNTg2YzBmNDEwOWU0 ZjliODQ3NDQuLjBkZTdhMjJkMmMwODE0NWJiMzU1YTcxZjgxN2FhODIwYzgyOThmMjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhwZXJpbWVudGFsRmVhdHVyZXMu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhwZXJpbWVudGFsRmVhdHVy ZXMuY3BwCkBAIC0zOSw2ICszOSw3IEBAIHN0cnVjdCBTZXR0aW5nIHsKIH07CiAKIHN0YXRpYyBT ZXR0aW5nIHNldHRpbmdzW10gPSB7CisgICAgeyBFeHBlcmltZW50YWxGZWF0dXJlczo6Q1NTR3Jp ZExheW91dCwgIkNTU19HUklEX0xBWU9VVCIsIHRydWUgfSwKICAgICB7IEV4cGVyaW1lbnRhbEZl YXR1cmVzOjpSZWdpb25CYXNlZENvbHVtbnMsICJSRUdJT05fQkFTRURfQ09MVU1OUyIsIGZhbHNl IH0KIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhwZXJp bWVudGFsRmVhdHVyZXMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvRXhwZXJpbWVu dGFsRmVhdHVyZXMuaAppbmRleCBlYjA0MjI4ODQwY2ZlY2ZjZjk4MTYzNDc5MmE4OWNkYTZjMmM4 MTg0Li41OTYwM2NiZjg1MGMxY2FkNDY4MzFlZWMwMjg1Njc2NTcyMTVmOTJjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0V4cGVyaW1lbnRhbEZlYXR1cmVzLmgKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9FeHBlcmltZW50YWxGZWF0dXJlcy5oCkBA IC0zNyw2ICszNyw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgRXhwZXJpbWVudGFsRmVh dHVyZXMgewogcHVibGljOgogICAgIGVudW0gRmVhdHVyZSB7CisgICAgICAgIENTU0dyaWRMYXlv dXQsCiAgICAgICAgIFJlZ2lvbkJhc2VkQ29sdW1ucwogICAgIH07CiAK