157368 2016-05-04 17:35:56 -0700 Web Inspector: Console is unresponsive for >10 seconds when it tries to render 10,000 messages 2016-05-05 13:11:44 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 142011 1 nvasilyev nvasilyev bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1190288 0 nvasilyev 2016-05-04 17:35:56 -0700 Steps: 1. Open the attached reduction. 2. Inspect <body>, make sure split console is closed 3. Open Console tab or press Esc to open the split console Expected: Inspector UI should be reasonable responsive. Actual: Inspector UI freezes for 10-15 seconds. Notes: After http://trac.webkit.org/changeset/200401, console messages get rendered only when the console shows up. Firing console.log-s when we're on, say, Elements tab, don't result in messages being rendered right away. This may create a case when we need to render thousands of console messages upon opening the console for the first time. Ideally, we'd want to render only messages in the viewport first. For now, I suggest to limit how many messages we render per requestAnimationFrame, to keep the UI responsive. 1190289 1 webkit-bug-importer 2016-05-04 17:36:34 -0700 <rdar://problem/26103657> 1190291 2 278147 nvasilyev 2016-05-04 17:39:02 -0700 Created attachment 278147 [HTML] Reduction 1190292 3 278148 nvasilyev 2016-05-04 17:49:43 -0700 Created attachment 278148 Patch 1190293 4 278148 nvasilyev 2016-05-04 17:51:46 -0700 Comment on attachment 278148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278148&action=review > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:288 > + const maxMessagesPerFrame = 100; Adding the first 100 messages to the DOM takes ~20ms (1/50 of a second). Adding 10,001st to 10,100th message takes >250ms (1/4 of a second). I think 100 is a reasonable number here. 1190424 5 278148 commit-queue 2016-05-05 13:11:40 -0700 Comment on attachment 278148 Patch Clearing flags on attachment: 278148 Committed r200471: <http://trac.webkit.org/changeset/200471> 1190425 6 commit-queue 2016-05-05 13:11:44 -0700 All reviewed patches have been landed. Closing bug. 278147 2016-05-04 17:39:02 -0700 2016-05-04 17:39:02 -0700 [HTML] Reduction 10000-console-logs.html text/html 197 nvasilyev PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxtZXRhIGNoYXJzZXQ9IlVURi04Ij4K ICAgIDx0aXRsZT4xMCwwMDAgbG9nIG1lc3NhZ2VzPC90aXRsZT4KPC9oZWFkPgo8Ym9keT4KPHNj cmlwdD4KZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKQogICAgY29uc29sZS5sb2coaSk7 Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4= 278148 2016-05-04 17:49:43 -0700 2016-05-05 13:11:40 -0700 Patch patch.txt text/plain 2611 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyODAyMTcuLjU5MGQ2YmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA1LTA0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnNv bGUgaXMgdW5yZXNwb25zaXZlIGZvciA+MTAgc2Vjb25kcyB3aGVuIGl0IHRyaWVzIHRvIHJlbmRl ciAxMCwwMDAgbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NzM2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYxMDM2NTc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyIG9ubHkg dXAgdG8gMTAwIG1lc3NhZ2VzIHBlciBhbmltYXRpb24gZnJhbWUgdG8ga2VlcCB0aGUgSW5zcGVj dG9yJ3MgVUkgcmVzcG9uc2l2ZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlci5wcm90b3R5cGUucmVuZGVyUGVuZGluZ01lc3Nh Z2VzKToKKworMjAxNi0wNS0wNCAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNv bT4KKwogICAgICAgICBSRUdSRVNTSU9OIChyMjAwNDAxKTogV2ViIEluc3BlY3RvcjogVHlwZUVy cm9yOiB1bmRlZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnbWVzc2FnZUVsZW1l bnQuY2xhc3NMaXN0JykKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NzM1NgogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjYwOTc0MjQ+CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZh U2NyaXB0TG9nVmlld0NvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0TG9nVmlld0NvbnRyb2xsZXIuanMKaW5kZXgg ZDgyMjU5MS4uZmFmMzAxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQ29udHJvbGxlcnMvSmF2YVNjcmlwdExvZ1ZpZXdDb250cm9sbGVyLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3Jp cHRMb2dWaWV3Q29udHJvbGxlci5qcwpAQCAtMjg1LDEzICsyODUsMTMgQEAgV2ViSW5zcGVjdG9y LkphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciA9IGNsYXNzIEphdmFTY3JpcHRMb2dWaWV3Q29u dHJvbGxlciBleHQKICAgICAgICAgaWYgKHRoaXMuX3BlbmRpbmdNZXNzYWdlcy5sZW5ndGggPT09 IDApCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbGV0IGxhc3RNZXNzYWdlVmlldyA9 IHRoaXMuX3BlbmRpbmdNZXNzYWdlcy5sYXN0VmFsdWU7CisgICAgICAgIGNvbnN0IG1heE1lc3Nh Z2VzUGVyRnJhbWUgPSAxMDA7CisgICAgICAgIGxldCBtZXNzYWdlcyA9IHRoaXMuX3BlbmRpbmdN ZXNzYWdlcy5zcGxpY2UoMCwgbWF4TWVzc2FnZXNQZXJGcmFtZSk7CisKKyAgICAgICAgbGV0IGxh c3RNZXNzYWdlVmlldyA9IG1lc3NhZ2VzLmxhc3RWYWx1ZTsKICAgICAgICAgbGV0IGlzQ29tbWFu ZFZpZXcgPSBsYXN0TWVzc2FnZVZpZXcgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQ29uc29sZUNv bW1hbmRWaWV3OwogICAgICAgICBsZXQgc2hvdWxkU2Nyb2xsVG9Cb3R0b20gPSBpc0NvbW1hbmRW aWV3IHx8IGxhc3RNZXNzYWdlVmlldy5tZXNzYWdlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5Db25z b2xlTWVzc2FnZS5NZXNzYWdlVHlwZS5SZXN1bHQgfHwgdGhpcy5pc1Njcm9sbGVkVG9Cb3R0b20o KTsKIAotICAgICAgICB2YXIgbWVzc2FnZXMgPSB0aGlzLl9wZW5kaW5nTWVzc2FnZXM7Ci0gICAg ICAgIHRoaXMuX3BlbmRpbmdNZXNzYWdlcyA9IFtdOwotCiAgICAgICAgIGZvciAobGV0IG1lc3Nh Z2VWaWV3IG9mIG1lc3NhZ2VzKSB7CiAgICAgICAgICAgICBtZXNzYWdlVmlldy5yZW5kZXIoKTsK ICAgICAgICAgICAgIHRoaXMuX2RpZFJlbmRlckNvbnNvbGVNZXNzYWdlVmlldyhtZXNzYWdlVmll dyk7CkBAIC0zMDEsNiArMzAxLDkgQEAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRMb2dWaWV3Q29u dHJvbGxlciA9IGNsYXNzIEphdmFTY3JpcHRMb2dWaWV3Q29udHJvbGxlciBleHQKICAgICAgICAg ICAgIHRoaXMuc2Nyb2xsVG9Cb3R0b20oKTsKIAogICAgICAgICBXZWJJbnNwZWN0b3IucXVpY2tD b25zb2xlLm5lZWRzTGF5b3V0KCk7CisKKyAgICAgICAgaWYgKHRoaXMuX3BlbmRpbmdNZXNzYWdl cy5sZW5ndGggPiAwKQorICAgICAgICAgICAgdGhpcy5yZW5kZXJQZW5kaW5nTWVzc2FnZXNTb29u KCk7CiAgICAgfQogCiAgICAgcmVuZGVyUGVuZGluZ01lc3NhZ2VzU29vbigpCg==