157167 2016-04-29 00:29:42 -0700 r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font' 2016-05-07 13:02:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157066 P2 Normal --- 126492 1 jeremyhu webkit-unassigned cgarcia commit-queue darin mmaxfield oldest_to_newest 1188542 0 jeremyhu 2016-04-29 00:29:42 -0700 Current trunk (r200216) fails to build for darwin/gtk. r199646 does (with fixes for bugs #156679 and #156683). I have not narrowed down the regression. [ 20%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/SelectorPseudoElementTypeMap.cpp.o cd /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/Source/WebCore && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -DBUILDING_GTK__=1 -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DDATA_DIR=\"share\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DMESA_EGL_NO_X11_HEADERS -DUSER_AGENT_GTK_MAJOR_VERSION=\"602\" -DUSER_AGENT_GTK_MINOR_VERSION=\"1\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -DWEBKIT_DOM_USE_UNSTABLE_API -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/airplay -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/battery -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/encryptedmedia -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/fetch -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/geolocation -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/indexeddb -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/indexeddb/client -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/indexeddb/server -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/indexeddb/shared -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/indieui -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/mediacontrols -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/mediasession -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/mediasource -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/mediastream -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/navigatorcontentutils -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/notifications -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/plugins -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/proximity -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/quota -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/speech -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/streams -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/vibration -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/webaudio -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/webdatabase -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/Modules/websockets -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/accessibility -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/animation -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bindings -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bindings/generic -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bindings/js -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bridge -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bridge/c -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bridge/jsc -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/contentextensions -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/crypto -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/crypto/algorithms -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/crypto/keys -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/crypto/parameters -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/css -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/cssjit -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/dom -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/dom/default -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/editing -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/fileapi -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/history -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html/canvas -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html/forms -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html/parser -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html/shadow -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/html/track -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/inspector -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader/appcache -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader/archive -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader/archive/mhtml -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader/cache -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/loader/icon -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/mathml -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/page -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/page/animation -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/page/csp -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/page/scrolling -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/animation -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/audio -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/crypto -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/cpu/arm -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/cpu/arm/filters -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/displaylists -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/filters -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/harfbuzz -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/harfbuzz/ng -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/opentype -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/transforms -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/mediastream -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/mock -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/mock/mediasource -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/network -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/sql -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/text -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/text/icu -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/plugins -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/line -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/mathml -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/shapes -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/style -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/svg -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/replay -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/storage -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/style -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/svg -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/svg/animation -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/svg/graphics -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/svg/graphics/filters -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/svg/properties -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/websockets -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/workers -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/xml -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/xml/parser -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/ForwardingHeaders -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/WebCore -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/gpu -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/ThirdParty/woff2/src -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/mediastream/openwebrtc -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/gstreamer -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/audio/gstreamer -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/bmp -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/gif -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/ico -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/jpeg -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/png -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/image-decoders/webp -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/linux -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/texmap -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/JavaScriptCore -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/JavaScriptCore/inspector -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/ForwardingHeaders -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/API -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/assembler -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/bytecode -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/bytecompiler -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/dfg -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/disassembler -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/heap -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/debugger -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/interpreter -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/jit -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/llint -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/parser -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/profiler -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/runtime -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/JavaScriptCore/yarr -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/ThirdParty/ANGLE -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/ThirdParty/ANGLE/include/KHR -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/accessibility/atk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/editing/atk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/page/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/cairo -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/geoclue -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/cairo -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/egl -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/glx -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/freetype -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/opengl -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/wayland -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/x11 -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/mediastream/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/network/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/network/soup -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/text/gtk -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WTF -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/bindings/gobject -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/webkitdom -isystem /opt/local/include -isystem /opt/local/include/gstreamer-1.0 -isystem /opt/local/lib/gstreamer-1.0/include -isystem /opt/local/include/glib-2.0 -isystem /opt/local/lib/glib-2.0/include -isystem /opt/local/include/atk-1.0 -isystem /opt/local/include/cairo -isystem /opt/local/include/enchant -isystem /opt/local/include/freetype2/freetype -isystem /opt/local/include/freetype2 -isystem /opt/local/include/gio-unix-2.0 -isystem /opt/local/include/harfbuzz -isystem /opt/local/include/libsecret-1 -isystem /opt/local/include/libsoup-2.4 -isystem /opt/local/include/libxml2 -I/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/testing -pipe -Os -ftemplate-depth=256 -stdlib=libc++ -std=c++11 -Qunused-arguments -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -arch x86_64 -mmacosx-version-min=10.11 -Wall -Wextra -Wcast-align -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wundef -Wwrite-strings -Wno-parentheses-equality -fPIC -o CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/SelectorPseudoElementTypeMap.cpp.o -c /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/WebCore/SelectorPseudoElementTypeMap.cpp In file included from /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/build/DerivedSources/WebCore/StyleBuilder.cpp:8: In file included from /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/style/RenderStyle.h:60: In file included from /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/rendering/style/StyleInheritedData.h:29: In file included from /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/FontCascade.h:29: In file included from /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/Font.h:30: /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/FontPlatformData.h:178:65: error: use of undeclared identifier 'm_font' uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get())); ^ 1188635 1 jeremyhu 2016-04-29 09:16:48 -0700 Note that r200069 doesn't have this issue, but it does fail to link due to bug #157182 1189156 2 jeremyhu 2016-04-30 20:45:16 -0700 Narrowed it down a bit more. It looks like this was caused by r200129 (bug #157066) 1189701 3 cgarcia 2016-05-03 01:23:41 -0700 (In reply to comment #2) > Narrowed it down a bit more. It looks like this was caused by r200129 (bug > #157066) So, is cairo used when building WebKitGTK+ for darwin? The thing is that in FontPlatformData.h m_font is defined for PLATFORM(COCOA) but then used when USE(APPKIT) is defined. I suspect in your case PLATFORM(COCOA) is false because you are building GTK, but USE(APPKIT) is true because you are building for mac. So, I think that inconsistency should be fixed in that header, either use USE(APPKIT) in all the cases or PLATFORM(COCOA), but i have no idea what should be used in your case. 1189702 4 cgarcia 2016-05-03 01:25:26 -0700 hmm, looking at the code again it's not USE(APPKIT), but OS(DARWIN). 1189738 5 darin 2016-05-03 08:10:35 -0700 Something high level like this normally should not use OS(DARWIN). Where is the OS(DARWIN) check we are talking about? 1189989 6 cgarcia 2016-05-04 00:00:49 -0700 (In reply to comment #5) > Something high level like this normally should not use OS(DARWIN). Where is > the OS(DARWIN) check we are talking about? /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/platform/graphics/FontPlatformData.h:178:65: error: use of undeclared identifier 'm_font' uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get())); ^ 1190413 7 darin 2016-05-05 12:30:16 -0700 (In reply to comment #6) > (In reply to comment #5) > > Something high level like this normally should not use OS(DARWIN). Where is > > the OS(DARWIN) check we are talking about? > > /opt/local/var/macports/build/ > _Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk- > devel/work/webkit-999e572d853fe32b9fb11955bc1a8f7ed97632c7/Source/WebCore/ > platform/graphics/FontPlatformData.h:178:65: error: use of undeclared > identifier 'm_font' > uintptr_t fontHash = > reinterpret_cast<uintptr_t>(CFHash(m_font.get())); > ^ That's the error, but where is the OS(DARWIN) conditional? I suspect we can just correct it and fix this bug. I am currently using an iPhone and can't easily go find the code myself. 1190627 8 cgarcia 2016-05-05 23:02:02 -0700 The ifdef is in that line, see the whole context: unsigned hash() const { #if PLATFORM(WIN) && !USE(CAIRO) return m_font ? m_font->hash() : 0; #elif OS(DARWIN) uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 5 | m_textRenderingMode << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique); #if USE(APPKIT) uintptr_t fontHash = (uintptr_t)m_font.get(); #else uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get())); #endif uintptr_t hashCodes[3] = { fontHash, m_widthVariant, flags }; return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes); #elif USE(CAIRO) return PtrHash<cairo_scaled_font_t*>::hash(m_scaledFont.get()); #endif } http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/FontPlatformData.h#L168 If cairo is used when building WebKitGTK+ on darwin, we should be using the cairo implementation of the hash. But I don't know if we should just replace the OS(DARWIN) by PLATFORM(COCOA) or change the order of the ifdefs. 1190641 9 jeremyhu 2016-05-06 00:02:55 -0700 It seems to me like it should be something like this: #if USE(CAIRO) return PtrHash<cairo_scaled_font_t*>::hash(m_scaledFont.get()); #elif PLATFORM(WIN) return m_font ? m_font->hash() : 0; #elif PLATFORM(COCOA) uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 5 | m_textRenderingMode << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique); #if USE(APPKIT) uintptr_t fontHash = (uintptr_t)m_font.get(); #else uintptr_t fontHash = reinterpret_cast<uintptr_t>(CFHash(m_font.get())); #endif uintptr_t hashCodes[3] = { fontHash, m_widthVariant, flags }; return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes); #else #error "Unsupported configuration" #endif 1190644 10 278242 jeremyhu 2016-05-06 00:14:35 -0700 Created attachment 278242 proposed change Testing the proposed change now. 1190678 11 jeremyhu 2016-05-06 08:28:05 -0700 Yep, that seems to work. 1190689 12 mmaxfield 2016-05-06 09:45:24 -0700 Out of curiosity, are we planning on making Darwin/GTK a first-party port? 1190690 13 jeremyhu 2016-05-06 09:52:32 -0700 It's been working great in MacPorts for quite some time. The main issues we run into are incorrect assumptions like this that happen every once in a while. I had an email chain about setting up a darwin/gtk CI system for webkit.org to use, but that thread went dead. I'm still interested in helping out with that effort as it will certainly catch these issues sooner. 1190698 14 darin 2016-05-06 11:01:26 -0700 (In reply to comment #9) > It seems to me like it should be something like this: Better, and will almost certainly solve the problem, but not I am not sure this is quite right. > #elif PLATFORM(COCOA) This should probably be USE(APPKIT) || xxx Myles, what are we using elsewhere in the font code? Are we using PLATFORM(COCOA)? 1190758 15 mmaxfield 2016-05-06 14:05:38 -0700 (In reply to comment #14) > (In reply to comment #9) > > It seems to me like it should be something like this: > > Better, and will almost certainly solve the problem, but not I am not sure > this is quite right. > > > #elif PLATFORM(COCOA) > > This should probably be USE(APPKIT) || xxx > > Myles, what are we using elsewhere in the font code? Are we using > PLATFORM(COCOA)? I've mostly seen #if blocks mentioning COCOA / MAC / IOS. For the issue about being a first-party port, I can refer you to https://trac.webkit.org/wiki/SuccessfulPortHowTo. Usually we require the following before a port is considered first party: - A buildbot running that reports results to https://build.webkit.org/dashboard/ - Two reviewers who are familiar with the port I'm happy to review patches to keep these non-first-party ports up and running, but you should know that breakages like these will likely continue until the port is considered first party. 1190759 16 278242 mmaxfield 2016-05-06 14:09:03 -0700 Comment on attachment 278242 proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=278242&action=review > Source/WebCore/platform/graphics/FontPlatformData.h:176 > #if USE(APPKIT) I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)? If so, I think we should migrate to it; otherwise, I suppose it's fine how it is. 1190783 17 278242 darin 2016-05-06 14:59:08 -0700 Comment on attachment 278242 proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=278242&action=review >> Source/WebCore/platform/graphics/FontPlatformData.h:176 >> #if USE(APPKIT) > > I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)? > > If so, I think we should migrate to it; otherwise, I suppose it's fine how it is. Yes, it will work with PLATFORM(MAC). No, I don’t agree that we should migrate to it. We should talk in person about our long term direction for platform #if statements; our goal was to use things like USE(APPKIT) to tell us whether to use an AppKit class like NSFont, rather than something more like PLATFORM(MAC). Maciej was the original visionary for this, although we have not moved very far in that direction. 1190803 18 mmaxfield 2016-05-06 15:39:57 -0700 (In reply to comment #17) > Comment on attachment 278242 [details] > proposed change > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278242&action=review > > >> Source/WebCore/platform/graphics/FontPlatformData.h:176 > >> #if USE(APPKIT) > > > > I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)? > > > > If so, I think we should migrate to it; otherwise, I suppose it's fine how it is. > > Yes, it will work with PLATFORM(MAC). > > No, I don’t agree that we should migrate to it. > > We should talk in person about our long term direction for platform #if > statements; our goal was to use things like USE(APPKIT) to tell us whether > to use an AppKit class like NSFont, rather than something more like > PLATFORM(MAC). Maciej was the original visionary for this, although we have > not moved very far in that direction. Ultimately, we want to move off NSFont wholesale. Perhaps we need a USE(CORETEXT)? 1190962 19 278242 darin 2016-05-07 12:40:38 -0700 Comment on attachment 278242 proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=278242&action=review >>>> Source/WebCore/platform/graphics/FontPlatformData.h:176 >>>> #if USE(APPKIT) >>> >>> I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)? >>> >>> If so, I think we should migrate to it; otherwise, I suppose it's fine how it is. >> >> Yes, it will work with PLATFORM(MAC). >> >> No, I don’t agree that we should migrate to it. >> >> We should talk in person about our long term direction for platform #if statements; our goal was to use things like USE(APPKIT) to tell us whether to use an AppKit class like NSFont, rather than something more like PLATFORM(MAC). Maciej was the original visionary for this, although we have not moved very far in that direction. > > Ultimately, we want to move off NSFont wholesale. > > Perhaps we need a USE(CORETEXT)? If we move off NSFont, then I don’t think we’ll need this particular #if at all. 1190968 20 278242 commit-queue 2016-05-07 13:02:01 -0700 Comment on attachment 278242 proposed change Clearing flags on attachment: 278242 Committed r200545: <http://trac.webkit.org/changeset/200545> 1190969 21 commit-queue 2016-05-07 13:02:06 -0700 All reviewed patches have been landed. Closing bug. 278242 2016-05-06 00:14:35 -0700 2016-05-07 13:02:01 -0700 proposed change 0001-Fix-an-incorrect-usage-of-OS-DARWIN-with-PLATFORM-CO.patch text/plain 2343 jeremyhu RnJvbSAzZDI0YzZiNjgzYTk3OTc4NDgyODQyZjdjMWM1MjNhNzhjOTc3MDYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IEZyaSwgNiBNYXkgMjAxNiAwMDowOToyNyAtMDcwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBhbiBpbmNvcnJlY3QgdXNhZ2Ugb2YgT1MoREFSV0lOKSB3aXRoIFBMQVRGT1JN KENPQ09BKQoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NzE2NwoK U2lnbmVkLW9mZi1ieTogSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSA8amVyZW15aHVAYXBwbGUu Y29tPgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8IDEwICsrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRQbGF0Zm9ybURhdGEuaCB8IDEwICsrKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzJjMjc4Zi4uZDU1MjMz OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA1LTA2ICBKZXJlbXkgSHVkZGxl c3RvbiBTZXF1b2lhICA8amVyZW15aHVAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBhbiBpbmNv cnJlY3QgdXNhZ2Ugb2YgT1MoREFSV0lOKSB3aXRoIFBMQVRGT1JNKENPQ09BKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU3MTY3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9Gb250UGxhdGZvcm1EYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRh OjpoYXNoKToKKwogMjAxNi0wNS0wNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFtpT1NdIFdlYkNvcmUgZG9lcyBub3QgbmVlZCB0byBsaW5rIHRvIENvcmVB dWRpbywgR3JhcGhpY3NTZXJ2aWNlcywgU3lzdGVtQ29uZmlndXJhdGlvbiBmcmFtZXdvcmtzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1E YXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRh LmgKaW5kZXggODI3ZjU0MC4uZDE2ZjZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRm9udFBsYXRmb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0ZvbnRQbGF0Zm9ybURhdGEuaApAQCAtMTY3LDkgKzE2NywxMSBAQCBw dWJsaWM6CiAKICAgICB1bnNpZ25lZCBoYXNoKCkgY29uc3QKICAgICB7Ci0jaWYgUExBVEZPUk0o V0lOKSAmJiAhVVNFKENBSVJPKQorI2lmIFVTRShDQUlSTykKKyAgICAgICAgcmV0dXJuIFB0ckhh c2g8Y2Fpcm9fc2NhbGVkX2ZvbnRfdCo+OjpoYXNoKG1fc2NhbGVkRm9udC5nZXQoKSk7CisjZWxp ZiBQTEFURk9STShXSU4pCiAgICAgICAgIHJldHVybiBtX2ZvbnQgPyBtX2ZvbnQtPmhhc2goKSA6 IDA7Ci0jZWxpZiBPUyhEQVJXSU4pCisjZWxpZiBQTEFURk9STShDT0NPQSkKICAgICAgICAgdWlu dHB0cl90IGZsYWdzID0gc3RhdGljX2Nhc3Q8dWludHB0cl90PihtX2lzSGFzaFRhYmxlRGVsZXRl ZFZhbHVlIDw8IDUgfCBtX3RleHRSZW5kZXJpbmdNb2RlIDw8IDMgfCBtX29yaWVudGF0aW9uIDw8 IDIgfCBtX3N5bnRoZXRpY0JvbGQgPDwgMSB8IG1fc3ludGhldGljT2JsaXF1ZSk7CiAjaWYgVVNF KEFQUEtJVCkKICAgICAgICAgdWludHB0cl90IGZvbnRIYXNoID0gKHVpbnRwdHJfdCltX2ZvbnQu Z2V0KCk7CkBAIC0xNzgsOCArMTgwLDggQEAgcHVibGljOgogI2VuZGlmCiAgICAgICAgIHVpbnRw dHJfdCBoYXNoQ29kZXNbM10gPSB7IGZvbnRIYXNoLCBtX3dpZHRoVmFyaWFudCwgZmxhZ3MgfTsK ICAgICAgICAgcmV0dXJuIFN0cmluZ0hhc2hlcjo6aGFzaE1lbW9yeTxzaXplb2YoaGFzaENvZGVz KT4oaGFzaENvZGVzKTsKLSNlbGlmIFVTRShDQUlSTykKLSAgICAgICAgcmV0dXJuIFB0ckhhc2g8 Y2Fpcm9fc2NhbGVkX2ZvbnRfdCo+OjpoYXNoKG1fc2NhbGVkRm9udC5nZXQoKSk7CisjZWxzZQor I2Vycm9yICJVbnN1cHBvcnRlZCBjb25maWd1cmF0aW9uIgogI2VuZGlmCiAgICAgfQogCi0tIAoy LjguMQoK