156954 2016-04-23 09:30:19 -0700 [Win] The function findTopLevelParent should return the first window which is not a child. 2023-10-27 18:13:56 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 peavo webkit-unassigned ahmad.saleem792 beidson bfulgham darin ddkilzer oldest_to_newest 1186621 0 peavo 2016-04-23 09:30:19 -0700 The function findTopLevelParent is used when the active state of the browser is determined. It usually works very well, but when there is a window with the style WS_POPUP in the hierarchy which has a parent, the function will not return this window, but keep walking the hierarchy. A window with the WS_POPUP style cannot have the WS_CHILD style, and is a type of top level window, even though it can have a parent/owner. 1186622 1 277151 peavo 2016-04-23 09:35:03 -0700 Created attachment 277151 Patch 1186745 2 277151 darin 2016-04-24 09:47:56 -0700 Comment on attachment 277151 Patch How did you test this change? 1340432 3 277151 beidson 2017-08-19 16:01:28 -0700 Comment on attachment 277151 Patch r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form. 1988160 4 ahmad.saleem792 2023-10-27 18:13:56 -0700 This seems to be not applied: https://github.com/WebKit/WebKit/blob/02f9dd1869da489a1d8ccc25e7e9b8a86aadef58/Source/WebKit/UIProcess/win/WebView.cpp#L302 277151 2016-04-23 09:35:03 -0700 2017-08-19 16:01:28 -0700 Patch bug-156954-20160423183531.patch text/plain 1722 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTk0OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTIz ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSBU aGUgZnVuY3Rpb24gZmluZFRvcExldmVsUGFyZW50IHNob3VsZCByZXR1cm4gdGhlIGZpcnN0IHdp bmRvdyB3aGljaCBpcyBub3QgYSBjaGlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1Njk1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBmdW5jdGlvbiBmaW5kVG9wTGV2ZWxQYXJlbnQgaXMgdXNl ZCB3aGVuIHRoZSBhY3RpdmUgc3RhdGUgb2YgdGhlIGJyb3dzZXIgaXMgZGV0ZXJtaW5lZC4KKyAg ICAgICAgSXQgdXN1YWxseSB3b3JrcyB2ZXJ5IHdlbGwsIGJ1dCB3aGVuIHRoZXJlIGlzIGEgd2lu ZG93IHdpdGggdGhlIHN0eWxlIFdTX1BPUFVQIGluIHRoZQorICAgICAgICBoaWVyYXJjaHkgd2hp Y2ggaGFzIGEgcGFyZW50LCB0aGUgZnVuY3Rpb24gd2lsbCBub3QgcmV0dXJuIHRoaXMgd2luZG93 LCBidXQga2VlcCB3YWxraW5nCisgICAgICAgIHRoZSBoaWVyYXJjaHkuIEEgd2luZG93IHdpdGgg dGhlIFdTX1BPUFVQIHN0eWxlIGNhbm5vdCBoYXZlIHRoZSBXU19DSElMRCBzdHlsZSwgYW5kIGlz IGEKKyAgICAgICAgdHlwZSBvZiB0b3AgbGV2ZWwgd2luZG93LCBldmVuIHRob3VnaCBpdCBjYW4g aGF2ZSBhIHBhcmVudC9vd25lci4KKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAo ZmluZFRvcExldmVsUGFyZW50KToKKwogMjAxNi0wNC0yMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxn aGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciA0MTk5 ODQxLgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDE5OTk0NykKKysrIFNvdXJj ZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzQ0LDcgKzIzNDQs NyBAQCBzdGF0aWMgSFdORCBmaW5kVG9wTGV2ZWxQYXJlbnQoSFdORCB3aW5kCiAKICAgICBIV05E IGN1cnJlbnQgPSB3aW5kb3c7CiAgICAgZm9yIChIV05EIHBhcmVudCA9IEdldFBhcmVudChjdXJy ZW50KTsgY3VycmVudDsgY3VycmVudCA9IHBhcmVudCwgcGFyZW50ID0gR2V0UGFyZW50KHBhcmVu dCkpCi0gICAgICAgIGlmICghcGFyZW50IHx8ICEoR2V0V2luZG93TG9uZ1B0cihjdXJyZW50LCBH V0xfU1RZTEUpICYgKFdTX1BPUFVQIHwgV1NfQ0hJTEQpKSkKKyAgICAgICAgaWYgKCFwYXJlbnQg fHwgIShHZXRXaW5kb3dMb25nUHRyKGN1cnJlbnQsIEdXTF9TVFlMRSkgJiBXU19DSElMRCkpCiAg ICAgICAgICAgICByZXR1cm4gY3VycmVudDsKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAg ICByZXR1cm4gMDsK