<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>156683</bug_id>
          
          <creation_ts>2016-04-17 16:04:13 -0700</creation_ts>
          <short_desc>libjavascriptcoregtk-4.0.dylib is no longer installed</short_desc>
          <delta_ts>2016-04-18 00:14:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Huddleston Sequoia">jeremyhu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1184531</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2016-04-17 16:04:13 -0700</bug_when>
    <thetext>libjavascriptcoregtk-4.0.dylib is not installed by &apos;make install&apos; in r199646.

Last known good was r198900.

Multiple unrelated build failures plague simple bisection.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184532</commentid>
    <comment_count>1</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2016-04-17 16:07:44 -0700</bug_when>
    <thetext>Looks like it was caused by https://bugs.webkit.org/show_bug.cgi?id=156268

More incorrect assumptions that APPLE == Mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184551</commentid>
    <comment_count>2</comment_count>
      <attachid>276613</attachid>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2016-04-17 17:09:54 -0700</bug_when>
    <thetext>Created attachment 276613
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

This patch fixes the issue and is being used now by MacPorts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184579</commentid>
    <comment_count>3</comment_count>
      <attachid>276613</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-04-17 23:01:20 -0700</bug_when>
    <thetext>Comment on attachment 276613
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

My bad</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184584</commentid>
    <comment_count>4</comment_count>
      <attachid>276613</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-17 23:52:27 -0700</bug_when>
    <thetext>Comment on attachment 276613
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

Clearing flags on attachment: 276613

Committed r199651: &lt;http://trac.webkit.org/changeset/199651&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184585</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-17 23:52:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184586</commentid>
    <comment_count>6</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-04-18 00:08:27 -0700</bug_when>
    <thetext>There&apos;s probably a similar assumption in WebKit2/CMakeLists.txt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1184590</commentid>
    <comment_count>7</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-04-18 00:14:28 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; There&apos;s probably a similar assumption in WebKit2/CMakeLists.txt.
Fixed in https://bugs.webkit.org/show_bug.cgi?id=156679</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>276613</attachid>
            <date>2016-04-17 17:09:54 -0700</date>
            <delta_ts>2016-04-17 23:52:27 -0700</delta_ts>
            <desc>0001-Fix-incorrect-assumption-that-APPLE-implies-Mac</desc>
            <filename>0001-Fix-incorrect-assumption-that-APPLE-implies-Mac.patch</filename>
            <type>text/plain</type>
            <size>1792</size>
            <attacher name="Jeremy Huddleston Sequoia">jeremyhu</attacher>
            
              <data encoding="base64">RnJvbSAwNDc5Y2IzYWZkNTJhNGFjMDdkYTEwMWRiYjJhMzk2NWMzYjczZWMyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh
cHBsZS5jb20+CkRhdGU6IFN1biwgMTcgQXByIDIwMTYgMTY6MTM6MzcgLTA3MDAKU3ViamVjdDog
W1BBVENIXSBGaXggaW5jb3JyZWN0IGFzc3VtcHRpb24gdGhhdCBBUFBMRSBpbXBsaWVzIE1hYy4K
Cmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY2ODMKCkFkZHJlc3Nl
cyBidWlsZCBmYWlsdXJlIGludHJvZHVjZWQgaW4gcjE5OTA5NAoKU2lnbmVkLW9mZi1ieTogSmVy
ZW15IEh1ZGRsZXN0b24gU2VxdW9pYSA8amVyZW15aHVAYXBwbGUuY29tPgotLS0KIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCB8ICAyICstCiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nICAgICAgfCAxMSArKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMiBp
bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMu
dHh0CmluZGV4IGVlNjdmODkuLjQ0NzM5YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0
cy50eHQKQEAgLTEzMjksNyArMTMyOSw3IEBAIGFkZF9zdWJkaXJlY3Rvcnkoc2hlbGwpCiBXRUJL
SVRfV1JBUF9TT1VSQ0VMSVNUKCR7SmF2YVNjcmlwdENvcmVfU09VUkNFU30pCiBXRUJLSVRfRlJB
TUVXT1JLKEphdmFTY3JpcHRDb3JlKQogCi1pZiAoTk9UIEFQUExFKQoraWYgKE5PVCAiJHtQT1JU
fSIgU1RSRVFVQUwgIk1hYyIpCiAgICAgaWYgKCR7SmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBF
fSBTVFJFUVVBTCAiU0hBUkVEIikKICAgICAgICAgUE9QVUxBVEVfTElCUkFSWV9WRVJTSU9OKEpB
VkFTQ1JJUFRDT1JFKQogICAgICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoSmF2YVNjcmlwdENv
cmUgUFJPUEVSVElFUyBWRVJTSU9OICR7SkFWQVNDUklQVENPUkVfVkVSU0lPTn0gU09WRVJTSU9O
ICR7SkFWQVNDUklQVENPUkVfVkVSU0lPTl9NQUpPUn0pCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpp
bmRleCA5ZGI5MTFiLi43NTVkYzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNCBAQAorMjAxNi0wNC0xNyAgSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSAgPGplcmVteWh1
QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW5jb3JyZWN0IGFzc3VtcHRpb24gdGhhdCBBUFBM
RSBpbXBsaWVzIE1hYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE1NjY4MworICAgIAorICAgICAgICBBZGRyZXNzZXMgYnVpbGQgZmFpbHVyZSBpbnRy
b2R1Y2VkIGluIHIxOTkwOTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE2LTA0LTE3ICBEYXJpbiBBZGxlciAg
PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbW9yZSB1c2VzIG9mIERlcHJlY2F0
ZWQ6OlNjcmlwdFhYWAotLSAKMi44LjEKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>