156589 2016-04-14 13:34:46 -0700 [css-grid] Add method to translate RTL coordinates 2016-04-18 01:03:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 156597 1 rego rego commit-queue esprehn+autocc glenn jfernandez kondapallykalyan simon.fraser svillar oldest_to_newest 1183814 0 rego 2016-04-14 13:34:46 -0700 [css-grid] Add method to translate RTL coordinates 1183816 1 276418 rego 2016-04-14 13:35:07 -0700 Created attachment 276418 Patch 1183823 2 rego 2016-04-14 13:40:07 -0700 This method was introduced in Blink in: https://codereview.chromium.org/1873163002/ The whole patch from Blink is not needed, as we don't have any painting optimization in WebKit. 1184121 3 276418 tonikitoo 2016-04-15 10:47:36 -0700 Comment on attachment 276418 Patch r=me 1184588 4 276418 rego 2016-04-18 00:10:09 -0700 Comment on attachment 276418 Patch Thanks for the review. 1184599 5 276418 commit-queue 2016-04-18 01:03:10 -0700 Comment on attachment 276418 Patch Clearing flags on attachment: 276418 Committed r199655: <http://trac.webkit.org/changeset/199655> 1184600 6 commit-queue 2016-04-18 01:03:14 -0700 All reviewed patches have been landed. Closing bug. 276418 2016-04-14 13:35:07 -0700 2016-04-18 01:03:10 -0700 Patch bug-156589-20160414223519.patch text/plain 4348 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU0ZjFjMjIyM2FmZmQy OTMxNzZlOWI0ZjlmNTZkYWM5MjM2ZmVhZi4uODE4ZWU3NTg5MDUyMGYwMjM4MmViOTUxNTZiZmRj ZjNlYWJhNzg5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA0LTE0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gQWRkIG1ldGhvZCB0byB0cmFuc2xhdGUgUlRMIGNvb3JkaW5hdGVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY1ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGp1c3QgYSBzbWFsbCBy ZWZhY3RvcmluZyBhZGRpbmcgYSBuZXcgZnVuY3Rpb24KKyAgICAgICAgTGF5b3V0R3JpZDo6dHJh bnNsYXRlUlRMQ29vcmRpbmF0ZSgpLgorICAgICAgICBUaGlzIG1ldGhvZCB0cmFuc2xhdGVzIHRv IHBoeXNpY2FsIGNvb3JkaW5hdGVzIHRoZSBpbmZvcm1hdGlvbgorICAgICAgICBzdG9yZWQgaW4g bV9jb2x1bW5Qb3NpdGlvbnMgd2hlbiB5b3UncmUgdXNpbmcgUlRMIGRpcmVjdGlvbi4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJHcmlkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6Om9m ZnNldEFuZEJyZWFkdGhGb3JQb3NpdGlvbmVkQ2hpbGQpOiBVc2UgdGhlIG5ldworICAgICAgICBt ZXRob2QgdHJhbnNsYXRlUlRMQ29vcmRpbmF0ZSgpLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy R3JpZDo6dHJhbnNsYXRlUlRMQ29vcmRpbmF0ZSk6IE5ldyBtZXRob2QgdGhhdCBjb252ZXJ0cwor ICAgICAgICBhIGNvb3JkaW5hdGUgZnJvbSBtX2NvbHVtblBvc2l0aW9ucyBpbiBSVEwgaW50byBh IHBoeXNpY2FsIGNvb3JkaW5hdGUuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpmaW5k Q2hpbGRMb2dpY2FsUG9zaXRpb24pOiBVc2UgdGhlIG5ldyBtZXRob2QKKyAgICAgICAgdHJhbnNs YXRlUlRMQ29vcmRpbmF0ZSgpLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHcmlkLmg6IEFk ZCBtZXRob2Qgc2lnbmF0dXJlLgorCiAyMDE2LTA0LTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR09iamVjdCBE T00gYmluZGluZ3MgQVBJIGJyZWFrIGFmdGVyIHIxOTkzOTIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyR3JpZC5jcHAKaW5kZXggYTcyMjNjMWM2Y2I5MGU5YzYxMzU4NTZkNGRhYjQwYmZj YmQ1MTNkZC4uMmRhZjcxMDYwZjAwZjVlODNjYzk1NDY5MjZjNWFhMjlhZjc0ZDEwNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtMTU0Nyw5ICsxNTQ3LDcgQEAg dm9pZCBSZW5kZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxkKGNvbnN0 IFJlbmRlckJveCYgY2hpbGQsIEdyaWQKICAgICAgICAgaWYgKGVuZElzQXV0bykKICAgICAgICAg ICAgIG9mZnNldCA9IExheW91dFVuaXQoKTsKICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBM YXlvdXRVbml0IGFsaWdubWVudE9mZnNldCA9ICBtX2NvbHVtblBvc2l0aW9uc1swXSAtIGJvcmRl ckFuZFBhZGRpbmdTdGFydCgpOwotICAgICAgICAgICAgTGF5b3V0VW5pdCBvZmZzZXRGcm9tTGFz dExpbmUgPSBtX2NvbHVtblBvc2l0aW9uc1ttX2NvbHVtblBvc2l0aW9ucy5zaXplKCkgLSAxXSAt IG1fY29sdW1uUG9zaXRpb25zW2VuZExpbmVdOwotICAgICAgICAgICAgb2Zmc2V0ID0gcGFkZGlu Z0xlZnQoKSArICBhbGlnbm1lbnRPZmZzZXQgKyBvZmZzZXRGcm9tTGFzdExpbmU7CisgICAgICAg ICAgICBvZmZzZXQgPSB0cmFuc2xhdGVSVExDb29yZGluYXRlKG1fY29sdW1uUG9zaXRpb25zW2Vu ZExpbmVdKSAtIGJvcmRlckxlZnQoKTsKIAogICAgICAgICAgICAgaWYgKGVuZExpbmUgPiBmaXJz dEV4cGxpY2l0TGluZSAmJiBlbmRMaW5lIDwgbGFzdEV4cGxpY2l0TGluZSkKICAgICAgICAgICAg ICAgICBvZmZzZXQgKz0gZ3V0dGVyc1NpemUoZGlyZWN0aW9uLCAyKTsKQEAgLTIwNDksMTYgKzIw NDcsMjIgQEAgQ29udGVudEFsaWdubWVudERhdGEgUmVuZGVyR3JpZDo6Y29tcHV0ZUNvbnRlbnRQ b3NpdGlvbkFuZERpc3RyaWJ1dGlvbk9mZnNldChHcmkKICAgICByZXR1cm4gezAsIDB9OwogfQog CitMYXlvdXRVbml0IFJlbmRlckdyaWQ6OnRyYW5zbGF0ZVJUTENvb3JkaW5hdGUoTGF5b3V0VW5p dCBjb29yZGluYXRlKSBjb25zdAoreworICAgIEFTU0VSVCghc3R5bGUoKS5pc0xlZnRUb1JpZ2h0 RGlyZWN0aW9uKCkpOworCisgICAgTGF5b3V0VW5pdCBhbGlnbm1lbnRPZmZzZXQgPSBtX2NvbHVt blBvc2l0aW9uc1swXSAtIGJvcmRlckFuZFBhZGRpbmdTdGFydCgpOworICAgIExheW91dFVuaXQg cmlnaHRHcmlkRWRnZVBvc2l0aW9uID0gbV9jb2x1bW5Qb3NpdGlvbnNbbV9jb2x1bW5Qb3NpdGlv bnMuc2l6ZSgpIC0gMV07CisgICAgcmV0dXJuIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsTGVmdCgp ICsgcmlnaHRHcmlkRWRnZVBvc2l0aW9uICsgYWxpZ25tZW50T2Zmc2V0IC0gY29vcmRpbmF0ZTsK K30KKwogTGF5b3V0UG9pbnQgUmVuZGVyR3JpZDo6ZmluZENoaWxkTG9naWNhbFBvc2l0aW9uKGNv bnN0IFJlbmRlckJveCYgY2hpbGQpIGNvbnN0CiB7CiAgICAgTGF5b3V0VW5pdCByb3dBeGlzT2Zm c2V0ID0gcm93QXhpc09mZnNldEZvckNoaWxkKGNoaWxkKTsKICAgICAvLyBXZSBzdG9yZWQgbV9j b2x1bW5Qb3NpdGlvbnMncyBkYXRhIGlnbm9yaW5nIHRoZSBkaXJlY3Rpb24sIGhlbmNlIHdlIG1p Z2h0IG5lZWQgbm93CiAgICAgLy8gdG8gdHJhbnNsYXRlIHBvc2l0aW9ucyBmcm9tIFJUTCB0byBM VFIsIGFzIGl0J3MgbW9yZSBjb252ZW5pZW50IGZvciBwYWludGluZy4KLSAgICBpZiAoIXN0eWxl KCkuaXNMZWZ0VG9SaWdodERpcmVjdGlvbigpKSB7Ci0gICAgICAgIExheW91dFVuaXQgYWxpZ25t ZW50T2Zmc2V0ID0gIG1fY29sdW1uUG9zaXRpb25zWzBdIC0gYm9yZGVyQW5kUGFkZGluZ1N0YXJ0 KCk7Ci0gICAgICAgIExheW91dFVuaXQgcmlnaHRHcmlkRWRnZVBvc2l0aW9uID0gbV9jb2x1bW5Q b3NpdGlvbnNbbV9jb2x1bW5Qb3NpdGlvbnMuc2l6ZSgpIC0gMV0gKyBhbGlnbm1lbnRPZmZzZXQg KyBib3JkZXJBbmRQYWRkaW5nTG9naWNhbExlZnQoKTsKLSAgICAgICAgcm93QXhpc09mZnNldCA9 IHJpZ2h0R3JpZEVkZ2VQb3NpdGlvbiAtIChyb3dBeGlzT2Zmc2V0ICsgY2hpbGQubG9naWNhbFdp ZHRoKCkpOwotICAgIH0KKyAgICBpZiAoIXN0eWxlKCkuaXNMZWZ0VG9SaWdodERpcmVjdGlvbigp KQorICAgICAgICByb3dBeGlzT2Zmc2V0ID0gdHJhbnNsYXRlUlRMQ29vcmRpbmF0ZShyb3dBeGlz T2Zmc2V0KSAtIGNoaWxkLmxvZ2ljYWxXaWR0aCgpOwogCiAgICAgcmV0dXJuIExheW91dFBvaW50 KHJvd0F4aXNPZmZzZXQsIGNvbHVtbkF4aXNPZmZzZXRGb3JDaGlsZChjaGlsZCkpOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuaCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmgKaW5kZXggMDQ0YjZlMTBhMmRjZDMzMTZjZGY0 Njk0ODQ1MTE5ZjZjZmMzMWQxYS4uNWNmODQ5ZDY5YTJhNTdiNmNmYjhlZGNmYTliMWE3MmQ5NzBh ZWUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5oCkBAIC0xODEsNiArMTgx LDcgQEAgcHJpdmF0ZToKICAgICB9CiAKICAgICBib29sIGhhc0RlZmluaXRlTG9naWNhbFNpemUo R3JpZFRyYWNrU2l6aW5nRGlyZWN0aW9uKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IHRyYW5zbGF0 ZVJUTENvb3JkaW5hdGUoTGF5b3V0VW5pdCkgY29uc3Q7CiAKICAgICBWZWN0b3I8VmVjdG9yPFZl Y3RvcjxSZW5kZXJCb3gqLCAxPj4+IG1fZ3JpZDsKICAgICBWZWN0b3I8TGF5b3V0VW5pdD4gbV9j b2x1bW5Qb3NpdGlvbnM7Cg==