156578 2016-04-14 06:16:00 -0700 [css-grid] Implement CSSGridTemplateAreasValue::equals 2016-04-14 13:49:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue jfernandez rego simon.fraser svillar oldest_to_newest 1183700 0 rego 2016-04-14 06:16:00 -0700 [css-grid] Implement CSSGridTemplateAreasValue::equals 1183702 1 276394 rego 2016-04-14 06:16:57 -0700 Created attachment 276394 Patch 1183703 2 rego 2016-04-14 06:18:32 -0700 There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004 1183704 3 rego 2016-04-14 06:18:52 -0700 There's a crash (infinite loop) if you just do something like this in a grid: grid.style.webkitGridTemplateAreas = '"a"'; grid.style.webkitGridTemplateAreas = '"b"'; This was already fixed in Blink a long time ago: https://codereview.chromium.org/1124063004 1183832 4 276394 commit-queue 2016-04-14 13:49:03 -0700 Comment on attachment 276394 Patch Clearing flags on attachment: 276394 Committed r199551: <http://trac.webkit.org/changeset/199551> 1183833 5 commit-queue 2016-04-14 13:49:06 -0700 All reviewed patches have been landed. Closing bug. 276394 2016-04-14 06:16:57 -0700 2016-04-14 13:49:03 -0700 Patch bug-156578-20160414151708.patch text/plain 4497 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU0ZjFjMjIyM2FmZmQy OTMxNzZlOWI0ZjlmNTZkYWM5MjM2ZmVhZi4uZmExMGI2ZTExMmY1YzM5ODNhMmU3ZjJmOGIyNmJl YWVlNGE0NjVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTE0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gSW1wbGVtZW50IENTU0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWU6OmVxdWFscworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTc4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXMgY2F1c2luZyBh biBpbmZpbml0ZSBsb29wIHNldHRpbmcgZ3JpZC10ZW1wbGF0ZS1hcmVhcworICAgICAgICBmcm9t IEphdmFTY3JpcHQuCisKKyAgICAgICAgVGhlIHJlYXNvbiB3YXMgdGhhdCBDU1NHcmlkVGVtcGxh dGVBcmVhc1ZhbHVlIG5lZWRzCisgICAgICAgIGFuIHNwZWNpZmljIGltcGxlbWVudGF0aW9uIG9m IGVxdWFscygpIG1ldGhvZC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy1ncmlkLWxheW91dC9n cmlkLXRlbXBsYXRlLWFyZWFzLWluZmluaXRlLWxvb3AuaHRtbAorCisgICAgICAgICogY3NzL0NT U0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTR3JpZFRl bXBsYXRlQXJlYXNWYWx1ZTo6ZXF1YWxzKToKKyAgICAgICAgKiBjc3MvQ1NTR3JpZFRlbXBsYXRl QXJlYXNWYWx1ZS5oOgorCiAyMDE2LTA0LTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR09iamVjdCBET00gYmlu ZGluZ3MgQVBJIGJyZWFrIGFmdGVyIHIxOTkzOTIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTR3JpZFRlbXBsYXRlQXJlYXNWYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTR3JpZFRlbXBsYXRlQXJlYXNWYWx1ZS5jcHAKaW5kZXggOTA5Mzk4ZTg4Mzk3ZmIxNGVlMmNk MWU4MDE5MjMzYzZjZmM0YmY5NS4uOWJjNGYwMTg3Y2M4NTBhOTcyNjQ2ZmIzYjg4NWJiZjk1ZGQ5 OWE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0dyaWRUZW1wbGF0ZUFyZWFz VmFsdWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkVGVtcGxhdGVBcmVhc1Zh bHVlLmNwcApAQCAtODUsNiArODUsMTEgQEAgU3RyaW5nIENTU0dyaWRUZW1wbGF0ZUFyZWFzVmFs dWU6OmN1c3RvbUNTU1RleHQoKSBjb25zdAogICAgIHJldHVybiBidWlsZGVyLnRvU3RyaW5nKCk7 CiB9CiAKK2Jvb2wgQ1NTR3JpZFRlbXBsYXRlQXJlYXNWYWx1ZTo6ZXF1YWxzKGNvbnN0IENTU0dy aWRUZW1wbGF0ZUFyZWFzVmFsdWUmIG90aGVyKSBjb25zdAoreworICAgIHJldHVybiBtX2dyaWRB cmVhTWFwID09IG90aGVyLm1fZ3JpZEFyZWFNYXAgJiYgbV9yb3dDb3VudCA9PSBvdGhlci5tX3Jv d0NvdW50ICYmIG1fY29sdW1uQ291bnQgPT0gb3RoZXIubV9jb2x1bW5Db3VudDsKK30KKwogfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLyogRU5BQkxFKENTU19HUklEX0xBWU9VVCkg Ki8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmlkVGVtcGxhdGVBcmVhc1Zh bHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3JpZFRlbXBsYXRlQXJlYXNWYWx1ZS5oCmlu ZGV4IGY0MzM3MThkYzI0ZjQxOGNkZjhiOTA4YzZmMTBkMzUxY2Y2OTJhOGIuLjk1ZjZmMmViNTBj ODBmZTlkOWVjNzdiM2E0MDk4MGIxMzkxYTM4ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NHcmlkVGVtcGxhdGVBcmVhc1ZhbHVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWUuaApAQCAtNTQsNiArNTQsOCBAQCBwdWJsaWM6CiAg ICAgc2l6ZV90IHJvd0NvdW50KCkgY29uc3QgeyByZXR1cm4gbV9yb3dDb3VudDsgfQogICAgIHNp emVfdCBjb2x1bW5Db3VudCgpIGNvbnN0IHsgcmV0dXJuIG1fY29sdW1uQ291bnQ7IH0KIAorICAg IGJvb2wgZXF1YWxzKGNvbnN0IENTU0dyaWRUZW1wbGF0ZUFyZWFzVmFsdWUmKSBjb25zdDsKKwog cHJpdmF0ZToKICAgICBDU1NHcmlkVGVtcGxhdGVBcmVhc1ZhbHVlKGNvbnN0IE5hbWVkR3JpZEFy ZWFNYXAmLCBzaXplX3Qgcm93Q291bnQsIHNpemVfdCBjb2x1bW5Db3VudCk7CiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBj YzFiNjQ3OWFlMWMxNjY1ZmU5N2U3MjNiNjQ2YzBiZDI3NjJmZWQ4Li4wOGQ5NzM3ZDY2MDEwNjlh MDNkZDI1YjEzNjNkZDVhYjhhYjkwZTNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDQt MTQgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAg W2Nzcy1ncmlkXSBJbXBsZW1lbnQgQ1NTR3JpZFRlbXBsYXRlQXJlYXNWYWx1ZTo6ZXF1YWxzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY1NzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2dyaWQtdGVtcGxhdGUtYXJlYXMtaW5maW5pdGUtbG9vcC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtdGVtcGxhdGUt YXJlYXMtaW5maW5pdGUtbG9vcC5odG1sOiBBZGRlZC4KKwogMjAxNi0wNC0xMyAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQ29udGV4dCBJbnNwZWN0 b3I6IEltcHJvdmUgQ2xhc3MgaW5zdGFuY2VzIGFuZCBKU0MgQVBJIEV4cG9ydGVkIFZhbHVlcyB2 aWV3IGluIENvbnNvbGUgLyBPYmplY3RUcmVlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy1ncmlkLWxheW91dC9ncmlkLXRlbXBsYXRlLWFyZWFzLWluZmluaXRlLWxvb3AtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC10ZW1wbGF0ZS1h cmVhcy1pbmZpbml0ZS1sb29wLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mYjRiZGRmOTUxMzlk Y2ZlYTM2NDE3NmQ3ZTViYzBjYTBhOTAxZjI3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC10ZW1wbGF0ZS1hcmVhcy1pbmZpbml0ZS1sb29w LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCBzZXR0 aW5nIGdyaWQtdGVtcGxhdGUtYXJlYXMgZnJvbSBKYXZhU2NyaXB0IGRvZXNuJ3QgY2F1c2UgYW4g aW5maW5pdGUgbG9vcC4KKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlk LWxheW91dC9ncmlkLXRlbXBsYXRlLWFyZWFzLWluZmluaXRlLWxvb3AuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtdGVtcGxhdGUtYXJlYXMtaW5maW5pdGUtbG9v cC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjAwYjc1ZWY0NjRiODQ3ZWNhYTFlZjg0ODNkZDJjYzg3MjQxMDdl YzcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9n cmlkLXRlbXBsYXRlLWFyZWFzLWluZmluaXRlLWxvb3AuaHRtbApAQCAtMCwwICsxLDE1IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxsaW5rIGhyZWY9InJlc291cmNlcy9ncmlkLmNzcyIgcmVsPSJzdHls ZXNoZWV0Ij4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzwvc3R5bGU+Cis8cD5UaGlzIHRlc3QgY2hlY2tz IHRoYXQgc2V0dGluZyBncmlkLXRlbXBsYXRlLWFyZWFzIGZyb20gSmF2YVNjcmlwdCBkb2Vzbid0 IGNhdXNlIGFuIGluZmluaXRlIGxvb3AuPC9wPgorPGRpdiBpZD0iZ3JpZCI+Cis8L2Rpdj4KKzxz Y3JpcHQ+CisgICAgdmFyIGdyaWQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZ3JpZCIpOwor ICAgIGdyaWQuc3R5bGUud2Via2l0R3JpZFRlbXBsYXRlQXJlYXMgPSAnImEiJzsKKyAgICBncmlk LnN0eWxlLndlYmtpdEdyaWRUZW1wbGF0ZUFyZWFzID0gJyJiIic7Cis8L3NjcmlwdD4K