156275 2016-04-05 20:00:43 -0700 Web Inspector: protocol generator should emit an error when 'type' is used instead of '$ref' 2016-04-08 00:13:33 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 147067 1 bburg bburg bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1181135 0 bburg 2016-04-05 20:00:43 -0700 Found by Joe here: https://bugs.webkit.org/attachment.cgi?id=275721&action=review 1181136 1 webkit-bug-importer 2016-04-05 20:01:37 -0700 <rdar://problem/25569331> 1181251 2 bburg 2016-04-06 08:39:28 -0700 It looks like in TypeReference.__init__, we never check whether the type_kind is valid. Then we return it as the fallback if the type_reference (i.e., $ref) is not set. 1182059 3 275979 bburg 2016-04-07 21:26:44 -0700 Created attachment 275979 Proposed Fix 1182060 4 commit-queue 2016-04-07 21:28:44 -0700 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1182079 5 275979 commit-queue 2016-04-08 00:13:29 -0700 Comment on attachment 275979 Proposed Fix Clearing flags on attachment: 275979 Committed r199219: <http://trac.webkit.org/changeset/199219> 1182080 6 commit-queue 2016-04-08 00:13:33 -0700 All reviewed patches have been landed. Closing bug. 275979 2016-04-07 21:26:44 -0700 2016-04-08 00:13:29 -0700 Proposed Fix bug-156275-20160407212647.patch text/plain 5795 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OGFmNjQyNGJhMTNjNWNhYWZlYzEyNmFjMjM4ZGExMjQ3MzIxMjQyLi5hZDk0Y2FjZDdlNzRlN2Qx ODM0MDQzZWU0NWZhNDVlYTdkYzI1YzdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNi0wNC0wNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIGVtaXQgYW4g ZXJyb3Igd2hlbiAndHlwZScgaXMgdXNlZCBpbnN0ZWFkIG9mICckcmVmJworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2Mjc1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNTU2OTMzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90b2NvbC9IZWFwLmpzb246IEZpeCBhIG1pc3Rh a2UgdGhhdCdzIG5vdyBjYXVnaHQgYnkgdGhlIHByb3RvY29sIGdlbmVyYXRvci4KKworICAgICAg ICAqIGluc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5OgorICAgICAgICAoVHlwZVJl ZmVyZW5jZS5fX2luaXRfXyk6IENoZWNrIGhlcmUgaWYgdHlwZV9raW5kIGlzIG9uIGEgd2hpdGVs aXN0IG9mIHByaW1pdGl2ZSB0eXBlcy4KKyAgICAgICAgKFR5cGVSZWZlcmVuY2UucmVmZXJlbmNl ZF9uYW1lKTogVXBkYXRlIGNvbW1lbnQuCisKKyAgICAgICAgQWRkIGEgbmV3IHRlc3Qgc3BlY2lm aWNhbGx5IGZvciB0aGUgY2FzZSB3aGVuIHRoZSB0eXBlIHdvdWxkIG90aGVyd2lzZSBiZSByZXNv bHZlZC4gUmViYXNlbGluZS4KKworICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2V4 cGVjdGVkL2ZhaWwtb24tdHlwZS1yZWZlcmVuY2UtYXMtcHJpbWl0aXZlLXR5cGUuanNvbi1lcnJv cjogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFp bC1vbi11bmtub3duLXR5cGUtcmVmZXJlbmNlLWluLXR5cGUtZGVjbGFyYXRpb24uanNvbi1lcnJv cjoKKyAgICAgICAgKiBpbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9mYWlsLW9uLXR5cGUtcmVmZXJl bmNlLWFzLXByaW1pdGl2ZS10eXBlLmpzb246IEFkZGVkLgorCiAyMDE2LTA0LTA3ICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50aW5nIGNhY2hpbmcg dHJhbnNpdGlvbiBwdXRzIHRoYXQgbmVlZCB0byByZWFsbG9jYXRlIHdpdGggaW5kZXhpbmcgc3Rv cmFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2Nv bC9IZWFwLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0hl YXAuanNvbgppbmRleCAxOWI1MjA2MDBmY2FmMTg5NzdmZDcxOTEzN2ViYjI1NmUwMTQ2ZTM5Li5j NzZlMzNmZDkwZWUzOTBiODg1MGJlMzA5YmYxZjU4MmJmNTRmM2U1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0hlYXAuanNvbgorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0hlYXAuanNvbgpAQCAtNzYsNyAr NzYsNyBAQAogICAgICAgICAgICAgIm5hbWUiOiAiZ2FyYmFnZUNvbGxlY3RlZCIsCiAgICAgICAg ICAgICAiZGVzY3JpcHRpb24iOiAiSW5mb3JtYXRpb24gYWJvdXQgdGhlIGdhcmJhZ2UgY29sbGVj dGlvbi4iLAogICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCi0gICAgICAgICAgICAgICAgeyAi bmFtZSI6ICJjb2xsZWN0aW9uIiwgInR5cGUiOiAiR2FyYmFnZUNvbGxlY3Rpb24iIH0KKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogImNvbGxlY3Rpb24iLCAiJHJlZiI6ICJHYXJiYWdlQ29sbGVj dGlvbiIgfQogICAgICAgICAgICAgXQogICAgICAgICB9LAogICAgICAgICB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9tb2RlbHMu cHkgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9tb2Rl bHMucHkKaW5kZXggZGQ5ZGIyZTY0ZWJkNWFkYWFiNWJlMDFkYzg2YWE3ZmUxNzk3MzRiMi4uMDQz N2E5ZWU1Y2I3NzI0YTJmN2ZiMGY5ZTIxOGRlNzE5ZjlhNzdjMCAxMDA3NTUKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vbW9kZWxzLnB5CisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL21vZGVscy5w eQpAQCAtMTE5LDYgKzExOSwxMCBAQCBjbGFzcyBUeXBlUmVmZXJlbmNlOgogICAgICAgICBpZiB0 eXBlX2tpbmQgaXMgbm90IE5vbmUgYW5kIHJlZmVyZW5jZWRfdHlwZV9uYW1lIGlzIG5vdCBOb25l OgogICAgICAgICAgICAgcmFpc2UgUGFyc2VFeGNlcHRpb24oIlR5cGUgcmVmZXJlbmNlIGNhbm5v dCBoYXZlIGJvdGggJ3R5cGUnIGFuZCAnJHJlZicga2V5cy4iKQogCisgICAgICAgIGFsbF9wcmlt aXRpdmVfdHlwZXMgPSBbImludGVnZXIiLCAibnVtYmVyIiwgInN0cmluZyIsICJib29sZWFuIiwg ImVudW0iLCAib2JqZWN0IiwgImFycmF5IiwgImFueSJdCisgICAgICAgIGlmIHR5cGVfa2luZCBp cyBub3QgTm9uZSBhbmQgdHlwZV9raW5kIG5vdCBpbiBhbGxfcHJpbWl0aXZlX3R5cGVzOgorICAg ICAgICAgICAgcmFpc2UgUGFyc2VFeGNlcHRpb24oIlR5cGUgcmVmZXJlbmNlICclcycgaXMgbm90 IGEgcHJpbWl0aXZlIHR5cGUuIEFsbG93ZWQgdmFsdWVzOiAlcyIgJSAodHlwZV9raW5kLCAnLCAn LmpvaW4oYWxsX3ByaW1pdGl2ZV90eXBlcykpKQorCiAgICAgICAgIGlmIHR5cGVfa2luZCA9PSAi YXJyYXkiIGFuZCBhcnJheV9pdGVtcyBpcyBOb25lOgogICAgICAgICAgICAgcmFpc2UgUGFyc2VF eGNlcHRpb24oIlR5cGUgcmVmZXJlbmNlIHdpdGggdHlwZSAnYXJyYXknIG11c3QgaGF2ZSBrZXkg J2l0ZW1zJyB0byBkZWZpbmUgYXJyYXkgZWxlbWVudCB0eXBlLiIpCiAKQEAgLTEyOSw3ICsxMzMs NyBAQCBjbGFzcyBUeXBlUmVmZXJlbmNlOgogICAgICAgICBpZiBzZWxmLnJlZmVyZW5jZWRfdHlw ZV9uYW1lIGlzIG5vdCBOb25lOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYucmVmZXJlbmNlZF90 eXBlX25hbWUKICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHJldHVybiBzZWxmLnR5cGVfa2lu ZCAgIyBpbnRlZ2VyLCBzdHJpbmcsIG51bWJlciwgYm9vbGVhbiwgZW51bSwgb2JqZWN0LCBhcnJh eQorICAgICAgICAgICAgcmV0dXJuIHNlbGYudHlwZV9raW5kICAjIG9uZSBvZiBhbGxfcHJpbWl0 aXZlX3R5cGVzCiAKIAogY2xhc3MgVHlwZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9mYWlsLW9uLXR5cGUtcmVmZXJl bmNlLWFzLXByaW1pdGl2ZS10eXBlLmpzb24tZXJyb3IgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi10eXBlLXJlZmVyZW5jZS1h cy1wcmltaXRpdmUtdHlwZS5qc29uLWVycm9yCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ3NmJjMWM3NzczYWEwZGE5 ODg0OWM5M2MzNGMzOTJmMTYyNzYzOTgKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi10eXBlLXJl ZmVyZW5jZS1hcy1wcmltaXRpdmUtdHlwZS5qc29uLWVycm9yCkBAIC0wLDAgKzEgQEAKK0VSUk9S OiBUeXBlIHJlZmVyZW5jZSAnRGF0YWJhc2VJZCcgaXMgbm90IGEgcHJpbWl0aXZlIHR5cGUuIEFs bG93ZWQgdmFsdWVzOiBpbnRlZ2VyLCBudW1iZXIsIHN0cmluZywgYm9vbGVhbiwgZW51bSwgb2Jq ZWN0LCBhcnJheSwgYW55CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3NjcmlwdHMvdGVzdHMvZXhwZWN0ZWQvZmFpbC1vbi11bmtub3duLXR5cGUtcmVmZXJlbmNl LWluLXR5cGUtZGVjbGFyYXRpb24uanNvbi1lcnJvciBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9mYWlsLW9uLXVua25vd24tdHlwZS1yZWZl cmVuY2UtaW4tdHlwZS1kZWNsYXJhdGlvbi5qc29uLWVycm9yCmluZGV4IGQzYzc4MmQ4OWRiNTY1 ZDcyNGU3NTQwZTMyZWRjZmRiZDc5YTJmNzMuLjJkMzhlNjQ2NzVkYTVhZTVjMjYzZDU0NmU4NTM0 YjQ5ZjNiNWU5YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv c2NyaXB0cy90ZXN0cy9leHBlY3RlZC9mYWlsLW9uLXVua25vd24tdHlwZS1yZWZlcmVuY2UtaW4t dHlwZS1kZWNsYXJhdGlvbi5qc29uLWVycm9yCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9leHBlY3RlZC9mYWlsLW9uLXVua25vd24tdHlwZS1yZWZl cmVuY2UtaW4tdHlwZS1kZWNsYXJhdGlvbi5qc29uLWVycm9yCkBAIC0xICsxIEBACi1FUlJPUjog TG9va3VwIGZhaWxlZCBmb3IgdHlwZSByZWZlcmVuY2U6IGRyYWdvbiAocmVmZXJlbmNlZCBmcm9t IGRvbWFpbjogUnVudGltZSkKK0VSUk9SOiBUeXBlIHJlZmVyZW5jZSAnZHJhZ29uJyBpcyBub3Qg YSBwcmltaXRpdmUgdHlwZS4gQWxsb3dlZCB2YWx1ZXM6IGludGVnZXIsIG51bWJlciwgc3RyaW5n LCBib29sZWFuLCBlbnVtLCBvYmplY3QsIGFycmF5LCBhbnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9mYWlsLW9uLXR5cGUtcmVmZXJl bmNlLWFzLXByaW1pdGl2ZS10eXBlLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL3NjcmlwdHMvdGVzdHMvZmFpbC1vbi10eXBlLXJlZmVyZW5jZS1hcy1wcmltaXRpdmUtdHlw ZS5qc29uCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjhjODNiYmZjZTQxMmI4YjA5ZGY3NDdhODc1ZTgwMzZkZmVjY2Jj MzYKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Nj cmlwdHMvdGVzdHMvZmFpbC1vbi10eXBlLXJlZmVyZW5jZS1hcy1wcmltaXRpdmUtdHlwZS5qc29u CkBAIC0wLDAgKzEsMTggQEAKK3sKKyAgICAiZG9tYWluIjogIkRhdGFiYXNlIiwKKyAgICAidHlw ZXMiOiBbCisgICAgICAgIHsKKyAgICAgICAgICAgICJpZCI6ICJEYXRhYmFzZUlkIiwKKyAgICAg ICAgICAgICJ0eXBlIjogInN0cmluZyIsCisgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiVW5p cXVlIGlkZW50aWZpZXIgb2YgRGF0YWJhc2Ugb2JqZWN0LiIKKyAgICAgICAgfQorICAgIF0sCisg ICAgImV2ZW50cyI6IFsKKyAgICAgICAgeworICAgICAgICAgICAgIm5hbWUiOiAiZGlkRXhlY3V0 ZU9wdGlvbmFsUGFyYW1ldGVycyIsCisgICAgICAgICAgICAicGFyYW1ldGVycyI6IFsKKyAgICAg ICAgICAgICAgICB7ICJuYW1lIjogImNvbHVtbk5hbWVzIiwgInR5cGUiOiAiRGF0YWJhc2VJZCIg fQorICAgICAgICAgICAgXQorICAgICAgICB9CisgICAgXQorfQo=