155997 2016-03-29 16:51:23 -0700 REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same data every time ImageSource::setData() is called 2016-04-22 13:09:43 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 155322 1 sabouhallawa sabouhallawa commit-queue joepeck simon.fraser webkit-bug-importer oldest_to_newest 1178864 0 sabouhallawa 2016-03-29 16:51:23 -0700 This bug causes logging an error message saying "CGImageSourceUpdateData image source was already finalized". When refactoring the code of ImageSource::setData(SharedBuffer* data), I moved its code to ImageDecoder::setData(SharedBuffer* data). And as a preparation for the asynchronous image decoding work, I added another ImageDecoder::setData(CFDataRef data), and I intended to call it from ImageDecoder::setData(SharedBuffer* data) for now and then I am going to call it also from the asynchronous image decoding code path. The bug is I left the old CGImageSourceUpdateData() in ImageDecoder::setData(SharedBuffer* data) after calling ImageDecoder::setData(CFDataRef data). 1178873 1 joepeck 2016-03-29 17:04:42 -0700 <rdar://problem/25427613> 1178876 2 275157 sabouhallawa 2016-03-29 17:12:56 -0700 Created attachment 275157 Patch 1178902 3 275157 commit-queue 2016-03-29 18:31:32 -0700 Comment on attachment 275157 Patch Clearing flags on attachment: 275157 Committed r198818: <http://trac.webkit.org/changeset/198818> 1178903 4 commit-queue 2016-03-29 18:31:36 -0700 All reviewed patches have been landed. Closing bug. 275157 2016-03-29 17:12:56 -0700 2016-03-29 18:31:32 -0700 Patch bug-155997-20160329171259.patch text/plain 1571 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODgxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTI5ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TiAocjE5ODc4Mik6IENHSW1hZ2VTb3VyY2VVcGRhdGVEYXRhKCkgaXMgY2FsbGVkIHR3aWNlIHdp dGggdGhlIHNhbWUgZGF0YSBldmVyeSB0aW1lIEltYWdlU291cmNlOjpzZXREYXRhKCkgaXMgY2Fs bGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU5 OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgYSBjYWxsIHRvIENHSW1hZ2VTb3VyY2VVcGRhdGVEYXRhKCkgd2hpY2ggd2FzIG1pc3Rha2Vu bHkgbGVmdCBpbgorICAgICAgICBJbWFnZURlY29kZXI6OnNldERhdGEoKSBhZnRlciBJbWFnZVNv dXJjZSByZWZhY3RvcmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdl U291cmNlQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyOjpzZXREYXRhKToK KwogMjAxNi0wMy0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGNsZWFuIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAJKHJl dmlzaW9uIDE5ODgxMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0lt YWdlU291cmNlQ0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzYsNyArNDM2LDYgQEAgdm9pZCBJ bWFnZURlY29kZXI6OnNldERhdGEoU2hhcmVkQnVmZmVyKgogICAgIC8vIFdlIHVzZSBTaGFyZWRC dWZmZXIncyBhYmlsaXR5IHRvIHdyYXAgaXRzZWxmIGluc2lkZSBDRkRhdGEgdG8gZ2V0IGFyb3Vu ZCB0aGlzLCBlbnN1cmluZyB0aGF0IEltYWdlSU8gaXMKICAgICAvLyByZWFsbHkgbG9va2luZyBh dCB0aGUgU2hhcmVkQnVmZmVyLgogICAgIHNldERhdGEoZGF0YS0+Y3JlYXRlQ0ZEYXRhKCkuZ2V0 KCksIGFsbERhdGFSZWNlaXZlZCk7Ci0gICAgQ0dJbWFnZVNvdXJjZVVwZGF0ZURhdGEobV9uYXRp dmVEZWNvZGVyLmdldCgpLCBkYXRhLT5jcmVhdGVDRkRhdGEoKS5nZXQoKSwgYWxsRGF0YVJlY2Vp dmVkKTsKICNlbHNlCiAgICAgLy8gQ3JlYXRlIGEgQ0dEYXRhUHJvdmlkZXIgdG8gd3JhcCB0aGUg U2hhcmVkQnVmZmVyLgogICAgIGRhdGEtPnJlZigpOwo=