<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>155872</bug_id>
          
          <creation_ts>2016-03-24 22:32:48 -0700</creation_ts>
          <short_desc>[Win] CMake seems to build all generated files every time</short_desc>
          <delta_ts>2016-10-30 19:10:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>163774</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=154938</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>155986</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>fujii</cc>
    
    <cc>peavo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1177893</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-24 22:32:48 -0700</bug_when>
    <thetext>It seems like the CMake-based build causes the IDL files to be processed in full every build. This is super annoying, especially since this has become a single-threaded bottleneck during the build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1177895</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-24 22:42:43 -0700</bug_when>
    <thetext>The bottleneck seems to be that Visual Studio waits for each invocation of the &quot;Custom Build Step&quot; to complete:

setlocal
cd C:\Projects\WebKit\OpenSource\Source\WebCore
if %errorlevel% neq 0 goto :cmEnd
C:
if %errorlevel% neq 0 goto :cmEnd
C:\cygwin\bin\perl.exe -IC:/Projects/WebKit/OpenSource/Source/WebCore/bindings/scripts C:/Projects/WebKit/OpenSource/Source/WebCore/bindings/scripts/generate-bindings.pl --defines &quot;LANGUAGE_JAVASCRIPT=1 &quot; ... endless stuff

if %errorlevel% neq 0 goto :cmEnd
:cmEnd
endlocal &amp; call :cmErrorLevel %errorlevel% &amp; goto :cmDone
:cmErrorLevel
exit /b %1
:cmDone
if %errorlevel% neq 0 goto :VCEnd</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1177897</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-24 22:43:41 -0700</bug_when>
    <thetext>I wonder what would happen if we did a &quot;CALL&quot; on the Perl program to run in a new process. We would lose the ability to end the build on an error in the script generation, but that doesn&apos;t really happen much anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1177900</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-24 22:52:58 -0700</bug_when>
    <thetext>We probably need some way to sync that the auto-generating is done before compiling stuff that depends on it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1177997</commentid>
    <comment_count>4</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2016-03-25 10:18:50 -0700</bug_when>
    <thetext>One thought was maybe derived sources should be split into their own projects. https://bugs.webkit.org/show_bug.cgi?id=151399 had some initial work on this but didn&apos;t land.

And here&apos;s a related bug you might want to roll into this https://bugs.webkit.org/show_bug.cgi?id=154938 that I opened.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178104</commentid>
    <comment_count>5</comment_count>
      <attachid>274940</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-25 14:14:02 -0700</bug_when>
    <thetext>Created attachment 274940
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178118</commentid>
    <comment_count>6</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-25 14:53:03 -0700</bug_when>
    <thetext>Blah. Well, that didn&apos;t work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178125</commentid>
    <comment_count>7</comment_count>
      <attachid>274940</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2016-03-25 15:05:06 -0700</bug_when>
    <thetext>Comment on attachment 274940
Patch

CMake Error at Source/WebCore/CMakeLists.txt:3832 (add_library):
  Cannot find source file:

    C:/cygwin/home/buildbot/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettings.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178164</commentid>
    <comment_count>8</comment_count>
      <attachid>274953</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-25 16:26:20 -0700</bug_when>
    <thetext>Created attachment 274953
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178197</commentid>
    <comment_count>9</comment_count>
      <attachid>274961</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-25 17:40:48 -0700</bug_when>
    <thetext>Created attachment 274961
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178431</commentid>
    <comment_count>10</comment_count>
      <attachid>274961</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-03-28 09:47:57 -0700</bug_when>
    <thetext>Comment on attachment 274961
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274961&amp;action=review

&gt; Source/cmake/WebKitMacros.cmake:96
&gt; +        set(_custom_outputs &quot;${_destination}/${_prefix}${_name}.${_extension}&quot; &quot;${_destination}/${_prefix}${_name}.h&quot;)
&gt; +        if (MSVC)
&gt; +            set(_custom_outputs &quot;${_destination}/${_prefix}${_name}.h&quot;)
&gt; +        endif ()

if else endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178664</commentid>
    <comment_count>11</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-03-29 08:42:43 -0700</bug_when>
    <thetext>Committed r198781: &lt;http://trac.webkit.org/changeset/198781&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1178782</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-03-29 13:34:42 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 155986</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237499</commentid>
    <comment_count>13</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-10-06 23:28:09 -0700</bug_when>
    <thetext>My patch in Bug 161433 Comment 9 mitigates this problem because:

1) It solves the problem editting one IDL triggers regenerating all bindings
2) It runs generate-bindings.pl parallel

But, not perfectly fixed. I&apos;ll fix this issue after finishing Bug 161433.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246323</commentid>
    <comment_count>14</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-10-30 19:10:19 -0700</bug_when>
    <thetext>I solved this problem in Bug 163774.

*** This bug has been marked as a duplicate of bug 163774 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>274940</attachid>
            <date>2016-03-25 14:14:02 -0700</date>
            <delta_ts>2016-03-25 16:26:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-155872-20160325141404.patch</filename>
            <type>text/plain</type>
            <size>2724</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODY5
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAz
LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IENNYWtlIHNlZW1zIHRvIGJ1aWxkIGFsbCBnZW5lcmF0ZWQgZmlsZXMgZXZlcnkgdGltZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODcyCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0
byBiZSBjYXVzZWQgYnkgVmlzdWFsIFN0dWRpbyBiZWluZyB1bmhhcHB5IHJlY2VpdmluZyBDeWd3
aW4tc3R5bGUgcGF0aHMuCisgICAgICAgIEx1Y2tpbHksIGlmIHdlIG9taXQgdGhlIGRpcmVjdG9y
eSBlbnRpcmVseSB0aGUgd29ya2luZyBkaXJlY3RvcnkgaXMgYWxyZWFkeSBjb3JyZWN0CisgICAg
ICAgIGFuZCB0aGUgYnVpbGQgKGFuZCBkZXBlbmRlbmN5IGNoZWNraW5nKSB3b3JrcyBwcm9wZXJs
eS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTYt
MDMtMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNvZnRl
biBwdXNoL3JlcGxhY2VTdGF0ZSBmcmVxdWVuY3kgcmVzdHJpY3Rpb25zLgpJbmRleDogU291cmNl
L2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvV2Vi
S2l0TWFjcm9zLmNtYWtlCShyZXZpc2lvbiAxOTg2OTApCisrKyBTb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC05MCw5ICs5MCwxNSBAQCBtYWNybyhHRU5F
UkFURV9CSU5ESU5HUyBfb3V0cHV0X3NvdXJjZSBfCiAgICAgICAgICAgICBzZXQoX25vX21tIDAp
CiAgICAgICAgIGVuZGlmICgpCiAKKyAgICAgICAgaWYgKE1TVkMpCisgICAgICAgICAgICBzZXQo
X2N1c3RvbV9jb21tYW5kX291dHB1dCAiJHtfcHJlZml4fSR7X25hbWV9IikKKyAgICAgICAgZWxz
ZSAoKQorICAgICAgICAgICAgc2V0KF9jdXN0b21fY29tbWFuZF9vdXRwdXQgIiR7X2Rlc3RpbmF0
aW9ufS8ke19wcmVmaXh9JHtfbmFtZX0iKQorICAgICAgICBlbmRpZiAoKQorCiAgICAgICAgIGlm
ICgke19ub19tbX0pCiAgICAgICAgICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCi0gICAgICAgICAg
ICAgICAgT1VUUFVUICR7X2Rlc3RpbmF0aW9ufS8ke19wcmVmaXh9JHtfbmFtZX0uaAorICAgICAg
ICAgICAgICAgIE9VVFBVVCAke19jdXN0b21fY29tbWFuZF9vdXRwdXR9LmgKICAgICAgICAgICAg
ICAgICBNQUlOX0RFUEVOREVOQ1kgJHtfZmlsZX0KICAgICAgICAgICAgICAgICBERVBFTkRTICR7
Q09NTU9OX0dFTkVSQVRPUl9ERVBFTkRFTkNJRVN9CiAgICAgICAgICAgICAgICAgQ09NTUFORCAk
e1BFUkxfRVhFQ1VUQUJMRX0gLUkke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzICR7QklO
RElOR19HRU5FUkFUT1J9IC0tZGVmaW5lcyAiJHtfZmVhdHVyZXN9IiAtLWdlbmVyYXRvciAke19n
ZW5lcmF0b3J9ICR7X2lkbF9pbmNsdWRlc30gLS1vdXRwdXREaXIgIiR7X2Rlc3RpbmF0aW9ufSIg
LS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09SfSIgLS1pZGxBdHRy
aWJ1dGVzRmlsZSAke19pZGxfYXR0cmlidXRlc19maWxlfSAke19zdXBwbGVtZW50YWxfZGVwZW5k
ZW5jeX0gJHtfZmlsZX0KQEAgLTEwMiw3ICsxMDgsNyBAQCBtYWNybyhHRU5FUkFURV9CSU5ESU5H
UyBfb3V0cHV0X3NvdXJjZSBfCiAgICAgICAgICAgICBsaXN0KEFQUEVORCAke19vdXRwdXRfc291
cmNlfSAke19kZXN0aW5hdGlvbn0vJHtfcHJlZml4fSR7X25hbWV9LmgpCiAgICAgICAgIGVsc2Ug
KCkKICAgICAgICAgICAgIGFkZF9jdXN0b21fY29tbWFuZCgKLSAgICAgICAgICAgICAgICBPVVRQ
VVQgJHtfZGVzdGluYXRpb259LyR7X3ByZWZpeH0ke19uYW1lfS4ke19leHRlbnNpb259ICR7X2Rl
c3RpbmF0aW9ufS8ke19wcmVmaXh9JHtfbmFtZX0uaAorICAgICAgICAgICAgICAgIE9VVFBVVCAk
e19jdXN0b21fY29tbWFuZF9vdXRwdXR9LiR7X2V4dGVuc2lvbn0gJHtfY3VzdG9tX2NvbW1hbmRf
b3V0cHV0fSR7X25hbWV9LmgKICAgICAgICAgICAgICAgICBNQUlOX0RFUEVOREVOQ1kgJHtfZmls
ZX0KICAgICAgICAgICAgICAgICBERVBFTkRTICR7Q09NTU9OX0dFTkVSQVRPUl9ERVBFTkRFTkNJ
RVN9CiAgICAgICAgICAgICAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gLUkke1dFQkNP
UkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzICR7QklORElOR19HRU5FUkFUT1J9IC0tZGVmaW5lcyAi
JHtfZmVhdHVyZXN9IiAtLWdlbmVyYXRvciAke19nZW5lcmF0b3J9ICR7X2lkbF9pbmNsdWRlc30g
LS1vdXRwdXREaXIgIiR7X2Rlc3RpbmF0aW9ufSIgLS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5F
UkFUT1JfUFJFUFJPQ0VTU09SfSIgLS1pZGxBdHRyaWJ1dGVzRmlsZSAke19pZGxfYXR0cmlidXRl
c19maWxlfSAke19zdXBwbGVtZW50YWxfZGVwZW5kZW5jeX0gJHtfZmlsZX0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>274953</attachid>
            <date>2016-03-25 16:26:20 -0700</date>
            <delta_ts>2016-03-25 17:40:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-155872-20160325162622.patch</filename>
            <type>text/plain</type>
            <size>2191</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODY5
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAz
LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IENNYWtlIHNlZW1zIHRvIGJ1aWxkIGFsbCBnZW5lcmF0ZWQgZmlsZXMgZXZlcnkgdGltZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODcyCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0
byBiZSBjYXVzZWQgYnkgVmlzdWFsIFN0dWRpbyBiZWluZyB1bmhhcHB5IHJlY2VpdmluZyBtdWx0
aXBsZSBvdXRwdXQgdGFyZ2V0cworICAgICAgICBmb3IgaXRzIGN1c3RvbSBidWlsZCBydWxlcy4g
SWYgSSBsaW1pdCB0aGUgb3V0cHV0IHRvIGp1c3QgdGhlIGltcGxlbWVudGF0aW9uIGZpbGUsIHRo
ZQorICAgICAgICBkZXBlbmRlbmN5IGNoZWNrIHNlZW1zIHRvIGRvIHRoZSByaWdodCB0aGluZy4K
KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTYtMDMt
MjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNvZnRlbiBw
dXNoL3JlcGxhY2VTdGF0ZSBmcmVxdWVuY3kgcmVzdHJpY3Rpb25zLgpJbmRleDogU291cmNlL2Nt
YWtlL1dlYktpdE1hY3Jvcy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlCShyZXZpc2lvbiAxOTg2OTApCisrKyBTb3VyY2UvY21ha2UvV2ViS2l0TWFj
cm9zLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCwxMSBAQCBtYWNybyhHRU5FUkFU
RV9CSU5ESU5HUyBfb3V0cHV0X3NvdXJjZSBfCiAgICAgICAgICAgICBzZXQoX25vX21tIDApCiAg
ICAgICAgIGVuZGlmICgpCiAKKyAgICAgICAgc2V0KF9jdXN0b21fb3V0cHV0cyAke19kZXN0aW5h
dGlvbn0vJHtfcHJlZml4fSR7X25hbWV9LiR7X2V4dGVuc2lvbn0pCisgICAgICAgIGlmIChOT1Qg
TVNWQykKKyAgICAgICAgICAgIGxpc3QoQVBQRU5EIF9jdXN0b21fb3V0cHV0cyAke19kZXN0aW5h
dGlvbn0vJHtfcHJlZml4fSR7X25hbWV9LmgpCisgICAgICAgIGVuZGlmICgpCisKICAgICAgICAg
aWYgKCR7X25vX21tfSkKICAgICAgICAgICAgIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAg
ICAgICAgICBPVVRQVVQgJHtfZGVzdGluYXRpb259LyR7X3ByZWZpeH0ke19uYW1lfS5oCkBAIC0x
MDIsNyArMTA3LDcgQEAgbWFjcm8oR0VORVJBVEVfQklORElOR1MgX291dHB1dF9zb3VyY2UgXwog
ICAgICAgICAgICAgbGlzdChBUFBFTkQgJHtfb3V0cHV0X3NvdXJjZX0gJHtfZGVzdGluYXRpb259
LyR7X3ByZWZpeH0ke19uYW1lfS5oKQogICAgICAgICBlbHNlICgpCiAgICAgICAgICAgICBhZGRf
Y3VzdG9tX2NvbW1hbmQoCi0gICAgICAgICAgICAgICAgT1VUUFVUICR7X2Rlc3RpbmF0aW9ufS8k
e19wcmVmaXh9JHtfbmFtZX0uJHtfZXh0ZW5zaW9ufSAke19kZXN0aW5hdGlvbn0vJHtfcHJlZml4
fSR7X25hbWV9LmgKKyAgICAgICAgICAgICAgICBPVVRQVVQgJHtfY3VzdG9tX291dHB1dHN9CiAg
ICAgICAgICAgICAgICAgTUFJTl9ERVBFTkRFTkNZICR7X2ZpbGV9CiAgICAgICAgICAgICAgICAg
REVQRU5EUyAke0NPTU1PTl9HRU5FUkFUT1JfREVQRU5ERU5DSUVTfQogICAgICAgICAgICAgICAg
IENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9IC1JJHtXRUJDT1JFX0RJUn0vYmluZGluZ3Mvc2Ny
aXB0cyAke0JJTkRJTkdfR0VORVJBVE9SfSAtLWRlZmluZXMgIiR7X2ZlYXR1cmVzfSIgLS1nZW5l
cmF0b3IgJHtfZ2VuZXJhdG9yfSAke19pZGxfaW5jbHVkZXN9IC0tb3V0cHV0RGlyICIke19kZXN0
aW5hdGlvbn0iIC0tcHJlcHJvY2Vzc29yICIke0NPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUn0i
IC0taWRsQXR0cmlidXRlc0ZpbGUgJHtfaWRsX2F0dHJpYnV0ZXNfZmlsZX0gJHtfc3VwcGxlbWVu
dGFsX2RlcGVuZGVuY3l9ICR7X2ZpbGV9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>274961</attachid>
            <date>2016-03-25 17:40:48 -0700</date>
            <delta_ts>2016-03-28 09:47:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-155872-20160325174050.patch</filename>
            <type>text/plain</type>
            <size>2225</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODY5
MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAz
LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IENNYWtlIHNlZW1zIHRvIGJ1aWxkIGFsbCBnZW5lcmF0ZWQgZmlsZXMgZXZlcnkgdGltZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1ODcyCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0
byBiZSBjYXVzZWQgYnkgVmlzdWFsIFN0dWRpbyBiZWluZyB1bmhhcHB5IHJlY2VpdmluZyBtdWx0
aXBsZSBvdXRwdXQgdGFyZ2V0cworICAgICAgICBmb3IgaXRzIGN1c3RvbSBidWlsZCBydWxlcy4g
SWYgSSBsaW1pdCB0aGUgb3V0cHV0IHRvIGp1c3QgdGhlIGhlYWRlciBmaWxlIG9uIFdpbmRvd3Ms
IHRoZQorICAgICAgICBkZXBlbmRlbmN5IGNoZWNrIHNlZW1zIHRvIGRvIHRoZSByaWdodCB0aGlu
Zy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTYt
MDMtMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNvZnRl
biBwdXNoL3JlcGxhY2VTdGF0ZSBmcmVxdWVuY3kgcmVzdHJpY3Rpb25zLgpJbmRleDogU291cmNl
L2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvV2Vi
S2l0TWFjcm9zLmNtYWtlCShyZXZpc2lvbiAxOTg2OTApCisrKyBTb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCwxMSBAQCBtYWNybyhHRU5F
UkFURV9CSU5ESU5HUyBfb3V0cHV0X3NvdXJjZSBfCiAgICAgICAgICAgICBzZXQoX25vX21tIDAp
CiAgICAgICAgIGVuZGlmICgpCiAKKyAgICAgICAgc2V0KF9jdXN0b21fb3V0cHV0cyAiJHtfZGVz
dGluYXRpb259LyR7X3ByZWZpeH0ke19uYW1lfS4ke19leHRlbnNpb259IiAiJHtfZGVzdGluYXRp
b259LyR7X3ByZWZpeH0ke19uYW1lfS5oIikKKyAgICAgICAgaWYgKE1TVkMpCisgICAgICAgICAg
ICBzZXQoX2N1c3RvbV9vdXRwdXRzICIke19kZXN0aW5hdGlvbn0vJHtfcHJlZml4fSR7X25hbWV9
LmgiKQorICAgICAgICBlbmRpZiAoKQorCiAgICAgICAgIGlmICgke19ub19tbX0pCiAgICAgICAg
ICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgICAgICAgICAgICAgT1VUUFVUICR7X2Rlc3Rp
bmF0aW9ufS8ke19wcmVmaXh9JHtfbmFtZX0uaApAQCAtMTAyLDcgKzEwNyw3IEBAIG1hY3JvKEdF
TkVSQVRFX0JJTkRJTkdTIF9vdXRwdXRfc291cmNlIF8KICAgICAgICAgICAgIGxpc3QoQVBQRU5E
ICR7X291dHB1dF9zb3VyY2V9ICR7X2Rlc3RpbmF0aW9ufS8ke19wcmVmaXh9JHtfbmFtZX0uaCkK
ICAgICAgICAgZWxzZSAoKQogICAgICAgICAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAotICAgICAg
ICAgICAgICAgIE9VVFBVVCAke19kZXN0aW5hdGlvbn0vJHtfcHJlZml4fSR7X25hbWV9LiR7X2V4
dGVuc2lvbn0gJHtfZGVzdGluYXRpb259LyR7X3ByZWZpeH0ke19uYW1lfS5oCisgICAgICAgICAg
ICAgICAgT1VUUFVUICR7X2N1c3RvbV9vdXRwdXRzfQogICAgICAgICAgICAgICAgIE1BSU5fREVQ
RU5ERU5DWSAke19maWxlfQogICAgICAgICAgICAgICAgIERFUEVORFMgJHtDT01NT05fR0VORVJB
VE9SX0RFUEVOREVOQ0lFU30KICAgICAgICAgICAgICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRB
QkxFfSAtSSR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3NjcmlwdHMgJHtCSU5ESU5HX0dFTkVSQVRP
Un0gLS1kZWZpbmVzICIke19mZWF0dXJlc30iIC0tZ2VuZXJhdG9yICR7X2dlbmVyYXRvcn0gJHtf
aWRsX2luY2x1ZGVzfSAtLW91dHB1dERpciAiJHtfZGVzdGluYXRpb259IiAtLXByZXByb2Nlc3Nv
ciAiJHtDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1J9IiAtLWlkbEF0dHJpYnV0ZXNGaWxlICR7
X2lkbF9hdHRyaWJ1dGVzX2ZpbGV9ICR7X3N1cHBsZW1lbnRhbF9kZXBlbmRlbmN5fSAke19maWxl
fQo=
</data>
<flag name="review"
          id="299359"
          type_id="1"
          status="+"
          setter="achristensen"
    />
          </attachment>
      

    </bug>

</bugzilla>