155657 2016-03-18 12:15:41 -0700 JSDOMGlobalObject.h needs to #include StructureInlines.h 2018-11-15 02:12:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191626 P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1176264 0 mark.lam 2016-03-18 12:15:41 -0700 The Win EWS is complaining about the following: WebCore.lib(EmptyClients.obj) : error LNK2019: unresolved external symbol "public: static class JSC::Structure * __cdecl JSC::Structure::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue,class JSC::TypeInfo const &,struct JSC::ClassInfo const *,unsigned char,unsigned int)" (?create@Structure@JSC@@SAPAV12@AAVVM@2@PAVJSGlobalObject@2@VJSValue@2@ABVTypeInfo@2@PBUClassInfo@2@EI@Z) referenced in function "public: static class JSC::Structure * __cdecl WebCore::JSDOMGlobalObject::createStructure(class JSC::VM &,class JSC::JSValue)" (?createStructure@JSDOMGlobalObject@WebCore@@SAPAVStructure@JSC@@AAVVM@4@VJSValue@4@@Z) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj] C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals Structure::create() is implemented in StructureInlines.h. Just need to #include the header file. 1176265 1 274444 mark.lam 2016-03-18 12:18:32 -0700 Created attachment 274444 proposed patch. 1176266 2 mark.lam 2016-03-18 12:18:53 -0700 Let's try it on the EWS first. 1176276 3 274444 fpizlo 2016-03-18 12:52:17 -0700 Comment on attachment 274444 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=274444&action=review > Source/WebCore/bindings/js/JSDOMGlobalObject.h:33 > +#include <runtime/StructureInlines.h> Any reason not to include JSCInlines.h? 1176278 4 mark.lam 2016-03-18 12:54:16 -0700 (In reply to comment #3) > Comment on attachment 274444 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274444&action=review > > > Source/WebCore/bindings/js/JSDOMGlobalObject.h:33 > > +#include <runtime/StructureInlines.h> > > Any reason not to include JSCInlines.h? I was only targeting the specific issue that was reported by the EWS. JSCInlines.h should work but is overkill for now. 1176279 5 mark.lam 2016-03-18 12:59:14 -0700 Thanks. Landed in r198440: <http://trac.webkit.org/r198440>. 274444 2016-03-18 12:18:32 -0700 2016-03-18 12:55:10 -0700 proposed patch. bug-155657.patch text/plain 1121 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODQzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAzLTE4ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBKU0RPTUdsb2JhbE9iamVjdC5oIG5l ZWRzIHRvICNpbmNsdWRlIFN0cnVjdHVyZUlubGluZXMuaC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTY1NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuICBUaGlzIGlz IGEgYnVpbGQgZml4IGZvciB0aGUgV2luIEVXUy4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT RE9NR2xvYmFsT2JqZWN0Lmg6CisKIDIwMTYtMDMtMTggIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgQ2FjaGVkUmVzb3VyY2U6Ok1lZGlhUmVzb3VyY2UgdHlwZXMg c2hvdWxkbid0IGJlIGJsb2NrZWQgZHVlIHRvIG1peGVkLWNvbnRlbnQuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0LmgJKHJldmlzaW9uIDE5 ODQzNikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJQbGF0Zm9ybUV4cG9y dE1hY3Jvcy5oIgogI2luY2x1ZGUgIldlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaCIKICNpbmNs dWRlIDxydW50aW1lL0pTR2xvYmFsT2JqZWN0Lmg+CisjaW5jbHVkZSA8cnVudGltZS9TdHJ1Y3R1 cmVJbmxpbmVzLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo=