154770 2016-02-26 19:30:20 -0800 Focusing a shadow host places the slot content after the shadow DOM content 2016-05-09 10:48:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 148695 1 rniwa webkit-unassigned koivisto simon.fraser webkit-bug-importer oldest_to_newest 1168787 0 272392 rniwa 2016-02-26 19:30:20 -0800 Created attachment 272392 Test case When a shadow host's focus state changes and outline is drawn, slots' assigned contents show up at the bottom of the shadow DOM. See the attached test case. 1168810 1 rniwa 2016-02-26 21:16:08 -0800 Antti, is RenderTreePosition's next sibling supposed to refer to a render node after a slot when we're at a node assigned to the slot? There appears to be a serious inconsistency in the way TreeResolver and RenderTreePosition traverse the composed tree. 1168811 2 webkit-bug-importer 2016-02-26 21:16:33 -0800 <rdar://problem/24873102> 1168814 3 rniwa 2016-02-26 21:20:56 -0800 More specifically, when TreeResolver::createRenderer is called on an assigned element, renderTreePosition's m_nextSibling is null so we end up inserting to the end of the shadow root. Either RenderTreePosition's nextSiblingRenderer or ComposedTreeIterator ought to find the render object after the slot to which the element is assigned. This could be recursive because the slot (A) can then be assigned to another slot (B) when (A)'s parent has a shadow root that contains (B). 1190870 4 rniwa 2016-05-06 19:24:34 -0700 It looks like this is fixed now :D We just need to land a test. 1191206 5 278408 rniwa 2016-05-09 10:32:06 -0700 Created attachment 278408 Add a test 1191213 6 278408 rniwa 2016-05-09 10:48:01 -0700 Comment on attachment 278408 Add a test Clearing flags on attachment: 278408 Committed r200581: <http://trac.webkit.org/changeset/200581> 1191214 7 rniwa 2016-05-09 10:48:06 -0700 All reviewed patches have been landed. Closing bug. 272392 2016-02-26 19:30:20 -0800 2016-05-09 10:32:06 -0700 Test case update-shadow-outline.html text/html 1126 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPHN0eWxlPgoKI2NvbnRhaW5lciB7CiAgICBw b3NpdGlvbjogcmVsYXRpdmU7Cn0KCiNob3N0IHsKICAgIHdpZHRoOiA5MHB4OwogICAgaGVpZ2h0 OiA5MHB4OwogICAgYm9yZGVyOiBzb2xpZCA1cHggcmVkOwogICAgb3V0bGluZTogbm9uZTsKfQoK I2hvc3Q6bm90KDpmb2N1cyk6OmFmdGVyIHsKICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgIGxl ZnQ6IDVweDsKICAgIGJvdHRvbTogNXB4OwogICAgd2lkdGg6IDkwcHg7CiAgICBoZWlnaHQ6IDQ1 cHg7CiAgICBjb250ZW50OiAnRkFJTCAtIG5vdCBmb2N1c2VkJzsKfQoKI2hvc3Q6Zm9jdXMgewog ICAgb3V0bGluZTogc29saWQgNXB4IGdyZWVuOwogICAgb3V0bGluZS1vZmZzZXQ6IC01cHg7Cn0K CiNob3N0IGRpdiB7CiAgICBiYWNrZ3JvdW5kOiByZWQ7CiAgICB3aWR0aDogOTBweDsKICAgIGhl aWdodDogNDVweDsKfQoKI292ZXJsYXkgewogICAgcG9zaXRpb246IGFic29sdXRlOwogICAgdG9w OiAwOwogICAgbGVmdDogMDsKICAgIGJhY2tncm91bmQ6IGdyZWVuOwogICAgZGlzcGxheTogYmxv Y2s7CiAgICB3aWR0aDogOTBweDsKICAgIGhlaWdodDogNDVweDsKfQoKPC9zdHlsZT4KPHA+VGVz dCBwYXNzZXMgaWYgeW91IHNlZSBhIHNpbmdsZSAxMDBweCBieSAxMDBweCBncmVlbiBib3ggYmVs b3cuPC9wPgo8ZGl2IGlkPSJjb250YWluZXIiPgo8ZGl2IGlkPSJob3N0IiB0YWJpbmRleD0wPjxk aXY+RkFJTCAtIG1pc3BsYWNlZDwvZGl2PjwvZGl2Pgo8ZGl2IGlkPSJvdmVybGF5Ij48L2Rpdj4K PC9kaXY+CjxzY3JpcHQ+Cgp2YXIgaG9zdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdob3N0 Jyk7CnZhciBzaGFkb3cgPSBob3N0LmF0dGFjaFNoYWRvdyh7bW9kZTogJ2Nsb3NlZCd9KTsKc2hh ZG93LmlubmVySFRNTCA9IGAKICAgIDxzdHlsZT4KICAgICAgICBkaXYgeyBiYWNrZ3JvdW5kOiBn cmVlbjsgd2lkdGg6IDkwcHg7IGhlaWdodDogNDVweDsgfQogICAgPC9zdHlsZT4KICAgIDxzbG90 Pjwvc2xvdD4KICAgIDxkaXY+PC9kaXY+CmA7Cgpob3N0LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp Owpob3N0LmZvY3VzKCk7Cgo8L3NjcmlwdD4KPC9ib2R5Pgo8L2h0bWw+Cg== 278408 2016-05-09 10:32:06 -0700 2016-05-09 10:48:01 -0700 Add a test fix154770.patch text/plain 2829 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDU3OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTA5ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZvY3VzaW5nIGEgc2hhZG93IGhvc3QgcGxhY2Vz IHRoZSBzbG90IGNvbnRlbnQgYWZ0ZXIgdGhlIHNoYWRvdyBET00gY29udGVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NzcwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yNDg3MzEwMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSByZWdyZXNzaW9uIHRlc3Qgbm93IHRoYXQgdGhlIGJ1ZyBo YXMgYmVlbiBmaXhlZC4KKworICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9zaGFkb3ctbGF5b3V0 LWFmdGVyLWZvY3VzLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93 LWRvbS9zaGFkb3ctbGF5b3V0LWFmdGVyLWZvY3VzLmh0bWw6IEFkZGVkLgorCiAyMDE2LTA1LTA5 ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtj c3MtZ3JpZF0gRml4IHN0YXRpYyBwb3NpdGlvbiBmb3IgcG9zaXRpb25lZCBncmlkIGl0ZW1zCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vc2hhZG93LWxheW91dC1hZnRlci1mb2N1 cy1leHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRv bS9zaGFkb3ctbGF5b3V0LWFmdGVyLWZvY3VzLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vc2hhZG93LWxheW91dC1hZnRlci1mb2N1cy1l eHBlY3RlZC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNyBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxib2R5PgorICAgIDxwPlRlc3QgcGFzc2VzIGlmIHlvdSBzZWUgYSBzaW5n bGUgMTAwcHggYnkgMTAwcHggZ3JlZW4gYm94IGJlbG93LjwvcD4KKyAgICA8ZGl2IHN0eWxlPSJ3 aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tncm91bmQ6IGdyZWVuOyI+PC9kaXY+Cis8 L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vc2hhZG93 LWxheW91dC1hZnRlci1mb2N1cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv c2hhZG93LWRvbS9zaGFkb3ctbGF5b3V0LWFmdGVyLWZvY3VzLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vc2hhZG93LWxheW91dC1hZnRlci1mb2N1cy5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNzAgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+Cis8Ym9keT4KKzxzdHlsZT4KKworI2NvbnRhaW5lciB7CisgICAgcG9zaXRpb246IHJlbGF0 aXZlOworfQorCisjaG9zdCB7CisgICAgd2lkdGg6IDkwcHg7CisgICAgaGVpZ2h0OiA5MHB4Owor ICAgIGJvcmRlcjogc29saWQgNXB4IHJlZDsKKyAgICBvdXRsaW5lOiBub25lOworfQorCisjaG9z dDpub3QoOmZvY3VzKTo6YWZ0ZXIgeworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICBsZWZ0 OiA1cHg7CisgICAgYm90dG9tOiA1cHg7CisgICAgd2lkdGg6IDkwcHg7CisgICAgaGVpZ2h0OiA0 NXB4OworICAgIGNvbnRlbnQ6ICdGQUlMIC0gbm90IGZvY3VzZWQnOworfQorCisjaG9zdDpmb2N1 cyB7CisgICAgb3V0bGluZTogc29saWQgNXB4IGdyZWVuOworICAgIG91dGxpbmUtb2Zmc2V0OiAt NXB4OworfQorCisjaG9zdCBkaXYgeworICAgIGJhY2tncm91bmQ6IHJlZDsKKyAgICB3aWR0aDog OTBweDsKKyAgICBoZWlnaHQ6IDQ1cHg7Cit9CisKKyNvdmVybGF5IHsKKyAgICBwb3NpdGlvbjog YWJzb2x1dGU7CisgICAgdG9wOiAwOworICAgIGxlZnQ6IDA7CisgICAgYmFja2dyb3VuZDogZ3Jl ZW47CisgICAgZGlzcGxheTogYmxvY2s7CisgICAgd2lkdGg6IDEwMHB4OworICAgIGhlaWdodDog NTBweDsKK30KKworPC9zdHlsZT4KKzxwPlRlc3QgcGFzc2VzIGlmIHlvdSBzZWUgYSBzaW5nbGUg MTAwcHggYnkgMTAwcHggZ3JlZW4gYm94IGJlbG93LjwvcD4KKzxkaXYgaWQ9ImNvbnRhaW5lciI+ Cis8ZGl2IGlkPSJob3N0IiB0YWJpbmRleD0wPjxkaXY+RkFJTCAtIG1pc3BsYWNlZDwvZGl2Pjwv ZGl2PgorPGRpdiBpZD0ib3ZlcmxheSI+PC9kaXY+Cis8L2Rpdj4KKzxzY3JpcHQ+CisKK3ZhciBo b3N0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2hvc3QnKTsKK3ZhciBzaGFkb3cgPSBob3N0 LmF0dGFjaFNoYWRvdyh7bW9kZTogJ2Nsb3NlZCd9KTsKK3NoYWRvdy5pbm5lckhUTUwgPSBgCisg ICAgPHN0eWxlPgorICAgICAgICBkaXYgeyBiYWNrZ3JvdW5kOiBncmVlbjsgd2lkdGg6IDkwcHg7 IGhlaWdodDogNDVweDsgfQorICAgIDwvc3R5bGU+CisgICAgPHNsb3Q+PC9zbG90PgorICAgIDxk aXY+PC9kaXY+CitgOworCitob3N0LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworaG9zdC5mb2N1 cygpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K