154357 2016-02-17 13:52:29 -0800 Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test 2016-05-24 22:07:42 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 154120 1 cdumez cdumez barraclough commit-queue darin esprehn+autocc kondapallykalyan l.krok rniwa sam oldest_to_newest 1165722 0 cdumez 2016-02-17 13:52:29 -0800 http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test after <http://trac.webkit.org/changeset/196648>. Previously it did not redirect and it does not redirect either in other browsers. It redirects to http://w3c-test.org/html/dom/undefined 1165725 1 cdumez 2016-02-17 13:56:25 -0800 I think the problem is that our Location.assign() / Location.replace() should take a mandatory parameter but it is optional in WebKit. The test tries to call these operations without parameter to make sure it throws. However, in our case, it does NOT throw and it calls the function with the string "undefined" instead. 1165755 2 271593 cdumez 2016-02-17 14:39:34 -0800 Created attachment 271593 Patch 1165903 3 271593 commit-queue 2016-02-17 21:44:09 -0800 Comment on attachment 271593 Patch Clearing flags on attachment: 271593 Committed r196742: <http://trac.webkit.org/changeset/196742> 1165904 4 commit-queue 2016-02-17 21:44:14 -0800 All reviewed patches have been landed. Closing bug. 1196203 5 cdumez 2016-05-24 22:07:42 -0700 *** Bug 125221 has been marked as a duplicate of this bug. *** 271593 2016-02-17 14:39:34 -0800 2016-02-17 21:44:09 -0800 Patch bug-154357-20160217143915.patch text/plain 5615 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2Njk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRhYzVmNjE4OThjNGFj YTIzZDVjMjc2ZjkzMGRlZTAzMzgxMDJiOS4uZmQxNjFmZTQ5NjVjNDAyMjI1YTE1ZDc1OGI4NDRj M2FhZTRkOGIzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE2LTAyLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMTk2NjQ4 KTogaHR0cDovL3czYy10ZXN0Lm9yZy9odG1sL2RvbS9pbnRlcmZhY2VzLmh0bWwgcmVkaXJlY3Rz IGF0IHRoZSBlbmQgb2YgdGhlIHRlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1NDM1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2UgbG9jYXRpb24uYXNzaWduKCkgLyBsb2NhdGlvbi5yZXBsYWNl KCkncyBwYXJhbWV0ZXIgbWFuZGF0b3J5LAorICAgICAgICBhcyBwZXIgdGhlIHNwZWNpZmljYXRp b246CisgICAgICAgIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL2Jyb3dz ZXJzLmh0bWwjdGhlLWxvY2F0aW9uLWludGVyZmFjZQorCisgICAgICAgIFByZXZpb3VzbHksIGNh bGxpbmcgbG9jYXRpb24uYXNzaWduKCkgLyBsb2NhdGlvbi5yZXBsYWNlKCkgd2l0aG91dAorICAg ICAgICBwYXJhbWV0ZXIgd291bGQgYmUgaWRlbnRpY2FsIHRvIGNhbGxpbmcgbG9jYXRpb24uYXNz aWduKCJ1bmRlZmluZWQiKSAvCisgICAgICAgIGxvY2F0aW9uLnJlcGxhY2UoInVuZGVmaW5lZCIp LCB3aGljaCBpcyBub3QgdXNlZnVsLgorCisgICAgICAgIEFmdGVyIHIxOTY2NDgsIGh0dHA6Ly93 M2MtdGVzdC5vcmcvaHRtbC9kb20vaW50ZXJmYWNlcy5odG1sIHdhcyBhYmxlIHRvCisgICAgICAg IHRlc3QgbG9jYXRpb24uYXNzaWduKCkgLyBsb2NhdGlvbi5yZXBsYWNlKCkgZnVydGhlciBiZWNh dXNlIHRoZXkgYXJlIG5vdworICAgICAgICBvbiB0aGUgaW5zdGFuY2UgKHdoZXJlIHRoZXkgc2hv dWxkIGJlKSBpbnN0ZWFkIG9mIHRoZSBwcm90b3R5cGUuIE9uZSBvZgorICAgICAgICB0aGVzZSB0 ZXN0cyBjYWxscyB0aGVzZSBmdW5jdGlvbnMgd2l0aG91dCBwYXJhbWV0ZXIsIGV4cGVjdGluZyB0 aGVtIHRvCisgICAgICAgIHRocm93IGFuIGV4Y2VwdGlvbi4gSG93ZXZlciwgaW4gV2ViS2l0LCBp dCB3b3VsZCBub3QgdGhyb3cgYW5kIGl0IHdvdWxkCisgICAgICAgIHJlZGlyZWN0IHVzIHRvIGh0 dHA6Ly93M2MtdGVzdC5vcmcvaHRtbC9kb20vdW5kZWZpbmVkLgorCisgICAgICAgIEZpcmVmb3gg YW5kIENocm9tZSBib3RoIGZvbGxvdyB0aGUgc3BlY2lmaWNhdGlvbiBhbHJlYWR5IGFuZCB0aHJv dyBpbgorICAgICAgICB0aGlzIGNhc2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5 IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHBhZ2UvTG9jYXRpb24uaWRs OgorICAgICAgICBNYWtlIGxvY2F0aW9uLmFzc2lnbigpIC8gbG9jYXRpb24ucmVwbGFjZSgpJ3Mg cGFyYW1ldGVyIG1hbmRhdG9yeSwKKyAgICAgICAgYXMgcGVyIHRoZSBzcGVjaWZpY2F0aW9uLgor CiAyMDE2LTAyLTE3ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtjc3MtZ3JpZF0gR3JpZFNwYW4gcmVmYWN0b3JpbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uaWRsIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Mb2Nh dGlvbi5pZGwKaW5kZXggOTMwMjVjODljZjY3ZmM1Nzk4ZDMxNWYzZDM3OTU3ZmY0NDNjY2E2Ny4u NmJkMmRhM2E3ZTc5NDNlZDU0YjI5YTdmYWM4ZWEwNzI2Yjc0Y2ZlYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9Mb2NhdGlvbi5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9M b2NhdGlvbi5pZGwKQEAgLTM5LDggKzM5LDggQEAKIF0gaW50ZXJmYWNlIExvY2F0aW9uIHsKICAg ICBbU2V0dGVyQ2FsbFdpdGg9QWN0aXZlV2luZG93JkZpcnN0V2luZG93XSBhdHRyaWJ1dGUgRE9N U3RyaW5nIGhyZWY7CiAKLSAgICBbQ2FsbFdpdGg9QWN0aXZlV2luZG93JkZpcnN0V2luZG93LCBG b3J3YXJkRGVjbGFyZUluSGVhZGVyXSB2b2lkIGFzc2lnbihbRGVmYXVsdD1VbmRlZmluZWRdIG9w dGlvbmFsIERPTVN0cmluZyB1cmwpOwotICAgIFtDYWxsV2l0aD1BY3RpdmVXaW5kb3cmRmlyc3RX aW5kb3csIEZvcndhcmREZWNsYXJlSW5IZWFkZXJdIHZvaWQgcmVwbGFjZShbRGVmYXVsdD1VbmRl ZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyB1cmwpOworICAgIFtDYWxsV2l0aD1BY3RpdmVXaW5k b3cmRmlyc3RXaW5kb3csIEZvcndhcmREZWNsYXJlSW5IZWFkZXJdIHZvaWQgYXNzaWduKERPTVN0 cmluZyB1cmwpOworICAgIFtDYWxsV2l0aD1BY3RpdmVXaW5kb3cmRmlyc3RXaW5kb3csIEZvcndh cmREZWNsYXJlSW5IZWFkZXJdIHZvaWQgcmVwbGFjZShET01TdHJpbmcgdXJsKTsKICAgICBbQ2Fs bFdpdGg9QWN0aXZlV2luZG93LCBGb3J3YXJkRGVjbGFyZUluSGVhZGVyXSB2b2lkIHJlbG9hZCgp OwogCiAgICAgLy8gVVJJIGRlY29tcG9zaXRpb24gYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9DaGFuZ2VMb2cKaW5kZXggMTg3NWJkOWU4YWRkZGY3MmM5NzUzMTNjYmQwNmUxMWRiYTQ1OWNh Mi4uNGFhODkwZTQxYjM1NDQ0OTM1MmIxY2ViNTE2NTU1NTUzNDFkNGYxZiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTYtMDItMTcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBSZWdyZXNzaW9uKHIxOTY2NDgpOiBo dHRwOi8vdzNjLXRlc3Qub3JnL2h0bWwvZG9tL2ludGVyZmFjZXMuaHRtbCByZWRpcmVjdHMgYXQg dGhlIGVuZCBvZiB0aGUgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU0MzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmViYXNlbGluZSBub3cgdGhhdCBtb3JlIGNoZWNrcyBhcmUgcGFzc2luZy4K KworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9pbnRlcmZhY2VzLWV4cGVj dGVkLnR4dDoKKworMjAxNi0wMi0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CiAgICAgICAgIFdpbmRvdyBzaG91bGQgaGF2ZSBpdHMgJ2NvbnN0cnVjdG9yJyBwcm9wZXJ0eSBv biB0aGUgcHJvdG90eXBlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTQwMzcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0Njg5MDc4PgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Rv bS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vaW50ZXJmYWNlcy1leHBlY3RlZC50eHQKaW5kZXggNDlk ODhmYzkxN2FlYmVlMjM3ZWY3YTZlYmE0N2U5ZDNkMTUxMzA5ZS4uMGFmMjI5ZmE5ZTQyOWFmNTk0 ZWQ0YmQzZGNiZmMwZTA0YmQxMmMzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9t L2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0CkBAIC00MTQ3LDEzICs0MTQ3LDkgQEAgUEFTUyBMb2Nh dGlvbiBpbnRlcmZhY2U6IHdpbmRvdy5sb2NhdGlvbiBtdXN0IGhhdmUgb3duIHByb3BlcnR5ICJw YXRobmFtZSIKIFBBU1MgTG9jYXRpb24gaW50ZXJmYWNlOiB3aW5kb3cubG9jYXRpb24gbXVzdCBo YXZlIG93biBwcm9wZXJ0eSAic2VhcmNoIiAKIFBBU1MgTG9jYXRpb24gaW50ZXJmYWNlOiB3aW5k b3cubG9jYXRpb24gbXVzdCBoYXZlIG93biBwcm9wZXJ0eSAiaGFzaCIgCiBGQUlMIExvY2F0aW9u IGludGVyZmFjZTogd2luZG93LmxvY2F0aW9uIG11c3QgaGF2ZSBvd24gcHJvcGVydHkgImFzc2ln biIgYXNzZXJ0X2VxdWFsczogcHJvcGVydHkgc2hvdWxkIGJlIHdyaXRhYmxlIGlmIGFuZCBvbmx5 IGlmIG5vdCB1bmZvcmdlYWJsZSBleHBlY3RlZCBmYWxzZSBidXQgZ290IHRydWUKLUZBSUwgTG9j YXRpb24gaW50ZXJmYWNlOiBjYWxsaW5nIGFzc2lnbihVU1ZTdHJpbmcpIG9uIHdpbmRvdy5sb2Nh dGlvbiB3aXRoIHRvbyBmZXcgYXJndW1lbnRzIG11c3QgdGhyb3cgVHlwZUVycm9yIGFzc2VydF90 aHJvd3M6IENhbGxlZCB3aXRoIDAgYXJndW1lbnRzIGZ1bmN0aW9uICJmdW5jdGlvbiAoKSB7Ci0g ICAgW25hdGl2ZSBjb2RlXQotfSIgZGlkIG5vdCB0aHJvdworUEFTUyBMb2NhdGlvbiBpbnRlcmZh Y2U6IGNhbGxpbmcgYXNzaWduKFVTVlN0cmluZykgb24gd2luZG93LmxvY2F0aW9uIHdpdGggdG9v IGZldyBhcmd1bWVudHMgbXVzdCB0aHJvdyBUeXBlRXJyb3IgCiBGQUlMIExvY2F0aW9uIGludGVy ZmFjZTogd2luZG93LmxvY2F0aW9uIG11c3QgaGF2ZSBvd24gcHJvcGVydHkgInJlcGxhY2UiIGFz c2VydF9lcXVhbHM6IHByb3BlcnR5IHNob3VsZCBiZSB3cml0YWJsZSBpZiBhbmQgb25seSBpZiBu b3QgdW5mb3JnZWFibGUgZXhwZWN0ZWQgZmFsc2UgYnV0IGdvdCB0cnVlCi1GQUlMIExvY2F0aW9u IGludGVyZmFjZTogY2FsbGluZyByZXBsYWNlKFVTVlN0cmluZykgb24gd2luZG93LmxvY2F0aW9u IHdpdGggdG9vIGZldyBhcmd1bWVudHMgbXVzdCB0aHJvdyBUeXBlRXJyb3IgYXNzZXJ0X3Rocm93 czogQ2FsbGVkIHdpdGggMCBhcmd1bWVudHMgZnVuY3Rpb24gImZ1bmN0aW9uICgpIHsKLSAgICBb bmF0aXZlIGNvZGVdCi19IiBkaWQgbm90IHRocm93CitQQVNTIExvY2F0aW9uIGludGVyZmFjZTog Y2FsbGluZyByZXBsYWNlKFVTVlN0cmluZykgb24gd2luZG93LmxvY2F0aW9uIHdpdGggdG9vIGZl dyBhcmd1bWVudHMgbXVzdCB0aHJvdyBUeXBlRXJyb3IgCiBGQUlMIExvY2F0aW9uIGludGVyZmFj ZTogd2luZG93LmxvY2F0aW9uIG11c3QgaGF2ZSBvd24gcHJvcGVydHkgInJlbG9hZCIgYXNzZXJ0 X2VxdWFsczogcHJvcGVydHkgc2hvdWxkIGJlIHdyaXRhYmxlIGlmIGFuZCBvbmx5IGlmIG5vdCB1 bmZvcmdlYWJsZSBleHBlY3RlZCBmYWxzZSBidXQgZ290IHRydWUKIFBBU1MgTG9jYXRpb24gaW50 ZXJmYWNlOiB3aW5kb3cubG9jYXRpb24gbXVzdCBoYXZlIG93biBwcm9wZXJ0eSAiYW5jZXN0b3JP cmlnaW5zIiAKIFBBU1MgUG9wU3RhdGVFdmVudCBpbnRlcmZhY2U6IGV4aXN0ZW5jZSBhbmQgcHJv cGVydGllcyBvZiBpbnRlcmZhY2Ugb2JqZWN0IAo=