<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>154085</bug_id>
          
          <creation_ts>2016-02-10 13:43:11 -0800</creation_ts>
          <short_desc>FontCache&apos;s clients should use references instead of pointers</short_desc>
          <delta_ts>2016-02-11 18:06:58 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>153346</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1163593</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2016-02-10 13:43:11 -0800</bug_when>
    <thetext>FontCache&apos;s clients should use references instead of pointers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1163595</commentid>
    <comment_count>1</comment_count>
      <attachid>271024</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2016-02-10 13:49:52 -0800</bug_when>
    <thetext>Created attachment 271024
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1163968</commentid>
    <comment_count>2</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2016-02-11 18:06:22 -0800</bug_when>
    <thetext>Committed http://trac.webkit.org/changeset/196393</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>271024</attachid>
            <date>2016-02-10 13:49:52 -0800</date>
            <delta_ts>2016-02-10 13:51:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-154085-20160210134930.patch</filename>
            <type>text/plain</type>
            <size>3579</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTliNzYyMDUwN2I2MzEz
MmI0MTBjNjUyZjZkMDk3ODAxZjgxNGJlOC4uOGI2MjRjZDMyMmU2ZTM3NjQxNGFlM2E4MTk2ZThi
OTNmMzc3ZjNlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTAyLTEwICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgRm9udENhY2hl
J3MgY2xpZW50cyBzaG91bGQgdXNlIHJlZmVyZW5jZXMgaW5zdGVhZCBvZiBwb2ludGVycworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MDg1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhleSBhcmUgbmV2
ZXIgbnVsbC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhh
dmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBjc3MvQ1NTRm9udFNlbGVjdG9yLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkNTU0ZvbnRTZWxlY3Rvcjo6Q1NTRm9udFNlbGVjdG9yKToKKyAgICAgICAg
KFdlYkNvcmU6OkNTU0ZvbnRTZWxlY3Rvcjo6fkNTU0ZvbnRTZWxlY3Rvcik6CisgICAgICAgICog
cGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRD
YWNoZTo6YWRkQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6cmVtb3ZlQ2xp
ZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuaDoKKworMjAxNi0w
Mi0xMCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgorCiAgICAgICAg
IENTU1NlZ21lbnRlZEZvbnRGYWNlIGRvZXMgbm90IG5lZWQgdG8gYmUgcmVmZXJlbmNlIGNvdW50
ZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDA4
MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udFNlbGVjdG9yLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250U2VsZWN0b3IuY3BwCmluZGV4IGE2NTZhMzQ5Yjc1
NGI1ZjFmN2FlZTU3MGYxNmYwOTI1ZTM5YTAzZWEuLjMwZTA2Y2VhNjc3MzE4MjJjNmFiM2Q2YTVl
MjNlN2RkOWRkMDRiNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250U2Vs
ZWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250U2VsZWN0b3IuY3BwCkBA
IC03MywxMyArNzMsMTMgQEAgQ1NTRm9udFNlbGVjdG9yOjpDU1NGb250U2VsZWN0b3IoRG9jdW1l
bnQmIGRvY3VtZW50KQogICAgIC8vIHNlZW0gdG8gYmUgYW55IHN1Y2ggZ3VhcmFudGVlLgogCiAg
ICAgQVNTRVJUKG1fZG9jdW1lbnQpOwotICAgIEZvbnRDYWNoZTo6c2luZ2xldG9uKCkuYWRkQ2xp
ZW50KHRoaXMpOworICAgIEZvbnRDYWNoZTo6c2luZ2xldG9uKCkuYWRkQ2xpZW50KCp0aGlzKTsK
IH0KIAogQ1NTRm9udFNlbGVjdG9yOjp+Q1NTRm9udFNlbGVjdG9yKCkKIHsKICAgICBjbGVhckRv
Y3VtZW50KCk7Ci0gICAgRm9udENhY2hlOjpzaW5nbGV0b24oKS5yZW1vdmVDbGllbnQodGhpcyk7
CisgICAgRm9udENhY2hlOjpzaW5nbGV0b24oKS5yZW1vdmVDbGllbnQoKnRoaXMpOwogfQogCiBi
b29sIENTU0ZvbnRTZWxlY3Rvcjo6aXNFbXB0eSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcAppbmRleCA4M2ZmZTFiZDI5ZmRkNmE1N2M4
N2FiZmVlOGVlYzFiZDI1ODUyNjc1Li5jYTg5Yjg4NmQzNmRiYTU3OTY0N2UxMjkzY2QzOWFkZmM4
ZDVmN2NlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250
Q2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYWNo
ZS5jcHAKQEAgLTQ4NSwyMSArNDg1LDIxIEBAIHNpemVfdCBGb250Q2FjaGU6OmluYWN0aXZlRm9u
dENvdW50KCkKIAogc3RhdGljIEhhc2hTZXQ8Rm9udFNlbGVjdG9yKj4qIGdDbGllbnRzOwogCi12
b2lkIEZvbnRDYWNoZTo6YWRkQ2xpZW50KEZvbnRTZWxlY3RvciogY2xpZW50KQordm9pZCBGb250
Q2FjaGU6OmFkZENsaWVudChGb250U2VsZWN0b3ImIGNsaWVudCkKIHsKICAgICBpZiAoIWdDbGll
bnRzKQogICAgICAgICBnQ2xpZW50cyA9IG5ldyBIYXNoU2V0PEZvbnRTZWxlY3Rvcio+OwogCi0g
ICAgQVNTRVJUKCFnQ2xpZW50cy0+Y29udGFpbnMoY2xpZW50KSk7Ci0gICAgZ0NsaWVudHMtPmFk
ZChjbGllbnQpOworICAgIEFTU0VSVCghZ0NsaWVudHMtPmNvbnRhaW5zKCZjbGllbnQpKTsKKyAg
ICBnQ2xpZW50cy0+YWRkKCZjbGllbnQpOwogfQogCi12b2lkIEZvbnRDYWNoZTo6cmVtb3ZlQ2xp
ZW50KEZvbnRTZWxlY3RvciogY2xpZW50KQordm9pZCBGb250Q2FjaGU6OnJlbW92ZUNsaWVudChG
b250U2VsZWN0b3ImIGNsaWVudCkKIHsKICAgICBBU1NFUlQoZ0NsaWVudHMpOwotICAgIEFTU0VS
VChnQ2xpZW50cy0+Y29udGFpbnMoY2xpZW50KSk7CisgICAgQVNTRVJUKGdDbGllbnRzLT5jb250
YWlucygmY2xpZW50KSk7CiAKLSAgICBnQ2xpZW50cy0+cmVtb3ZlKGNsaWVudCk7CisgICAgZ0Ns
aWVudHMtPnJlbW92ZSgmY2xpZW50KTsKIH0KIAogc3RhdGljIHVuc2lnbmVkIHNob3J0IGdHZW5l
cmF0aW9uID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0ZvbnRDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hl
LmgKaW5kZXggY2Y0OGJjNmRkZjI5ZjQyYTJmNWNjNmRiMmNiMTcyMGI3NzgwN2Q4NC4uNTEzZTk3
YThlZTZmYTVlYjlmYzg3MWYxM2ZhM2UwNzM5YzViODRhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmgKQEAgLTE5Myw4ICsxOTMsOCBAQCBwdWJsaWM6
CiAgICAgV0VCQ09SRV9FWFBPUlQgUmVmPEZvbnQ+IGZvbnRGb3JQbGF0Zm9ybURhdGEoY29uc3Qg
Rm9udFBsYXRmb3JtRGF0YSYpOwogICAgIFJlZlB0cjxGb250PiBzaW1pbGFyRm9udChjb25zdCBG
b250RGVzY3JpcHRpb24mLCBjb25zdCBBdG9taWNTdHJpbmcmIGZhbWlseSk7CiAKLSAgICB2b2lk
IGFkZENsaWVudChGb250U2VsZWN0b3IqKTsKLSAgICB2b2lkIHJlbW92ZUNsaWVudChGb250U2Vs
ZWN0b3IqKTsKKyAgICB2b2lkIGFkZENsaWVudChGb250U2VsZWN0b3ImKTsKKyAgICB2b2lkIHJl
bW92ZUNsaWVudChGb250U2VsZWN0b3ImKTsKIAogICAgIHVuc2lnbmVkIHNob3J0IGdlbmVyYXRp
b24oKTsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGludmFsaWRhdGUoKTsK
</data>
<flag name="review"
          id="295873"
          type_id="1"
          status="+"
          setter="koivisto"
    />
          </attachment>
      

    </bug>

</bugzilla>