154083 2016-02-10 13:00:16 -0800 CSSSegmentedFontFace does not need to be reference counted 2016-02-11 18:06:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153346 1 mmaxfield mmaxfield oldest_to_newest 1163575 0 mmaxfield 2016-02-10 13:00:16 -0800 CSSSegmentedFontFace does not need to be reference counted 1163576 1 271021 mmaxfield 2016-02-10 13:01:04 -0800 Created attachment 271021 Patch 1163577 2 271021 koivisto 2016-02-10 13:03:22 -0800 Comment on attachment 271021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271021&action=review > Source/WebCore/css/CSSSegmentedFontFace.h:43 > -class CSSSegmentedFontFace : public RefCounted<CSSSegmentedFontFace> { > +class CSSSegmentedFontFace { > public: You might want to add WTF_MAKE_FAST_ALLOCATED; 1163580 3 mmaxfield 2016-02-10 13:08:07 -0800 Committed r196388: <http://trac.webkit.org/changeset/196388> 1163599 4 mmaxfield 2016-02-10 13:57:57 -0800 Committed r196393: <http://trac.webkit.org/changeset/196393> 1163763 5 271021 darin 2016-02-11 09:42:57 -0800 Comment on attachment 271021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271021&action=review > Source/WebCore/css/CSSFontSelector.cpp:472 > + std::unique_ptr<CSSSegmentedFontFace>& face = segmentedFontFaceCache.add(traitsMask, nullptr).iterator->value; I think auto& is an improvement for code like this; what’s the need to restate the type on this line of code? > Source/WebCore/css/CSSSegmentedFontFace.h:42 > +class CSSSegmentedFontFace { Maybe mark this class final. Along with the lack of virtual functions, makes it clear there’s no polymorphism here. 271021 2016-02-10 13:01:04 -0800 2016-02-10 13:03:22 -0800 Patch bug-154083-20160210130042.patch text/plain 4136 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTk2MzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjM1OTRhMDAzZTVlY2Fk NjhlNjcwMjdmYTBlMDc1ZWJlNWMyMDBjYi4uMmIzYWZkOTMwMTQwNWMwZmIyZDNjMTQ0ODFmMmRh OTNiYTFlMTJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAyLTEwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ1NTU2VnbWVu dGVkRm9udEZhY2UgZG9lcyBub3QgbmVlZCB0byBiZSByZWZlcmVuY2UgY291bnRlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0MDgzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLi4uVGhlcmUgaXMgb25s eSBldmVyIGEgc2luZ2xlIHJlZmVyZW5jZSB0byBvbmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogY3NzL0NT U0ZvbnRTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NGb250U2VsZWN0b3I6Omdl dEZvbnRGYWNlKToKKyAgICAgICAgKiBjc3MvQ1NTRm9udFNlbGVjdG9yLmg6CisgICAgICAgICog Y3NzL0NTU1NlZ21lbnRlZEZvbnRGYWNlLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWdtZW50 ZWRGb250RmFjZTo6Y3JlYXRlKTogRGVsZXRlZC4KKwogMjAxNi0wMi0wOSAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQg Zml4IGFmdGVyIHIxOTYzMjIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250 U2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRTZWxlY3Rvci5jcHAKaW5k ZXggNjNiMWQ2Y2ZjZGViYjJiYTBhYzkxM2M4MzE2YTQ1Zjg1OWIxZjZiMS4uYTY1NmEzNDliNzU0 YjVmMWY3YWVlNTcwZjE2ZjA5MjVlMzlhMDNlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU0ZvbnRTZWxlY3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRT ZWxlY3Rvci5jcHAKQEAgLTQ2NSwxNSArNDY1LDE1IEBAIENTU1NlZ21lbnRlZEZvbnRGYWNlKiBD U1NGb250U2VsZWN0b3I6OmdldEZvbnRGYWNlKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udERl CiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIGF1dG8mIGZhbWlseUZvbnRGYWNlcyA9IGl0 ZXJhdG9yLT52YWx1ZTsKIAotICAgIGF1dG8mIHNlZ21lbnRlZEZvbnRGYWNlQ2FjaGUgPSBtX2Zv bnRzLmFkZChmYW1pbHksIEhhc2hNYXA8dW5zaWduZWQsIFJlZlB0cjxDU1NTZWdtZW50ZWRGb250 RmFjZT4+KCkpLml0ZXJhdG9yLT52YWx1ZTsKKyAgICBhdXRvJiBzZWdtZW50ZWRGb250RmFjZUNh Y2hlID0gbV9mb250cy5hZGQoZmFtaWx5LCBIYXNoTWFwPHVuc2lnbmVkLCBzdGQ6OnVuaXF1ZV9w dHI8Q1NTU2VnbWVudGVkRm9udEZhY2U+PigpKS5pdGVyYXRvci0+dmFsdWU7CiAKICAgICBGb250 VHJhaXRzTWFzayB0cmFpdHNNYXNrID0gZm9udERlc2NyaXB0aW9uLnRyYWl0c01hc2soKTsKIAot ICAgIFJlZlB0cjxDU1NTZWdtZW50ZWRGb250RmFjZT4mIGZhY2UgPSBzZWdtZW50ZWRGb250RmFj ZUNhY2hlLmFkZCh0cmFpdHNNYXNrLCBudWxscHRyKS5pdGVyYXRvci0+dmFsdWU7CisgICAgc3Rk Ojp1bmlxdWVfcHRyPENTU1NlZ21lbnRlZEZvbnRGYWNlPiYgZmFjZSA9IHNlZ21lbnRlZEZvbnRG YWNlQ2FjaGUuYWRkKHRyYWl0c01hc2ssIG51bGxwdHIpLml0ZXJhdG9yLT52YWx1ZTsKICAgICBp ZiAoZmFjZSkKICAgICAgICAgcmV0dXJuIGZhY2UuZ2V0KCk7CiAKLSAgICBmYWNlID0gQ1NTU2Vn bWVudGVkRm9udEZhY2U6OmNyZWF0ZSgqdGhpcyk7CisgICAgZmFjZSA9IHN0ZDo6bWFrZV91bmlx dWU8Q1NTU2VnbWVudGVkRm9udEZhY2U+KCp0aGlzKTsKIAogICAgIFZlY3RvcjxzdGQ6OnJlZmVy ZW5jZV93cmFwcGVyPENTU0ZvbnRGYWNlPiwgMzI+IGNhbmRpZGF0ZUZvbnRGYWNlczsKICAgICBm b3IgKGludCBpID0gZmFtaWx5Rm9udEZhY2VzLnNpemUoKSAtIDE7IGkgPj0gMDsgLS1pKSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udFNlbGVjdG9yLmggYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTRm9udFNlbGVjdG9yLmgKaW5kZXggZWY4OWFjZDYwOGIxNDJiNzllYzQw ZGU5ZTc2ODllYTdkYWFhMjE1Mi4uZWFkYTllNzU2Y2Y5ZWYyZWRhZmIwNjk2ZGI4ZjQwNjRiYzcx NDU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRTZWxlY3Rvci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250U2VsZWN0b3IuaApAQCAtODgsNyArODgsNyBA QCBwcml2YXRlOgogICAgIERvY3VtZW50KiBtX2RvY3VtZW50OwogICAgIEhhc2hNYXA8U3RyaW5n LCBWZWN0b3I8UmVmPENTU0ZvbnRGYWNlPj4sIEFTQ0lJQ2FzZUluc2Vuc2l0aXZlSGFzaD4gbV9m b250RmFjZXM7CiAgICAgSGFzaE1hcDxTdHJpbmcsIFZlY3RvcjxSZWY8Q1NTRm9udEZhY2U+Piwg QVNDSUlDYXNlSW5zZW5zaXRpdmVIYXNoPiBtX2xvY2FsbHlJbnN0YWxsZWRGb250RmFjZXM7Ci0g ICAgSGFzaE1hcDxTdHJpbmcsIEhhc2hNYXA8dW5zaWduZWQsIFJlZlB0cjxDU1NTZWdtZW50ZWRG b250RmFjZT4+LCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+IG1fZm9udHM7CisgICAgSGFzaE1h cDxTdHJpbmcsIEhhc2hNYXA8dW5zaWduZWQsIHN0ZDo6dW5pcXVlX3B0cjxDU1NTZWdtZW50ZWRG b250RmFjZT4+LCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+IG1fZm9udHM7CiAgICAgSGFzaFNl dDxGb250U2VsZWN0b3JDbGllbnQqPiBtX2NsaWVudHM7CiAKICAgICBWZWN0b3I8Q2FjaGVkUmVz b3VyY2VIYW5kbGU8Q2FjaGVkRm9udD4+IG1fZm9udHNUb0JlZ2luTG9hZGluZzsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWdtZW50ZWRGb250RmFjZS5oIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU1NlZ21lbnRlZEZvbnRGYWNlLmgKaW5kZXggODUyNDdkMDk5MmFiOWMwMWNm M2E0YmJjYjAzMjYxOTcwNWNiMzBiYy4uNmI1ZTllYWY3ZDhlMGM4N2Q1NGIzYWVkNTEzYzg5NTVm MGJjZmZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlZ21lbnRlZEZvbnRG YWNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1NlZ21lbnRlZEZvbnRGYWNlLmgKQEAg LTM5LDkgKzM5LDkgQEAgY2xhc3MgQ1NTRm9udEZhY2U7CiBjbGFzcyBDU1NGb250U2VsZWN0b3I7 CiBjbGFzcyBGb250RGVzY3JpcHRpb247CiAKLWNsYXNzIENTU1NlZ21lbnRlZEZvbnRGYWNlIDog cHVibGljIFJlZkNvdW50ZWQ8Q1NTU2VnbWVudGVkRm9udEZhY2U+IHsKK2NsYXNzIENTU1NlZ21l bnRlZEZvbnRGYWNlIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUmVmPENTU1NlZ21lbnRlZEZvbnRG YWNlPiBjcmVhdGUoQ1NTRm9udFNlbGVjdG9yJiBzZWxlY3RvcikgeyByZXR1cm4gYWRvcHRSZWYo Km5ldyBDU1NTZWdtZW50ZWRGb250RmFjZShzZWxlY3RvcikpOyB9CisgICAgQ1NTU2VnbWVudGVk Rm9udEZhY2UoQ1NTRm9udFNlbGVjdG9yJik7CiAgICAgfkNTU1NlZ21lbnRlZEZvbnRGYWNlKCk7 CiAKICAgICBDU1NGb250U2VsZWN0b3ImIGZvbnRTZWxlY3RvcigpIGNvbnN0IHsgcmV0dXJuIG1f Zm9udFNlbGVjdG9yOyB9CkBAIC01Myw3ICs1Myw2IEBAIHB1YmxpYzoKICAgICBGb250UmFuZ2Vz IGZvbnRSYW5nZXMoY29uc3QgRm9udERlc2NyaXB0aW9uJik7CiAKIHByaXZhdGU6Ci0gICAgQ1NT U2VnbWVudGVkRm9udEZhY2UoQ1NTRm9udFNlbGVjdG9yJik7CiAKICAgICBDU1NGb250U2VsZWN0 b3ImIG1fZm9udFNlbGVjdG9yOwogICAgIEhhc2hNYXA8Rm9udERlc2NyaXB0aW9uS2V5LCBGb250 UmFuZ2VzLCBGb250RGVzY3JpcHRpb25LZXlIYXNoLCBXVEY6OlNpbXBsZUNsYXNzSGFzaFRyYWl0 czxGb250RGVzY3JpcHRpb25LZXk+PiBtX2NhY2hlOwo=