153740 2016-02-01 05:12:09 -0800 [GTK] WebKitWebView should send crossing events to the WebProcess 2018-09-14 06:34:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153990 153995 187545 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1160824 0 cgarcia 2016-02-01 05:12:09 -0800 We don't currently handle crossing events in the web view (enter/leave). That's why if you hover a scrollbar and leave the window, the scrollbar is still rendered as hovered. 1160825 1 270383 cgarcia 2016-02-01 05:20:19 -0800 Created attachment 270383 Patch I'll try to make a layout test for this once bug #153479 is fixed. 1160827 2 commit-queue 2016-02-01 05:22:22 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1162738 3 270383 mcatanzaro 2016-02-07 09:21:28 -0800 Comment on attachment 270383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270383&action=review r=me with a test > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:816 > + // if the coordinates of the leave event are for example (25.2, -0.9), the WebProcess will receive (25, 0) and any hit test will success success -> succeed > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:817 > + // because those coorindates are inside the web view. coorindates -> coordinates 1162843 4 cgarcia 2016-02-08 01:15:17 -0800 I'll add the test once bug #153479 is fixed, let's not block this on that. 1162891 5 cgarcia 2016-02-08 08:59:51 -0800 Committed r196253: <http://trac.webkit.org/changeset/196253> 1162909 6 commit-queue 2016-02-08 10:24:20 -0800 Re-opened since this is blocked by bug 153990 1162928 7 cgarcia 2016-02-08 10:58:05 -0800 Crashes were not actually introduced by this patch, but for some reason I don't know yet, it happens after this patch. It only affects WTR, because it forces the events IPC messages to be synchronous, and it ends up in an infinite loop. #0 0x00007ffff5bbb133 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007ffff5bbc48c in IPC::Connection::sendSyncMessage(unsigned long, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007ffff5bbb1f5 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007ffff5c20e37 in WebKit::ChildProcessProxy::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007ffff5c5c02a in bool WebKit::ChildProcessProxy::send<Messages::WebPage::MouseEvent>(Messages::WebPage::MouseEvent&&, unsigned long, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007ffff5c4579c in WebKit::WebPageProxy::handleMouseEvent(WebKit::NativeWebMouseEvent const&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007ffff5c5170a in WebKit::WebPageProxy::didReceiveEvent(unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007ffff5e686f7 in WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007ffff5bbf039 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007ffff5c75102 in WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007ffff5bbb546 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007ffff5bbb89e in IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007ffff5bbb4a1 in IPC::Connection::dispatchSyncMessage(IPC::MessageDecoder&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007ffff5bbb5bd in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #14 0x00007ffff5bbb89e in IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #15 0x00007ffff5bbbd8f in IPC::Connection::waitForSyncReply(unsigned long, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #16 0x00007ffff5bbc4b8 in IPC::Connection::sendSyncMessage(unsigned long, std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, std::chrono::duration<long, std::ratio<1l, 1000l> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #17 0x00007ffff5bbb1f5 in IPC::Connection::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #18 0x00007ffff5c20e37 in WebKit::ChildProcessProxy::sendMessage(std::unique_ptr<IPC::MessageEncoder, std::default_delete<IPC::MessageEncoder> >, unsigned int) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 ...... I'll file a separate bug report for this problem 1162962 8 cgarcia 2016-02-08 11:42:53 -0800 Committed r196265: <http://trac.webkit.org/changeset/196265> 270383 2016-02-01 05:20:19 -0800 2016-02-08 04:56:24 -0800 Patch wk2-crossing-events.diff text/plain 8044 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NGVjODU3Li43NDM2MDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTYtMDItMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYktpdFdlYlZpZXcgc2hvdWxkIHNlbmQgY3Jvc3NpbmcgZXZl bnRzIHRvIHRoZSBXZWJQcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTM3NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgdGhlIHRhcmdldCBlbGVtZW50IHVuZGVyIHRoZSBtb3VzZSBh bHNvIHdoZW4gb25seSB1cGRhdGluZworICAgICAgICBzY3JvbGxiYXJzLCBzbyB0aGF0IGlmIHRo ZSBtb3VzZSBlbnRlcnMgdGhlIHBhZ2Ugd2hlbiB0aGUgd2luZG93CisgICAgICAgIGlzIG5vdCBh Y3RpdmUsIHRoZSBzY3JvbGwgYW5pbWF0b3IgaXMgbm90aWZpZWQgdGhhdCB0aGUgbW91c2UKKyAg ICAgICAgZW50ZXJlZCB0aGUgc2Nyb2xsYWJsZSBhcmVhLgorCisgICAgICAgICogcGFnZS9FdmVu dEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3Vz ZU1vdmVFdmVudCk6IENhbGwKKyAgICAgICAgdXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUoKSBi ZWZvcmUgZWFybHkgcmV0dXJuaW5nIGluIGNhc2Ugb2YKKyAgICAgICAgb25seSB1cGRhdGluZyBz Y3JvbGxiYXJzLgorCiAyMDE2LTAxLTMxICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgcmVzaXplIGV2ZW50IGZvciBIVE1MTWVkaWFFbGVtZW50CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggYTI0ODkwYy4uNTRhY2I5NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTg4Miw4ICsxODgyLDEwIEBAIGJvb2wg RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZU1vdmVFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZl bnQmIHBsYXRmb3JtTW91c2VFCiAgICAgICAgIGlmICghbV9tb3VzZVByZXNzZWQgJiYgc2Nyb2xs YmFyKQogICAgICAgICAgICAgc2Nyb2xsYmFyLT5tb3VzZU1vdmVkKHBsYXRmb3JtTW91c2VFdmVu dCk7IC8vIEhhbmRsZSBob3ZlciBlZmZlY3RzIG9uIHBsYXRmb3JtcyB0aGF0IHN1cHBvcnQgdmlz dWFsIGZlZWRiYWNrIG9uIHNjcm9sbGJhciBob3ZlcmluZy4KICNlbmRpZgotICAgICAgICBpZiAo b25seVVwZGF0ZVNjcm9sbGJhcnMpCisgICAgICAgIGlmIChvbmx5VXBkYXRlU2Nyb2xsYmFycykg eworICAgICAgICAgICAgdXBkYXRlTW91c2VFdmVudFRhcmdldE5vZGUobW91c2VFdmVudC50YXJn ZXROb2RlKCksIHBsYXRmb3JtTW91c2VFdmVudCwgdHJ1ZSk7CiAgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGJvb2wgc3dhbGxvd0V2ZW50ID0gZmFsc2U7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKaW5kZXggOGQ4NmQ0ZS4uMzYzY2Y0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE2LTAyLTAxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBXZWJLaXRXZWJWaWV3IHNob3VsZCBzZW5kIGNyb3NzaW5nIGV2 ZW50cyB0byB0aGUgV2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUzNzQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2UgZG9uJ3QgY3VycmVudGx5IGhhbmRsZSBjcm9zc2luZyBldmVudHMg aW4gdGhlIHdlYiB2aWV3CisgICAgICAgIChlbnRlci9sZWF2ZSkuIFRoYXQncyB3aHkgaWYgeW91 IGhvdmVyIGEgc2Nyb2xsYmFyIGFuZCBsZWF2ZSB0aGUKKyAgICAgICAgd2luZG93LCB0aGUgc2Ny b2xsYmFyIGlzIHN0aWxsIHJlbmRlcmVkIGFzIGhvdmVyZWQuCisKKyAgICAgICAgKiBTaGFyZWQv Z3RrL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1dHRvbkZvckV2ZW50 KTogSGFuZGxlIHRoZSBjYXNlIG9mIEdES19FTlRFUl9OT1RJRlkgYW5kCisgICAgICAgIEdES19M RUFWRV9OT1RJRlkgZXZlbnRzLgorICAgICAgICAoV2ViS2l0OjpXZWJFdmVudEZhY3Rvcnk6OmNy ZWF0ZVdlYk1vdXNlRXZlbnQpOiBEaXR0by4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUp OiBBZGQgR0RLX0VOVEVSX05PVElGWV9NQVNLIGFuZAorICAgICAgICBHREtfTEVBVkVfTk9USUZZ X01BU0sgZmxhZ3MgdG8gdGhlIHdlYiB2aWV3IGV2ZW50IG1hc2suCisgICAgICAgICh3ZWJraXRX ZWJWaWV3QmFzZUNyb3NzaW5nTm90aWZ5RXZlbnQpOiBIYW5kbGUgZW50ZXIvbGVhdmUgbm90aWZ5 CisgICAgICAgIGV2ZW50cyBieSBnZW5lcmF0aW5nIGEgbW91c2UgbW92ZSBldmVudCwgZW5zdXJp bmcgdGhlIGRvdWJsZSB0bworICAgICAgICBpbnQgY29udmVyc2lvbiB3aWxsIG5vdCBjYXVzZSBh bnkgcHJvYmxlbS4KKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19iYXNlX2NsYXNzX2luaXQpOiBB ZGQgYW4gaW1wbGVtZW50YXRpb24gZm9yCisgICAgICAgIGVudGVyX25vdGlmeV9ldmVudCBhbmQg bGVhdmVfbm90aWZ5X2V2ZW50LgorCiAyMDE2LTAxLTMxICBEYXJpbiBBZGxlciAgPGRhcmluQGFw cGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIG1vc3QgY2FsbHMgdG8gU3RyaW5nOjp1cHBl cjsgbW9zdGx5IHJlcGxhY2UgdGhlbSB3aXRoIGNvbnZlcnRUb0FTQ0lJVXBwZXJjYXNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5jcHAKaW5kZXggZjdlODk3 ZS4uMmQ2NjM5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2d0ay9XZWJFdmVu dEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0 b3J5LmNwcApAQCAtNzIsMTUgKzcyLDIwIEBAIHN0YXRpYyBpbmxpbmUgV2ViTW91c2VFdmVudDo6 QnV0dG9uIGJ1dHRvbkZvckV2ZW50KGNvbnN0IEdka0V2ZW50KiBldmVudCkKICAgICB1bnNpZ25l ZCBidXR0b24gPSAwOwogCiAgICAgc3dpdGNoIChldmVudC0+dHlwZSkgewotICAgIGNhc2UgR0RL X01PVElPTl9OT1RJRlk6CisgICAgY2FzZSBHREtfRU5URVJfTk9USUZZOgorICAgIGNhc2UgR0RL X0xFQVZFX05PVElGWToKKyAgICBjYXNlIEdES19NT1RJT05fTk9USUZZOiB7CiAgICAgICAgIGJ1 dHRvbiA9IFdlYk1vdXNlRXZlbnQ6Ok5vQnV0dG9uOwotICAgICAgICBpZiAoZXZlbnQtPm1vdGlv bi5zdGF0ZSAmIEdES19CVVRUT04xX01BU0spCisgICAgICAgIEdka01vZGlmaWVyVHlwZSBzdGF0 ZTsKKyAgICAgICAgZ2RrX2V2ZW50X2dldF9zdGF0ZShldmVudCwgJnN0YXRlKTsKKyAgICAgICAg aWYgKHN0YXRlICYgR0RLX0JVVFRPTjFfTUFTSykKICAgICAgICAgICAgIGJ1dHRvbiA9IFdlYk1v dXNlRXZlbnQ6OkxlZnRCdXR0b247Ci0gICAgICAgIGVsc2UgaWYgKGV2ZW50LT5tb3Rpb24uc3Rh dGUgJiBHREtfQlVUVE9OMl9NQVNLKQorICAgICAgICBlbHNlIGlmIChzdGF0ZSAmIEdES19CVVRU T04yX01BU0spCiAgICAgICAgICAgICBidXR0b24gPSBXZWJNb3VzZUV2ZW50OjpNaWRkbGVCdXR0 b247Ci0gICAgICAgIGVsc2UgaWYgKGV2ZW50LT5tb3Rpb24uc3RhdGUgJiBHREtfQlVUVE9OM19N QVNLKQorICAgICAgICBlbHNlIGlmIChzdGF0ZSAmIEdES19CVVRUT04zX01BU0spCiAgICAgICAg ICAgICBidXR0b24gPSBXZWJNb3VzZUV2ZW50OjpSaWdodEJ1dHRvbjsKICAgICAgICAgYnJlYWs7 CisgICAgfQogICAgIGNhc2UgR0RLX0JVVFRPTl9QUkVTUzoKICAgICBjYXNlIEdES18yQlVUVE9O X1BSRVNTOgogICAgIGNhc2UgR0RLXzNCVVRUT05fUFJFU1M6CkBAIC0xMDgsNiArMTEzLDggQEAg V2ViTW91c2VFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoY29uc3Qg R2RrRXZlbnQqIGV2ZW50LCBpbnQgY3UKICAgICBXZWJFdmVudDo6VHlwZSB0eXBlID0gc3RhdGlj X2Nhc3Q8V2ViRXZlbnQ6OlR5cGU+KDApOwogICAgIHN3aXRjaCAoZXZlbnQtPnR5cGUpIHsKICAg ICBjYXNlIEdES19NT1RJT05fTk9USUZZOgorICAgIGNhc2UgR0RLX0VOVEVSX05PVElGWToKKyAg ICBjYXNlIEdES19MRUFWRV9OT1RJRlk6CiAgICAgICAgIHR5cGUgPSBXZWJFdmVudDo6TW91c2VN b3ZlOwogICAgICAgICBicmVhazsKICAgICBjYXNlIEdES19CVVRUT05fUFJFU1M6CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAKaW5kZXggYzQ3MTAyZS4uNzU0ZGU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMzI3LDYgKzMyNyw4 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVhbGl6ZShHdGtXaWRnZXQqIHdpZGdl dCkKICAgICAgICAgfCBHREtfU0NST0xMX01BU0sKICAgICAgICAgfCBHREtfU01PT1RIX1NDUk9M TF9NQVNLCiAgICAgICAgIHwgR0RLX1BPSU5URVJfTU9USU9OX01BU0sKKyAgICAgICAgfCBHREtf RU5URVJfTk9USUZZX01BU0sKKyAgICAgICAgfCBHREtfTEVBVkVfTk9USUZZX01BU0sKICAgICAg ICAgfCBHREtfS0VZX1BSRVNTX01BU0sKICAgICAgICAgfCBHREtfS0VZX1JFTEVBU0VfTUFTSwog ICAgICAgICB8IEdES19CVVRUT05fTU9USU9OX01BU0sKQEAgLTgwMCw2ICs4MDIsNDcgQEAgc3Rh dGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdCYXNlTW90aW9uTm90aWZ5RXZlbnQoR3RrV2lkZ2V0 KiB3aWRnZXQsIEdka0V2ZW50TW8KICAgICByZXR1cm4gRkFMU0U7CiB9CiAKK3N0YXRpYyBnYm9v bGVhbiB3ZWJraXRXZWJWaWV3QmFzZUNyb3NzaW5nTm90aWZ5RXZlbnQoR3RrV2lkZ2V0KiB3aWRn ZXQsIEdka0V2ZW50Q3Jvc3NpbmcqIGNyb3Nzc2luZ0V2ZW50KQoreworICAgIFdlYktpdFdlYlZp ZXdCYXNlKiB3ZWJWaWV3QmFzZSA9IFdFQktJVF9XRUJfVklFV19CQVNFKHdpZGdldCk7CisgICAg V2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlKiBwcml2ID0gd2ViVmlld0Jhc2UtPnByaXY7CisKKyAg ICBpZiAocHJpdi0+YXV0aGVudGljYXRpb25EaWFsb2cpCisgICAgICAgIHJldHVybiBGQUxTRTsK KworICAgIC8vIEluIHRoZSBjYXNlIG9mIGNyb3NzaW5nIGV2ZW50cywgaXQncyB2ZXJ5IGltcG9y dGFudCB0aGUgYWN0dWFsIGNvb3JkaW5hdGVzIHRoZSBXZWJQcm9jZXNzIHJlY2VpdmVzLCBiZWNh dXNlIG9uY2UgdGhlIG1vdXNlIGxlYXZlcworICAgIC8vIHRoZSB3ZWIgdmlldywgdGhlIFdlYlBy b2Nlc3Mgd29uJ3QgcmVjZWl2ZSBtb3JlIGV2ZW50cyB1bnRpbCB0aGUgbW91c2UgZW50ZXJzIGFn YWluIGluIHRoZSB3ZWIgdmlldy4gU28sIGlmIHRoZSBjb29yZGluYXRlcyBvZiB0aGUgbGVhdmUK KyAgICAvLyBldmVudCBhcmUgbm90IGFjY3VyYXRlLCB0aGUgV2ViUHJvY2VzcyBtaWdodCBub3Qg a25vdyB0aGUgbW91c2UgbGVmdCB0aGUgdmlldy4gVGhpcyBjYW4gaGFwcGVuIGJlY2F1c2Ugb2Yg ZG91YmxlIHRvIGludGVnZXIgY29udmVyc2lvbiwKKyAgICAvLyBpZiB0aGUgY29vcmRpbmF0ZXMg b2YgdGhlIGxlYXZlIGV2ZW50IGFyZSBmb3IgZXhhbXBsZSAoMjUuMiwgLTAuOSksIHRoZSBXZWJQ cm9jZXNzIHdpbGwgcmVjZWl2ZSAoMjUsIDApIGFuZCBhbnkgaGl0IHRlc3Qgd2lsbCBzdWNjZXNz CisgICAgLy8gYmVjYXVzZSB0aG9zZSBjb29yaW5kYXRlcyBhcmUgaW5zaWRlIHRoZSB3ZWIgdmll dy4KKyAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb247CisgICAgZ3RrX3dpZGdldF9nZXRfYWxs b2NhdGlvbih3aWRnZXQsICZhbGxvY2F0aW9uKTsKKyAgICBkb3VibGUgd2lkdGggPSBhbGxvY2F0 aW9uLndpZHRoOworICAgIGRvdWJsZSBoZWlnaHQgPSBhbGxvY2F0aW9uLmhlaWdodDsKKyAgICBk b3VibGUgeCA9IGNyb3Nzc2luZ0V2ZW50LT54OworICAgIGRvdWJsZSB5ID0gY3Jvc3NzaW5nRXZl bnQtPnk7CisgICAgaWYgKHggPCAwICYmIHggPiAtMSkKKyAgICAgICAgeCA9IC0xOworICAgIGVs c2UgaWYgKHggPj0gd2lkdGggJiYgeCA8IHdpZHRoICsgMSkKKyAgICAgICAgeCA9IHdpZHRoICsg MTsKKyAgICBpZiAoeSA8IDAgJiYgeSA+IC0xKQorICAgICAgICB5ID0gLTE7CisgICAgZWxzZSBp ZiAoeSA+PSBoZWlnaHQgJiYgeSA8IGhlaWdodCArIDEpCisgICAgICAgIHkgPSBoZWlnaHQgKyAx OworCisgICAgR2RrRXZlbnQqIGV2ZW50ID0gcmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGNy b3Nzc2luZ0V2ZW50KTsKKyAgICBHVW5pcXVlUHRyPEdka0V2ZW50PiBjb3BpZWRFdmVudDsKKyAg ICBpZiAoeCAhPSBjcm9zc3NpbmdFdmVudC0+eCB8fCB5ICE9IGNyb3Nzc2luZ0V2ZW50LT55KSB7 CisgICAgICAgIGNvcGllZEV2ZW50LnJlc2V0KGdka19ldmVudF9jb3B5KGV2ZW50KSk7CisgICAg ICAgIGNvcGllZEV2ZW50LT5jcm9zc2luZy54ID0geDsKKyAgICAgICAgY29waWVkRXZlbnQtPmNy b3NzaW5nLnkgPSB5OworICAgIH0KKworICAgIHByaXYtPnBhZ2VQcm94eS0+aGFuZGxlTW91c2VF dmVudChOYXRpdmVXZWJNb3VzZUV2ZW50KGNvcGllZEV2ZW50ID8gY29waWVkRXZlbnQuZ2V0KCkg OiBldmVudCwgMCAvKiBjdXJyZW50Q2xpY2tDb3VudCAqLykpOworCisgICAgcmV0dXJuIEZBTFNF OworfQorCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKIHN0YXRpYyB2b2lkIGFwcGVuZFRvdWNo RXZlbnQoVmVjdG9yPFdlYlBsYXRmb3JtVG91Y2hQb2ludD4mIHRvdWNoUG9pbnRzLCBjb25zdCBH ZGtFdmVudCogZXZlbnQsIFdlYlBsYXRmb3JtVG91Y2hQb2ludDo6VG91Y2hQb2ludFN0YXRlIHN0 YXRlKQogewpAQCAtMTA0NCw2ICsxMDg3LDggQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3 X2Jhc2VfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3QmFzZUNsYXNzKiB3ZWJraXRXZWJWaWUKICAg ICB3aWRnZXRDbGFzcy0+YnV0dG9uX3JlbGVhc2VfZXZlbnQgPSB3ZWJraXRXZWJWaWV3QmFzZUJ1 dHRvblJlbGVhc2VFdmVudDsKICAgICB3aWRnZXRDbGFzcy0+c2Nyb2xsX2V2ZW50ID0gd2Via2l0 V2ViVmlld0Jhc2VTY3JvbGxFdmVudDsKICAgICB3aWRnZXRDbGFzcy0+bW90aW9uX25vdGlmeV9l dmVudCA9IHdlYmtpdFdlYlZpZXdCYXNlTW90aW9uTm90aWZ5RXZlbnQ7CisgICAgd2lkZ2V0Q2xh c3MtPmVudGVyX25vdGlmeV9ldmVudCA9IHdlYmtpdFdlYlZpZXdCYXNlQ3Jvc3NpbmdOb3RpZnlF dmVudDsKKyAgICB3aWRnZXRDbGFzcy0+bGVhdmVfbm90aWZ5X2V2ZW50ID0gd2Via2l0V2ViVmll d0Jhc2VDcm9zc2luZ05vdGlmeUV2ZW50OwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAg d2lkZ2V0Q2xhc3MtPnRvdWNoX2V2ZW50ID0gd2Via2l0V2ViVmlld0Jhc2VUb3VjaEV2ZW50Owog I2VuZGlmCg==